Re: [libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs
On 03/15/2017 11:37 AM, Peter Krempa wrote:
Our code calls it when starting or re-starting the domain or when
hotplugging the disk so there's nothing to be detected.
---
src/qemu/qemu_driver.c | 5 -----
1 file changed, 5 deletions(-)
I think I added it here because block jobs have the tendency to rewrite
the backing chain (think active commit, for example, which reduces the
backing chain). Forcing a redetermination is therefore a way to ensure
no stale data associated with the pre-job chain is left in memory.
So I'm not sure this is correct.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)