Re: [libvirt] [PATCH] Introduce virDomainChrDefNew()
On 04/13/2011 11:14 AM, Michal Novotny wrote:
Hi,
this is the commit to introduce the function to create new character
device definition for the domain as advices by Cole Robinson
<crobinso(a)redhat.com>.
The function is used on the relevant places and the make, make check
and make syntax-check all passed.
Michal
Signed-off-by: Michal Novotny <minovotn(a)redhat.com>
Signed-off-by: Michal Novotny <mignov(a)gmail.com>
---
src/conf/domain_conf.c | 20 +++++++++++++++++---
src/conf/domain_conf.h | 2 ++
src/libvirt_private.syms | 1 +
src/qemu/qemu_command.c | 3 ++-
src/xenxs/xen_xm.c | 3 ++-
5 files changed, 24 insertions(+), 5 deletions(-)
There's at least one other instance that needs changing in xenxs/xen_sxpr.c
And I really don't think we should commit this until there is a regression
test demonstrating the regression (and that this patch fixes it). I mentioned
this earlier:
https://www.redhat.com/archives/libvir-list/2011-April/msg00287.html
Aside from that the patch looks fine.
Thanks,
Cole