Re: [libvirt] [PATCH 6/6] storage: create separate loadable modules for storage file drivers

On Wed, Apr 25, 2018 at 16:52:43 +0100, Daniel Berrange wrote: > The storage file drivers are currently loaded as a side effect of > loading the storage driver. This is a bogus dependancy because the > storage file code has no interaction with the storage drivers, and > even ultimately be running in a completely separate daemon. > > Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com&gt; > --- > libvirt.spec.in | 4 ++ > src/storage/Makefile.inc.am | 40 +++++++++++++++++++ > src/storage/storage_backend_fs.c | 4 -- > src/storage/storage_backend_gluster.c | 4 -- > src/util/virstoragefile.c | 10 +++-- > src/util/virstoragefilebackend.c | 72 +++++++++++++++++++++++++++-------- > src/util/virstoragefilebackend.h | 9 ++--- > 7 files changed, 111 insertions(+), 32 deletions(-) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 5090dfa2aa..e8705bbb48 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in [...] > @@ -1886,6 +1888,7 @@ exit 0 > %attr(0755, root, root) %{_libexecdir}/libvirt_parthelper > %{_libdir}/%{name}/connection-driver/libvirt_driver_storage.so > %{_libdir}/%{name}/storage-backend/libvirt_storage_backend_fs.so > +%{_libdir}/%{name}/storage-file/libvirt_storage_file_fs.so > > %files daemon-driver-storage-disk > %{_libdir}/%{name}/storage-backend/libvirt_storage_backend_disk.so > @@ -1905,6 +1908,7 @@ exit 0 > %if %{with_storage_gluster} > %files daemon-driver-storage-gluster > %{_libdir}/%{name}/storage-backend/libvirt_storage_backend_gluster.so > +%{_libdir}/%{name}/storage-file/libvirt_storage_file_gluster.so Should we also later create a few sub-packages so that the qemu driver can be installed without the storage driver?

ACK, the code looks good, but I'm running 'make rpm' and 'make dist' which will take a while. I'll report only if something breaks.