Re: [libvirt] [PATCH 1/2] build: virrandommock.c not needed on mingw
On 07/12/2016 03:27 AM, Martin Kletzander wrote:
On Mon, Jul 11, 2016 at 09:55:00PM -0600, Eric Blake wrote:
> We can't mock tests on Mingw, which lacks dlopen() and friends;
> follow the paradigms used in other mock files of conditionally
> compiling nothing when not building for Linux.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
> ---
> +# endif
> +#else /* WIN32 */
> +/* Can't mock on WIN32 */
Is taht really true? For both cygwin and mingw? If we can't
mock on
WIN32 why don't we just disable those tests and the mocks in Makefile?
I wish I knew that when I was spending so much time fixing that gnulib
bug that was causing mingw fails for almost two months =)
Cygwin supports dlopen(), and therefore mocking. However, cygwin is NOT
a WIN32 compile (it is so much closer to Linux than windows, that
compiling it with WIN32 is actively wrong). On the other hand, we don't
have a working port of libvirt to cygwin.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)