Re: [libvirt] [PATCH] virsh: fix mingw failure on creating nonblocking pipe
On Thu, Mar 31, 2011 at 04:12:09PM -0600, Eric Blake wrote:
On 03/31/2011 04:03 PM, Eric Blake wrote:
> * .gnulib: Update to latest, for nonblocking module.
> * bootstrap.conf (gnulib_modules): Add nonblocking.
> * src/util/util.c (virSetBlocking): Defer to gnulib.
> ---
>
> Matthias, does this work for you on your mingw build? So far,
> I have only tested that it cross-compiles, and that the new
> gnulib module passes its self-test when run in isolation on mingw.
>
> int virSetBlocking(int fd, bool blocking) {
> - if (blocking)
> - flags &= ~O_NONBLOCK;
> + return set_nonblocking_flag (fd, blocking);
Oops - that _can't_ work. s/blocking/!blocking/ in that return statement.
ACK with that fix :-)
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|