On Thu, Mar 01, 2018 at 09:50:00PM -0500, Laine Stump wrote:
The nwfilter tests have a few places that hardcode 192.168.122 as
the
address of libvirt's default network. Remove all of these and replace
them with addresses that are dynamically determined based on
get_network_ip().
(This will have the immediate effect of helping the tests to succeed
when libvirt-tck is run in a virtual machine, since virtual machines
often have their default network set to a different subnet (in order
to avoid conflict with the L0 host's default network)).
Signed-off-by: Laine Stump <laine(a)laine.org>
---
New in V2.
Another patch not necessarily related to $subject of the cover letter,
but useful to have.
scripts/nwfilter/210-no-mac-spoofing.t | 9 ++++++---
scripts/nwfilter/220-no-ip-spoofing.t | 14 ++++++++++----
scripts/nwfilter/230-no-mac-broadcast.t | 8 ++++++--
scripts/nwfilter/240-no-arp-spoofing.t | 19 ++++++++++++++-----
4 files changed, 36 insertions(+), 14 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|