Re: [libvirt] [PATCH v3 06/20] po: generate files into build directory

On Thu, Oct 24, 2019 at 03:05:24PM +0200, Pavel Hrdina wrote: > -endif HAVE_GNU_GETTEXT_TOOLS > - > if ENABLE_NLS > > # Cannot use 'localedir' since this conflicts with autoconf. > @@ -99,7 +104,7 @@ install-data-hook: $(GMOFILES) > for lang in $(LANGS); do \ > d=$(DESTDIR)$(langinstdir)/$$lang/LC_MESSAGES; \ > mkdir -p $$d; \ > - install -m 0644 $(srcdir)/$$lang.gmo $$d/$(DOMAIN).mo; \ > + install -m 0644 $$lang.gmo $$d/$(DOMAIN).mo; \ > done > > uninstall-hook: > @@ -109,3 +114,5 @@ uninstall-hook: > done > > endif ENABLE_NLS > + > +endif HAVE_GNU_GETTEXT_TOOLS Moving this HAVE_GNU_GETTEXT_TOOLS conditional means that on OS that lack the GNU gettext impl, we are no longer able to 'make install' the translation files, despite having them prebuilt & bundled in the tarball. IIRC, this affects any non-Linux host.