Re: [Libvir] [PATCH] add scheduler API(take 3?)

On Wed, May 30, 2007 at 04:40:39PM +0100, Richard W.M. Jones wrote: Actually there is one thing I would revert from your patch it's the change from int to virSchedParameterType in structs and parameters. Basically the problem comes from the fact that C does not define the size of an enum, so some compiler may use 8 bits to encode it, others may use 32bits, or worse say you add a new error value -1 it could change from 8 to 32 bits breaking ABI compatibility. I really prefer to use int for the virSchedParameterType in public structs and public functions parameters for this reason, it's far from ideal, but I prefer this than having weird ABI incompatibilities due to compiler variations :-) otherwise thanks a lot for the cleanup ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/