On 05/04/2011 07:49 AM, Daniel P. Berrange wrote:
To cope with the QEMU binary being changed while a VM is running,
it is neccessary to persist the original qemu capabilities at the
time the VM is booted.
Yay! About time.
@@ -1986,13 +1984,16 @@ qemuProcessReconnect(void *payload, const
void *name ATTRIBUTE_UNUSED, void *opa
goto error;
}
- /* XXX we should be persisting the original flags in the XML
- * not re-detecting them, since the binary may have changed
- * since launch time */
- if (qemuCapsExtractVersionInfo(obj->def->emulator, obj->def->os.arch,
+ /* If upgrading from old QEMU we won't have found any
s/QEMU/libvirt/
ACK with that nit fixed.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org