Re: [PATCH 1/2] ch: Add config file support
On 5/22/25 08:21, Stefan Kober wrote:
Similar to the QEMU driver, the ch driver receives support for
configuration files that allows doing certain configuration on the
virtchd daemon.
The initial use case will be setting the verbosity of the cloud
hypervisor instances started by virtchd, but the implementation allows
for adding further options.
---
src/ch/ch_conf.c | 22 ++++++++++++++++++++++
src/ch/ch_conf.h | 3 +++
src/ch/ch_driver.c | 6 ++++++
3 files changed, 31 insertions(+)
This is lacking documentation. Users wouldn't know that this new config
file is read.
And for completeness, maybe we want to add some example file (for this
particular patch basically empty ch.conf with only a comment on top,
just like qemu.conf.in has it) and augeas file so that the config file
can be modified pragmatically?
Otherwise looking good.
Michal