Re: [libvirt] [PATCHv3 00/13] Add new PCIe controllers
On Sat, Jul 25, 2015 at 03:58:24PM -0400, Laine Stump wrote:
Since the first 3 patches of V2 were ACKed and uncontroversial, I
fixed the small problems pointed out in the reviews and pushed
them. Thus, Patches 01-13 here correspond to Patches 04-17 in V2.
4 patches with the DHCP rework that gotten there by mistake :-) It
took me a while to find that out.
Most of these patches were already ACKed in V2 (pending my making
small fixes pointed out in review), but the main things that need
review are:
1) changing of model name from a char* to an enum in Patch 01, and
corresponding blowback in patches 02, 07, 10, and 13
2) range checking of chassisNr in Patch 03 and chassis+port in patch
06.
3) check for duplicate <model> in patch 01, and duplicate <target> in
patch 03.
I did add one new negative test, and reworded some documentation, but I'm
I haven't found one, but it's not needed, that was just a suggestion
from some ignorant guy I guess (me).
about to go mostly offline for 10 days, and would rather not have
these patches bitrotting during that time if they are okay other than
that. (also, I see both of those tasks as having no practical end, but
do give my word to add more to both in later followups).
If by chance everything is ACKed before DV freezes for RC1, but after
I'm already offline (which will happen Sunday morning U.S. east coast
time), I would appreciate if the reviewer could push the patches so
they'll get the RC testing and be in the 1.2.18 release. (If not, I'll
take care of it when I return).
Unfortunately, I was mostly away for the whole week as well, I got to
reading my mail for few minutes a day. And I haven't managed to go
through this over the weekend, I figured since rc2 was out already,
this needs to wait anyway.
Only patches 06 and 12 have some needed work in, all other mails are
just either suggestions for future re-factors or random rants.
ACK series with a) all 1.2.18 occurrences changed to 1.2.19 (I've
probably missed most of them) and b) reviews for 6 and 12 worked in.
Have a nice day,
Martin
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)