Re: [libvirt] [PATCH RFC] libxl: fix paths in capability string
On Tue, Jan 06, 2015 at 10:28:13AM -0700, Eric Blake wrote:
On 01/06/2015 09:12 AM, Wei Liu wrote:
> Currently libxl driver hardcodes some paths in its capability string,
> which might not be the correct paths.
>
> This patch introduces --with-libxl-prefix, so that user can specify the
> prefix used to build Xen tools. The default value is /usr/local which is
> the default --prefix for Xen tools.
Why can't you just make '--with-libxl=/path/to/alt' work? That is,
--with-libxl=yes uses a default (which matches the prefix where LIBVIRT
will be installed [1]), --with-libxl=no turns it off, and specifying a
path says to use that path. Then you don't need to add a new option.
Yep, that would be preferrable.
Alternatively the next best would be for xen to include a pkg-config
configuration file, with a custom variable that reports the paths
required
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|