Re: [libvirt] [PATCH] domain_conf: skip boot order check of CD-ROM or floppy device

On 12/25/2017 06:21 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao(a)gmail.com&gt; > > If we insert or eject a CD-ROM/floppy device with a boot order, > we may get: > unsupported configuration: boot order 2 is already used by another device > > This check should be skipped in this case. > > Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com&gt; > --- > src/conf/domain_conf.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > Is there a specific reason for your assertion? Given what scenario? virDomainDefCompatibleDevice is called from Attach and Update qemu/lxc code currently. I dunno, but if someone is trying to attach or update a floppy/cdrom and wanted to use a boot index in use by something else, then I would think inhibiting that is a good idea...