On Fri, Jan 05, 2018 at 10:01:50AM -0500, John Ferlan wrote:
On 12/25/2017 06:21 AM, Chen Hanxiao wrote:
From: Chen Hanxiao <chenhanxiao@gmail.com>
If we insert or eject a CD-ROM/floppy device with a boot order, we may get: unsupported configuration: boot order 2 is already used by another device
This check should be skipped in this case.
Signed-off-by: Chen Hanxiao <chenhanxiao@gmail.com> --- src/conf/domain_conf.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-)
Is there a specific reason for your assertion? Given what scenario?
virDomainDefCompatibleDevice is called from Attach and Update qemu/lxc code currently.
I dunno, but if someone is trying to attach or update a floppy/cdrom and wanted to use a boot index in use by something else, then I would think inhibiting that is a good idea...
Yes. Also, even though libvirt does not support cdrom/floppy hotplug, assuming that this is an update based only on the disk type feels wrong. Jan