Re: [libvirt] [PATCHv4 00/51] shared snapshot meta-data

Hello, On Friday 02 September 2011 11:57:15 Daniel Veillard wrote: We are currently doing this and it works more or less. 1. You have to put /var/lib/libvirt/qemu/snapshot/ on a shared storage, but only that and not /var/lib/libvirt/qemu/ itself, because there the UNIX domain monitor sockets are located; if you do that, you'll get problems because on migration two KVM instances will use the same path name for their monitor sockets. 2. You have to hook qemuDomainSnapshotLoad() to qemudDomainMigrateFinish2() (and qemudDomainDefine()) to get already existing snapshots associated to newly migrated domains, either via migrate() for live domains, or via define() for non-live domains. 3. You need do remove the locking from qemudDomainDefine(), because the two functions mentioned above alread hold the domain lock. That is what get me started to work on "Fix memory leak while scanning snapshots", "killall -SIGHUP libvirtd / virStateReload" and "Reload snapshots on SIGHUP". At leas our patched 0.8.7 is working fine with those changes. Sincerely Philipp -- Philipp Hahn Open Source Software Engineer hahn(a)univention.de Univention GmbH Linux for Your Business fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D-28359 Bremen fax: +49 421 22 232-99 http://www.univention.de/ ---------------------------------------------------------------------------- Treffen Sie Univention auf der IT&Business vom 20. bis 22. September 2011 auf dem Gemeinschaftsstand der Open Source Business Alliance in Stuttgart in Halle 3 Stand 3D27-7.