Re: [libvirt] [PATCHv4] libvirt: do not mix internal flags into public API
On 07/18/2011 02:39 PM, Eric Blake wrote:
> On second thought, I don't like this. It's nicer to have
all the driver
> callbacks match the public API as much as possible, and to instead
> create a new entry point in libvirt_private.syms that qemu can use for
> the case where it needs to call the internal API instead of the public
> virSecretGetValue. v5 coming up.
Here's the interdiff for v5:
Except that this break docs/hvsupport.pl, since that file doesn't know
that the new function is for internal use only.
At this point, I'm leaning back towards just using v4 as is, with a
single driver.h callback for secretGetValue, instead of trying to have
two different driver callbacks, one public and one for internal only.
If we change our minds later, then further touching up of secretGetValue
can be an independent patch.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org