On Wed, Oct 26, 2011 at 6:32 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
On Wed, Oct 26, 2011 at 01:17:36AM +0300, Zeeshan Ali (Khattak) wrote:
From: "Zeeshan Ali (Khattak)" <zeeshanak@gnome.org>
API to create new storage pools.
ACK, but please add the 'unsigned int flags' parameter to this, rather than hardcoding 0. Through bitter experiance, all libvirt APIs now strive to have an 'unsigned int flags' parameter, because we invariably need to invent flags at some time or another.
Oh, I forgot to fix that. Thanks for reminding..
I wish GObject introspection supported default values, so we could annotate all the flags parameters as taking a '0' default value to avoid apps needing to set it all the time.... The annotations are all defined, but the girscanner ignores them :-(
Yeah, Vala has supported that for a long time and I intend to fix this for Vala bindings at least sometimes soon. -- Regards, Zeeshan Ali (Khattak) FSF member#5124