Re: [libvirt] [PATCH] Clarify behavior or virDomainDetachDevice
On 20.02.2015 14:23, Ján Tomko wrote:
<snip/>
Would you object to a more general wording, or should we just not
advertise this at all?
For example:
The supplied XML description of the device should be as specific
as its definition in the domain XML. The set of attributes used
to match the device are internal to the drivers. Using a partial definition,
or attempting to detach a device that is not present in the domain XML,
but shares some specific attributes with one that is present
may lead to unexpected results.
Yes, this is definitely better wording. Moreover, going through our
docs, it doesn't seem like we have stated explicitly that users are
required to pass full XML. Nor in virsh, nor in APIs docs.
ACK to this and adding it to Detach APIs too.
Michal