On 07/29/2010 09:35 AM, Daniel Veillard wrote:
On Wed, Jul 28, 2010 at 03:15:35PM -0600, Eric Blake wrote:
> './autobuild.sh' with lcov installed discovered that our
> coverage support has been bit-rotting for a while. This
> restores it back to a successful state, although I have
> not yet spent any time looking through the resulting files to
> look for low-hanging fruit in the unit test coverage front.
>
>
> v3 had an ACK at:
>
https://www.redhat.com/archives/libvir-list/2010-June/msg00660.html
> Changes from v3:
> rebase to present status (several conflicts resolved in src/Makefile.am)
> fix 'cov' rule in Makefile.am to allow VPATH usage
Hum, this is a rather large patch, in one hand it would be good to
run this before 0.8.3, but on the other hand it touches a lot of
Makefiles. With the release postponed to early next week maybe we can
push this, but I let you decide
ACK
I went ahead and pushed this now, after doing one more manual search to
make sure I got everything cleanly even after the rebasing from v3, and
after running './autobuild.sh' on the result.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org