Re: [libvirt] [PATCH 2/2] build: enforce reference count checking

On 03/18/2011 01:37 PM, Eric Blake wrote: > Add the compiler attribute to ensure we don't introduce any more > ref bugs like were just patched in commit 9741f34, then explicitly > mark the remaining places in code that are safe. > > * src/qemu/qemu_monitor.h (qemuMonitorUnref): Mark > ATTRIBUTE_RETURN_CHECK. > * src/conf/domain_conf.h (virDomainObjUnref): Likewise. > * src/conf/domain_conf.c (virDomainObjParseXML) > (virDomainLoadStatus): Fix offenders. > * src/openvz/openvz_conf.c (openvzLoadDomains): Likewise. > * src/vmware/vmware_conf.c (vmwareLoadDomains): Likewise. > * src/qemu/qemu_domain.c (qemuDomainObjBeginJob) > (qemuDomainObjBeginJobWithDriver) > (qemuDomainObjExitRemoteWithDriver): Likewise. > * src/qemu/qemu_monitor.c (QEMU_MONITOR_CALLBACK): Likewise. > Suggested by Daniel P. Berrange. > --- > src/conf/domain_conf.c | 6 ++++-- > src/conf/domain_conf.h | 2 +- > src/openvz/openvz_conf.c | 6 ++++-- > src/qemu/qemu_domain.c | 11 ++++++++--- > src/qemu/qemu_monitor.c | 2 +- > src/qemu/qemu_monitor.h | 2 +- > src/qemu/qemu_process.c | 3 ++- > src/vmware/vmware_conf.c | 7 +++++-- > 8 files changed, 26 insertions(+), 13 deletions(-) ACK.