Re: [libvirt] [PATCHv2 8/9] qemu: snapshot: Switch snapshot file deletion to the new storage API
On 01/16/2014 06:14 AM, Peter Krempa wrote:
Use the new storage conversion APIs to delete garbage left behind
after
a failed snapshot attempt using the storage driver.
---
src/qemu/qemu_driver.c | 60 ++++++++++++++++++++++++++++++++++++++------------
1 file changed, 46 insertions(+), 14 deletions(-)
+ switch (origdisk->type) {
+ case VIR_DOMAIN_DISK_TYPE_BLOCK:
+ case -1: /* type was not provided in snapshot conf */
Is this case leftover that can be removed after your earlier refactoring?
ACK with that fixed.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 604 bytes)