Re: [libvirt] [PATCH v3 17/18] util: Alter virNodeDevice{Create|Delete}Vport to use nodedev APIs
On 03/10/2017 04:10 PM, John Ferlan wrote:
If we have a connection pointer there's no sense walking through
the
sysfs in order to create/destroy the vHBA. Instead, let's make use of
the node device create/destroy API's.
Since we don't have to rewrite all the various parent options for
the test driver in order to test whether the storage pool creation
works as the node device creation has been tested already, let's just
use the altered API to test the storage pool paths.
Fix a "bug" in the storage pool test driver code which "assumed"
testStoragePoolObjSetDefaults should fill in the configFile for
both the Define/Create (persistent) and CreateXML (transient) pools
by just VIR_FREE() of the pool during CreateXML. Because the
configFile was filled in, during Destroy, the pool wouldn't be
free causing a test using the same name pool to fail.
Without trying to go through this patch, the commit log makes it sound like there are 3
separate things being done. Or am I misinterpreting? Can it maybe be split up so a
mindless reviewer doesn't need to do any work to figure out which is the code fixing
the bug. If no splitting is possible/useful, then I'll tackle it as-is tomorrow.