Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver
Good, I spend many hours on this but I see I'll continue working on this tomorrow
since it's not OK yet.
Michal
----- Original Message -----
From: "Paolo Bonzini" <pbonzini(a)redhat.com>
To: "Michal Novotny" <minovotn(a)redhat.com>
Cc: "Libvirt" <libvir-list(a)redhat.com>
Sent: Thursday, January 20, 2011 3:13:22 PM
Subject: Re: [libvirt] [PATCH] Add support for multiple serial ports to Xen driver
On 01/20/2011 02:39 PM, Michal Novotny wrote:
Well, I'm working on support for serial port configuration as
serial = [
"/dev/null", "/dev/ttyS0", "/dev/ttyS1" ] to:
1) pass /dev/null to the guest as /dev/ttyS0
2) pass /dev/ttyS0 to the guest as /dev/ttyS1
3) pass /dev/ttyS1 to the guest as /dev/ttyS2
I think this could be good thing to be implemented as well. Also, the
libvirt XML definition should be:
<serial type='dev'>
<source path='/dev/null'/>
<target port='0'/>
</serial>
<serial type='dev'>
<source path='/dev/ttyS0'/>
<target port='1'/>
</serial>
<serial type='dev'>
<source path='/dev/ttyS1'/>
<target port='2'/>
</serial>
Are you OK with that?
Yes, and it should "just work" with your patch.
I'm also thinking of omitting the first <serial> block and
automatically
set the path to /dev/null when target.port is not present in the libvirt
XML definition but it shouldn't be necessary after all. What do you
think on this one?
No, even the qemu driver disregards target.port in the XML you give it,
as far as I understand.
Paolo