On 04/12/2013 09:29 AM, Stefan Berger wrote:
On 04/12/2013 09:37 AM, Daniel P. Berrange wrote:
On Fri, Apr 12, 2013 at 09:25:14AM -0400, Stefan Berger wrote:
Hello!
The following set of patches adds support to libvirt for adding a TPM passthrough device to a QEMU guest. Support for this was recently accepted into QEMU.
This set of patches borrows a lot from the recently added support for rng's.
Regards, Stefan
--- v5->v6: - followed tree to 039a3283 - simplified virTPMFindCancelPath in 4/11 following D. Berrange's comments ACK to all patches in v6. Argh, after removing the cancel_path from the virDomainTPMDef structure and now determining the cancel_path at the places where it is needed and verifying that the file actually exists, the test case only works if the device actually exists since it runs through that code when creating the QEMU command line...
Can we keep it in the virDomainTPMDef structure, so that normal code computes cancel_path from the normal path at the time of SELinux labeling, while the testsuite just populates it with a string without any SELinux labeling? The testsuite must not be influenced by actual files on the system running the test. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org