Re: [libvirt] [PATCH] virsh: fix regression in log to file
On 04/30/2011 04:56 AM, Supriya Kannery wrote:
Commit 36deff04 introduced a regression due to which virsh is not
able
to log to a file - msg_buf was changed from an array to a pointer
without corresponding change to usage of "sizeof()".
Fix regression in virsh logging
Good catch. However, I'd prefer if we instead rewrote this function to
use virBuffer instead of snprintf. Much less error-prone to maintain.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)