On 09/13/2012 06:17 AM, Daniel P. Berrange wrote:
>
> Spoke too soon; I'm getting a test coredump:
> TEST: qemuxml2argvtest
> .../bin/sh: line 5: 19492 Segmentation fault
> abs_top_builddir=`cd '..'; pwd` abs_top_srcdir=`cd '..'; pwd`
> abs_builddir=`pwd` abs_srcdir=`cd '.'; pwd` CONFIG_HEADER="`cd
'..';
> pwd`/config.h" PATH="`cd '..'; pwd`/daemon:`cd '..';
pwd`/tools:`cd
> '..'; pwd`/tests:$PATH" SHELL="/bin/sh"
> LIBVIRT_DRIVER_DIR="/home/remote/eblake/libvirt/src/.libs"
> LIBVIRT_AUTOSTART=0 LC_ALL=C ${dir}$tst
> FAIL: qemuxml2argvtest
>
> but haven't yet takent the time to pin it down.
Hmm, I already pushed this patch & others you ACKd. I ran 'make check'
first and didn't see this crash though.
Weird - I saw it on the tree where I was hand-applying your patches, but
not on a fresh checkout. Wonder what I did wrong to my tree? At any
rate, I think we're safe, after all.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org