On Fri, 2018-01-05 at 19:18 +0530, Shivaprasad G Bhat wrote:
When the -machine pseries,max-cpu-compat=X is supported use machine parameter instead of -cpu host,compat=X parameter as that is deprecated now with qemu > v2.10.
That's actually >= 2.10.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1519146
Signed-off-by: Shivaprasad G Bhat <sbhat@linux.vnet.ibm.com> --- src/qemu/qemu_command.c | 11 ++++++++++ .../pseries-machine-max-cpu-compat.args | 21 ++++++++++++++++++++ .../pseries-machine-max-cpu-compat.xml | 17 ++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++++ 4 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.args create mode 100644 tests/qemuxml2argvdata/pseries-machine-max-cpu-compat.xml
Everything else looks good, so Reviewed-by: Andrea Bolognani <abologna@redhat.com> I've performed some minor formatting tweaks that wouldn't justify a full respin, addressed the commit message issue mentioned above and pushed the series. -- Andrea Bolognani / Red Hat / Virtualization