On 10/13/2015 06:20 AM, Daniel P. Berrange wrote:
There's of course the obvious solution - not change anything and have mgmt apps calling two separate APIs - like they oughtta be doing today.
That's the right solution IMHO
What's your view?
I see no compelling reason to add anything to the API or implementation. We provide enough functionality already to deal with this scenario. Trying to overload multiple operations into a single API "for convenience" ends up not being convenient at all, due to the error reporting scenarios you mention. I don't see any real burden on applications to call these existing APIs when they wish to.
I still think virsh can be taught the convenience method. I agree that the lowlevel libvirt.so entry points don't need convenience, but we have already established that virsh is perfectly capable of doing 2 or more low-level API calls under a single command, in part because virsh has decent error reporting about which step of the sequence fails. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org