Re: [libvirt] [PATCH v3 0/4] Move ide validation from qemuBuildControllerDevStr to qemuDomainDeviceDefValidate
On 12/01/2017 06:31 AM, Lin Ma wrote:
Validate IDE controllers in qemuDomainDeviceDefValidate for reminding
users earlier.
v2->v3:
* split original patch to multiple patches.
* making the validation is preferred over the PostParse for avoiding guests disappear.
* remove ide from the pseries and the ccw tests.
Lin Ma (4):
tests: qemuxml2argv: Use scsi controller instead of ide in pseries
tests: qemuhotplugtest: Drop ide controller in ccw
qemu_command: Drop IDE validation code in qemuBuildControllerDevStr
qemu_domain: Error out earlier when configuring IDE controller
incorrectly
src/qemu/qemu_command.c | 10 +------
src/qemu/qemu_domain.c | 35 +++++++++++++++++++++-
.../qemuhotplug-base-ccw-live+ccw-virtio.xml | 4 ---
...ive-with-2-ccw-virtio+ccw-virtio-1-explicit.xml | 4 ---
...live-with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 4 ---
...qemuhotplug-base-ccw-live-with-2-ccw-virtio.xml | 4 ---
...-live-with-ccw-virtio+ccw-virtio-2-explicit.xml | 4 ---
...-base-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 4 ---
.../qemuhotplug-base-ccw-live-with-ccw-virtio.xml | 4 ---
.../qemuhotplug-base-ccw-live.xml | 4 ---
.../qemuxml2argv-disk-floppy-pseries.args | 2 +-
.../qemuxml2argv-disk-floppy-pseries.xml | 4 +--
12 files changed, 38 insertions(+), 45 deletions(-)
Essentially what I was looking for; however, patches 3 & 4 need to be
combined; otherwise, a git bisect that lands at patch 3 wouldn't get the
desired result. Also, not sure the comment (currently) in patch 3 would
need to stay in the qemu_command code or as you've also done move it to
the qemu_domain code.
In any case, I have some patches on my local branch which would take the
next step to move a majority of the checks in qemuBuildControllerDevStr
into a sequence of Validation API's in qemu_domain.
Once the freeze is over, I'll post it with your changes merged in. It's
ready to go, I just didn't want to post during freeze.
Tks -
John