Re: [libvirt] [PATCH] Unify most error reporting (ver 2)

Daniel Veillard <veillard(a)redhat.com&gt; wrote: > On Thu, Oct 09, 2008 at 11:44:02AM -0400, Cole Robinson wrote: >> Daniel Veillard wrote: >> > On Wed, Oct 08, 2008 at 08:35:38PM +0100, Daniel P. Berrange wrote: > > Hum, this breaks "make check" > > PASS: read-non-seekable > --- out 2008-10-10 10:23:57.000000000 +0200 > +++ exp 2008-10-10 10:23:57.000000000 +0200 > @@ -1,2 +1,2 @@ > -libvir: Test error : internal error Domain is still running > +libvir: Test error test: internal error Domain is still running > error: Failed to undefine domain test > FAIL: undefine > > Seems we loose the domain name in the error message when trying to > undefine a running domain: > > paphio:~/libvirt/tests -> /usr/bin/virsh -q -c test:///default undefine > test > libvir: Test error test: internal error Domain is still running > error: Failed to undefine domain test > paphio:~/libvirt/tests -> ../src/virsh -q -c test:///default undefine > test > libvir: Test error : internal error Domain is still running > error: Failed to undefine domain test > paphio:~/libvirt/tests -> > > I should be possible to restore the old behaviour of reporting the domain > name there The documentation suggests that the new interface was initially supposed to have dom and net parameters:

/** * __virReportErrorHelper * * @conn: the connection to the hypervisor if available * @dom: the domain if available * @net: the network if available * @domcode: the virErrorDomain indicating where it's coming from ... void __virReportErrorHelper(virConnectPtr conn, int domcode, int errcode, const char *filename ATTRIBUTE_UNUSED, const char *funcname ATTRIBUTE_UNUSED, long long linenr ATTRIBUTE_UNUSED, const char *fmt, ...) { ... virerr = __virErrorMsg(errcode, (errorMessage[0] ? errorMessage : NULL)); __virRaiseError(conn, NULL, NULL, domcode, errcode, VIR_ERR_ERROR, virerr, errorMessage, NULL, -1, -1, virerr, errorMessage); } Shouldn't be hard to make the code agree with the documentation. There are fewer than 20 uses of __virReportErrorHelper so far.