Re: [libvirt] [PATCH 1/7] lxc: Drop container stdio as late as possible
On 06/02/2011 01:40 PM, Cole Robinson wrote:
Makes it more likely we get useful error output in the logs
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
---
src/lxc/lxc_container.c | 29 ++++++++++++++++-------------
1 files changed, 16 insertions(+), 13 deletions(-)
ACK; however, this series is late enough that it should wait until after
the 0.9.2 release.
@@ -806,17 +798,28 @@ static int lxcContainerChild( void *data )
/* rename and enable interfaces */
if (lxcContainerRenameAndEnableInterfaces(argv->nveths,
- argv->veths) < 0)
+ argv->veths) < 0) {
goto cleanup;
+ }
This particular change doesn't hurt or help; but I'm okay with leaving
it in from the consistency standpoint of using {} everywhere.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)