- Devel - libvirt List Archives

[PATCH] qemu: driver: Remove unused variable 'cfg'
by Peter Krempa 23 Sep '21

23 Sep '21

Commit a50c473ad6c988a2 removed last use of 'cfg' from qemuDomainMemoryPeek and qemuDomainScreenshot triggering a compile time warning. Fixes: a50c473ad6c988a249bf79a30fb7c6dc19733347 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Build-fix && trivial. Pushed. src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f57e943b48..28aa7351ee 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3374,7 +3374,6 @@ qemuDomainScreenshot(virDomainPtr dom, const char *videoAlias = NULL; char *ret = NULL; bool unlink_tmp = false; - g_autoptr(virQEMUDriverConfig) cfg = NULL; virCheckFlags(0, NULL); @@ -3382,7 +3381,6 @@ qemuDomainScreenshot(virDomainPtr dom, goto cleanup; priv = vm->privateData; - cfg = virQEMUDriverGetConfig(driver); if (virDomainScreenshotEnsureACL(dom->conn, vm->def) < 0) goto cleanup; @@ -10559,7 +10557,6 @@ qemuDomainMemoryPeek(virDomainPtr dom, g_autofree char *tmp = NULL; int fd = -1, ret = -1; qemuDomainObjPrivate *priv; - g_autoptr(virQEMUDriverConfig) cfg = NULL; virCheckFlags(VIR_MEMORY_VIRTUAL | VIR_MEMORY_PHYSICAL, -1); @@ -10567,7 +10564,6 @@ qemuDomainMemoryPeek(virDomainPtr dom, goto cleanup; priv = vm->privateData; - cfg = virQEMUDriverGetConfig(driver); if (virDomainMemoryPeekEnsureACL(dom->conn, vm->def) < 0) goto cleanup; -- 2.31.1

1 0

[PATCH v4 00/11] Implement IOThreads related APIs for test driver
by Luke Yue 23 Sep '21

23 Sep '21

v4: - Rebase to current master branch - Add the forgotten virObjectUnlock(vm) in PATCH 09/11 - Refine tests CI link: https://gitlab.com/lukedyue/libvirt/-/pipelines/371315349 Luke Yue (11): domain_driver.c: Introduce and use virDomainDriverAddIOThreadCheck() test_driver: Introduce testIOThreadInfo and generate IOThread infos test_driver: Implement virDomainAddIOThread test_driver: Implement virDomainDelIOThread domain_driver.c: Introduce and use virDomainDriverGetIOThreadsConfig() test_driver: Implement virDomainGetIOThreadInfo test_driver: Implement virDomainPinIOThread test_driver: Implement testDomainSetIOThreadParams test_driver: Implement virConnectGetAllDomainStats test_driver: Introduce testDomainGetStatsIOThread tests: Test IOThread related functions for test driver examples/xml/test/testdomfc4.xml | 5 + src/hypervisor/domain_driver.c | 132 ++++++++ src/hypervisor/domain_driver.h | 10 + src/libvirt_private.syms | 3 + src/qemu/qemu_driver.c | 113 +------ src/test/test_driver.c | 516 +++++++++++++++++++++++++++++++ tests/virshtest.c | 110 +++++++ 7 files changed, 781 insertions(+), 108 deletions(-) -- 2.33.0

2 12

[PATCH v3 0/2] qemu: don't change ownership of cache directory
by Peng Liang 23 Sep '21

23 Sep '21

See path 2 for detail. v2 -> v3: - Change the directory to put the temp files of screenshot and memorypeek from autoDumpPath to per-domain directory [Daniel] v1 -> v2: - Add commit message for path1 [Peter] Peng Liang (2): qemu: move temp file of screenshot and memorypeek to per-domain dir qemu: don't change ownership of cache directory src/qemu/qemu_driver.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) -- 2.31.1

2 3

[RFC PATCH 0/7] qemu: QAPI-schema: Add support for enum value 'features'
by Peter Krempa 23 Sep '21

23 Sep '21

This series is based on Markus' effort to add 'feature' flags to enum values so that e.g. they can be deprecated: https://listman.redhat.com/archives/libvir-list/2021-September/msg00453.html This series adapts both the schema query language to support querying for arbitrary feature flags and also the schema validator to reject deprecated enum values. Libvirt didn't use any deprecated value for now so to see that this really works you can fetch this series including patches which show it's working (tests fail): git fetch https://gitlab.com/pipo.sk/libvirt.git qemu-deprecate-enum The above branch also demonstrates that parsing from the new arrays produces identical results as it has updated qemu capabilities. This series is RFC as it's waiting for the qemu additions first. Peter Krempa (7): virQEMUQAPISchemaTraverseEnum: Move helper variables into loop virQEMUQAPISchemaTraverseEnum: Use the modern 'members' array virQEMUQAPISchemaTraverseEnum: Allow query of enume type features testQEMUSchemaValidateEnum: Refactor logic to simplify switching to new QMP schema format testQEMUSchemaValidateEnum: Use new 'members' for 'enum' meta type testQEMUSchemaValidateDeprecated: Move to the top testQEMUSchemaValidateEnum: Validate deprecated members src/qemu/qemu_qapi.c | 46 +++++++++++-- tests/testutilsqemuschema.c | 130 +++++++++++++++++++++--------------- 2 files changed, 117 insertions(+), 59 deletions(-) -- 2.31.1

2 8

[libvirt PATCH 0/2] Random improvements to work around a build system issue
by Tim Wiederhake 23 Sep '21

23 Sep '21

This is an alternative to https://listman.redhat.com/archives/libvir-list/2021-September/msg00522.html. When libvirt is build: * with sanitizers enabled, * buildtype explicitly set to "debug", * on clang, the build fails with: ../src/conf/nwfilter_conf.c:2190:1: error: stack frame size of 10616 bytes in function 'virNWFilterRuleDefFixup' [-Werror,-Wframe-larger-than=] virNWFilterRuleDefFixup(virNWFilterRuleDef *rule) ^ 1 error generated. ../src/conf/domain_conf.c:19514:1: error: stack frame size of 8312 bytes in function 'virDomainDefParseXML' [-Werror,-Wframe-larger-than=] virDomainDefParseXML(xmlXPathContextPtr ctxt, ^ 1 error generated. Note that this does not happen when "-Dbuildtype" is not specified, even though "debug" is the default build type. The patches in this series happen to make these errors go away. Regards, Tim Tim Wiederhake (2): virDomainDefParseXML: Use automatic memory management virNWFilterRuleDefFixup: Replace macro with function src/conf/domain_conf.c | 208 ++++++++++++++-------------- src/conf/nwfilter_conf.c | 284 ++++++++++++++++++++------------------- 2 files changed, 245 insertions(+), 247 deletions(-) -- 2.31.1

4 5

[libvirt PATCH 0/1] Fix rpmbuild on CentOS Stream 8
by Erik Skultety 23 Sep '21

23 Sep '21

When running rpmbuild on CentOS 8 results in the following error: error: Too many levels of recursion in macro expansion. It is likely caused by recursive macro declaration. error: Macro %libvirt_daemon_perform_restart failed to expand error: line 1275: %global libvirt_daemon_perform_restart() \ if test %libvirt_daemon_needs_restart %1 \ then \ /bin/systemctl try-restart %1.service >/dev/null 2>&1 || : \ fi \ %libvirt_daemon_finish_restart %1 Erik Skultety (1): libvirt.spec.in: Replace %global with %define libvirt.spec.in | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.31.1

2 2

[libvirt PATCH 0/9] ch: use g_auto where possible
by Ján Tomko 23 Sep '21

23 Sep '21

While cleaning up the tests, I noticed that the 'ch' driver is not using g_auto up to its full potential. Use automatic cleanup where possible and remove redundant labels. Ján Tomko (9): ch: use g_auto in virCHMonitorBuildCPUJson ch: use g_auto in virCHMonitorBuildKernelRelatedJson ch: use g_auto in virCHMonitorBuildMemoryJson ch: use g_auto in virCHMonitorBuildDiskJson ch: use g_auto in virCHMonitorBuildDisksJson ch: use g_auto in virCHMonitorBuildNetJson ch: use g_auto in virCHMonitorBuildNetsJson ch: use g_auto in virCHMonitorBuildVMJson ch: use g_auto in virCHMonitorNew src/ch/ch_monitor.c | 167 +++++++++++++++++--------------------------- 1 file changed, 63 insertions(+), 104 deletions(-) -- 2.31.1

3 14

[libvirt PATCH v4 0/4] Add a PCI/PCIe device VPD Capability
by Dmitrii Shcherbakov 22 Sep '21

22 Sep '21

Add support for deserializing the binary PCI/PCIe VPD format and exposing VPD resources as XML elements in a new nested capability of PCI/PCIe devices called 'vpd'. The series contains the following incremental changes: * The PCI VPD parser module, in-memory resource representation and tests; * VPD-related helpers added to the virpci module; * VPD capability support: XML serialization/deserialization from/into VPD resource data structures; * Documentation. The VPD format is specified in "I.3. VPD Definitions" in PCI specs (2.2+) and "6.28.1 VPD Format" PCIe 4.0. As section 6.28 in PCIe 4.0 notes, the PCI Local Bus and PCIe VPD formats are binary compatible and PCIe 4.0 merely started incorporating what was already present in PCI specs. Linux kernel exposes a binary blob in the VPD format via sysfs since v2.6.26 (commit 94e6108803469a37ee1e3c92dafdd1d59298602f) which requires a parser to interpret. There are usage scenarios where information such as the board serial number needs to be retrieved from PCI(e) VPD. Projects like Nova can utilize this information for cases which involve virtual interface plugging on SmartNIC DPUs but there may be other scenarios and types of information useful to retrieve from VPD. The fact that the format is binary requires proper parsing instead of substring searching hence the full parser is proposed. Likewise, checksum validation requires proper parsing as well. A usage example is present here: https://review.opendev.org/c/openstack/nova/+/808199 The patch follows a prior discussion on the mailing list which has additional context about the use-case but a narrower proposal: https://listman.redhat.com/archives/libvir-list/2021-May/msg00873.html https://www.mail-archive.com/libvir-list@redhat.com/msg218165.html The new functionality is mostly contained in virpcivpd with a couple of new functions added to virpci. Additionally, the necessary XML serialization/deserialization and glue code is added to expose the VPD capability to external clients as XML. A new capability flag is added along with a new capability in order to allow for filtering of PCI devices with the VPD capability using virsh: virsh nodedev-list --cap vpd sudo virsh nodedev-dumpxml --device pci_dddd_bb_ss_f In this example having the root uid is required in order to access the vpd sysfs entry, therefore, the nodedev XML output will only contain the VPD capability if virsh is run as root. The capability is treated as dynamic due to the presence of read-write sections in the VPD format per PCI/PCIe specs (the idea being that read-write resource fields may potentially be altered by the DPU OS over time independently from the host OS). Unit tests cover the parser functionality (including many possible invalid cases), in-memory representation as well as XML serialization and deserialization. Manual functional testing was performed with 2 DPUs and several other NIC models which expose PCI(e) VPD. Testing have also been performed for devices that do not have VPD or those that expose a VPD capability but exhibit invalid behavior (I/O errors while reading a sysfs entry). Per the existing guidelines, the implementation relies heavily on glib for various purposes. https://libvirt.org/glib-adoption.html The v4 of the patch includes a number of fixes compared to v3: * Fixed the patch to correctly build against older glib (2.56.0); * Notably, glib commit 86c073dba9d82ef3f1bc3d3116b058b9b5c3b1eb (in 2.59.0) fixes g_autolist support for derivable Glib types. To make things work in 2.56.0 a workaround is conditionally applied; * virCreateAnonymousFile now uses a temporary file which is unlinked after creation instead of memfd because OpenSUSE 15.2 does not have support memfd; * Keyword resources now use GTree instead of GHashTable as the underlying data structure: * This allows for stable ordering which is important for XML2XML tests as they were failing with when GLib versions were different, resulting in a different ordering of elements; * The keyword resource iteration function was complex and got replaced by a simpler g_tree_foreach-based approach; * Added more testing: functions added to virpci are now assessed by creating a mocked vpd file under a mocked sysfs structure while the parser is still tested in virpcivpdtest file; * Refactoring: * Applied changes based on the indent tool operation with some post-processing; * Renamed functions which had the Glib naming style to use camel case where possible. Auto-generated declarations are an exception: gobject/gtype.h defines type_name##_init, type_name##_class_init, module_obj_name##_get_type functions which were left unchanged; * camelCase is now used for local variables and function parameters; * Replaced //-style comments with multi-line ones; * Split out one patch into 4 based on distinct features: * PCI VPD parser functionality and the respective in-memory types; * VPD helpers in virpci; * XML serialization/deserialization and VPD capability support; * Documentation. Build & test results for targets in ci/manifest.yaml: ci/helper test --meson-args='-Dexpensive_tests=enabled' <target> * First Patch: https://gist.github.com/dshcherb/8388165df0b62b71c2c95fbc351d1aee * Patches 1 and 2: https://gist.github.com/dshcherb/33c3f0f6e717788aea24b5dae2210f38 * Patches 1, 2 and 3: https://gist.github.com/dshcherb/400bcb13d01fd28030f4986e3e178262 * All patches: https://gist.github.com/dshcherb/b2fc8bd3a349f6357a25da85c542dda3 Dmitrii Shcherbakov (4): Add a PCI/PCIe device VPD Parser Add PCI VPD-related helper functions to virpci Add PCI VPD Capability Support Add PCI VPD Capability Documentation build-aux/syntax-check.mk | 4 +- docs/drvnodedev.html.in | 46 ++ docs/formatnode.html.in | 24 +- docs/schemas/nodedev.rng | 40 + include/libvirt/libvirt-nodedev.h | 1 + po/POTFILES.in | 1 + src/conf/node_device_conf.c | 271 +++++++ src/conf/node_device_conf.h | 6 +- src/conf/virnodedeviceobj.c | 7 +- src/libvirt_private.syms | 17 + src/node_device/node_device_driver.c | 2 + src/node_device/node_device_udev.c | 2 + src/util/meson.build | 1 + src/util/virpci.c | 62 ++ src/util/virpci.h | 3 + src/util/virpcivpd.c | 755 ++++++++++++++++++ src/util/virpcivpd.h | 117 +++ src/util/virpcivpdpriv.h | 45 ++ tests/meson.build | 1 + .../pci_0000_42_00_0_vpd.xml | 33 + .../pci_0000_42_00_0_vpd.xml | 1 + tests/nodedevxml2xmltest.c | 1 + tests/testutils.c | 40 + tests/testutils.h | 4 + tests/virpcimock.c | 30 + tests/virpcitest.c | 64 ++ tests/virpcivpdtest.c | 704 ++++++++++++++++ tools/virsh-nodedev.c | 3 + 28 files changed, 2280 insertions(+), 5 deletions(-) create mode 100644 src/util/virpcivpd.c create mode 100644 src/util/virpcivpd.h create mode 100644 src/util/virpcivpdpriv.h create mode 100644 tests/nodedevschemadata/pci_0000_42_00_0_vpd.xml create mode 120000 tests/nodedevxml2xmlout/pci_0000_42_00_0_vpd.xml create mode 100644 tests/virpcivpdtest.c -- 2.30.2

1 5

[RFC PATCH 0/1] qemuxml2argvtest: Add DO_TEST_CAPS_LATEST cases for every input file
by Peter Krempa 22 Sep '21

22 Sep '21

Our QEMU commandline generation testsuite has still quite a few test cases based on fake capabilities. This might be okay in many cases but comparably doesn't scale with any real use case. I propose we add a DO_TEST_CAPS_LATEST case for every test case we have (currently this patch does it only for DO_TEST_NOCAPS as example). In this instance since we are keeping the old test too we can approach it IMO by just trusting that they are okay. The DO_TEST_NOCAPS were simple enough for now, but DO_TEST caused few more problems, thus I'm keeping this open for discussion or potentially somebody stepping up and fixing another set of test cases as I've did with 'disk'-related cases. Peter Krempa (1): qemuxml2argvtest: Add 'latest' test case for each DO_TEST_NOCAPS case

1 1

[PATCH 00/20] qemuxml2argvtest: Cleanup and modernize disk-related (and other) tests
by Peter Krempa 22 Sep '21

22 Sep '21

This series cleans up disk related tests and ensures that all use real capabilities. This is preparation for an upcoming RFC patch adding real caps test for everything. Peter Krempa (20): testCompareXMLToArgv: Avoid use of uninitialized 'monitor_chr' testQemuInfoInitArgs: Report error if path to 'latest' caps for an arch is NULL qemuxml2argvtest: Remove 'boot-strict' case qemuxml2argvtest: Agregate all 'disk'-related test cases qemuxml2argvtest: Remove fake caps versions of disk tests we have a versioned test for qemuxml2argvtest: Remove negative case for 'luks-disks-source-qcow2' qemuxml2argvtest: Remove 'disk-usb-nosupport' case qemuxml2argvtest: Convert encrypted disk test cases to DO_TEST_CAPS_LATEST qemuxml2argvtest: Use DO_TEST_CAPS_LATEST_PARSE_ERROR for disk cases qemuxml2argvtest: Use real caps for all disk frontend property tests qemuxml2argvtest: Replace 'disk-network-iscsi' by the more comprehensive 'disk-network-iscsi-modern' qemuxml2argvtest: Merge 'disk-iscsi' case into 'disk-cache' qemuxml2argvtest: Modernize 'disk-network-rbd-no-colon' case qemuxml2argvtest: Modernize outstanding disk-backend related tests qemuxml2argvtest: Modernize 'disk-floppy-pseries' case qemuxml2argvtest: Modernize s390x disk tests tests: qemu: Remove 'virtio-ccw' machine type from fake capabilities qemuxml2argvtest: Use versioned ("4.1.0") capabilities for pre '-audiodev' cases qemuxml2argvtest: Pin old-style '-no-reboot' usage to qemu-5.2 qemuxml2argvtest: remove 'fs9p' cases with fake capabilities. .../qemuhotplug-base-ccw-live+ccw-virtio.xml | 2 +- ...ith-2-ccw-virtio+ccw-virtio-1-explicit.xml | 2 +- ...with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 2 +- ...otplug-base-ccw-live-with-2-ccw-virtio.xml | 2 +- ...-with-ccw-virtio+ccw-virtio-2-explicit.xml | 2 +- ...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 2 +- ...uhotplug-base-ccw-live-with-ccw-virtio.xml | 2 +- .../qemuhotplug-base-ccw-live.xml | 2 +- ...args => audio-alsa-best.x86_64-4.1.0.args} | 9 +- ...l.err => audio-alsa-full.x86_64-4.1.0.err} | 0 ...s => audio-alsa-minimal.x86_64-4.1.0.args} | 9 +- ...=> audio-coreaudio-best.x86_64-4.1.0.args} | 9 +- ... => audio-coreaudio-full.x86_64-4.1.0.err} | 0 ...audio-coreaudio-minimal.x86_64-4.1.0.args} | 9 +- ...udio-default-nographics.x86_64-4.1.0.args} | 9 +- ...args => audio-file-best.x86_64-4.1.0.args} | 9 +- ...l.err => audio-file-full.x86_64-4.1.0.err} | 0 ...s => audio-file-minimal.x86_64-4.1.0.args} | 9 +- ...l.err => audio-jack-full.x86_64-4.1.0.err} | 0 ...rr => audio-jack-minimal.x86_64-4.1.0.err} | 0 ...r => audio-many-backends.x86_64-4.1.0.err} | 0 ...args => audio-none-best.x86_64-4.1.0.args} | 9 +- ...l.err => audio-none-full.x86_64-4.1.0.err} | 0 ...s => audio-none-minimal.x86_64-4.1.0.args} | 9 +- ....args => audio-oss-best.x86_64-4.1.0.args} | 9 +- ...ll.err => audio-oss-full.x86_64-4.1.0.err} | 0 ...gs => audio-oss-minimal.x86_64-4.1.0.args} | 9 +- ...> audio-pulseaudio-best.x86_64-4.1.0.args} | 9 +- ...=> audio-pulseaudio-full.x86_64-4.1.0.err} | 0 ...udio-pulseaudio-minimal.x86_64-4.1.0.args} | 9 +- ....args => audio-sdl-best.x86_64-4.1.0.args} | 9 +- ...ll.err => audio-sdl-full.x86_64-4.1.0.err} | 0 ...gs => audio-sdl-minimal.x86_64-4.1.0.args} | 9 +- ...rgs => audio-spice-best.x86_64-4.1.0.args} | 9 +- ....err => audio-spice-full.x86_64-4.1.0.err} | 0 ... => audio-spice-minimal.x86_64-4.1.0.args} | 9 +- .../qemuxml2argvdata/balloon-ccw-deflate.args | 2 +- .../qemuxml2argvdata/balloon-ccw-deflate.xml | 2 +- tests/qemuxml2argvdata/boot-strict.args | 48 ---- tests/qemuxml2argvdata/boot-strict.xml | 66 ----- .../qemuxml2argvdata/console-virtio-ccw.args | 2 +- tests/qemuxml2argvdata/console-virtio-ccw.xml | 2 +- ...> disk-address-conflict.x86_64-latest.err} | 0 tests/qemuxml2argvdata/disk-aio.args | 34 --- tests/qemuxml2argvdata/disk-blockio.args | 34 --- .../disk-blockio.x86_64-latest.args | 39 +++ tests/qemuxml2argvdata/disk-boot-cdrom.args | 33 --- .../disk-boot-cdrom.x86_64-latest.args | 38 +++ tests/qemuxml2argvdata/disk-boot-disk.args | 33 --- .../disk-boot-disk.x86_64-latest.args | 38 +++ .../disk-cache.x86_64-2.12.0.args | 2 +- .../disk-cache.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cache.xml | 2 +- .../qemuxml2argvdata/disk-cdrom-network.args | 35 --- tests/qemuxml2argvdata/disk-cdrom-tray.args | 36 --- tests/qemuxml2argvdata/disk-cdrom.args | 37 --- tests/qemuxml2argvdata/disk-copy_on_read.args | 37 --- ...device-lun-type-invalid.x86_64-latest.err} | 0 tests/qemuxml2argvdata/disk-error-policy.args | 35 --- ...dc-incompatible-address.x86_64-latest.err} | 0 ...r => disk-floppy-pseries.ppc64-latest.err} | 0 tests/qemuxml2argvdata/disk-floppy-tray.args | 36 --- .../disk-floppy-tray.x86_64-latest.args | 42 +++ tests/qemuxml2argvdata/disk-floppy.args | 35 --- ...cow.err => disk-fmt-cow.x86_64-latest.err} | 0 ...dir.err => disk-fmt-dir.x86_64-latest.err} | 0 ...iso.err => disk-fmt-iso.x86_64-latest.err} | 0 ...w.args => disk-fmt-qcow.x86_64-4.1.0.args} | 9 +- .../disk-fmt-qcow.x86_64-latest.args | 38 +++ tests/qemuxml2argvdata/disk-geometry.args | 32 --- .../disk-geometry.x86_64-latest.args | 36 +++ ...v-scsi-address-conflict.x86_64-latest.err} | 0 ...de-incompatible-address.x86_64-latest.err} | 0 tests/qemuxml2argvdata/disk-ide-split.args | 34 --- .../disk-ide-split.x86_64-latest.args | 39 +++ tests/qemuxml2argvdata/disk-ide-wwn.args | 32 --- .../disk-ide-wwn.x86_64-latest.args | 36 +++ tests/qemuxml2argvdata/disk-ioeventfd.args | 37 --- .../disk-ioeventfd.x86_64-latest.args | 42 +++ tests/qemuxml2argvdata/disk-iscsi.args | 31 --- tests/qemuxml2argvdata/disk-iscsi.xml | 28 -- ...-missing-target-invalid.x86_64-latest.err} | 0 .../disk-network-gluster.args | 35 --- ...auth-secrettype-invalid.x86_64-latest.err} | 0 ...i-auth-wrong-secrettype.x86_64-latest.err} | 0 .../disk-network-iscsi-modern.args | 47 ---- .../disk-network-iscsi-modern.xml | 88 ------ .../qemuxml2argvdata/disk-network-iscsi.args | 42 --- .../disk-network-iscsi.x86_64-2.12.0.args | 5 + .../disk-network-iscsi.x86_64-latest.args | 31 ++- tests/qemuxml2argvdata/disk-network-iscsi.xml | 25 +- tests/qemuxml2argvdata/disk-network-nbd.args | 39 --- ...isk-network-rbd-no-colon.x86_64-4.1.0.err} | 0 ...sk-network-rbd-no-colon.x86_64-latest.args | 39 +++ .../disk-network-sheepdog.args | 33 --- ...etwork-source-auth-both.x86_64-latest.err} | 0 .../disk-network-source-auth.args | 38 --- tests/qemuxml2argvdata/disk-network-vxhs.args | 32 --- tests/qemuxml2argvdata/disk-no-boot.args | 36 --- .../disk-no-boot.x86_64-latest.args | 42 +++ tests/qemuxml2argvdata/disk-order.args | 38 --- .../disk-order.x86_64-latest.args | 45 +++ .../qemuxml2argvdata/disk-readonly-disk.args | 34 --- ...rr => disk-same-targets.x86_64-latest.err} | 0 tests/qemuxml2argvdata/disk-sata-device.args | 33 --- .../disk-sata-device.x86_64-latest.args | 37 +++ ...ta-incompatible-address.x86_64-latest.err} | 0 .../disk-scsi-disk-split.args | 42 --- .../disk-scsi-disk-split.x86_64-latest.args | 49 ++++ ...si-disk-vpd-build-error.x86_64-latest.err} | 0 .../qemuxml2argvdata/disk-scsi-disk-vpd.args | 36 --- .../disk-scsi-disk-vpd.x86_64-latest.args | 41 +++ .../qemuxml2argvdata/disk-scsi-disk-wwn.args | 36 --- .../disk-scsi-disk-wwn.x86_64-latest.args | 41 +++ ...si-incompatible-address.x86_64-latest.err} | 0 .../disk-scsi-lun-passthrough.args | 36 --- ...sk-scsi-lun-passthrough.x86_64-latest.args | 41 +++ tests/qemuxml2argvdata/disk-serial.args | 35 --- .../disk-serial.x86_64-latest.args | 40 +++ ...err => disk-shared-qcow.x86_64-latest.err} | 0 tests/qemuxml2argvdata/disk-snapshot.args | 36 --- .../disk-snapshot.x86_64-latest.args | 42 +++ ...> disk-source-pool-mode.x86_64-4.1.0.args} | 9 +- .../disk-source-pool-mode.x86_64-latest.args | 45 +++ ...rgs => disk-source-pool.x86_64-4.1.0.args} | 13 +- .../disk-source-pool.x86_64-latest.args | 46 +++ .../disk-usb-device-removable.args | 34 --- ...sk-usb-device-removable.x86_64-latest.args | 39 +++ tests/qemuxml2argvdata/disk-usb-device.args | 34 --- .../disk-usb-device.x86_64-latest.args | 39 +++ tests/qemuxml2argvdata/disk-usb-nosupport.err | 1 - tests/qemuxml2argvdata/disk-usb-nosupport.xml | 35 --- ...pci.err => disk-usb-pci.x86_64-latest.err} | 0 .../disk-virtio-ccw-many.args | 36 --- .../disk-virtio-ccw-many.s390x-latest.args | 43 +++ .../qemuxml2argvdata/disk-virtio-ccw-many.xml | 2 +- tests/qemuxml2argvdata/disk-virtio-ccw.args | 32 --- .../disk-virtio-ccw.s390x-latest.args | 37 +++ tests/qemuxml2argvdata/disk-virtio-ccw.xml | 2 +- .../disk-virtio-s390-zpci.args | 31 --- .../disk-virtio-s390-zpci.s390x-latest.args | 35 +++ tests/qemuxml2argvdata/disk-virtio.args | 37 --- .../disk-virtio.x86_64-latest.args | 44 +++ ...=> encrypted-disk-usage.x86_64-4.1.0.args} | 11 +- .../encrypted-disk-usage.x86_64-latest.args | 37 +++ ....args => encrypted-disk.x86_64-4.1.0.args} | 11 +- .../encrypted-disk.x86_64-latest.args | 37 +++ tests/qemuxml2argvdata/event_idx.args | 37 --- .../event_idx.x86_64-latest.args | 42 +++ tests/qemuxml2argvdata/floppy-drive-fat.args | 33 --- tests/qemuxml2argvdata/fs9p-ccw.args | 36 --- tests/qemuxml2argvdata/fs9p.args | 34 --- .../hostdev-scsi-vhost-scsi-ccw.args | 2 +- .../hostdev-scsi-vhost-scsi-ccw.xml | 2 +- ...-drive-address-conflict.x86_64-latest.err} | 0 .../iothreads-disk-virtio-ccw.args | 2 +- .../iothreads-disk-virtio-ccw.xml | 2 +- ...rr => luks-disk-invalid.x86_64-latest.err} | 0 ... luks-disks-source-both.x86_64-latest.err} | 0 .../luks-disks-source-qcow2.err | 1 - ...gs => luks-disks-source.x86_64-4.1.0.args} | 17 +- .../luks-disks-source.x86_64-latest.args | 54 ++++ ...isks.args => luks-disks.x86_64-4.1.0.args} | 11 +- .../luks-disks.x86_64-latest.args | 41 +++ tests/qemuxml2argvdata/misc-no-reboot.args | 31 --- .../misc-no-reboot.x86_64-5.2.0.args | 35 +++ tests/qemuxml2argvdata/net-virtio-ccw.args | 2 +- tests/qemuxml2argvdata/net-virtio-ccw.xml | 2 +- .../non-x86_64-timer-error.err | 2 +- .../non-x86_64-timer-error.xml | 2 +- tests/qemuxml2argvdata/virtio-lun.args | 37 --- .../virtio-lun.x86_64-latest.args | 42 +++ tests/qemuxml2argvdata/virtio-rng-ccw.args | 2 +- tests/qemuxml2argvdata/virtio-rng-ccw.xml | 2 +- tests/qemuxml2argvtest.c | 261 +++++++----------- .../disk-cache.x86_64-2.12.0.xml | 2 +- .../disk-cache.x86_64-latest.xml | 2 +- .../qemuxml2xmloutdata/disk-network-iscsi.xml | 25 ++ .../hostdev-scsi-vhost-scsi-ccw.xml | 2 +- .../iothreads-disk-virtio-ccw.xml | 2 +- tests/testutilsqemu.c | 8 +- 181 files changed, 1726 insertions(+), 2164 deletions(-) rename tests/qemuxml2argvdata/{audio-alsa-best.args => audio-alsa-best.x86_64-4.1.0.args} (81%) rename tests/qemuxml2argvdata/{audio-alsa-full.err => audio-alsa-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-alsa-minimal.args => audio-alsa-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-coreaudio-best.args => audio-coreaudio-best.x86_64-4.1.0.args} (81%) rename tests/qemuxml2argvdata/{audio-coreaudio-full.err => audio-coreaudio-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-coreaudio-minimal.args => audio-coreaudio-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-default-nographics.args => audio-default-nographics.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-file-best.args => audio-file-best.x86_64-4.1.0.args} (81%) rename tests/qemuxml2argvdata/{audio-file-full.err => audio-file-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-file-minimal.args => audio-file-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-jack-full.err => audio-jack-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-jack-minimal.err => audio-jack-minimal.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-many-backends.err => audio-many-backends.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-none-best.args => audio-none-best.x86_64-4.1.0.args} (80%) rename tests/qemuxml2argvdata/{audio-none-full.err => audio-none-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-none-minimal.args => audio-none-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-oss-best.args => audio-oss-best.x86_64-4.1.0.args} (82%) rename tests/qemuxml2argvdata/{audio-oss-full.err => audio-oss-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-oss-minimal.args => audio-oss-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-pulseaudio-best.args => audio-pulseaudio-best.x86_64-4.1.0.args} (82%) rename tests/qemuxml2argvdata/{audio-pulseaudio-full.err => audio-pulseaudio-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-pulseaudio-minimal.args => audio-pulseaudio-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-sdl-best.args => audio-sdl-best.x86_64-4.1.0.args} (81%) rename tests/qemuxml2argvdata/{audio-sdl-full.err => audio-sdl-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-sdl-minimal.args => audio-sdl-minimal.x86_64-4.1.0.args} (75%) rename tests/qemuxml2argvdata/{audio-spice-best.args => audio-spice-best.x86_64-4.1.0.args} (80%) rename tests/qemuxml2argvdata/{audio-spice-full.err => audio-spice-full.x86_64-4.1.0.err} (100%) rename tests/qemuxml2argvdata/{audio-spice-minimal.args => audio-spice-minimal.x86_64-4.1.0.args} (75%) delete mode 100644 tests/qemuxml2argvdata/boot-strict.args delete mode 100644 tests/qemuxml2argvdata/boot-strict.xml rename tests/qemuxml2argvdata/{disk-address-conflict.err => disk-address-conflict.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-aio.args delete mode 100644 tests/qemuxml2argvdata/disk-blockio.args create mode 100644 tests/qemuxml2argvdata/disk-blockio.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-boot-cdrom.args create mode 100644 tests/qemuxml2argvdata/disk-boot-cdrom.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-boot-disk.args create mode 100644 tests/qemuxml2argvdata/disk-boot-disk.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-network.args delete mode 100644 tests/qemuxml2argvdata/disk-cdrom-tray.args delete mode 100644 tests/qemuxml2argvdata/disk-cdrom.args delete mode 100644 tests/qemuxml2argvdata/disk-copy_on_read.args rename tests/qemuxml2argvdata/{disk-device-lun-type-invalid.err => disk-device-lun-type-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-error-policy.args rename tests/qemuxml2argvdata/{disk-fdc-incompatible-address.err => disk-fdc-incompatible-address.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{disk-floppy-pseries.err => disk-floppy-pseries.ppc64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-floppy-tray.args create mode 100644 tests/qemuxml2argvdata/disk-floppy-tray.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-floppy.args rename tests/qemuxml2argvdata/{disk-fmt-cow.err => disk-fmt-cow.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{disk-fmt-dir.err => disk-fmt-dir.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{disk-fmt-iso.err => disk-fmt-iso.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{disk-fmt-qcow.args => disk-fmt-qcow.x86_64-4.1.0.args} (77%) create mode 100644 tests/qemuxml2argvdata/disk-fmt-qcow.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-geometry.args create mode 100644 tests/qemuxml2argvdata/disk-geometry.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-hostdev-scsi-address-conflict.err => disk-hostdev-scsi-address-conflict.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{disk-ide-incompatible-address.err => disk-ide-incompatible-address.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-ide-split.args create mode 100644 tests/qemuxml2argvdata/disk-ide-split.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-ide-wwn.args create mode 100644 tests/qemuxml2argvdata/disk-ide-wwn.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-ioeventfd.args create mode 100644 tests/qemuxml2argvdata/disk-ioeventfd.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-iscsi.args delete mode 100644 tests/qemuxml2argvdata/disk-iscsi.xml rename tests/qemuxml2argvdata/{disk-missing-target-invalid.err => disk-missing-target-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-network-gluster.args rename tests/qemuxml2argvdata/{disk-network-iscsi-auth-secrettype-invalid.err => disk-network-iscsi-auth-secrettype-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{disk-network-iscsi-auth-wrong-secrettype.err => disk-network-iscsi-auth-wrong-secrettype.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi-modern.args delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi-modern.xml delete mode 100644 tests/qemuxml2argvdata/disk-network-iscsi.args delete mode 100644 tests/qemuxml2argvdata/disk-network-nbd.args rename tests/qemuxml2argvdata/{disk-network-rbd-no-colon.err => disk-network-rbd-no-colon.x86_64-4.1.0.err} (100%) create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-no-colon.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-network-sheepdog.args rename tests/qemuxml2argvdata/{disk-network-source-auth-both.err => disk-network-source-auth-both.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-network-source-auth.args delete mode 100644 tests/qemuxml2argvdata/disk-network-vxhs.args delete mode 100644 tests/qemuxml2argvdata/disk-no-boot.args create mode 100644 tests/qemuxml2argvdata/disk-no-boot.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-order.args create mode 100644 tests/qemuxml2argvdata/disk-order.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-readonly-disk.args rename tests/qemuxml2argvdata/{disk-same-targets.err => disk-same-targets.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-sata-device.args create mode 100644 tests/qemuxml2argvdata/disk-sata-device.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-sata-incompatible-address.err => disk-sata-incompatible-address.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-split.args create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-split.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-scsi-disk-vpd-build-error.err => disk-scsi-disk-vpd-build-error.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-vpd.args create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-vpd.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-wwn.args create mode 100644 tests/qemuxml2argvdata/disk-scsi-disk-wwn.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-scsi-incompatible-address.err => disk-scsi-incompatible-address.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-scsi-lun-passthrough.args create mode 100644 tests/qemuxml2argvdata/disk-scsi-lun-passthrough.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-serial.args create mode 100644 tests/qemuxml2argvdata/disk-serial.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-shared-qcow.err => disk-shared-qcow.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-snapshot.args create mode 100644 tests/qemuxml2argvdata/disk-snapshot.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-source-pool-mode.args => disk-source-pool-mode.x86_64-4.1.0.args} (84%) create mode 100644 tests/qemuxml2argvdata/disk-source-pool-mode.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-source-pool.args => disk-source-pool.x86_64-4.1.0.args} (73%) create mode 100644 tests/qemuxml2argvdata/disk-source-pool.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-usb-device-removable.args create mode 100644 tests/qemuxml2argvdata/disk-usb-device-removable.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-usb-device.args create mode 100644 tests/qemuxml2argvdata/disk-usb-device.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-usb-nosupport.err delete mode 100644 tests/qemuxml2argvdata/disk-usb-nosupport.xml rename tests/qemuxml2argvdata/{disk-usb-pci.err => disk-usb-pci.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw-many.args create mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw-many.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw.args create mode 100644 tests/qemuxml2argvdata/disk-virtio-ccw.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.args create mode 100644 tests/qemuxml2argvdata/disk-virtio-s390-zpci.s390x-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio.args create mode 100644 tests/qemuxml2argvdata/disk-virtio.x86_64-latest.args rename tests/qemuxml2argvdata/{encrypted-disk-usage.args => encrypted-disk-usage.x86_64-4.1.0.args} (74%) create mode 100644 tests/qemuxml2argvdata/encrypted-disk-usage.x86_64-latest.args rename tests/qemuxml2argvdata/{encrypted-disk.args => encrypted-disk.x86_64-4.1.0.args} (74%) create mode 100644 tests/qemuxml2argvdata/encrypted-disk.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/event_idx.args create mode 100644 tests/qemuxml2argvdata/event_idx.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/floppy-drive-fat.args delete mode 100644 tests/qemuxml2argvdata/fs9p-ccw.args delete mode 100644 tests/qemuxml2argvdata/fs9p.args rename tests/qemuxml2argvdata/{hostdevs-drive-address-conflict.err => hostdevs-drive-address-conflict.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{luks-disk-invalid.err => luks-disk-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{luks-disks-source-both.err => luks-disks-source-both.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/luks-disks-source-qcow2.err rename tests/qemuxml2argvdata/{luks-disks-source.args => luks-disks-source.x86_64-4.1.0.args} (80%) create mode 100644 tests/qemuxml2argvdata/luks-disks-source.x86_64-latest.args rename tests/qemuxml2argvdata/{luks-disks.args => luks-disks.x86_64-4.1.0.args} (77%) create mode 100644 tests/qemuxml2argvdata/luks-disks.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/misc-no-reboot.args create mode 100644 tests/qemuxml2argvdata/misc-no-reboot.x86_64-5.2.0.args delete mode 100644 tests/qemuxml2argvdata/virtio-lun.args create mode 100644 tests/qemuxml2argvdata/virtio-lun.x86_64-latest.args -- 2.31.1

2 23