- Devel - libvirt List Archives

[libvirt] [PATCH] libxenlight driver
by Jim Fehlig 14 Feb '11

14 Feb '11

Hi All, Here's a first cut of libxenlight driver for libvirt. The driver is stateful and provides functionality for managed (persistent) domains. The driver only maintains state for and manages domains under its control, ignoring domains created by other libxenlight clients, e.g. xl. As you can see, a fair number of the driver functions are implemented, at least what I think constitutes a minimal set for upstream inclusion. Are there any required functions missing? I'm still looking into a problem with failure to restart a domain, persistent or otherwise. E.g. virsh start|create domU; virsh shutdown domU; virsh start|create domU. The second start/create fails in libxenlight, but I've not yet tracked down the cause. Also, I've not yet handled restart of libvirtd if domains are running - not sure if this is a requirement for initial inclusion. TIA for your review and comment. Regards, Jim

2 1

[libvirt] [PATCH] libvirt-qemu: Fix enum type declaration
by Jiri Denemark 14 Feb '11

14 Feb '11

--- Ugh! Sorry for this stupid typo. include/libvirt/libvirt-qemu.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 9257c2f..f172eff 100644 --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -20,7 +20,7 @@ extern "C" { # endif -enum { +typedef enum { VIR_DOMAIN_QEMU_MONITOR_COMMAND_DEFAULT = 0, VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP = (1 << 0), /* cmd is in HMP */ } virDomainQemuMonitorCommandFlags; -- 1.7.4

2 2

[libvirt] [PATCH] osx: fix broken enum typedef declaration breaking compilation on osx
by Justin Clift 14 Feb '11

14 Feb '11

As pointed out by Daniel Berrange, this broken enum declaration was the cause of "duplicate symbol _virDomainQemuMonitorCommandFlags ..." errors on OSX. --- include/libvirt/libvirt-qemu.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/libvirt/libvirt-qemu.h b/include/libvirt/libvirt-qemu.h index 9257c2f..f172eff 100644 --- a/include/libvirt/libvirt-qemu.h +++ b/include/libvirt/libvirt-qemu.h @@ -20,7 +20,7 @@ extern "C" { # endif -enum { +typedef enum { VIR_DOMAIN_QEMU_MONITOR_COMMAND_DEFAULT = 0, VIR_DOMAIN_QEMU_MONITOR_COMMAND_HMP = (1 << 0), /* cmd is in HMP */ } virDomainQemuMonitorCommandFlags; -- 1.7.4.1

1 1

[libvirt] [PATCH 0/3] Basic libxenlight driver
by Markus Groß 14 Feb '11

14 Feb '11

Hi, I started working on a libxenlight driver for libvirt a few weeks ago. By that time I didn't knew Jim Fehlig was also working on a driver for that api: http://article.gmane.org/gmane.comp.emulators.libvirt/33024 Because I already did some work and there is no driver from Jim yet, I am posting my current version of the driver here. It is a driver for the libxl (libxenlight) interface from the upcoming xen 4.1. This driver is divided into 3 patches, the first adds the driver without changing anything in libvirt, the second one integrates it into the build system of libvirt. The last one is self explanatory. However there are a few caveats. 1. The driver offers only basic functionality like: suspend, resume, pinvcpu, etc. create, restore, definexml and others are not yet implemented. 2. The driver supports libvirtxml <-> xen-xm conversion, thanks to the unified xen driver which already offered this functionality. But since this driver is not part of xen unified, I had to copy this functionality, rather than reusing it. 3. To compile libvirt with this driver, there is a new flag --with-xenlight. To fix some linker errors, libvirt has to link against several additional libraries now which are used in xen's libxenlight. These libraries are not directly used within libvirt, but I believe that some of them are GPL licensed, so that could be an issue. 4. To compile the driver you may need to copy the libxl_utils.h from tools/libxl of your xen-source directory to an include dir in your PATH. Right now this file is not copied when installing xen, but I will talk with the xen developers about that. Please let me know what you think about it. Thanks, Markus Markus Groß (3): Add basic libxenlight driver Integrate libxenlight driver into libvirt Add myself to AUTHORS AUTHORS | 1 + configure.ac | 35 +- include/libvirt/virterror.h | 1 + po/POTFILES.in | 2 + src/Makefile.am | 25 + src/driver.h | 3 +- src/libvirt.c | 13 + src/util/virterror.c | 3 + src/xenlight/xl_driver.c | 948 ++++++++++++++++++ src/xenlight/xl_driver.h | 46 + src/xenlight/xl_driver_private.h | 52 + src/xenlight/xl_utils.c | 1969 ++++++++++++++++++++++++++++++++++++++ src/xenlight/xl_utils.h | 90 ++ tools/virsh.c | 3 + 14 files changed, 3188 insertions(+), 3 deletions(-) create mode 100644 src/xenlight/xl_driver.c create mode 100644 src/xenlight/xl_driver.h create mode 100644 src/xenlight/xl_driver_private.h create mode 100644 src/xenlight/xl_utils.c create mode 100644 src/xenlight/xl_utils.h -- 1.7.4

3 7

[libvirt] [PATCH 0/2] Give each virtual network bridge its own fixed MAC address
by Laine Stump 14 Feb '11

14 Feb '11

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=609463 As usual for me, this series has a problem searching for a more elegant solution. See PATCH 2/2 for details. Is it too late to put this in 0.8.8? (assuming a solution to that problem, of course).

4 10

[libvirt] Entering freeze for libvirt-0.8.8
by Daniel Veillard 13 Feb '11

13 Feb '11

We're entering the week freeze for 0.8.8, so let's delay new feature until the end of next week and let's focuse on bug fixes. I have put an initial release candidate at: ftp://libvirt.org/libvirt/libvirt-0.8.8-rc1.tar.gz it seems to compile and work fine for me. there is however a small problem at configure time: ------------------------------------- thinkpad:~/tmp/libvirt-0.8.8 -> ./autogen.sh --system ; make Running ./configure with --prefix=/usr --sysconfdir=/etc --localstatedir=/var --libdir=/usr/lib fatal: Not a git repository (or any of the parent directories): .git fatal: Cannot open 'bootstrap.conf': No such file or directory usage: git diff [--no-index] <path> <path> /home/veillard/tmp/libvirt-0.8.8/tmpwrk2661/archive /home/veillard/tmp/libvirt-0.8.8/tmpwrk2661/archive /home/veillard/tmp/libvirt-0.8.8/tmpwrk2661/archive Copying file m4/codeset.m4 ------------------------------------- Seems some git command is launched but errors out, that's normal but it should not pollute the output (there is also the extra paths output but that's due to the fact that I use CDPATH env variable and as a result "cd dir" is not silent when successful but output the target dir). Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

6 9

[libvirt] [PATCH] Update src/README
by Matthias Bolte 12 Feb '11

12 Feb '11

Add missing subdirectories. --- src/README | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/README b/src/README index 75acbe0..ad171a5 100644 --- a/src/README +++ b/src/README @@ -20,6 +20,8 @@ There are two core shared modules to be aware of: files used by the public API. This directory is only in the include path for driver implementation modules + * vmx/ - VMware VMX config handling (used by esx/ and vmware/) + Then there are the hypervisor implementations: @@ -33,7 +35,9 @@ Then there are the hypervisor implementations: * test/ - A "mock" driver for testing * uml/ - User Mode Linux * vbox/ - Virtual Box using native API + * vmware/ - VMware Workstation and Player using the vmrun tool * xen/ - Xen using hypercalls, XenD SEXPR & XenStore + * xenapi/ - Xen using libxenserver Finally some secondary drivers that are shared for several HVs. @@ -41,8 +45,10 @@ Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers. The ESX, OpenNebula, Power Hypervisor, Remote, Test & VirtualBox drivers all implement the secondary drivers directly + * cpu/ - CPU feature management * interface/ - Host network interface management * network/ - Virtual NAT networking + * nwfilter/ - Network traffic filtering rules * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers -- 1.7.0.4

2 2

[libvirt] [PATCH] Avoid pthread_sigmask on Win32 platforms
by Daniel P. Berrange 12 Feb '11

12 Feb '11

Win32 doesn't have a concept of signal masks so disable that code. It is unclear how SIGINT is delivered (if at all) on Win32, so this might further work to provide an alternative to pthread_sigmask * tools/virsh.c: Avoid pthread_sigmask on Win32 --- tools/virsh.c | 20 +++++++++++++++----- 1 files changed, 15 insertions(+), 5 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index be2cd67..6d9861f 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -3489,15 +3489,17 @@ doMigrate (void *opaque) const char *migrateuri; const char *dname; int flags = 0, found; - sigset_t sigmask, oldsigmask; vshCtrlData *data = opaque; vshControl *ctl = data->ctl; const vshCmd *cmd = data->cmd; +#if HAVE_PTHREAD_SIGMASK + sigset_t sigmask, oldsigmask; sigemptyset(&sigmask); sigaddset(&sigmask, SIGINT); if (pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask) < 0) goto out_sig; +#endif if (!vshConnectionUsability (ctl, ctl->conn)) goto out; @@ -3563,8 +3565,10 @@ doMigrate (void *opaque) } out: +#if HAVE_PTHREAD_SIGMASK pthread_sigmask(SIG_SETMASK, &oldsigmask, NULL); out_sig: +#endif if (dom) virDomainFree (dom); ignore_value(safewrite(data->writefd, &ret, sizeof(ret))); } @@ -3607,12 +3611,16 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd) struct sigaction old_sig_action; virDomainJobInfo jobinfo; bool verbose = false; - sigset_t sigmask, oldsigmask; int timeout; struct timeval start, curr; bool live_flag = false; - vshCtrlData data; +#if HAVE_PTHREAD_SIGMASK + sigset_t sigmask, oldsigmask; + + sigemptyset(&sigmask); + sigaddset(&sigmask, SIGINT); +#endif if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) return FALSE; @@ -3665,8 +3673,6 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd) pollfd.fd = p[0]; pollfd.events = POLLIN; pollfd.revents = 0; - sigemptyset(&sigmask); - sigaddset(&sigmask, SIGINT); GETTIMEOFDAY(&start); while (1) { @@ -3709,9 +3715,13 @@ repoll: } if (verbose) { +#if HAVE_PTHREAD_SIGMASK pthread_sigmask(SIG_BLOCK, &sigmask, &oldsigmask); +#endif ret = virDomainGetJobInfo(dom, &jobinfo); +#if HAVE_PTHREAD_SIGMASK pthread_sigmask(SIG_SETMASK, &oldsigmask, NULL); +#endif if (ret == 0) print_job_progress(jobinfo.dataRemaining, jobinfo.dataTotal); } -- 1.7.4

3 9

[libvirt] [PATCH] build: avoid problems with autogen.sh runs from tarball
by Eric Blake 12 Feb '11

12 Feb '11

Introduced by commit fac97c65c distributing cfg.mk, which previously could blindly assume it was in a git checkout. * cfg.mk (_update_required): Also check for .git. * autogen.sh: Don't run bootstrap from a tarball. Reported by Daniel Veillard. --- This should fix the issues of mistakenly running git on a tarball, as reported here: https://www.redhat.com/archives/libvir-list/2011-February/msg00371.html autogen.sh | 27 +++++++++++++++------------ cfg.mk | 1 + 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/autogen.sh b/autogen.sh index ff13fd1..b64521e 100755 --- a/autogen.sh +++ b/autogen.sh @@ -8,8 +8,8 @@ THEDIR=`pwd` cd "$srcdir" test -f src/libvirt.c || { - echo "You must run this script in the top-level libvirt directory" - exit 1 + echo "You must run this script in the top-level libvirt directory" + exit 1 } @@ -52,16 +52,19 @@ bootstrap_hash() # Also, running 'make rpm' tends to litter the po/ directory, and some people # like to run 'git clean -x -f po' to fix it; but only ./bootstrap regenerates # the required file po/Makevars. -curr_status=.git-module-status -t=$(bootstrap_hash; git diff .gnulib) -if test "$t" = "$(cat $curr_status 2>/dev/null)" \ - && test -f "po/Makevars"; then - # good, it's up to date, all we need is autoreconf - autoreconf -if -else - echo running bootstrap$no_git... - ./bootstrap$no_git --bootstrap-sync && bootstrap_hash > $curr_status \ - || { echo "Failed to bootstrap, please investigate."; exit 1; } +# Only run bootstrap from a git checkout, never from a tarball. +if test -d .git; then + curr_status=.git-module-status + t=$(bootstrap_hash; git diff .gnulib) + if test "$t" = "$(cat $curr_status 2>/dev/null)" \ + && test -f "po/Makevars"; then + # good, it's up to date, all we need is autoreconf + autoreconf -if + else + echo running bootstrap$no_git... + ./bootstrap$no_git --bootstrap-sync && bootstrap_hash > $curr_status \ + || { echo "Failed to bootstrap, please investigate."; exit 1; } + fi fi cd "$THEDIR" diff --git a/cfg.mk b/cfg.mk index 120f452..4bbeb96 100644 --- a/cfg.mk +++ b/cfg.mk @@ -507,6 +507,7 @@ ifeq (0,$(MAKELEVEL)) _submodule_hash = sed 's/^[ +-]//;s/ .*//' _update_required := $(shell \ cd '$(srcdir)'; \ + test -d .git || { echo 0; exit; }; \ test -f po/Makevars || { echo 1; exit; }; \ actual=$$(git submodule status | $(_submodule_hash); \ git hash-object bootstrap.conf; \ -- 1.7.4

2 2

[libvirt] [PATCH] qemu: Report a more informative error for missing cgroup controllers
by Matthias Bolte 12 Feb '11

12 Feb '11

Patch attached. Matthias

2 2