- Devel - libvirt List Archives

[libvirt] [PATCH 00/10 v5] Integration of lock managers in QEMU
by Daniel P. Berrange 03 Jun '11

03 Jun '11

Another update to http://www.redhat.com/archives/libvir-list/2011-May/msg01272.html New in this series - Return values < -200 are not errnos, they are sanlock specific error codes. - Fix state handling after migration This is also available at http://gitorious.org/~berrange/libvirt/staging/commits/qemu-locking where it is combined with the migration series i just sent

2 11

[libvirt] [PATCH] security driver: ignore EINVAL when chowning an image file
by Laine Stump 03 Jun '11

03 Jun '11

This fixes: https://bugzilla.redhat.com/show_bug.cgi?id=702044 https://bugzilla.redhat.com/show_bug.cgi?id=709454 Both of these complain of a failure to use an image file that resides on a read-only NFS volume. The function in the DAC security driver that chowns image files to the qemu user:group before using them already has special cases to ignore failure of chown on read-only file systems, and in a few other cases, but it hadn't been checking for EINVAL, which is what is returned if the qemu user doesn't even exist on the NFS server. Since the explanation of EINVAL in the chown man page almost exactly matches the log message already present for the case of EOPNOTSUPP, I've just added EINVAL to that same conditional. --- src/security/security_dac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index b8642d2..24b50e6 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -110,7 +110,7 @@ virSecurityDACSetOwnership(const char *path, int uid, int gid) } } - if (chown_errno == EOPNOTSUPP) { + if (chown_errno == EOPNOTSUPP || chown_errno == EINVAL) { VIR_INFO("Setting user and group to '%d:%d' on '%s' not supported by filesystem", uid, gid, path); } else if (chown_errno == EPERM) { -- 1.7.3.4

2 2

[libvirt] [PATCH] qemu: Avoid use after free in qemuCaps parsing
by Jiri Denemark 03 Jun '11

03 Jun '11

--- src/qemu/qemu_domain.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 46414cd..332c09e 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -264,12 +264,13 @@ static int qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, void *data) char *str = virXMLPropString(nodes[i], "name"); if (str) { int flag = qemuCapsTypeFromString(str); - VIR_FREE(str); if (flag < 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("Unknown qemu capabilities flag %s"), str); + VIR_FREE(str); goto error; } + VIR_FREE(str); qemuCapsSet(qemuCaps, flag); } } -- 1.7.5.3

3 3

[libvirt] [PATCH] virsh: Document nodeinfo output
by Jiri Denemark 03 Jun '11

03 Jun '11

--- tools/virsh.pod | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index 9251db6..1f41652 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -235,7 +235,9 @@ Print the XML representation of the hypervisor sysinfo, if available. =item B<nodeinfo> Returns basic information about the node, like number and type of CPU, -and size of the physical memory. +and size of the physical memory. The output corresponds to virNodeInfo +structure. Specifically, the "CPU socket(s)" field means number of CPU +sockets per NUMA cell. =item B<capabilities> -- 1.7.5.3

2 2

[libvirt] Libvirt 0.9.2 week freeze, RC1 version to test
by Daniel Veillard 03 Jun '11

03 Jun '11

So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.2-rc1.tar.gz I also made rpms too for those interested. I didn't included the locking patches from Dan Berrange, though I had given a review and ACK on the previous version. Maybe we can push this soon and then I will made an rc2. It would be nice to try to identify the OpenSolaris portability issues,a dn if someone could give it a try on Win32 that would be great (along other linux builds of course !) I have tried it locally and basic operations seems to work fine, please give it a try too. thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

5 10

[libvirt] [PATCH] Correct 'cputune' documentation example.
by Neil Wilson 03 Jun '11

03 Jun '11

Signed-off-by: Neil Wilson <neil(a)aldur.co.uk> --- docs/formatdomain.html.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 0517119..225e0c8 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -293,7 +293,7 @@ <vcpupin vcpu="1" cpuset="0,1"/> <vcpupin vcpu="2" cpuset="2,3"/> <vcpupin vcpu="3" cpuset="0,4"/> - <cpushares>2048</cpushares> + <shares>2048</shares> </cputune> ...</pre> -- 1.7.4.1

2 1

[libvirt] [PATCH 00/10] coverity cleanups, round 1
by Eric Blake 03 Jun '11

03 Jun '11

Coverity reported a number of bugs against libvirt. I ran out of time to get through them all today, but there are certainly some real doozies in here. I've blamed commits where non-trivial bugs were introduced, to help distros decide if things need back-porting (I think that leaks on OOM situations and coverity false positives are not serious enough to warrant a back-port). These patches are pretty much independent (can be applied in any order); I suppose I could have rebased it to order the series by severity, oh well. Eric Blake (10): command: avoid leak on failure libvirtd: avoid leak on failure storage: avoid memory leak storage: avoid memory leak on stat failure lock: avoid leak on failure remote: avoid leak on failure qemu: avoid memory leak on vcpupin event: avoid memory leak on cleanup build: silence coverity false positive build: silence coverity false positive daemon/libvirtd.c | 4 +++- daemon/remote.c | 1 + src/conf/domain_event.c | 3 ++- src/locking/lock_manager.c | 3 ++- src/qemu/qemu_process.c | 21 +++++++++++++-------- src/remote/remote_driver.c | 7 ++++++- src/storage/storage_backend_fs.c | 15 +-------------- src/util/command.c | 5 ++++- src/util/storage_file.c | 15 +++++++-------- 9 files changed, 39 insertions(+), 35 deletions(-) -- 1.7.4.4

2 24

[libvirt] [PATCH] Fix regressions BlockStats/Info APIs in QEMU driver
by Daniel P. Berrange 03 Jun '11

03 Jun '11

From: "Daniel P. Berrange" <berrange(a)redhat.com> The change 18c2a592064d69499f70428e498f4a3cb5161cda caused some regressions in behaviour of virDomainBlockStats and virDomainBlockInfo in the QEMU driver. The virDomainBlockInfo API stopped working for inactive guests if querying a block device. The virDomainBlockStats API did not promptly report an error if the guest was not running in some cases. * src/qemu/qemu_driver.c: Fix inactive guest handling in BlockStats/Info APIs --- src/qemu/qemu_driver.c | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5632d62..3716b15 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5531,6 +5531,12 @@ qemudDomainBlockStats (virDomainPtr dom, goto cleanup; } + if (!virDomainObjIsActive(vm)) { + qemuReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + for (i = 0 ; i < vm->def->ndisks ; i++) { if (STREQ(path, vm->def->disks[i]->dst)) { disk = vm->def->disks[i]; @@ -5994,7 +6000,8 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, highest allocated extent from QEMU */ if (disk->type == VIR_DOMAIN_DISK_TYPE_BLOCK && format != VIR_STORAGE_FILE_RAW && - S_ISBLK(sb.st_mode)) { + S_ISBLK(sb.st_mode) && + virDomainObjIsActive(vm)) { qemuDomainObjPrivatePtr priv = vm->privateData; if ((priv->jobActive == QEMU_JOB_MIGRATION_OUT) @@ -6017,10 +6024,9 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, if (qemuDomainObjBeginJob(vm) < 0) goto cleanup; - if (!virDomainObjIsActive(vm)) { - qemuReportError(VIR_ERR_OPERATION_INVALID, - "%s", _("domain is not running")); - goto endjob; + if (virDomainObjIsActive(vm)) { + ret = 0; + goto cleanup; } qemuDomainObjEnterMonitor(vm); @@ -6029,7 +6035,6 @@ static int qemuDomainGetBlockInfo(virDomainPtr dom, &info->allocation); qemuDomainObjExitMonitor(vm); -endjob: if (qemuDomainObjEndJob(vm) == 0) vm = NULL; } -- 1.7.5.2

2 2

[libvirt] [PATCH] Fix minor issues in libxenlight managed save
by Jim Fehlig 03 Jun '11

03 Jun '11

There were a few minor issues in commit 5b6c961e - leak managed save path - leak managed save fd - functions that open an fd should also close it --- src/libxl/libxl_driver.c | 30 ++++++++++++++++++++---------- 1 files changed, 20 insertions(+), 10 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 9a794e8..ed24d10 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -632,23 +632,27 @@ libxlVmStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, int ret; uint32_t domid = 0; char *dom_xml = NULL; - char *managed_save = NULL; + char *managed_save_path = NULL; + int managed_save_fd = -1; pid_t child_console_pid = -1; libxlDomainObjPrivatePtr priv = vm->privateData; /* If there is a managed saved state restore it instead of starting * from scratch. The old state is removed once the restoring succeeded. */ if (restore_fd < 0) { - managed_save = libxlDomainManagedSavePath(driver, vm); - if (managed_save == NULL) + managed_save_path = libxlDomainManagedSavePath(driver, vm); + if (managed_save_path == NULL) goto error; - if (virFileExists(managed_save)) { + if (virFileExists(managed_save_path)) { - restore_fd = libxlSaveImageOpen(driver, managed_save, &def, &hdr); - if (restore_fd < 0) + managed_save_fd = libxlSaveImageOpen(driver, managed_save_path, + &def, &hdr); + if (managed_save_fd < 0) goto error; + restore_fd = managed_save_fd; + if (STRNEQ(vm->def->name, def->name) || memcmp(vm->def->uuid, def->uuid, VIR_UUID_BUFLEN)) { char vm_uuidstr[VIR_UUID_STRING_BUFLEN]; @@ -665,9 +669,12 @@ libxlVmStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, virDomainObjAssignDef(vm, def, true); def = NULL; - if (unlink(managed_save) < 0) - VIR_WARN("Failed to remove the managed state %s", managed_save); + if (unlink(managed_save_path) < 0) { + VIR_WARN("Failed to remove the managed state %s", + managed_save_path); + } } + VIR_FREE(managed_save_path); } memset(&d_config, 0, sizeof(d_config)); @@ -738,6 +745,7 @@ libxlVmStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, libxl_domain_config_destroy(&d_config); VIR_FREE(dom_xml); + VIR_FORCE_CLOSE(managed_save_fd); return 0; error: @@ -748,9 +756,9 @@ error: } libxl_domain_config_destroy(&d_config); VIR_FREE(dom_xml); - VIR_FREE(managed_save); + VIR_FREE(managed_save_path); virDomainDefFree(def); - VIR_FORCE_CLOSE(restore_fd); + VIR_FORCE_CLOSE(managed_save_fd); return -1; } @@ -1955,6 +1963,8 @@ libxlDomainRestore(virConnectPtr conn, const char *from) } cleanup: + if (VIR_CLOSE(fd) < 0) + virReportSystemError(errno, "%s", _("cannot close file")); virDomainDefFree(def); if (vm) virDomainObjUnlock(vm); -- 1.7.3.1

3 3

[libvirt] [PATCH 0/2] libxl driver additions
by Markus Groß 02 Jun '11

02 Jun '11

I know it is very late for 0.9.2 but perhabs we could squeeze these patches in (then the version numbers of the functions in patch 2 have to be changed to 0.9.2). Markus Groß (2): Get maximum memory of running domain in libxl driver Add managedSave support to libxl driver src/libxl/libxl_driver.c | 356 ++++++++++++++++++++++++++++++++++++---------- 1 files changed, 278 insertions(+), 78 deletions(-) -- 1.7.5.2

3 5