- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Fix virFileMakePath error handling in snapshot creation
by Matthias Bolte 05 Jul '11

05 Jul '11

virFileMakePath returns an errno value on error, that will never be negative. So a virFileMakePath error whould have been ignored here. --- src/qemu/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 363a361..aab3ab9 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7498,7 +7498,7 @@ static int qemuDomainSnapshotWriteMetadata(virDomainObjPtr vm, goto cleanup; } err = virFileMakePath(snapDir); - if (err < 0) { + if (err != 0) { virReportSystemError(err, _("cannot create snapshot directory '%s'"), snapDir); goto cleanup; -- 1.7.4.1

2 2

[libvirt] problems with <seclabel> when restarting libvirtd
by Laine Stump 05 Jul '11

05 Jul '11

I had libvirtd build from 0.9.2+something running on my test machine. There was a single guest running on it. I grabbed the latest libvirt from git (0.9.3+??), built an rpm, and installed it. My guest reconnected with no problems, but I was unable to start new guests due to an selinux problem with the labeling of the image file. Interestingly, I found that I could shutdown and restart the one guest that had been running at the time of the upgrade. *Until* I restarted libvirtd again while the guest was stopped. After this point, I could no longer start that guest either. I then set selinux to permissive mode and was able to start my original guest. Then I restarted libvirtd and found that, although the qemu-kvm process was still running, libvirtd couldn't reconnect to the guest. When I looked at the logs, I saw this: error: virSecurityLabelDefParseXML:5073 : unsupported configuration: dynamic label type must use resource relabeling In the domain state file, I see this: | <seclabel type='dynamic' model='selinux' relabel='no'> | <label>system_u:system_r:svirt_t:s-:c419,c955</label> | </seclabel> The data in the state file was written by the same version of libvirtd that wrote it. So why did it write something it knows it doesn't support?

2 1

[libvirt] Duplicate symbol error with 0.9.3 on OSX
by Justin Clift 05 Jul '11

05 Jul '11

Hi all, Just went to update the OSX libvirt build for 0.9.3, but it's giving a duplicate symbol error: ld: duplicate symbol _virNetworkDNSHostsDef in ./.libs/libvirt_driver_test.a(libvirt_driver_test_la-test_driver.o) and ./.libs/libvirt_conf.a(libvirt_conf_la-network_conf.o) "virNetworkDNSHostsDef" is definitely in src/conf/network_conf.*, but not seeing it anywhere in src/test/test_driver.*. Anyone have suggestions on what to look at? Regards and best wishes, Justin Clift -- Aeolus Community Manager http://www.aeolusproject.org

2 4

[libvirt] [PATCH] Quieten build & ensure API build scripts exit with non-zero status
by Daniel P. Berrange 04 Jul '11

04 Jul '11

The current API build scripts will continue and exit with a zero status even if they find problems. This has been the cause of many build problems, or hidden build errors, in the past. Change the scripts so they always exit with a non-zero status for any problems they do not understand. Also turn off all debug output by default so they respect $(AM_V_GEN) * docs/Makefile.am: Use $(AM_V_GEN) for API/HTML scripts * docs/apibuild.py, python/generator.py: Exit with non-zero status if problems are found. Also be silent, not outputting any debug messages. * src/Makefile.am: Use $(AM_V_GEN) for ESX generator * python/Makefile.am: Tweak rule --- docs/Makefile.am | 11 ++---- docs/apibuild.py | 95 ++++++++++++++++++++++++++++++-------------------- python/Makefile.am | 6 ++-- python/generator.py | 16 +++++--- src/Makefile.am | 2 +- 5 files changed, 75 insertions(+), 55 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 050ebe1..e7d356e 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -153,21 +153,18 @@ internals/%.html.tmp: internals/%.html.in subsite.xsl page.xsl sitemap.html.in html/index.html: libvirt-api.xml newapi.xsl page.xsl sitemap.html.in - -@if [ -x $(XSLTPROC) ] ; then \ - echo "Rebuilding the HTML pages from the XML API" ; \ + $(AM_V_GEN)if [ -x $(XSLTPROC) ] ; then \ $(XSLTPROC) --nonet -o $(srcdir)/ \ - $(srcdir)/newapi.xsl $(srcdir)/libvirt-api.xml ; fi - -@if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ + $(srcdir)/newapi.xsl $(srcdir)/libvirt-api.xml ; fi ; \ + if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ if $(XMLCATALOG) '$(XML_CATALOG_FILE)' "-//W3C//DTD XHTML 1.0 Strict//EN" \ > /dev/null ; then \ - echo "Validating the resulting XHTML pages" ; \ SGML_CATALOG_FILES='$(XML_CATALOG_FILE)' \ $(XMLLINT) --catalogs --nonet --valid --noout $(srcdir)/html/*.html ; \ else echo "missing XHTML1 DTD" ; fi ; fi $(addprefix $(srcdir)/,$(devhelphtml)): $(srcdir)/libvirt-api.xml $(devhelpxsl) - -@echo Rebuilding devhelp files - -@if [ -x $(XSLTPROC) ] ; then \ + $(AM_V_GEN)if [ -x $(XSLTPROC) ] ; then \ $(XSLTPROC) --nonet -o $(srcdir)/devhelp/ \ $(top_srcdir)/docs/devhelp/devhelp.xsl $(srcdir)/libvirt-api.xml ; fi diff --git a/docs/apibuild.py b/docs/apibuild.py index f31a853..cb273dc 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -11,6 +11,8 @@ import os, sys import string import glob +quiet=1 +warnings=0 debug=0 debugsym=None @@ -95,7 +97,7 @@ class identifier: self.conditionals = None else: self.conditionals = conditionals[:] - if self.name == debugsym: + if self.name == debugsym and not quiet: print "=> define %s : %s" % (debugsym, (module, type, info, extra, conditionals)) @@ -155,7 +157,7 @@ class identifier: def update(self, header, module, type = None, info = None, extra=None, conditionals=None): - if self.name == debugsym: + if self.name == debugsym and not quiet: print "=> update %s : %s" % (debugsym, (module, type, info, extra, conditionals)) if header != None and self.header == None: @@ -203,7 +205,7 @@ class index: if d != None and name != None and type != None: self.references[name] = d - if name == debugsym: + if name == debugsym and not quiet: print "New ref: %s" % (d) return d @@ -244,9 +246,9 @@ class index: elif type == "macro": self.macros[name] = d else: - print "Unable to register type ", type + self.warning("Unable to register type ", type) - if name == debugsym: + if name == debugsym and not quiet: print "New symbol: %s" % (d) return d @@ -260,8 +262,8 @@ class index: if self.macros.has_key(id): del self.macros[id] if self.functions.has_key(id): - print "function %s from %s redeclared in %s" % ( - id, self.functions[id].header, idx.functions[id].header) + self.warning("function %s from %s redeclared in %s" % ( + id, self.functions[id].header, idx.functions[id].header)) else: self.functions[id] = idx.functions[id] self.identifiers[id] = idx.functions[id] @@ -273,15 +275,15 @@ class index: if self.macros.has_key(id): del self.macros[id] if self.variables.has_key(id): - print "variable %s from %s redeclared in %s" % ( - id, self.variables[id].header, idx.variables[id].header) + self.warning("variable %s from %s redeclared in %s" % ( + id, self.variables[id].header, idx.variables[id].header)) else: self.variables[id] = idx.variables[id] self.identifiers[id] = idx.variables[id] for id in idx.structs.keys(): if self.structs.has_key(id): - print "struct %s from %s redeclared in %s" % ( - id, self.structs[id].header, idx.structs[id].header) + self.warning("struct %s from %s redeclared in %s" % ( + id, self.structs[id].header, idx.structs[id].header)) else: self.structs[id] = idx.structs[id] self.identifiers[id] = idx.structs[id] @@ -294,8 +296,8 @@ class index: self.identifiers[id] = idx.unions[id] for id in idx.typedefs.keys(): if self.typedefs.has_key(id): - print "typedef %s from %s redeclared in %s" % ( - id, self.typedefs[id].header, idx.typedefs[id].header) + self.warning("typedef %s from %s redeclared in %s" % ( + id, self.typedefs[id].header, idx.typedefs[id].header)) else: self.typedefs[id] = idx.typedefs[id] self.identifiers[id] = idx.typedefs[id] @@ -311,15 +313,15 @@ class index: if self.enums.has_key(id): continue if self.macros.has_key(id): - print "macro %s from %s redeclared in %s" % ( - id, self.macros[id].header, idx.macros[id].header) + self.warning("macro %s from %s redeclared in %s" % ( + id, self.macros[id].header, idx.macros[id].header)) else: self.macros[id] = idx.macros[id] self.identifiers[id] = idx.macros[id] for id in idx.enums.keys(): if self.enums.has_key(id): - print "enum %s from %s redeclared in %s" % ( - id, self.enums[id].header, idx.enums[id].header) + self.warning("enum %s from %s redeclared in %s" % ( + id, self.enums[id].header, idx.enums[id].header)) else: self.enums[id] = idx.enums[id] self.identifiers[id] = idx.enums[id] @@ -330,10 +332,10 @@ class index: # check that function condition agrees with header if idx.functions[id].conditionals != \ self.functions[id].conditionals: - print "Header condition differs from Function for %s:" \ - % id - print " H: %s" % self.functions[id].conditionals - print " C: %s" % idx.functions[id].conditionals + self.warning("Header condition differs from Function for %s:" \ + % id) + self.warning(" H: %s" % self.functions[id].conditionals) + self.warning(" C: %s" % idx.functions[id].conditionals) up = idx.functions[id] self.functions[id].update(None, up.module, up.type, up.info, up.extra) # else: @@ -356,12 +358,13 @@ class index: def analyze(self): - self.analyze_dict("functions", self.functions) - self.analyze_dict("variables", self.variables) - self.analyze_dict("structs", self.structs) - self.analyze_dict("unions", self.unions) - self.analyze_dict("typedefs", self.typedefs) - self.analyze_dict("macros", self.macros) + if not quiet: + self.analyze_dict("functions", self.functions) + self.analyze_dict("variables", self.variables) + self.analyze_dict("structs", self.structs) + self.analyze_dict("unions", self.unions) + self.analyze_dict("typedefs", self.typedefs) + self.analyze_dict("macros", self.macros) class CLexer: """A lexer for the C language, tokenize the input by reading and @@ -621,6 +624,8 @@ class CParser: info, extra, self.conditionals) def warning(self, msg): + global warnings + warnings = warnings + 1 if self.no_error: return print msg @@ -1802,7 +1807,8 @@ class CParser: return token def parse(self): - self.warning("Parsing %s" % (self.filename)) + if not quiet: + print "Parsing %s" % (self.filename) token = self.token() while token != None: if token[0] == 'name': @@ -1869,7 +1875,8 @@ class docBuilder: pass def analyze(self): - print "Project %s : %d headers, %d modules" % (self.name, len(self.headers.keys()), len(self.modules.keys())) + if not quiet: + print "Project %s : %d headers, %d modules" % (self.name, len(self.headers.keys()), len(self.modules.keys())) self.idx.analyze() def scanHeaders(self): @@ -1995,7 +2002,7 @@ class docBuilder: else: output.write(" <field name='%s' type='%s' info='%s'/>\n" % (field[1] , field[0], desc)) except: - print "Failed to serialize struct %s" % (name) + self.warning("Failed to serialize struct %s" % (name)) output.write(" </struct>\n") else: output.write("/>\n"); @@ -2023,7 +2030,7 @@ class docBuilder: def serialize_function(self, output, name): id = self.idx.functions[name] - if name == debugsym: + if name == debugsym and not quiet: print "=>", id output.write(" <%s name='%s' file='%s' module='%s'>\n" % (id.type, @@ -2059,7 +2066,7 @@ class docBuilder: output.write(" <arg name='%s' type='%s' info='%s'/>\n" % (param[1], param[0], escape(param[2]))) self.indexString(name, param[2]) except: - print "Failed to save function %s info: " % name, `id.info` + self.warning("Failed to save function %s info: " % name, `id.info`) output.write(" </%s>\n" % (id.type)) def serialize_exports(self, output, file): @@ -2074,7 +2081,7 @@ class docBuilder: escape(dict.info[data]), string.lower(data))) except: - print "Header %s lacks a %s description" % (module, data) + self.warning("Header %s lacks a %s description" % (module, data)) if dict.info.has_key('Description'): desc = dict.info['Description'] if string.find(desc, "DEPRECATED") != -1: @@ -2287,7 +2294,8 @@ class docBuilder: def serialize(self): filename = "%s/%s-api.xml" % (self.path, self.name) - print "Saving XML description %s" % (filename) + if not quiet: + print "Saving XML description %s" % (filename) output = open(filename, "w") output.write('<?xml version="1.0" encoding="ISO-8859-1"?>\n') output.write("<api name='%s'>\n" % self.name) @@ -2323,7 +2331,8 @@ class docBuilder: output.close() filename = "%s/%s-refs.xml" % (self.path, self.name) - print "Saving XML Cross References %s" % (filename) + if not quiet: + print "Saving XML Cross References %s" % (filename) output = open(filename, "w") output.write('<?xml version="1.0" encoding="ISO-8859-1"?>\n') output.write("<apirefs name='%s'>\n" % self.name) @@ -2336,7 +2345,8 @@ def rebuild(): builder = None srcdir = os.environ["srcdir"] if glob.glob(srcdir + "/../src/libvirt.c") != [] : - print "Rebuilding API description for libvirt" + if not quiet: + print "Rebuilding API description for libvirt" dirs = [srcdir + "/../src", srcdir + "/../src/util", srcdir + "/../include/libvirt"] @@ -2344,12 +2354,13 @@ def rebuild(): dirs.append("../include/libvirt") builder = docBuilder("libvirt", srcdir, dirs, []) elif glob.glob("src/libvirt.c") != [] : - print "Rebuilding API description for libvirt" + if not quiet: + print "Rebuilding API description for libvirt" builder = docBuilder("libvirt", srcdir, ["src", "src/util", "include/libvirt"], []) else: - print "rebuild() failed, unable to guess the module" + self.warning("rebuild() failed, unable to guess the module") return None builder.scan() builder.analyze() @@ -2368,5 +2379,13 @@ if __name__ == "__main__": if len(sys.argv) > 1: debug = 1 parse(sys.argv[1]) + if warnings > 0: + sys.exit(2) + else: + sys.exit(0) else: rebuild() + if warnings > 0: + sys.exit(2) + else: + sys.exit(0) diff --git a/python/Makefile.am b/python/Makefile.am index 0edb3e4..a4c9a6b 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -53,11 +53,11 @@ GENERATED= libvirt-export.c \ libvirt.h \ libvirt.py -generated.stamp: $(srcdir)/$(GENERATE) $(API_DESC) - $(PYTHON) $(srcdir)/$(GENERATE) $(PYTHON) +$(GENERATE).stamp: $(srcdir)/$(GENERATE) $(API_DESC) + $(AM_V_GEN)$(PYTHON) $(srcdir)/$(GENERATE) $(PYTHON) && \ touch $@ -$(GENERATED): generated.stamp +$(GENERATED): $(GENERATE).stamp $(libvirtmod_la_OBJECTS): $(GENERATED) diff --git a/python/generator.py b/python/generator.py index c27ff73..d3a3616 100755 --- a/python/generator.py +++ b/python/generator.py @@ -11,6 +11,8 @@ import sys import string import re +quiet=1 + if __name__ == "__main__": # launched as a script srcPref = os.path.dirname(sys.argv[0]) @@ -617,7 +619,8 @@ def buildStubs(): sys.exit(1) n = len(functions.keys()) - print "Found %d functions in libvirt-api.xml" % (n) + if not quiet: + print "Found %d functions in libvirt-api.xml" % (n) py_types['pythonObject'] = ('O', "pythonObject", "pythonObject", "pythonObject") try: @@ -629,8 +632,8 @@ def buildStubs(): except IOError, msg: print file, ":", msg - - print "Found %d functions in libvirt-override-api.xml" % ( + if not quiet: + print "Found %d functions in libvirt-override-api.xml" % ( len(functions.keys()) - n) nb_wrap = 0 failed = 0 @@ -662,20 +665,21 @@ def buildStubs(): export.close() wrapper.close() - print "Generated %d wrapper functions" % nb_wrap + if not quiet: + print "Generated %d wrapper functions" % nb_wrap if unknown_types: print "Missing type converters: " for type in unknown_types.keys(): print "%s:%d " % (type, len(unknown_types[type])), - print - for f in functions_failed: print "ERROR: failed %s" % f if failed > 0: return -1 + if len(unknown_types) > 0: + return -1 return 0 ####################################################################### diff --git a/src/Makefile.am b/src/Makefile.am index cd8a7e9..844ec9d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -786,7 +786,7 @@ endif BUILT_SOURCES += $(ESX_DRIVER_GENERATED) $(ESX_DRIVER_GENERATED): $(srcdir)/esx/esx_vi_generator.input $(srcdir)/esx/esx_vi_generator.py - -srcdir=$(srcdir) $(srcdir)/esx/esx_vi_generator.py + $(AM_V_GEN)srcdir=$(srcdir) $(srcdir)/esx/esx_vi_generator.py if WITH_ESX if WITH_DRIVER_MODULES -- 1.7.4.4

2 1

[libvirt] [PATCH] qemu: Add support for SGA video
by Michal Privoznik 04 Jul '11

04 Jul '11

This patch extends possible values for <video> element. Serial Graphics Adapter allows users to see BIOS messages from the very first moment domain boots up. Therefore, users can choose boot medium, set PXE, etc. However, to be able to use this, one need SGABIOS, which is accessible here: http://code.google.com/p/sgabios/ --- docs/formatdomain.html.in | 5 +++-- docs/schemas/domain.rng | 1 + src/conf/domain_conf.c | 43 ++++++++++++++++++++++++------------------- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 28 ++++++++++++++++++++++------ 5 files changed, 51 insertions(+), 27 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 3a64983..2d89b37 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2005,8 +2005,9 @@ qemu-kvm -net nic,model=? /dev/null <dd> The <code>model</code> element has a mandatory <code>type</code> attribute which takes the value "vga", "cirrus", "vmvga", "xen", - "vbox", or "qxl" (since 0.8.6) - depending on the hypervisor features available. + "vbox", "qxl" (since 0.8.6), or "sga" + (Since 0.9.4) depending on the hypervisor + features available. You can also provide the amount of video memory in kilobytes using <code>vram</code> and the number of screen with <code>heads</code>. </dd> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 891662d..74bc111 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -1502,6 +1502,7 @@ <value>xen</value> <value>vbox</value> <value>qxl</value> + <value>sga</value> </choice> </attribute> <optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f9bf51e..9848359 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -299,7 +299,8 @@ VIR_ENUM_IMPL(virDomainVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, "vmvga", "xen", "vbox", - "qxl") + "qxl", + "sga") VIR_ENUM_IMPL(virDomainInput, VIR_DOMAIN_INPUT_TYPE_LAST, "mouse", @@ -4713,28 +4714,32 @@ virDomainVideoDefParseXML(const xmlNodePtr node, } } - if (vram) { - if (virStrToLong_ui(vram, NULL, 10, &def->vram) < 0) { - virDomainReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse video ram '%s'"), vram); - goto error; + /* SGA video device does not support heads, vram + * or PCI address. It is not PCI device anyway */ + if (def->type != VIR_DOMAIN_VIDEO_TYPE_SGA) { + if (vram) { + if (virStrToLong_ui(vram, NULL, 10, &def->vram) < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse video ram '%s'"), vram); + goto error; + } + } else { + def->vram = virDomainVideoDefaultRAM(dom, def->type); } - } else { - def->vram = virDomainVideoDefaultRAM(dom, def->type); - } - if (heads) { - if (virStrToLong_ui(heads, NULL, 10, &def->heads) < 0) { - virDomainReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse video heads '%s'"), heads); - goto error; + if (heads) { + if (virStrToLong_ui(heads, NULL, 10, &def->heads) < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse video heads '%s'"), heads); + goto error; + } + } else { + def->heads = 1; } - } else { - def->heads = 1; - } - if (virDomainDeviceInfoParseXML(node, &def->info, flags) < 0) - goto error; + if (virDomainDeviceInfoParseXML(node, &def->info, flags) < 0) + goto error; + } VIR_FREE(type); VIR_FREE(vram); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index e81977c..7f60754 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -605,6 +605,7 @@ enum virDomainVideoType { VIR_DOMAIN_VIDEO_TYPE_XEN, VIR_DOMAIN_VIDEO_TYPE_VBOX, VIR_DOMAIN_VIDEO_TYPE_QXL, + VIR_DOMAIN_VIDEO_TYPE_SGA, VIR_DOMAIN_VIDEO_TYPE_LAST }; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6e4480e..7685d7e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -80,7 +80,8 @@ VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, "vmware", "", /* no arg needed for xen */ "", /* don't support vbox */ - "qxl"); + "qxl", + "sga"); static void uname_normalize (struct utsname *ut) @@ -1213,7 +1214,8 @@ qemuAssignDevicePCISlots(virDomainDefPtr def, qemuDomainPCIAddressSetPtr addrs) /* Further non-primary video cards */ for (i = 1; i < def->nvideos ; i++) { - if (def->videos[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) + if (def->videos[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE || + def->videos[i]->type == VIR_DOMAIN_VIDEO_TYPE_SGA) continue; if (qemuDomainPCIAddressSetNextAddr(addrs, &def->videos[i]->info) < 0) goto error; @@ -2083,8 +2085,9 @@ qemuBuildVideoDevStr(virDomainVideoDefPtr video, virBufferAsprintf(&buf, ",vram_size=%u", video->vram * 1024); } - if (qemuBuildDeviceAddressStr(&buf, &video->info, qemuCaps) < 0) - goto error; + if (video->type != VIR_DOMAIN_VIDEO_TYPE_SGA) + if (qemuBuildDeviceAddressStr(&buf, &video->info, qemuCaps) < 0) + goto error; if (virBufferError(&buf)) { virReportOOMError(); @@ -4254,6 +4257,11 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuCapsGet(qemuCaps, QEMU_CAPS_VGA)) { if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_XEN) { /* nothing - vga has no effect on Xen pvfb */ + } else if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_SGA) { + if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) + virCommandAddArgList(cmd, "-device", "sga", NULL); + else + virCommandAddArg(cmd, "-nographic"); } else { if ((def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_QXL) && !qemuCapsGet(qemuCaps, QEMU_CAPS_VGA_QXL)) { @@ -4309,6 +4317,13 @@ qemuBuildCommandLine(virConnectPtr conn, /* No special args - this is the default */ break; + case VIR_DOMAIN_VIDEO_TYPE_SGA: + if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) + virCommandAddArgList(cmd, "-device", "sga", NULL); + else + virCommandAddArg(cmd, "-nographic"); + break; + default: qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("video type %s is not supported with this QEMU"), @@ -4321,10 +4336,11 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { for (i = 1 ; i < def->nvideos ; i++) { char *str; - if (def->videos[i]->type != VIR_DOMAIN_VIDEO_TYPE_QXL) { + if (def->videos[i]->type != VIR_DOMAIN_VIDEO_TYPE_QXL && + def->videos[i]->type != VIR_DOMAIN_VIDEO_TYPE_SGA) { qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("video type %s is only valid as primary video card"), - virDomainVideoTypeToString(def->videos[0]->type)); + virDomainVideoTypeToString(def->videos[i]->type)); goto error; } -- 1.7.5.rc3

2 1

[libvirt] VMWare "independent disk" processing needed
by computernews＠rambler.ru 04 Jul '11

04 Jul '11

Hello, On VMware ESX server it is possible for the virtual machine to add the "independent disk" - the kind of virtual disk that (among other features) is not being covered by the snapshot logic. As I am working on some kind of backup solution I need to be able to backup the precise state of the guest virtual machine running on say VMware ESX server. I am able to perform a backup of a guest machine description with libvirts's amazing API which covers most of my needs except the aforementioned "independent disk" virtual disk type. The problem shows up at the restore type when I need to create the new virtual machine having an .xml file created by "virsh dumpxml" command. In fact I use API but "virsh does the same". This .xml file covers most of guest machine's aspects but it doesn't reflect the "independent" nature of such disks. So the virtual machine is going to be restored incorrectly when includes "independent disks". From the source codes of "libvirt" ("/libvirt/src/vmx/vmx.*") I see that this is ment to be covered but yet is not implemented. Appropriate nodes must be stored in .xml file during the backup and returned back to .vmx file during the restore. So here are my questions: Is someone on it at the moment ? If yes - can I help somehow ? If no - whom shell I approach in order to be mentored/directed if I decide to participate, implement this and contribute the patch back to the source code ? Thanks for an answer in advance. Best regards Oleh Paliy

1 0

[libvirt] PPPoE-Server problem
by B Veera-B37207 04 Jul '11

04 Jul '11

HI, I am using Libvirt with LXC as hypervisor. When I am starting pppoe-server , unable to create ppp0 interface in Virtual machine, it is unable to serve ips to clients. Let me know is there any plug-in for this (Or) What is the solution. Regards, Veera.

1 0

[libvirt] [PATCH 1/4] libvirtd: avoid memory leak on OOM
by Eric Blake 04 Jul '11

04 Jul '11

Detected by Coverity; only strikes on OOM so not serious. * daemon/libvirtd.c (daemonPidFilePath): Plug leak. --- daemon/libvirtd.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 60ee705..06d2077 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -310,8 +310,10 @@ daemonPidFilePath(bool privileged, if (!(userdir = virGetUserDirectory(geteuid()))) goto error; - if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0) + if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0) { + VIR_FREE(userdir); goto no_memory; + } VIR_FREE(userdir); } -- 1.7.4.4

4 11

[libvirt] [PATCH] storage: Do not override the exact error of createRawFile
by Osier Yang 04 Jul '11

04 Jul '11

virStorageBackendCreateRaw: createRawFile already reported the exact error. Before the fix: error: Failed to create vol vol-create.img error: cannot create path '/var/lib/libvirt/images/vol-create.img': Unknown error 18446744073709551597 After the fix: error: Failed to create vol vol-create.img error: cannot fill file '/var/lib/libvirt/images/vol-create.img': No space left on device --- src/storage/storage_backend.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index a6e66e1..cee2010 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -299,6 +299,7 @@ createRawFile(int fd, virStorageVolDefPtr vol, { int ret = 0; unsigned long long remain; + off_t cur_pos = 0; /* Seek to the final size, so the capacity is available upfront * for progress reporting */ @@ -310,7 +311,12 @@ createRawFile(int fd, virStorageVolDefPtr vol, goto cleanup; } + cur_pos = lseek(fd, 0, SEEK_CUR); + + VIR_WARN("cur_pos = %jd", cur_pos); + remain = vol->allocation; + VIR_WARN("remain = %llu", remain); if (inputvol) { ret = virStorageBackendCopyToFD(vol, inputvol, fd, &remain, 1); @@ -399,12 +405,9 @@ virStorageBackendCreateRaw(virConnectPtr conn ATTRIBUTE_UNUSED, goto cleanup; } - if ((ret = createRawFile(fd, vol, inputvol)) < 0) { - virReportSystemError(-fd, - _("cannot create path '%s'"), - vol->target.path); + if ((ret = createRawFile(fd, vol, inputvol)) < 0) + /* createRawFile already reported the exact error. */ ret = -1; - } cleanup: VIR_FORCE_CLOSE(fd); -- 1.7.4

2 4

[libvirt] Release of libvirt-0.9.3
by Daniel Veillard 04 Jul '11

04 Jul '11

As scheduled, I made the new release of libvirt-0.9.3 today, it is available at ftp://libvirt.org/libvirt/ , the rpms are still being pushed as I write. This is a fairly large release again, with over 330 commits incorporated, including a number of new APIs, large refactoring of the client server code, LXC containers improvements and many improvements and various bug fixes. Features: - vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo) (Taku Izumi) - Add TXT record support for virtual DNS service (Michal Novotny) - Support reboots with the QEMU driver (Daniel P. Berrange) - Introduce virDomainGetControlInfo API (Jiri Denemark) - virNodeGetMemoryStats: Expose new API (Minoru Usui) - virNodeGetCPUTime: Implement public API (Minoru Usui) - send-key: Defining the public API (Lai Jiangshan) - vcpupin: introduce a new libvirt API (virDomainPinVcpuFlags) (Taku Izumi) - support multifunction PCI device (Wen Congyang) - lxc: various improvements Documentation: - Add documentation for configuration lock managers (Daniel P. Berrange) - fix indentation of sub-elements of <ip> in network XML (Laine Stump) - document correct flag name (Eric Blake) - documenting the 802.1Qbh parameters of a 'direct' interface (David S. Wang) - Make virConnectClose comply to apibuild.py expectations (Matthias Bolte) - fix docs to match behavior of virConnectClose (Eric Blake) - numatune: Add doc for new numatune XML (Osier Yang) - Fix documentation of virStreamRecv (Matthias Bolte) - updated list of applications using libvirt. (Ohad Levy) - improve VIR_DOMAIN_AFFECT_CURRENT description (Eric Blake) - Add doc for video element (Osier Yang) - Make hvsupport.pl pick up the host device drivers (Matthias Bolte) Portability: - Explicitely invoke python for API doc generator (Daniel Veillard) - fix virParseVersionString with linux 3.0 (Scott Moser) - Add conditionals to allow build without SASL (Daniel P. Berrange) - Add missing include of signal.h in virnetsocket.c (Daniel P. Berrange) - Fix compilation with systemtap 1.3 (Matthias Bolte) - build: fix mingw build (Eric Blake) - daemon: Fix build without polkit (Jiri Denemark) - build: fix 'make check' when pdwtags is available (Eric Blake) - build: sanlock-devel is not in F15 yet (Eric Blake) - Only include parthelper if built with storage_disk (Ruben Kerkhof) - build: fix VPATH builds (Eric Blake) - python: Don't declare Py_ssize_t for Python 2.6 (Matthias Bolte) - build: avoid python 2.4 build failure (Eric Blake) - build: fix NUMA build on RHEL 5 (Eric Blake) - build: avoid python 2.4 build failure (Eric Blake) - build: avoid compiler failure (Eric Blake) - build: fix compilation on systems missing libnl and new includes (Stefan Berger) - configure: Make libnl optional unless macvtap is required (Matthias Bolte) - build: require newer netcf when it is available (Eric Blake) - build: fix building error when building without libvirtd (Wen Congyang) - Skip nodeinfo test on non intel architectures (Guido Günther) - Fix dlopen dependency (Matthias Bolte) - virt-aa-helper: add missing include (Eric Blake) Bug Fixes: - initialize pointer to NULL (Wen Congyang) - storage: avoid crash on parse error (Eric Blake) - vmware: avoid null deref on failed lookup (Eric Blake) - qemu: avoid null deref on low memory (Eric Blake) - rpc: avoid memory leak on error (Eric Blake) - rpc: fix logic bug (Eric Blake) - pci: avoid memory leak on error (Eric Blake) - interface: avoid memory leak on parse error (Eric Blake) - libvirtd: avoid memory leak on OOM (Eric Blake) - build: avoid double-close bug with pipe2 (Eric Blake) - rpc: avoid freeing uninitialized variable (Eric Blake) - virsh: avoid uninitialized variable (Eric Blake) - virsh: avoid integer overflow (Eric Blake) - Fix stream procedure number for virDomainMigratePrepareTunnel3 (Daniel P. Berrange) - Fix release of virNetMessagePtr instances in streams processing (Daniel P. Berrange) - Fix potential crash when saving guests (Daniel P. Berrange) - Fix uninitialized value in QEMU monitor FD sending code (Daniel P. Berrange) - Fix leak of JSON object for events (Daniel P. Berrange) - Fix use of uninitialized memory when releasing PCI slots (Daniel P. Berrange) - Fix leak of virStreamPtr object with callback added in fdstream impl (Daniel P. Berrange) - Fix leak of mdnsGroupName in virNetServer object (Daniel P. Berrange) - Fix release of filtered stream messages (Daniel P. Berrange) - save domain status after modifing vcpupin (Wen Congyang) - Fix memory leak in virDomainVcpuPinDel() (Wen Congyang) - sysinfo: fix illegal NULL return (Minoru Usui) - Fix locking wrt virNetClientStreamPtr object (Daniel P. Berrange) - Avoid referencing NULL pointer when copying stream error (Daniel P. Berrange) - Avoid free'ing a filtered RPC message in the server (Daniel P. Berrange) - Ensure empty payload is written upon stream completion (Daniel P. Berrange) - Fix propagation of RPC errors from streams (Daniel P. Berrange) - Fix crash when aborting a stream from a I/O callback (Daniel P. Berrange) - dnsmasq: Fix errno handling and don't unlink non-existing files (Matthias Bolte) - tests: Fix memory leak in virnetmessagetest (Osier Yang) - conf: Fix memory leak in virNetworkDNSDefFormat (Osier Yang) - sysinfo: fix parsing regression (Eric Blake) - remote: fix uninitialized variable (Eric Blake) - build: avoid uninitialized variable (Eric Blake) - buf: protect against integer overflow (Eric Blake) - remote: protect against integer overflow (Eric Blake) - Fix typo in libvirt_private.syms (Matthias Bolte) - Fix some bugs in RPC protocol make rules (Daniel P. Berrange) - Fix job type set in qemuMigrationPrepareDirect/PrepareTunnel (Daniel P. Berrange) - Avoid high privileges taint warning for QEMU session driver (Daniel P. Berrange) - util: Fix memory leak in virJSONParserHandleStartMap (Osier Yang) - qemu: Fix memory leak in qemuProcessWaitForMonitor (Osier Yang) - storage: fix volDelete return when volume still being allocated (Matthew Booth) - Fix use-after-free in handling domain taint flags (Daniel P. Berrange) - qemu: Fix one memory leak (Osier Yang) - virsh: avoid bogus description (Eric Blake) - set and restore MAC address of a NIC when using PASSTHROUGH mode (Dirk Herrendoerfer) - conf: Fix one memory leak (Osier Yang) - Add missing checks for NULL in domain lock manager (Daniel P. Berrange) - Fix errno return in safezero() (Daniel P. Berrange) - Fix allocation of veth's to not skip an index (Daniel P. Berrange) - command: avoid double close (Eric Blake) - qemu: Fix parsing 'info chardev' (Cole Robinson) - vcpupin: Fix cpu affinity setting bug of qemu driver (Taku Izumi) - daemon: plug memory leak (Eric Blake) - qemu: add missing break statement (Eric Blake) - storage: avoid mishandling backing store > 2GB (Eric Blake) Improvements: - tests: Add a general util test (Matthias Bolte) - util: choose whether to require micro in version strings (Eric Blake) - build: consistently use CFLAGS (Eric Blake) - build: simplify sanlock distribution (Eric Blake) - build: allow 'make syntax-check' on fresh checkout (Eric Blake) - Send back an error if we get unexpected stream control message (Daniel P. Berrange) - Add test case for parsing JSON docs (Daniel P. Berrange) - Remove bogus warning message in JSON code (Daniel P. Berrange) - Ensure RPC message is cleared before being reused (Daniel P. Berrange) - Fix hardcoded limit on client requests in RPC code (Daniel P. Berrange) - tests: Add valgrind.supp into EXTRA_DIST (Osier Yang) - virsh: Fix a problem of buildPoolXML (Osier Yang) - lock qemu_driver early in qemuGetSchedulerParametersFlags() (Wen Congyang) - build: avoid pod2man on tarball (Eric Blake) - Ensure that EOF is dispatched to the stream callback (Daniel P. Berrange) - Improve two log messages in virNetMessage (Daniel P. Berrange) - Lower logging level when failing to register socket watch (Daniel P. Berrange) - screenshot: Set access rights to temporary file (Michal Privoznik) - maint: improve makefile whitespace (Eric Blake) - network: Don't ignore errors in dnsmasq config file creation (Matthias Bolte) - network: Fix dnsmasq hostsfile creation logic and related tests (Matthias Bolte) - build: update translated files (Eric Blake) - Support automatic creation of leases for disks in sanlock (Daniel P. Berrange) - Support loading a configuration file for sanlock plugin (Daniel P. Berrange) - Allow per-driver config file for lock manager plugins (Daniel P. Berrange) - network: add domain to unqualified names defined with <host> (Laine Stump) - Convert libvirtd over to the new RPC handling APIs (Daniel P. Berrange) - Convert the remote driver to new RPC client APIs (Daniel P. Berrange) - Add XDR_CFLAGS to libvirt-net-rpc.la library (Daniel P. Berrange) - Ensure sanlock socket is labelled with the VM process label (Daniel P. Berrange) - Add a virSecurityManagerSetProcessFDLabel (Daniel P. Berrange) - Rename virSecurityManagerSetFDLabel method (Daniel P. Berrange) - Add node prefix to virNodeGet(CPU|Memory)Stats structs and defines (Matthias Bolte) - qemu: Fix update device for CURRENT + FORCE flags (Jiri Denemark) - nwfilter: Return error message about unresolvable variables (Stefan Berger) - build: rename Vcpupin to VcpuPin (Eric Blake) - sysinfo: cleanup function/struct names. (Minoru Usui) - sysinfo: fix lack of error check in virSysinfoFormat(). (Minoru Usui) - tests: Partly fix networkxml2argvtest being configure result dependent (Matthias Bolte) - qemu: Remove bogus error codes for NUMA memory tuning (Osier Yang) - network: fix indentation in networkBuildDnsmasqArgv (Laine Stump) - vcpupin: add query option to virsh vcpupin command (Taku Izumi) - vcpuinfo: add the code to fallback to try new API (Taku Izumi) - vcpupin: implement the remote protocol to address the new API (Taku Izumi) - vcpupin: implement the code to support new API for the qemu driver (Taku Izumi) - build: update gnulib for intprops (Eric Blake) - Rename iface(G|S)etMacaddr to iface(G|S)etMacAddress for consistency (Matthias Bolte) - Network: Add support for DNS hosts definition to the network XML (Michal Novotny) - Network: Add additional hosts internal infrastructure (Michal Novotny) - Network: Add regression tests for the command-line arguments (Michal Novotny) - Network: modify dnsmasq commandline build function to allow testing (Michal Novotny) - tests: Improve IPv6 detection for virNetSocket tests (Matthias Bolte) - Move load of AppArmor profile to GenLabel() (Jamie Strandboge) - Add Memory Device Information to virSysinfoRead() from dmidecode type 17 (Minoru Usui) - Add Processor Information to virSysinfoRead() from dmidecode type 4 (Minoru Usui) - Cleanup virSysinfoRead() (Minoru Usui) - Make sure virnetprotocol.[ch] are in BUILT_SOURCES (Daniel P. Berrange) - maint: typo fixes (Eric Blake) - Add missing translation of error message from QEMU reboot patch (Daniel P. Berrange) - Allow automatic kill of guests when a connection is closed (Daniel P. Berrange) - Automatically kill target QEMU if migration aborts abnormally (Daniel P. Berrange) - Add infrastructure to automatically destroy guests when a connection closes (Daniel P. Berrange) - Move the RPC generator scripts into src/rpc (Daniel P. Berrange) - Introduce generic RPC client objects (Daniel P. Berrange) - Introduce generic RPC module for advertising via MDNS (Daniel P. Berrange) - Introduce generic RPC server objects (Daniel P. Berrange) - Integrate TLS/SASL directly into the socket APIs (Daniel P. Berrange) - Generic module for handling SASL authentication & encryption (Daniel P. Berrange) - Generic module for handling TLS encryption and x509 certs (Daniel P. Berrange) - Introduce a generic object for using network sockets (Daniel P. Berrange) - Provide a simple object for encoding/decoding RPC messages (Daniel P. Berrange) - Defines the basics of a generic RPC protocol in XDR (Daniel P. Berrange) - build: update to latest gnulib (Eric Blake) - python: Generate virStreamFree but don't expose in bindings (Cole Robinson) - maint: avoid future setgid problems (Eric Blake) - qemu: Only check for NUMA availability if required (Jiri Denemark) - util: avoid PATH_MAX-sized array (Eric Blake) - xen: avoid PATH_MAX-sized array (Eric Blake) - tests: avoid PATH_MAX-sized array (Eric Blake) - virStorageVol: avoid PATH_MAX-sized array (Eric Blake) - cleanup: make several interface functions commonly available (Stefan Berger) - cleanup: make nlComm commonly available (Stefan Berger) - maint: remove syntax-check exception (Eric Blake) - Remove macvtap dependency on domain configuration (Daniel P. Berrange) - util: Correct the error prompt string (Osier Yang) - Fix to python API extractor and API doc generation (Daniel Veillard) - qemu: domain I/O asynchronous handling (Michal Privoznik) - python: Mark event callback wrappers as private (Cole Robinson) - python: events: Fix C->Python handle callback prototype (Cole Robinson) - python: Add bindings for virEvent*Handle/Timeout (Cole Robinson) - events: Correct virEventAddTimeout docs (Cole Robinson) - Promote virEvent*Handle/Timeout to public API (Cole Robinson) - python: Implement virStreamSend/RecvAll helpers (Cole Robinson) - python: Implement virStreamSend/Recv (Cole Robinson) - conf: Make full use of goto label (Osier Yang) - python: Implement bindings for virStreamEventAddCallback (Cole Robinson) - python: generator: Don't print warning if nothing to warn about (Cole Robinson) - python: libvirt-override: use simpler debug (Cole Robinson) - virsh: enhance snapshot-create-as (Eric Blake) - virsh: add snapshot-create-as command (Eric Blake) - virsh: clarify snapshot vs. save (Eric Blake) - Fix compile warnings in virsh vcpupin (Daniel P. Berrange) - remote generator: Allow to annotate arrays with typecasts (Matthias Bolte) - remote: Handle functions that return optional strings (Matthias Bolte) - remote: Generate virDomainGetBlockPullInfo (Matthias Bolte) - vcpupin: add vcpupin resetting feature to qemu driver (Taku Izumi) - vcpupin: add virDomainVcpupinDel function (Taku Izumi) - vcpupin: add reset option to virsh vcpupin command (Taku Izumi) - vcpupin: improve vcpupin definition of virsh vcpupin (Taku Izumi) - Fix preprocessor indentation in nodeinfo.c (Matthias Bolte) - Move XenAPI driver to correct spec file section (Matthias Bolte) - numatune: Add tests for numatune XML (Osier Yang) - numatune: Support NUMA memory tuning in qemu driver (Osier Yang) - numatune: Support persistent XML for numatune (Osier Yang) - numatune: Define XML schema (Osier Yang) - Update qemuDomainSetBlkioParameters to use flags (Hu Tao) - update qemuDomainGetBlkioParameters to use flags (Hu Tao) - Add new parameters for blkiotune (Hu Tao) - apparmor: implement AppArmorSetFDLabel() (Jamie Strandboge) - Add missing error reporting when loading mac filter config for QEMU (Daniel P. Berrange) - virsh: Add support for virDomainGetControlInfo (Jiri Denemark) - qemu: Implement virDomainGetControlInfo (Jiri Denemark) - Wire protocol and remote driver for virDomainGetControlInfo (Jiri Denemark) - sendkey: use consistent API convention (Eric Blake) - build: export correct function names (Eric Blake) - build: avoid compiler warning on non-Linux (Eric Blake) - remote generator: Handle struct returning functions better (part 2) (Matthias Bolte) - Fix apibuild.py warnings about missing comment headers (Matthias Bolte) - remote generator: Handle struct returning functions better (Matthias Bolte) - support for Xen HVM Viridian (Hyper-V) enlightenment interface (Daniel Gollub) - virsh: reduce complexity in argv iteration (Eric Blake) - Add support for network filter code in LXC driver (Daniel P. Berrange) - qemu: Translate boot config into bootindex if possible (Jiri Denemark) - spice: add <clipboard copypaste='yes|no'> option (Marc-André Lureau) - virNodeGetMemoryStats: Implement linux support (Minoru Usui) - virNodeGetMemoryStats: Implement virsh support (Minoru Usui) - virNodeGetMemoryStats: Implement remote protocol (Minoru Usui) - virNodeGetMemoryStats: Implement public API (Minoru Usui) - virNodeGetMemoryStats: Define internal driver API (Minoru Usui) - virNodeGetCPUStats: Implement linux support (Minoru Usui) - virNodeGetCPUStats: Implement virsh support (Minoru Usui) - virNodeGetCPUStats: Implement remote protocol (Minoru Usui) - virNodeGetCPUStats: Define internal driver API (Minoru Usui) - virNodeGetCPUStats: Expose new API (Minoru Usui) - Fix autostart flag when loading running domains (Michael Chapman) - send-key: Implementing the remote protocol (Lai Jiangshan) - send-key: Implementing the public API (Lai Jiangshan) - send-key: Defining the internal API (Lai Jiangshan) - remote generator: Handle (unsigned) int arrays (Lai Jiangshan) - add VSH_OFLAG_REQ_OPT options (Lai Jiangshan) - allow name for VSH_OT_ARGV options (Lai Jiangshan) - storage: avoid an intermediate malloc (Eric Blake) - command: reduce duplicated debug messages (Eric Blake) - qemu: Scrape stdout for virtio console pty (Cole Robinson) - virsh: Add daemon version reporting (Michal Privoznik) - nodeinfo: remove superflous braces (Guido Günther) - util: Cleanup indention problem in virterror.c (Osier Yang) - qemu: Parse current balloon value returned by query_balloon (Osier Yang) - Deprecate several CURRENT/LIVE/CONFIG enums (Hu Tao) - qemu: Faster response time to qemu startup errors (Stefan Berger) - build: update to latest gnulib (Eric Blake) - vcpupin: add the new option to "virsh vcpupin" command (Taku Izumi) - vcpupin: implement the remote protocol to address the new API (Taku Izumi) - vcpupin: implement the code to address the new API in the qemu driver (Taku Izumi) - Use virTimeMs when appropriate (Jiri Denemark) - Introduce virTimeMs for getting current time in ms (Jiri Denemark) - test: Remove unused timeval (Jiri Denemark) - tests: add a test for multi function PCI device (Wen Congyang) - the hotplugged PCI device should use the whole slot (Wen Congyang) - assign the whole slot to the PCI device that has no address (Wen Congyang) - Reimplement qemuDomainPCIAddressReserveSlot(): reserve all functions in the slot (Wen Congyang) - the key of hash table should include the function value (Wen Congyang) - prevent hot unplugging multi function PCI device (Wen Congyang) - check whether qemu supports multi function PCI device (Wen Congyang) - xenapi: Improve error message on session failure (Matthew Booth) - qemu: Fix one type in the error prompt string (Osier Yang) - Move VMware Workstation/Player driver to correct spec file section (Matthias Bolte) - esx: avoid dead code (Eric Blake) - qemu: reorder checks for safety (Eric Blake) - uuid: annotate non-null requirements (Eric Blake) - debug: avoid null dereference on uuid lookup api (Eric Blake) - python: avoid unlikely sign extension bug (Eric Blake) - build: detect Coverity 5.3.0 (Eric Blake) - build: Fix typos in configure.ac (Osier Yang) - virsh: Expose virDomainMigrateSetMaxSpeed API to virsh (Osier Yang) - lxc: Ensure container <init> actually exists (Cole Robinson) - lxc: Verify root fs exists before mounting (Cole Robinson) - lxc: controller: Improve container error reporting (Cole Robinson) - lxc: Improve guest startup error reporting (Cole Robinson) - lxc: Refactor controller command building (Cole Robinson) - lxc: Don't report error in Wait/SendContinue (Cole Robinson) - lxc: Drop container stdio as late as possible (Cole Robinson) - util: Implement virRun as a wrapper around virCommand (Cole Robinson) - qemu: Convert virExec usage to virCommand (Cole Robinson) - Use VIR_USE_CPU instead of new wheel (Osier Yang) - Avoid virGetVersion failure on specific driver support configurations (Matthias Bolte) Cleanups - cgroup: silence coverity warning (Eric Blake) - rpc: silence coverity warning (Eric Blake) - qemu: silence coverity warnings (Eric Blake) - build: avoid 'make syntax-check' failure (Eric Blake) - build: remove dead variables (Eric Blake) - Remove bogus jsondata.h file reference which does not exist (Daniel P. Berrange) - build: ignore generated file (Eric Blake) - build: Don't expect translatable strings in a dead file (Jiri Denemark) - Cleanup remote protocol definitions (Daniel P. Berrange) - Remove obsolete libvirtd mdns code (Daniel P. Berrange) - build: avoid long line tests (Eric Blake) - maint: add omitted copyright header (Eric Blake) - build: break some long lines (Eric Blake) - build: silence coverity false positives (Eric Blake) - secret: drop dead code (Eric Blake) - build: silence coverity false positive (Eric Blake) - Move virRun, virExec*, virFork to util/command (Cole Robinson) - util: Remove unused virExec wrapper (Cole Robinson) - esx: Remove duplicated invalid-argument checks (Matthias Bolte) Thanks everybody for your help with this release, be it by submitting documentations, ideas, patches, etc ... ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0