- Devel - libvirt List Archives

[libvirt] Release of libvirt-0.9.9
by Daniel Veillard 06 Jan '12

06 Jan '12

As expected, I made the release of 0.9.9 today, it is tagged in git and available at: ftp://libvirt.org/libvirt/ Apparently some people expect the next one to be 1.0.0, but more realistically it should be 0.9.10 and occuring in a month from today :-) So this realease is a relatively light one with around 150 commits i.e. half the usual amount, I assume most people envoyed the end of year vacations :-) . The content is in a large part focused on local improvements and bug fixes though we have a few new features ! Features: - Add new API virDomain{S,G}etInterfaceParameters (Hu Tao) - Add new API virDomain{G, S}etNumaParameters (Hu Tao) - Add support for ppc64 qemu (Prerna Saxena, Bharata B Rao, Michael Ellerman) - Support Xen domctl v8 (Jim Fehlig) Documentation: - Fix typos in messages. (Yuri Chornoivan) - docs: re-fix stray / (Eric Blake) - virsh: move version command to host group (Lai Jiangshan) - docs: Move 'echo' command description into the generic commands section (Satoru SATOH) - docs: Move 'send-key' command description into the domain commands section (Satoru SATOH) - docs: remove stray / (Eric Blake) - docs: fix missing / in xml examples (Eric Blake) - docs: improve virsh domxml-*-native command docs (Alex Jia) - docs: document <qemu:commandline> xml (Eric Blake) - Fix typo in storage pool documentation (Christophe Fergeau) - docs: tweak 'virsh edit' wording (Eric Blake) - docs: document <address> elements in one place (Eric Blake) - threads: Document spurious wakeups on virCondWait (Michal Privoznik) Portability: - build: fix mingw virCommand build (Eric Blake) - tests: avoid test failure on rawhide gnutls (Eric Blake) - build: drop check for ANSI compiler (Eric Blake) - Fix build on s390(x) and other stange arches (Daniel Veillard) - Require avahi as an rpm dependancy (Daniel Veillard) - Disable python explicitly in mingw32 autobuild (Daniel P. Berrange) - build: disable dtrace on non-Linux builds (Eric Blake) - build: let autobuild check more code (Eric Blake) - maint: allow bootstrap in a sandbox (Eric Blake) Bug Fixes: - qemu: Avoid memory leaks on qemuParseRBDString (Alex Jia) - qemu: fix a bug in numatune (Hu Tao) - qemu: fix use-after-free regression (Eric Blake) - seclabel: fix regression in libvirtd restart (Eric Blake) - command: Discard FD_SETSIZE limit for opened files (Michal Privoznik) - Fix xenstore serial console path for HVM guests (Jim Fehlig) - schemas: Allow '.' in CPU feature name (Jiri Denemark) - virCommand: Properly handle POLLHUP (Michal Privoznik) - virCPUDefCopy forgot to copy NUMA topology (Jiri Denemark) - qemu: fix block stat naming (Eric Blake) - domiftune: clean up previous patches (Eric Blake) - virsh: Fix checking for reconnect conditions (Peter Krempa) - qemu: Fix bandwidth memory leak on failure (Alex Jia) - qemu: fix blkio memory leak on failure (Eric Blake) - remove a static limit on max domains in python bindings (Daniel Veillard) - python: Fix problems of virDomain{Set, Get}BlockIoTune bindings (Alex Jia) - qemu: fix inf-loop in blkio parameters (Eric Blake) - qemu: Keep list of USB devices attached to domains (Michal Privoznik) - qemu: Release the lock on domobj if fails on finding the disk path (Osier Yang) - virsh: plug mem leaks in domxml-*-native (Alex Jia) - console: plug memory leaks (Alex Jia) - rpc: handle param_int, plug memory leaks (Eric Blake) - python: plug memory leak on libvirt_virConnectOpenAuth (Alex Jia) - Only add the timer when a callback is registered (Daniel P. Berrange) - qemu: detect truncated file as invalid save image (Eric Blake) - qemu: Don't drop hostdev config until security label restore (Michal Privoznik) - Fix default migration speed in qemu driver (Jim Fehlig) - qemu: Fix race between async and query jobs (Jiri Denemark) - qemu: Do not free the device from activePciHostdevs if it's in use (Osier Yang) - qemu: Honor the original properties of PCI device when detaching (Osier Yang) - spec: fix inverted logic on sanlock (Wen Congyang) - tests: plug memory leak on linuxTestNodeInfo (Alex Jia) - storage: Fix a potential crash when creating vol object (Osier Yang) - qemu: Disable EOF processing during qemuDomainDestroy (Jiri Denemark) - virsh: Free returned MIME type string (Michal Privoznik) - storage: Activate/deactivate logical volumes only on local node (Rommer) - security: don't try to label network disks (Josh Durgin) - test: replace deprecated "fedora-13" machine with "pc-0.13" (Laine Stump) - network: don't add iptables rules for externally managed networks (Laine Stump) - threadpool: Use while loop on virCondWait (Michal Privoznik) - virsh: plug memory leak on cmdDomblklist (Alex Jia) - fix error when parsing ppc64 models on x86 host (Stefan Berger) - fix memory leak in src/nodeinfo.c (Stefan Berger) - threadpool: Don't wait on condition if pool has no workers (Michal Privoznik) - bridge: Fix forward delay APIs (Jiri Denemark) - virsh: return correct value from cmdDomIfGetLink (Peter Krempa) - virsh: plug memory leak on cmdDomIfGetLink() sucessful path (Alex Jia) - virsh: plug memory leak on cmdBlkdeviotune() sucessful path (Alex Jia) - test: fix potential lock corruption in test driver (Laine Stump) - spec: fix logic bug in deciding to turn on cgconfig (Eric Blake) - When checking nttyFDs to see if it is != 1, be sure to use '1' and not '-1' (Daniel P. Berrange) - Fix installation of libvirt-guests.service (Daniel P. Berrange) Improvements: - Implement DNS SRV record into the bridge driver (Michal Novotny) - seclabel: honor device override in selinux (Eric Blake) - seclabel: allow a seclabel override on a disk src (Eric Blake) - seclabel: extend XML to allow per-disk label overrides (Eric Blake) - seclabel: move seclabel stuff earlier (Eric Blake) - seclabel: refactor existing domain_conf usage (Eric Blake) - schema: rewrite seclabel rng to match code (Eric Blake) - domiftune: Enable the virDomain{S,G}etInterfaceParameters in virsh (Hu Tao) - domiftune: Add virDomain{S,G}etInterfaceParameters support to qemu driver (Hu Tao) - domiftune: Add a util function virDomainNetFind (Hu Tao) - domiftune: Add support of new APIs to the remote driver (Hu Tao) - domiftune: virDomain{S,G}etInterfaceParameters: the main entry points (Hu Tao) - daemon: clean up daemonization (Eric Blake) - tests: fix schema checks sorting (Eric Blake) - qemu: Support for overriding NOFILE limit (Michal Privoznik) - virsh: Use vshWatchJob in cmdManagedSave (Michal Privoznik) - virsh: Use vshWatchJob in cmdSave (Michal Privoznik) - virsh: Use vshWatchJob in cmdDump (Michal Privoznik) - virsh: Move job watch code to a separate function (Michal Privoznik) - qemuhelptest: Add new qemuCap flag (Michal Privoznik) - qemu: Support readonly filesystem passthrough (Osier Yang) - nwfilter: Do not require DHCP requests to be broadcasted (Stefan Berger) - tests: run schema checks in sorted order (Eric Blake) - tests: Add fake PPC64 emulator for QEMU testing (Michael Ellerman) - qemu: Add spapr-vio address assignment (Michael Ellerman) - Add New address type spapr-vio to domain.rng (Bharata B Rao) - Add address type for SPAPR VIO devices (Michael Ellerman) - qemu: Add a capability flag for -no-acpi (Michael Ellerman) - add new command numatune to virsh (Hu Tao) - Implement virDomain{G, S}etNumaParameters for the qemu driver (Hu Tao) - Add virDomain{G, S}etNumaParameters support to the remote driver (Hu Tao) - use cpuset to manage numa (Hu Tao) - Add functions to set/get cgroup cpuset parameters (Hu Tao) - virsh: simplify printing of typed parameters (Eric Blake) - Hide use of timers for domain event dispatch (Daniel P. Berrange) - Remove decl of all APIs related to domain event callbacks & queues (Daniel P. Berrange) - Remove all domain event structs from header (Daniel P. Berrange) - Convert drivers to thread safe APIs for adding callbacks (Daniel P. Berrange) - Add APIs to allow management of callbacks purely with virDomainEventState (Daniel P. Berrange) - Return count of callbacks when registering callbacks (Daniel P. Berrange) - Convert Xen & VBox drivers to use virDomainEventState (Daniel P. Berrange) - nwfilter: do not create ebtables chain unnecessarily (Stefan Berger) - migration: Add more specific error code/message on migration abort (Peter Krempa) - virsh: Add option to undefine storage with domains (Peter Krempa) - python: Expose blockPeek and memoryPeek in Python binding (Osier Yang) - virsh: support multifunction in attach-disk (KAMEZAWA Hiroyuki) - python: Fix export of virDomainSnapshotListChildrenNames (Peter Krempa) - Provide a helper method virDomainLiveConfigHelperMethod (Lei Li) - virsh: Print error message if argument parsing fails for cmdNodesuspend (Peter Krempa) - build: follow directory install conventions (Eric Blake) - Fix make uninstall (Dave Allan) - qemu: Prepare to cater for more general address assignment (Michael Ellerman) - qemu: Add address in qemuBuildChrDeviceStr() on pseries (Michael Ellerman) - qemu: Use spapr-vscsi on pseries machine type (Michael Ellerman) - network: allow '-' in model name (Eric Blake) - cpu: Add cpu flags supported by newest qemu (Peter Krempa) - Pass the VM's UUID into the nwfilter subsystem (Stefan Berger) - nwfilter: cleanup return codes in nwfilter subsystem (Stefan Berger) - spec: make it easier to autoreconf when building rpm (Eric Blake) - Ensure to prefix %{buildroot} when overriding systemd install location (Daniel P. Berrange) - Add ppc64 specific definitions to domain.rng (Bharata B Rao) - Clean up qemuBuildCommandLine to remove x86-specific (Prerna Saxena) - Modify the tests/nodeinfotest.c to use sysfs in addition (Prerna Saxena) - Use sysfs to gather host topology, in place of (Prerna Saxena) Cleanups: - network_conf: Fix whitespace to pass syntax-check (Peter Krempa) So thanks for everybody who contributed for this first release of 2012, please continue to send reports, ideas and patches :-) ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] tests: work around pdwtags 1.9 failure
by Eric Blake 06 Jan '12

06 Jan '12

On rawhide, gcc is new enough to output new DWARF information that pdwtags has not yet learned, but the resulting 'make check' output was rather confusing: $ make -C src check ... GEN virkeepaliveprotocol-structs die__process_function: DW_TAG_INVALID (0x4109) @ <0x58c> not handled! WARNING: your pdwtags program is too old WARNING: skipping the virkeepaliveprotocol-structs test WARNING: install dwarves-1.3 or newer ... $ pdwtags --version v1.9 I've filed the pdwtags deficiency as https://bugzilla.redhat.com/show_bug.cgi?id=772358 * src/Makefile.am (PDWTAGS): Don't leave -t file behind on version mismatch. Soften warning message, since 1.9 is newer than 1.3. Don't leak stderr from broken version. --- Although this feels pretty trivial, it's not quite a build-breaker (everything still worked), so I'll await a review before pushing. src/Makefile.am | 17 +++++++++++------ 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 93bf54c..0a1221a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,6 +1,6 @@ ## Process this file with automake to produce Makefile.in -## Copyright (C) 2005-2011 Red Hat, Inc. +## Copyright (C) 2005-2012 Red Hat, Inc. ## See COPYING.LIB for the License of this software # No libraries with the exception of LIBXML should be listed @@ -248,8 +248,12 @@ struct_prefix = (remote_|qemu_|virNet|keepalive_) PDWTAGS = \ $(AM_V_GEN)if (pdwtags --help) > /dev/null 2>&1; then \ - pdwtags --verbose $(<:.lo=.$(OBJEXT)) \ - | perl -0777 -n \ + pdwtags --verbose $(<:.lo=.$(OBJEXT)) > $(@F)-t1 2> $(@F)-t2; \ + if test -s $(@F)-t2; then \ + rm -rf $(@F)-t?; \ + echo 'WARNING: pdwtags appears broken; skipping the $@ test' >&2;\ + else \ + perl -0777 -n \ -e 'foreach my $$p (split m!\n*(?:$(r1)|$(r2))\n!) {' \ -e ' if ($$p =~ /^(struct|enum) $(struct_prefix)/ ||' \ -e ' $$p =~ /^enum {/) {' \ @@ -272,9 +276,10 @@ PDWTAGS = \ -e ' exit 8;' \ -e ' }' \ -e '}' \ - > $(@F)-t; \ - case $$? in 8) exit 0;; 0) ;; *) exit 1;; esac; \ - diff -u $(@F)-t $@; st=$$?; rm -f $(@F)-t; exit $$st; \ + < $(@F)-t1 > $(@F)-t3; \ + case $$? in 8) rm -f $(@F)-t?; exit 0;; 0) ;; *) exit 1;; esac;\ + diff -u $(@F)-t3 $@; st=$$?; rm -f $(@F)-t?; exit $$st; \ + fi; \ else \ echo 'WARNING: you lack pdwtags; skipping the $@ test' >&2; \ echo 'WARNING: install the dwarves package to get pdwtags' >&2; \ -- 1.7.7.5

2 1

[libvirt] [PATCH] build: fix mingw build
by Eric Blake 06 Jan '12

06 Jan '12

Commit db371a2 mistakenly added new functions inside a #ifdef WIN32 guard, even though they are needed on all platforms. * src/util/command.c (virCommandFDSet): Move outside WIN32 conditional. --- Pushing under the build-breaker rule. src/util/command.c | 54 ++++++++++++++++++++++++++-------------------------- 1 files changed, 27 insertions(+), 27 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index 9e03a55..f05493e 100644 --- a/src/util/command.c +++ b/src/util/command.c @@ -1,7 +1,7 @@ /* * command.c: Child command execution * - * Copyright (C) 2010-2011 Red Hat, Inc. + * Copyright (C) 2010-2012 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -105,32 +105,6 @@ struct _virCommand { bool reap; }; -#ifndef WIN32 - -# if HAVE_CAPNG -static int virClearCapabilities(void) -{ - int ret; - - capng_clear(CAPNG_SELECT_BOTH); - - if ((ret = capng_apply(CAPNG_SELECT_BOTH)) < 0) { - virCommandError(VIR_ERR_INTERNAL_ERROR, - _("cannot clear process capabilities %d"), ret); - return -1; - } - - return 0; -} -# else -static int virClearCapabilities(void) -{ -// VIR_WARN("libcap-ng support not compiled in, unable to clear " -// "capabilities"); - return 0; -} -# endif - /* * virCommandFDIsSet: * @fd: FD to test @@ -191,6 +165,32 @@ virCommandFDSet(int fd, return 0; } +#ifndef WIN32 + +# if HAVE_CAPNG +static int virClearCapabilities(void) +{ + int ret; + + capng_clear(CAPNG_SELECT_BOTH); + + if ((ret = capng_apply(CAPNG_SELECT_BOTH)) < 0) { + virCommandError(VIR_ERR_INTERNAL_ERROR, + _("cannot clear process capabilities %d"), ret); + return -1; + } + + return 0; +} +# else +static int virClearCapabilities(void) +{ +// VIR_WARN("libcap-ng support not compiled in, unable to clear " +// "capabilities"); + return 0; +} +# endif + /** * virFork: * @pid - a pointer to a pid_t that will receive the return value from -- 1.7.7.5

1 0

[libvirt] [libvirt-glib 1/2] API to suspend a domain
by Zeeshan Ali (Khattak) 06 Jan '12

06 Jan '12

From: "Zeeshan Ali (Khattak)" <zeeshanak(a)gnome.org> --- libvirt-gobject/libvirt-gobject-domain.c | 30 ++++++++++++++++++++++++++++++ libvirt-gobject/libvirt-gobject-domain.h | 3 +++ libvirt-gobject/libvirt-gobject.sym | 1 + 3 files changed, 34 insertions(+), 0 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 4301b14..e4963ed 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -678,3 +678,33 @@ gboolean gvir_domain_open_graphics(GVirDomain *dom, cleanup: return ret; } + +/** + * gir_domain_suspend: + * @dom: the domain to suspend + * @err: Place-holder for possible errors + * + * Suspends an active domain, the process is frozen without further access to + * CPU resources and I/O but the memory used by the domain at the hypervisor + * level will stay allocated. Use gvir_domain_resume() to reactivate the domain. + * + * Returns: TRUE if domain was suspended successfully, FALSE otherwise. + */ +gboolean gvir_domain_suspend (GVirDomain *dom, + GError **err) +{ + gboolean ret = FALSE; + + g_return_val_if_fail(GVIR_IS_DOMAIN(dom), FALSE); + + if (virDomainSuspend(dom->priv->handle) < 0) { + gvir_set_error_literal(err, GVIR_DOMAIN_ERROR, + 0, + "Unable to suspend domain"); + goto cleanup; + } + + ret = TRUE; +cleanup: + return ret; +} diff --git a/libvirt-gobject/libvirt-gobject-domain.h b/libvirt-gobject/libvirt-gobject-domain.h index 6fcec8d..a5923f4 100644 --- a/libvirt-gobject/libvirt-gobject-domain.h +++ b/libvirt-gobject/libvirt-gobject-domain.h @@ -153,6 +153,9 @@ gboolean gvir_domain_open_graphics(GVirDomain *dom, unsigned int flags, GError **err); +gboolean gvir_domain_suspend (GVirDomain *dom, + GError **err); + G_END_DECLS #endif /* __LIBVIRT_GOBJECT_DOMAIN_H__ */ diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index a523adc..526098d 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -51,6 +51,7 @@ LIBVIRT_GOBJECT_0.0.3 { gvir_domain_start; gvir_domain_resume; gvir_domain_stop; + gvir_domain_suspend; gvir_domain_delete; gvir_domain_open_console; gvir_domain_open_graphics; -- 1.7.7.4

4 8

[libvirt] Xen driver and vif naming
by Tomas Kopal 06 Jan '12

06 Jan '12

Hello, I am currently trying to use libvirt (debian stable, version 0.8.3) to gather some information about our xen server. (I am complete libvirt newbie :-) ). But when trying to get some info about network interfaces (e.g. via "virsh -c xen:/// domifstat domname vif1.0"), I am receiving an error: error: Failed to get interface stats domname vif1.0 error: invalid argument in xenHypervisorDomainInterfaceStats: invalid path, vif<domid> should match this domain ID The error is right, the 1 in vif name does not match domain id. Due to some restarts, the id is right now 6. In Xen configuration, I am using the vifname=vif1.0 option to set the interface name - I need this so I can refer to these names in firewall configuration (I am not using a bridge between xen interfaces). I have found no way to set the domain ID to a fixed number, so it is always generated (and always different from the vif name). So, for me, this mis-match is expected. Why is libvirt checking the name against the id? Any real reason for this? Any known workaround to circumvent this problem for me? Thanks a lot Regards Tomas P.S. - I am not subscribed to the list, please keep me on the cc-list.

1 0

[libvirt] [libvirt-glib] Don't mix g_new0 and g_slice_free
by Christophe Fergeau 06 Jan '12

06 Jan '12

There were 2 places where memory was allocated with g_new0 and was later freed with g_slice_free. This commit uses g_slice_new0 instead. After this, there are no other occurrences of g_new0 in gobject/ so the rest of the codebase should be safe from this issue. --- libvirt-gobject/libvirt-gobject-storage-pool.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-storage-pool.c b/libvirt-gobject/libvirt-gobject-storage-pool.c index f46dc32..0ba1768 100644 --- a/libvirt-gobject/libvirt-gobject-storage-pool.c +++ b/libvirt-gobject/libvirt-gobject-storage-pool.c @@ -621,7 +621,7 @@ void gvir_storage_pool_build_async (GVirStoragePool *pool, GSimpleAsyncResult *res; StoragePoolBuildData *data; - data = g_new0(StoragePoolBuildData, 1); + data = g_slice_new0(StoragePoolBuildData); data->flags = flags; res = g_simple_async_result_new(G_OBJECT(pool), @@ -721,7 +721,7 @@ void gvir_storage_pool_start_async (GVirStoragePool *pool, GSimpleAsyncResult *res; StoragePoolBuildData *data; - data = g_new0(StoragePoolBuildData, 1); + data = g_slice_new0(StoragePoolBuildData); data->flags = flags; res = g_simple_async_result_new(G_OBJECT(pool), -- 1.7.7.5

2 1

[libvirt] [PATCH] build: drop check for ANSI compiler
by Eric Blake 06 Jan '12

06 Jan '12

Using automake.git (will become 1.12 someday), I got this error: configure.ac:90: error: automatic de-ANSI-fication support has been removed /usr/local/share/aclocal-1.11a/protos.m4:13: AM_C_PROTOTYPES is expanded from... configure.ac:90: the top level autom4te: /usr/bin/m4 failed with exit status: 1 In short, pre-C89 compilers are no longer a viable portability target. Besides, our code base already requires C99, so worrying about pre-C89 seems pointless. * configure.ac (AM_C_PROTOTYPES): Drop, since newer automake no longer provides it. --- Pushing under the build-breaker rule. configure.ac | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 46a9129..e9e17f4 100644 --- a/configure.ac +++ b/configure.ac @@ -1,6 +1,6 @@ dnl Process this file with autoconf to produce a configure script. -dnl Copyright (C) 2005-2011 Red Hat, Inc. +dnl Copyright (C) 2005-2012 Red Hat, Inc. dnl See COPYING.LIB for the License of this software AC_INIT([libvirt], [0.9.8], [libvir-list(a)redhat.com] [], [http://libvirt.org] @@ -86,10 +86,6 @@ gl_INIT AC_TYPE_UID_T -dnl Make sure we have an ANSI compiler -AM_C_PROTOTYPES -test "x$U" != "x" && AC_MSG_ERROR([Compiler not ANSI compliant]) - dnl Support building Win32 DLLs (must appear *before* AM_PROG_LIBTOOL) AC_LIBTOOL_WIN32_DLL -- 1.7.7.5

2 1

[libvirt] [PATCH v2 0/5] RFC: grant KVM guests retain arbitrary capabilities
by Taku Izumi 06 Jan '12

06 Jan '12

Hi Daniel-san and all, This patchset adds an option for KVM guests to retain arbitrary capabilities. The first version is here: http://www.redhat.com/archives/libvir-list/2011-December/msg00857.html According to Daniel-san's comment, I changed my patch like the following: v1 -> v2 - introduce "process" and "cap" elements in the capability XML - change XML element name of domain XML likewise ; process capabilities host supports are found in the capability XML. # virsh capabilities <capabilities> <host> <uuid>00000000-0000-0000-0000-00199914f1c5</uuid> ... <process> <cap name='chown'/> <cap name='dac_override'/> <cap name='dac_read_search'/> <cap name='fowner'/> ... </process> </host> ... ; VM can retain cap_sys_rawio capability # virsh edit VM ... </features> <process> <cap name='sys_rawio'/> </process> <clock offset='utc'/> ... # virsh start VM # cat /proc/<VM's PID>/status ... CapInh: 0000000000000000 CapPrm: fffffffc00020000 CapEff: fffffffc00020000 CapBnd: fffffffc00020000 ... *[PATCH v2 1/5] conf: add XML schema for capability XML *[PATCH v2 2/5] conf: add XML schema for domain XML *[PATCH v2 3/5] util: add functions to keep capabilities *[PATCH v2 4/5] util: extend virExecWithHook() *[PATCH v2 5/5] qemu: make qemu processes to retain capabilities Best regards, Taku Izumi

3 18

[libvirt] [PATCHv2] python: Fix problems of virDomain{Set, Get}BlkioParameters bindings
by ajia＠redhat.com 06 Jan '12

06 Jan '12

From: Alex Jia <ajia(a)redhat.com> The parameter 'device_weight' is a string, however, the 'VIR_TYPED_PARAM_STRING' type condition is missed by libvirt_virDomain{Set, Get}BlkioParameters bindings, the result is we can't get or change 'device_weight' value. * python/libvirt-override.c: Add missing 'VIR_TYPED_PARAM_STRING' condition into libvirt_virDomain{Set, Get}BlkioParameters bindings and free allocated memory. https://bugzilla.redhat.com/show_bug.cgi?id=770795 Signed-off-by: Alex Jia <ajia(a)redhat.com> --- python/libvirt-override.c | 20 ++++++++++++++++++++ 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index d2aad0f..38a35b8 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -726,6 +726,10 @@ libvirt_virDomainSetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED, } break; + case VIR_TYPED_PARAM_STRING: + params[i].value.s = PyString_AsString(val); + break; + default: free(params); return VIR_PY_INT_FAIL; @@ -735,6 +739,11 @@ libvirt_virDomainSetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED, LIBVIRT_BEGIN_ALLOW_THREADS; i_retval = virDomainSetBlkioParameters(domain, params, nparams, flags); LIBVIRT_END_ALLOW_THREADS; + + for(i=0; i < nparams; i++) + if (params[i].type == VIR_TYPED_PARAM_STRING) + free(params[i].value.s); + if (i_retval < 0) { free(params); return VIR_PY_INT_FAIL; @@ -811,6 +820,10 @@ libvirt_virDomainGetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED, val = PyBool_FromLong((long)params[i].value.b); break; + case VIR_TYPED_PARAM_STRING: + val = PyString_FromString((char *)params[i].value.s); + break; + default: free(params); Py_DECREF(info); @@ -819,7 +832,14 @@ libvirt_virDomainGetBlkioParameters(PyObject *self ATTRIBUTE_UNUSED, key = libvirt_constcharPtrWrap(params[i].field); PyDict_SetItem(info, key, val); + Py_DECREF(key); + Py_DECREF(val); } + + for(i=0; i < nparams; i++) + if (params[i].type == VIR_TYPED_PARAM_STRING) + free(params[i].value.s); + free(params); return(info); } -- 1.7.1

3 4

[libvirt] [PATCH] network: Avoid memory leaks on networkBuildDnsmasqArgv
by ajia＠redhat.com 05 Jan '12

05 Jan '12

From: Alex Jia <ajia(a)redhat.com> Detected by valgrind. Leaks introduced in commit 973af236. * src/network/bridge_driver.c: fix memory leaks on failure and successful path. * How to reproduce? % cd tests && valgrind -v --leak-check=full ./networkxml2argvtest * Actual result: ==2226== 3 bytes in 1 blocks are definitely lost in loss record 1 of 24 ==2226== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==2226== by 0x39CF0FEDE7: __vasprintf_chk (in /lib64/libc-2.12.so) ==2226== by 0x41DFF7: virVasprintf (stdio2.h:199) ==2226== by 0x41E0B7: virAsprintf (util.c:1695) ==2226== by 0x41A2D9: networkBuildDhcpDaemonCommandLine (bridge_driver.c:545) ==2226== by 0x4145C8: testCompareXMLToArgvHelper (networkxml2argvtest.c:47) ==2226== by 0x4156A1: virtTestRun (testutils.c:141) ==2226== by 0x414332: mymain (networkxml2argvtest.c:123) ==2226== by 0x414D97: virtTestMain (testutils.c:696) ==2226== by 0x39CF01ECDC: (below main) (in /lib64/libc-2.12.so) ==2226== ==2226== 3 bytes in 1 blocks are definitely lost in loss record 2 of 24 ==2226== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==2226== by 0x39CF0FEDE7: __vasprintf_chk (in /lib64/libc-2.12.so) ==2226== by 0x41DFF7: virVasprintf (stdio2.h:199) ==2226== by 0x41E0B7: virAsprintf (util.c:1695) ==2226== by 0x41A307: networkBuildDhcpDaemonCommandLine (bridge_driver.c:551) ==2226== by 0x4145C8: testCompareXMLToArgvHelper (networkxml2argvtest.c:47) ==2226== by 0x4156A1: virtTestRun (testutils.c:141) ==2226== by 0x414332: mymain (networkxml2argvtest.c:123) ==2226== by 0x414D97: virtTestMain (testutils.c:696) ==2226== by 0x39CF01ECDC: (below main) (in /lib64/libc-2.12.so) ==2226== ==2226== 5 bytes in 1 blocks are definitely lost in loss record 4 of 24 ==2226== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==2226== by 0x39CF0FEDE7: __vasprintf_chk (in /lib64/libc-2.12.so) ==2226== by 0x41DFF7: virVasprintf (stdio2.h:199) ==2226== by 0x41E0B7: virAsprintf (util.c:1695) ==2226== by 0x41A2AB: networkBuildDhcpDaemonCommandLine (bridge_driver.c:539) ==2226== by 0x4145C8: testCompareXMLToArgvHelper (networkxml2argvtest.c:47) ==2226== by 0x4156A1: virtTestRun (testutils.c:141) ==2226== by 0x414332: mymain (networkxml2argvtest.c:123) ==2226== by 0x414D97: virtTestMain (testutils.c:696) ==2226== by 0x39CF01ECDC: (below main) (in /lib64/libc-2.12.so) ==2226== ==2226== LEAK SUMMARY: ==2226== definitely lost: 11 bytes in 3 blocks Signed-off-by: Alex Jia <ajia(a)redhat.com> --- src/network/bridge_driver.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 9afada7..63a28a6 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -544,12 +544,15 @@ networkBuildDnsmasqArgv(virNetworkObjPtr network, if (dns->srvrecords[i].priority) { if (virAsprintf(&recordPriority, "%d", dns->srvrecords[i].priority) < 0) { virReportOOMError(); + VIR_FREE(recordPort); goto cleanup; } } if (dns->srvrecords[i].weight) { if (virAsprintf(&recordWeight, "%d", dns->srvrecords[i].weight) < 0) { virReportOOMError(); + VIR_FREE(recordPort); + VIR_FREE(recordPriority); goto cleanup; } } @@ -567,6 +570,9 @@ networkBuildDnsmasqArgv(virNetworkObjPtr network, } virCommandAddArgPair(cmd, "--srv-host", record); + VIR_FREE(recordPort); + VIR_FREE(recordPriority); + VIR_FREE(recordWeight); VIR_FREE(record); } } -- 1.7.1

3 2