- Devel - libvirt List Archives

[libvirt] Release of libvirt-0.9.11
by Daniel Veillard 04 Apr '12

04 Apr '12

So as stated last week I made the release today. It is available from the ftp: ftp://libvirt.org/libvirt/libvirt-0.9.11.tar.gz along with Fedora 16 rpms I signed. And the release is tagged in the tree so normal development can resume :-) The release is rather big, which is not surprizing since in includes 6 weeks of developments instead of the 4 as usual. BTW considering the rate of the push I still think we should keep a monthly release schedule, this is way higher than most other projects but as long as the people doing the packaging and pushes downstream think it's okay I guess everyone benefits from a shorter cycle (well as long as we don't break API/features !) It is sometime difficult to separate from what to label as an improvement and what to label really as a new feature, in any case there was plenty of both in this release, along with a copious dose of bug fixes: Features: - Add support for the suspend event (Osier Yang) - Add support for event tray moved of removable disks (Osier Yang) - qemu: Support numad (Osier Yang) - cpustats: API, improvements and qemu support (KAMEZAWA Hiroyuki and Eric Blake) - qemu: support type='hostdev' network devices at domain start (Laine Stump) - Introduce virDomainPMWakeup API (Michal Privoznik) - network: support Open vSwitch (Ansis Atteka) - a number of snapshot improvements (Eric Blake) Portability: - build: fix build on cygwin (Eric Blake) - build: fix mingw ssize_t, syntax check (Eric Blake) - Disable build of commandhelper & ssh on Win32 (Daniel P. Berrange) - build: avoid 'devname' for BSD (Eric Blake) - build: avoid frame size error when building without -O2 (Laine Stump) - spec: Add missed dependancy for numad (Osier Yang) - util: fix build mingw (and all non-linux) build failure (Laine Stump) - Build error on OSX in src/util/virnetlink.c (Duncan Rance) - Fix build after commit e3ba4025 (Jim Fehlig) - build: Fix build with dtrace + apparmor (Jiri Denemark) - build: fix output of pid values (Eric Blake) - avoid global variable shadowed (Hu Tao) - lxc: Cleaner fix for compilation without SELinux (Martin Kletzander) - Fix compilation on MacOS X (Lincoln Myers) Documentation: - snapshot: fix virsh docs (Eric Blake) - Expand docs for timer tick policy (Daniel P. Berrange) - Add documentation for new attribute tray of disk target (Osier Yang) - Clarify virsh freecell manpage entry (Dave Allan) - fix typo (Zhou Peng) - Clarify what documentation is being referenced (Dave Allan) - Minor docs fix (Martin Kletzander) - libvirt: fix comment typo (Alex Jia) - fix usage example on setting log levels (Eric Blake) - use correct terminology for 1024 bytes (Eric Blake) - Fix typo (Osier Yang) - Fix typo in domain XML documentation (Christophe Fergeau) - storage: fix typo (Michal Privoznik) - comments wiping supported algorithms (Alex Jia) - Fix libvirt name in qemu commandline namespace URL (Michal Privoznik) - virsh: Break long lines in virsh.pod (Osier Yang) - Update bug reporting page (Dave Allan) - lib: Fix function documentation for virConnectListDomains (Peter Krempa) - virsh: Fix docs for list command (Peter Krempa) Bug fixes: - qemu: Start nested job in qemuDomainCheckEjectableMedia (Jiri Denemark) - qemu: fix memory leak in virDomainGetVcpus (Laine Stump) - conf: allow fuzz in XML with cur balloon > max (Eric Blake) - qemu: reflect any memory rounding back to xml (Eric Blake) - qemu: support live change of the bridge used by a guest network device (Hendrik Schwartke) - qemu_agent: Issue guest-sync prior to every command (Michal Privoznik) - conf: Prevent crash of libvirtd without channel target name (Alex Jia) - fix a deadlock when qemu cannot start (Wen Congyang) - qemu: Make migration fail when port profile association fails on the dst host (Christian Benvenuti) - virsh: plug memory leaks on failure path (Alex Jia) - snapshot: don't pass NULL to QMP command creation (Eric Blake) - qemu: Avoid entering monitor with locked driver (Jiri Denemark) - Leave all child processes running when stopping systemd service (Daniel P. Berrange) - python: Avoid memory leaks on libvirt_virNodeGetCPUStats (Alex Jia) - qemu: Avoid dangling migration-out job when client dies (Jiri Denemark) - qemu: Avoid dangling migration-in job on shutoff domains (Jiri Denemark) - qemu: Use unlimited speed when migrating to file (Jiri Denemark) - python: Avoid memory leaks on libvirt_virNodeGetMemoryStats (Alex Jia) - conf: forbid use of multicast mac addresses (Laine Stump) - conf: return immediately on error in dhcp host element (Laine Stump) - util: fail attempts to use same mac address for guest and tap (Laine Stump) - snapshot: make quiesce a bit safer (Eric Blake) - virConfGetValue: Fixed NULL pointer check (Martin Kletzander) - Fix handling of blkio deviceWeight empty string (Daniel P. Berrange) - remote: Fix migration leaks (Osier Yang) - lib: Don't access configuration if none is present (Peter Krempa) - qemuDomainDetachPciDiskDevice: Free allocated cgroup (Michal Privoznik) - virsh: fix invalid free (Alex Jia) - qemu: Reverse condition in qemuDomainCheckDiskPresence (Michal Privoznik) - qemu: fix segfault when detaching non-existent network device (Guannan Ren) - qemu: Fix (managed)save and snapshots with host mode CPU (Jiri Denemark) - qemu: support disk filenames with comma (Eric Blake) - Fix a few typo in translated strings (Daniel Veillard) - qemuBuildCommandLine: Don't add tlsPort if none set (Michal Privoznik) - qemu: eliminate memory leak in qemuDomainUpdateDeviceConfig (Laine Stump) - util: eliminate device object leaks related to virDomain*Remove*() (Laine Stump) - qemu: don't 'remove' hostdev objects from domain if operation fails (Laine Stump) - util: Don't overflow on errno in virFileAccessibleAs (Michal Privoznik) - sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null (Peter Krempa) - qemu: Fix startupPolicy for snapshot-revert (Michal Privoznik) - rpc: allow truncated return for virDomainGetCPUStats (Eric Blake) - conf: fix error log with "address address" (Laine Stump) - Ensure max_id is initialized in linuxParseCPUmap() (Daniel P. Berrange) - util: eliminate crash in virNetDevMacVLanCreateWithVPortProfile (Laine Stump) - rpc: Fix client crash on connection close (Jiri Denemark) - Correct a check for capacity arg of storageVolumeResize() (Zeeshan Ali (Khattak)) - qemu: Don't emit tls-port spice option if port is -1 (Jiri Denemark) - libxl: eliminate memory leak in libxmlDomainModifyDeviceFlags (Laine Stump) - qemu: fix cleanup of bridge during failure of qemuDomainAttachNetDevice (Laine Stump) - qemu: unescape HMP commands before converting them to json (Josh Durgin) - virsh: fix informational message in iface-bridge command (Laine Stump) - virterror: Misleading error message when name is missing (Benjamin Cama) - util: Fix virFileAccessibleAs return path from parent (Michal Privoznik) - qemu: Prevent crash of libvirtd without guest agent (Alex Jia) - qemu: Unlock monitor when connecting to dest qemu fails (Jiri Denemark) - qemu: Fix segfault when host CPU is empty (Jiri Denemark) - Fix polkit0 authentication (Jim Fehlig) - snapshot: fix snapshot deletion use-after-free (Eric Blake) - daemon: fix logic bug with virAsprintf (Eric Blake) - daemon: plug memory leak (Eric Blake) - Fix typos in API XML file paths (Daniel P. Berrange) Improvements: - Xen: Fix <clock> handling (Philipp Hahn) - Support clock=variable relative to localtime (Philipp Hahn) - python: improve conversion validation (Eric Blake) - Fix client only RPM build & other misc RPM problems (Daniel P. Berrange) - virnetdevtap: Don't check for flags in virNetDevTapCreateFlags (Michal Privoznik) - Consistent style for usage of sizeof operator (Daniel P. Berrange) - Don't redefine the CPU comparison constants in CPU test (Daniel P. Berrange) - Fix some format specifiers for size_t vs ssize_t (Daniel P. Berrange) - build: silence recent syntax check violations (Eric Blake) - private.syms: Add virNetDevMacVLanRestartWithVPortProfile (Zhou Peng) - Set default name for SPICE agent channel (Christophe Fergeau) - python: make python APIs use these helper functions (Guannan Ren) - python: Add new helper functions for python to C integral conversion (Guannan Ren) - Enable all warnings permanently & default to -Werror for GIT builds (Daniel P. Berrange) - Enable build of test suite programs by default for GIT checkouts (Daniel P. Berrange) - Change the default of mdns_adv to false (Stef Walter) - Add LXC XML files to schema test & fix problems this uncovers (Daniel P. Berrange) - Add support for setting init argv for LXC (Daniel P. Berrange) - Detect location fo selinux mount point (Daniel P. Berrange) - qemu,util: on restart of libvirt restart vepa callbacks (D. Herrendoerfer) - build: fix "missing initializer" error in qemu_process.c (Laine Stump) - build: fix "missing initializer" errors in virsh.c (Laine Stump) - Added syntax-check rule for return with parentheses (Martin Kletzander) - Cleanup for a return statement in source files (Martin Kletzander) - Fix and test round-trip of query parameters (Eric Blake) - snapshot: improve qemu handling of reused snapshot targets (Eric Blake) - snapshot: wire up qemu transaction command (Eric Blake) - snapshot: add support for qemu transaction command (Eric Blake) - snapshot: rudimentary qemu support for atomic disk snapshot (Eric Blake) - snapshot: make offline qemu snapshots atomic (Eric Blake) - snapshot: add atomic create flag (Eric Blake) - snapshot: add qemu capability for 'transaction' command (Eric Blake) - build: fix incorrect enum declaration (Eric Blake) - Add qemu support for ppc64 on FC16 or above for rpm packaging (Li Zhang) - Fix typo s/virURIFormatQuery/virURIFormatParams/ (Daniel P. Berrange) - qemu: Update domain status to running while wakeup event is emitted (Osier Yang) - qemu: Update domain state to pmsuspended while suspend event occurs (Osier Yang) - New domain state pmsuspended (Osier Yang) - Add support for the wakeup event (Osier Yang) - qemu: Update tray status while tray moved event is emitted (Osier Yang) - qemu: Prohibit setting tray status as open for block type disk (Osier Yang) - qemu: Do not start with source for removable disks if tray is open (Osier Yang) - conf: Parse and for the tray attribute (Osier Yang) - Implement sysinfo on PowerPC. (Prerna Saxena) - Lookup auth credentials in config file before prompting (Daniel P. Berrange) - Refactor code prompting for SASL credentials (Daniel P. Berrange) - Add helper API for finding auth file path (Daniel P. Berrange) - Rename virRequest{Username,Password} to virAuthGet{Username,Password} (Daniel P. Berrange) - Rename src/util/authhelper.[ch] to src/util/virauth.[ch] (Daniel P. Berrange) - Add a virKeyfilePtr object for parsing '.ini' files (Daniel P. Berrange) - Convert drivers over to use virURIPtr for query params (Daniel P. Berrange) - Store parsed query parameters directly in the virURIPtr struct (Daniel P. Berrange) - Use a libvirt custom struct for virURIPtr (Daniel P. Berrange) - Centralize error reporting for URI parsing/formatting problems (Daniel P. Berrange) - s/xmlURIPtr/virURIPtr/ in virURIFormat impl (Daniel P. Berrange) - Use virURIFree instead of xmlFreeURI (Daniel P. Berrange) - Add test case for virURIPtr classs (Daniel P. Berrange) - python: add virDomainGetCPUStats python binding API (Guannan Ren) - qemu: Make autodestroy utilize connection close callbacks (Jiri Denemark) - qemu: Add connection close callbacks (Jiri Denemark) - qemu: Add support for domain cleanup callbacks (Jiri Denemark) - python: always include config.h first (Eric Blake) - Cpu mapping cleanup (Martin Kletzander) - virsh: trim aliases from -h output (Eric Blake) - Add support for forcing a private network namespace for LXC guests (Daniel P. Berrange) - Emit graphics events when a SPICE client connects/disconnects (Laine Stump) - numad: Fix typo and warning (Osier Yang) - Add container_uuid env variable to LXC guests (Daniel P. Berrange) - Allow overriding default URI in config file (Daniel P. Berrange) - virsh: A bit smarter attach-disk (Osier Yang) - qemu: Use scsi-block for lun passthrough instead of scsi-disk (Osier Yang) - cpu: Add cpu definition for Intel Sandy Bridge cpu type (Peter Krempa) - Added support for AMD Bulldozer CPU (Martin Kletzander) - graphics: Cleanup port policy (Michal Privoznik) - cpustats: report user and sys times (Eric Blake) - qemuxml2argvtest: Pass some additional flags to graphics-spice-agentmouse (Michal Privoznik) - qemu: spice agent-mouse support (Peng Zhou) - virsh: Use option alias for outmoded "--persistent" (Osier Yang) - util: consolidate duplicated error messages in pci.c (Laine Stump) - qemu: support persistent hotplug of <hostdev> devices (Laine Stump) - util: standardize return from functions calling virNetlinkCommand (Laine Stump) - util: make virDomainLeaseDefFree global (Laine Stump) - util: consolidate duplicated error messages in virnetlink.c (Laine Stump) - util: log error on OOM in virNetDevOpenvswitchAddPort (Laine Stump) - Attach vm-id to Open vSwitch interfaces. (Ansis Atteka) - util: whitespace change to virNetDevOpenvswitchAddPort (Laine Stump) - util: add stub pciConfigAddressToSysfsFile for non-linux platforms (Laine Stump) - rpc: generalize solution for VPATH builds (Eric Blake) - xml: Clean up schemas to use shared data types instead of local (Peter Krempa) - qemu: Don't parse device twice in attach/detach (Michal Privoznik) - virsh: improve memory unit parsing (Eric Blake) - virsh: improve storage unit parsing (Eric Blake) - virsh: add command aliases, and rename nodedev-detach (Eric Blake) - virsh: use option aliases (Eric Blake) - virsh: add option aliases (Eric Blake) - xml: allow scaled memory on input (Eric Blake) - xml: use better types for memory values (Eric Blake) - xml: use long long internally, to centralize overflow checks (Eric Blake) - xml: drop unenforced minimum memory limit from RNG (Eric Blake) - storage: support more scaling suffixes (Eric Blake) - xml: output memory unit for clarity (Eric Blake) - xml: share 'unit' in RNG (Eric Blake) - util: new function for scaling numbers (Eric Blake) - api: add overflow error (Eric Blake) - cpu-stats command shows cpu statistics information of a domain. (KAMEZAWA Hiroyuki) - qemu driver for virDomainGetCPUstats using cpuacct cgroup. (KAMEZAWA Hiroyuki) - add nodeGetCPUmap() for getting available CPU IDs in a cpumap. (KAMEZAWA Hiroyuki) - qemu: install port profile and mac address on netdev hostdevs (Roopa Prabhu) - util: Changes to support portprofiles for hostdevs (Roopa Prabhu) - util: support functions for mac/portprofile associations on hostdev (Roopa Prabhu) - util: two new pci util functions (Roopa Prabhu) - qemu: support type=hostdev network device live hotplug attach/detach (Laine Stump) - qemu: use virDomainNetRemove instead of inline code (Laine Stump) - conf: change virDomainNetRemove from static to global (Laine Stump) - conf: parse/format type='hostdev' network interfaces (Laine Stump) - qemu: refactor hotplug detach of hostdevs (Laine Stump) - qemu: re-order functions in qemu_hotplug.c (Laine Stump) - conf: hostdev utility functions (Laine Stump) - conf: put subsys part of virDomainHostdevDef into its own struct (Laine Stump) - conf: give each hostdevdef a parent pointer (Laine Stump) - conf: HostdevDef parse/format helper functions (Laine Stump) - conf: make hostdev info a separate object (Laine Stump) - conf: add device pointer to args of virDomainDeviceInfoIterate callback (Laine Stump) - qemu: rename virDomainDeviceInfoPtr variables to avoid confusion (Laine Stump) - conf: reorder static functions in domain_conf.c (Laine Stump) - conf: relocate virDomainDeviceDef and virDomainHostdevDef (Laine Stump) - conf: add missing device types to virDomainDevice(Type|Def) (Laine Stump) - blockResize: add flag for bytes (Eric Blake) - qemu: Shared or readonly disks are always safe wrt migration (Jiri Denemark) - libvirt-guests: Add parallel startup and shutdown of guests (Peter Krempa) - Fix type and add missed comment for diskChange callback (Osier Yang) - cpu: Add new flag supported by qemu to the cpu definition (Peter Krempa) - util: combine bools in virNetDevTapCreateInBridgePort into flags (Laine Stump) - util: centralize tap device MAC address 1st byte "0xFE" modification (Ansis Atteka) - build: use correct type for pid and similar types (Eric Blake) - build: prohibit cross-inclusion (Eric Blake) - virsh: expose partial pull (Eric Blake) - qemu: pass block pull backing file to monitor (Eric Blake) - qemu: require json for block jobs (Eric Blake) - fix alphabetical order of virNetlink functions in symbol file (Laine Stump) - build: update to latest gnulib (Eric Blake) - Add de-association handling to macvlan code (D. Herrendoerfer) - util: Add netlink event handling to virnetlink.c (D. Herrendoerfer) - Support for cpu64-rhel* qemu cpu models (Martin Kletzander) - libvirt-guests: Check if URI is reachable before launching commands (Peter Krempa) - libvirt-guests: Don't try to do a managed-save of transient guests (Peter Krempa) - libvirt-guests: Add documentation and clean up to use virsh's improved list (Peter Krempa) - qemu: Add pre-migration hook (Jiri Denemark) - hooks: Add support for capturing hook output (Jiri Denemark) - util: fix a typo (Alex Jia) - storage: fix a typo (Alex Jia) - Do not include binaries in EXTRA_DIST (Daniel Veillard) - virsh: New command cmdChangeMedia (Osier Yang) - virsh: Use vshFindDisk and vshPrepareDiskXML in cmdDetachDisk (Osier Yang) - virsh: Two new helper functions for disk device changes (Osier Yang) - tests: Add tests for virtio-scsi and ibmvscsi controllers (Osier Yang) - qemu: Build command line for the new address format (Osier Yang) - qemu: New cap flag to indicate if channel is supported by scsi-disk (Osier Yang) - conf: Introduce new attribute for device address format (Osier Yang) - conf: Add helper function to look up disk controller model (Osier Yang) - qemu: add virtio-scsi controller model (Paolo Bonzini) - qemu: add ibmvscsi controller model (Paolo Bonzini) - qemu: Add ability to abort existing console while creating new one (Peter Krempa) - util: Add helpers for safe domain console operations (Peter Krempa) - fdstream: Add internal callback on stream close (Peter Krempa) - fdstream: Emit stream abort callback even if poll() doesnt. (Peter Krempa) - virsh: add support for VIR_DOMAIN_CONSOLE_* flags (Peter Krempa) - Add flags for virDomainOpenConsole (Peter Krempa) - pidfile: Make checking binary path in virPidFileRead optional (Peter Krempa) - qemu: Implement virDomainPMWakeup API (Michal Privoznik) - virsh: Expose virDomainPMWakeup (Michal Privoznik) - Fixed URI parsing (Martin Kletzander) - Workaround python header file insanity (Daniel P. Berrange) - Improve error reporting when virsh console is run without a TTY (Daniel P. Berrange) - Error out when using SPICE TLS with spice_tls=0 (Christophe Fergeau) - vmx: Better Workstation vmx handling (Jean-Baptiste Rouault) - qemu: nicer error message on failed graceful destroy (Eric Blake) - qemu: Forbid migration with cache != none (Jiri Denemark) - Introduce virStorageFileIsClusterFS (Jiri Denemark) - virsh: Add --unsafe option to migrate command (Jiri Denemark) - Add support for unsafe migration (Jiri Denemark) - configure: Define program name if not found (Michal Privoznik) - virsh: Enhance list command to ease creation of shell scripts (Peter Krempa) - vmware: implement domainXMLFromNative (Jean-Baptiste Rouault) - esx: Correctly disable HTTP Expect header usage of libcurl (Matthias Bolte) - caps: Improve error if passed an unknown arch (Cole Robinson) - spec: use ix86 macros (Peter Robinson) - nwfilter: improved logging during driver initialization (Stefan Berger) - storage: Allow runtime detection of scrub (Michal Privoznik) - Fix build with polkit0 (Jim Fehlig) - python: Expose virDomain{G,S}etInterfaceParameters APIs in python binding (Alex Jia) - conf: rename virDomainNetGetActualDirectVirtPortProfile (Laine Stump) - qemu: increase the timeout before sending SIGKILL to qemu process (Laine Stump) - qemu: drop driver lock while trying to terminate qemu process (Laine Stump) - qemu: Implement DomainPMSuspendForDuration (Michal Privoznik) - qemu: Set capabilities based on supported monitor commands (Michal Privoznik) - Install API XML desc to a standard location (Daniel P. Berrange) - qemu: make block io tuning smarter (Eric Blake) Cleanups: - Fix typos and spacing in messages. (Yuri Chornoivan) - qemu: eliminate nested switch, simplify code (Laine Stump) - Fix typo in previous patch (Daniel P. Berrange) - build: drop obsolete qparams test (Eric Blake) - build: drop a painfully long gnulib test (Eric Blake) - Removed more AMD-specific features from cpu64-rhel* models (Martin Kletzander) - conf: eliminate redundant VIR_ALLOC of 1st element of network DNS hosts. (Laine Stump) - remove daemon/probes.h from .gitignore (Laine Stump) - sanlock: Fix condition left crippled while debugging (Peter Krempa) - qemu: Fix indention (Osier Yang) - daemon: Remove deprecated HAL from init script dependencies (Peter Krempa) - util: remove unneeded #include in virrandom.c (Laine Stump) - util: wrap virnetlink.c to 80 columns (Laine Stump) - Fixed service handling in specfile (Martin Kletzander) So thanks everybody for this massive amount of work, be it bug reports, patches, documentation, portability, everybody should enjoy that release now ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

3 4

[libvirt] Create domain using libvirt-php
by Ali Raza Memon 04 Apr '12

04 Apr '12

Hello...! I want to create a new domain using libvirt-php, and after creating I want to start it. I have seen this to create new domain: libvirt_domain_new($conn, $name, $arch, $memMB, $maxmemMB, $vcpus, $iso_image, $disks, $networks, $flags) So in the above sysntax what should I pass in $iso_image? $disk? $networks and $flag?? Please give me a complete example that can solve my problem. Thanks..

2 1

[libvirt] [test-API PATCH] Added screenshot test
by Martin Kletzander 04 Apr '12

04 Apr '12

This patch adds a test that obtains a screenshot of a domain and saves it in a file. --- repos/domain/screenshot.py | 57 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 57 insertions(+), 0 deletions(-) create mode 100644 repos/domain/screenshot.py diff --git a/repos/domain/screenshot.py b/repos/domain/screenshot.py new file mode 100644 index 0000000..9986cab --- /dev/null +++ b/repos/domain/screenshot.py @@ -0,0 +1,57 @@ +#!/usr/bin/env python +"""This test is used for creating a screenshot of a domain and saving + it in a file. The Screenshot format is hypervisor specific. + + mandatory arguments: guestname + screen + filename +""" + +import os +import mimetypes + +import libvirt + +def check_params(params): + """Verify input parameters""" + for key in ('guestname', 'screen', 'filename'): + if key not in params: + raise KeyError('Missing key %s required for screenshot test' % key) + + params['screen'] = int(params['screen']) + params['filename'] = os.path.abspath(params['filename']) + +def saver(stream, data, file_): + return file_.write(data) + +def screenshot(params): + """This method takes a screenshot of a running machine and saves + it in a filename""" + ret = 1 + try: + logger = params['logger'] + + check_params(params) + + conn = libvirt.open(params['uri']) + dom = conn.lookupByName(params['guestname']) + + st = conn.newStream(0) + mime = dom.screenshot(st, params['screen'], 0) + + ext = mimetypes.guess_extension(mime) or '.ppm' + filename = params['filename'] + ext + f = file(filename, 'w') + + logger.debug('Saving screenshot into %s' % filename) + st.recvAll(saver, f) + logger.debug('Mimetype of the file is %s' % mime) + + ret = st.finish() + + finally: + # Some error occurred, cleanup + if 'conn' in locals() and conn.isAlive(): + conn.close() + + return ret -- 1.7.8.5

3 9

[libvirt] [PATCH 0/3] qemu: Improve USB devices list handling
by Michal Privoznik 04 Apr '12

04 Apr '12

This patch set fixes two bugs: https://bugzilla.redhat.com/show_bug.cgi?id=806449 https://bugzilla.redhat.com/show_bug.cgi?id=743671 tl;dr - we are only adding to the list, removing only on detach-device. Need to remove on qemuProcessStop too. And need to rebuild the list on qemuProcessReconnect. Michal Privoznik (3): qemu: Don't leak temporary list of USB devices qemu: Delete USB devices used by domain on stop qemu: Build activeUsbHostdevs list on process reconnect src/qemu/qemu_hostdev.c | 112 +++++++++++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_hostdev.h | 2 + src/qemu/qemu_process.c | 3 + 3 files changed, 113 insertions(+), 4 deletions(-) -- 1.7.8.5

2 8

[libvirt] question on API spelling
by Eric Blake 04 Apr '12

04 Apr '12

We're quite inconsistent on US (canceled) vs. UK (cancelled) spelling in our public API: include/libvirt/libvirt.h.in:124: VIR_DOMAIN_RUNNING_MIGRATION_CANCELED = 6, /* returned from migration */ include/libvirt/libvirt.h.in:125: VIR_DOMAIN_RUNNING_SAVE_CANCELED = 7, /* returned from failed save process */ include/libvirt/libvirt.h.in:3220: VIR_DOMAIN_JOB_CANCELLED = 5, /* Job was aborted, but isn't cleaned up */ include/libvirt/virterror.h:247: canceled/aborted by user */ include/libvirt/virterror.h:248: VIR_ERR_AUTH_CANCELLED = 79, /* authentication cancelled */ Is it worth adding aliases so that a programmer can use consistent spelling? -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

4 4

[libvirt] [PATCH] news.html.in: Fix void tag
by Michal Privoznik 04 Apr '12

04 Apr '12

Void elements should be written with slash *after* the tag name, not before, so they are not confused with ending tags. --- Pushing under trivial rule. Produced by: :%s/<\/br>/<br\/>/g command, so if breaks something, blame vim :) docs/news.html.in | 642 ++++++++++++++++++++++++++-------------------------- 1 files changed, 321 insertions(+), 321 deletions(-) diff --git a/docs/news.html.in b/docs/news.html.in index 68b2d3a..eb9c3ec 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -1,4 +1,4 @@ -<?xml version="1.0"?> +<?xml version="1.0"? <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> @@ -11,336 +11,336 @@ and check the <a href="http://libvirt.org/git/?p=libvirt.git;a=log">GIT log</a> <h3>0.9.11: Apr 3 2012</h3> <ul> <li> Features: - Add support for the suspend event (Osier Yang), - Add support for event tray moved of removable disks (Osier Yang), - qemu: Support numad (Osier Yang), - cpustats: API, improvements and qemu support (KAMEZAWA Hiroyuki and Eric Blake), - qemu: support type='hostdev' network devices at domain start (Laine Stump), - Introduce virDomainPMWakeup API (Michal Privoznik), - network: support Open vSwitch (Ansis Atteka), - a number of snapshot improvements (Eric Blake) + Add support for the suspend event (Osier Yang), + Add support for event tray moved of removable disks (Osier Yang), + qemu: Support numad (Osier Yang), + cpustats: API, improvements and qemu support (KAMEZAWA Hiroyuki and Eric Blake), + qemu: support type='hostdev' network devices at domain start (Laine Stump), + Introduce virDomainPMWakeup API (Michal Privoznik), + network: support Open vSwitch (Ansis Atteka), + a number of snapshot improvements (Eric Blake) </li> - <li> Portability: - build: fix build on cygwin (Eric Blake), - build: fix mingw ssize_t, syntax check (Eric Blake), - Disable build of commandhelper & ssh on Win32 (Daniel P. Berrange), - build: avoid 'devname' for BSD (Eric Blake), - build: avoid frame size error when building without -O2 (Laine Stump), - spec: Add missed dependancy for numad (Osier Yang), - util: fix build mingw (and all non-linux) build failure (Laine Stump), - Build error on OSX in src/util/virnetlink.c (Duncan Rance), - Fix build after commit e3ba4025 (Jim Fehlig), - build: Fix build with dtrace + apparmor (Jiri Denemark), - build: fix output of pid values (Eric Blake), - avoid global variable shadowed (Hu Tao), - lxc: Cleaner fix for compilation without SELinux (Martin Kletzander), - Fix compilation on MacOS X (Lincoln Myers) + <li> Portability: + build: fix build on cygwin (Eric Blake), + build: fix mingw ssize_t, syntax check (Eric Blake), + Disable build of commandhelper & ssh on Win32 (Daniel P. Berrange), + build: avoid 'devname' for BSD (Eric Blake), + build: avoid frame size error when building without -O2 (Laine Stump), + spec: Add missed dependancy for numad (Osier Yang), + util: fix build mingw (and all non-linux) build failure (Laine Stump), + Build error on OSX in src/util/virnetlink.c (Duncan Rance), + Fix build after commit e3ba4025 (Jim Fehlig), + build: Fix build with dtrace + apparmor (Jiri Denemark), + build: fix output of pid values (Eric Blake), + avoid global variable shadowed (Hu Tao), + lxc: Cleaner fix for compilation without SELinux (Martin Kletzander), + Fix compilation on MacOS X (Lincoln Myers) </li> - <li> Documentation: - snapshot: fix virsh docs (Eric Blake), - Expand docs for timer tick policy (Daniel P. Berrange), - Add documentation for new attribute tray of disk target (Osier Yang), - Clarify virsh freecell manpage entry (Dave Allan), - fix typo (Zhou Peng), - Clarify what documentation is being referenced (Dave Allan), - Minor docs fix (Martin Kletzander), - libvirt: fix comment typo (Alex Jia), - fix usage example on setting log levels (Eric Blake), - use correct terminology for 1024 bytes (Eric Blake), - Fix typo (Osier Yang), - Fix typo in domain XML documentation (Christophe Fergeau), - storage: fix typo (Michal Privoznik), - comments wiping supported algorithms (Alex Jia), - Fix libvirt name in qemu commandline namespace URL (Michal Privoznik), - virsh: Break long lines in virsh.pod (Osier Yang), - Update bug reporting page (Dave Allan), - lib: Fix function documentation for virConnectListDomains (Peter Krempa), - virsh: Fix docs for list command (Peter Krempa) + <li> Documentation: + snapshot: fix virsh docs (Eric Blake), + Expand docs for timer tick policy (Daniel P. Berrange), + Add documentation for new attribute tray of disk target (Osier Yang), + Clarify virsh freecell manpage entry (Dave Allan), + fix typo (Zhou Peng), + Clarify what documentation is being referenced (Dave Allan), + Minor docs fix (Martin Kletzander), + libvirt: fix comment typo (Alex Jia), + fix usage example on setting log levels (Eric Blake), + use correct terminology for 1024 bytes (Eric Blake), + Fix typo (Osier Yang), + Fix typo in domain XML documentation (Christophe Fergeau), + storage: fix typo (Michal Privoznik), + comments wiping supported algorithms (Alex Jia), + Fix libvirt name in qemu commandline namespace URL (Michal Privoznik), + virsh: Break long lines in virsh.pod (Osier Yang), + Update bug reporting page (Dave Allan), + lib: Fix function documentation for virConnectListDomains (Peter Krempa), + virsh: Fix docs for list command (Peter Krempa) </li> - <li> Bug fixes: - qemu: Start nested job in qemuDomainCheckEjectableMedia (Jiri Denemark), - qemu: fix memory leak in virDomainGetVcpus (Laine Stump), - conf: allow fuzz in XML with cur balloon > max (Eric Blake), - qemu: reflect any memory rounding back to xml (Eric Blake), - qemu: support live change of the bridge used by a guest network device (Hendrik Schwartke), - qemu_agent: Issue guest-sync prior to every command (Michal Privoznik), - conf: Prevent crash of libvirtd without channel target name (Alex Jia), - fix a deadlock when qemu cannot start (Wen Congyang), - qemu: Make migration fail when port profile association fails on the dst host (Christian Benvenuti), - virsh: plug memory leaks on failure path (Alex Jia), - snapshot: don't pass NULL to QMP command creation (Eric Blake), - qemu: Avoid entering monitor with locked driver (Jiri Denemark), - Leave all child processes running when stopping systemd service (Daniel P. Berrange), - python: Avoid memory leaks on libvirt_virNodeGetCPUStats (Alex Jia), - qemu: Avoid dangling migration-out job when client dies (Jiri Denemark), - qemu: Avoid dangling migration-in job on shutoff domains (Jiri Denemark), - qemu: Use unlimited speed when migrating to file (Jiri Denemark), - python: Avoid memory leaks on libvirt_virNodeGetMemoryStats (Alex Jia), - conf: forbid use of multicast mac addresses (Laine Stump), - conf: return immediately on error in dhcp host element (Laine Stump), - util: fail attempts to use same mac address for guest and tap (Laine Stump), - snapshot: make quiesce a bit safer (Eric Blake), - virConfGetValue: Fixed NULL pointer check (Martin Kletzander), - Fix handling of blkio deviceWeight empty string (Daniel P. Berrange), - remote: Fix migration leaks (Osier Yang), - lib: Don't access configuration if none is present (Peter Krempa), - qemuDomainDetachPciDiskDevice: Free allocated cgroup (Michal Privoznik), - virsh: fix invalid free (Alex Jia), - qemu: Reverse condition in qemuDomainCheckDiskPresence (Michal Privoznik), - qemu: fix segfault when detaching non-existent network device (Guannan Ren), - qemu: Fix (managed)save and snapshots with host mode CPU (Jiri Denemark), - qemu: support disk filenames with comma (Eric Blake), - Fix a few typo in translated strings (Daniel Veillard), - qemuBuildCommandLine: Don't add tlsPort if none set (Michal Privoznik), - qemu: eliminate memory leak in qemuDomainUpdateDeviceConfig (Laine Stump), - util: eliminate device object leaks related to virDomain*Remove*() (Laine Stump), - qemu: don't 'remove' hostdev objects from domain if operation fails (Laine Stump), - util: Don't overflow on errno in virFileAccessibleAs (Michal Privoznik), - sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null (Peter Krempa), - qemu: Fix startupPolicy for snapshot-revert (Michal Privoznik), - rpc: allow truncated return for virDomainGetCPUStats (Eric Blake), - conf: fix error log with "address address" (Laine Stump), - Ensure max_id is initialized in linuxParseCPUmap() (Daniel P. Berrange), - util: eliminate crash in virNetDevMacVLanCreateWithVPortProfile (Laine Stump), - rpc: Fix client crash on connection close (Jiri Denemark), - Correct a check for capacity arg of storageVolumeResize() (Zeeshan Ali (Khattak)), - qemu: Don't emit tls-port spice option if port is -1 (Jiri Denemark), - libxl: eliminate memory leak in libxmlDomainModifyDeviceFlags (Laine Stump), - qemu: fix cleanup of bridge during failure of qemuDomainAttachNetDevice (Laine Stump), - qemu: unescape HMP commands before converting them to json (Josh Durgin), - virsh: fix informational message in iface-bridge command (Laine Stump), - virterror: Misleading error message when name is missing (Benjamin Cama), - util: Fix virFileAccessibleAs return path from parent (Michal Privoznik), - qemu: Prevent crash of libvirtd without guest agent (Alex Jia), - qemu: Unlock monitor when connecting to dest qemu fails (Jiri Denemark), - qemu: Fix segfault when host CPU is empty (Jiri Denemark), - Fix polkit0 authentication (Jim Fehlig), - snapshot: fix snapshot deletion use-after-free (Eric Blake), - daemon: fix logic bug with virAsprintf (Eric Blake), - daemon: plug memory leak (Eric Blake), - Fix typos in API XML file paths (Daniel P. Berrange) + <li> Bug fixes: + qemu: Start nested job in qemuDomainCheckEjectableMedia (Jiri Denemark), + qemu: fix memory leak in virDomainGetVcpus (Laine Stump), + conf: allow fuzz in XML with cur balloon > max (Eric Blake), + qemu: reflect any memory rounding back to xml (Eric Blake), + qemu: support live change of the bridge used by a guest network device (Hendrik Schwartke), + qemu_agent: Issue guest-sync prior to every command (Michal Privoznik), + conf: Prevent crash of libvirtd without channel target name (Alex Jia), + fix a deadlock when qemu cannot start (Wen Congyang), + qemu: Make migration fail when port profile association fails on the dst host (Christian Benvenuti), + virsh: plug memory leaks on failure path (Alex Jia), + snapshot: don't pass NULL to QMP command creation (Eric Blake), + qemu: Avoid entering monitor with locked driver (Jiri Denemark), + Leave all child processes running when stopping systemd service (Daniel P. Berrange), + python: Avoid memory leaks on libvirt_virNodeGetCPUStats (Alex Jia), + qemu: Avoid dangling migration-out job when client dies (Jiri Denemark), + qemu: Avoid dangling migration-in job on shutoff domains (Jiri Denemark), + qemu: Use unlimited speed when migrating to file (Jiri Denemark), + python: Avoid memory leaks on libvirt_virNodeGetMemoryStats (Alex Jia), + conf: forbid use of multicast mac addresses (Laine Stump), + conf: return immediately on error in dhcp host element (Laine Stump), + util: fail attempts to use same mac address for guest and tap (Laine Stump), + snapshot: make quiesce a bit safer (Eric Blake), + virConfGetValue: Fixed NULL pointer check (Martin Kletzander), + Fix handling of blkio deviceWeight empty string (Daniel P. Berrange), + remote: Fix migration leaks (Osier Yang), + lib: Don't access configuration if none is present (Peter Krempa), + qemuDomainDetachPciDiskDevice: Free allocated cgroup (Michal Privoznik), + virsh: fix invalid free (Alex Jia), + qemu: Reverse condition in qemuDomainCheckDiskPresence (Michal Privoznik), + qemu: fix segfault when detaching non-existent network device (Guannan Ren), + qemu: Fix (managed)save and snapshots with host mode CPU (Jiri Denemark), + qemu: support disk filenames with comma (Eric Blake), + Fix a few typo in translated strings (Daniel Veillard), + qemuBuildCommandLine: Don't add tlsPort if none set (Michal Privoznik), + qemu: eliminate memory leak in qemuDomainUpdateDeviceConfig (Laine Stump), + util: eliminate device object leaks related to virDomain*Remove*() (Laine Stump), + qemu: don't 'remove' hostdev objects from domain if operation fails (Laine Stump), + util: Don't overflow on errno in virFileAccessibleAs (Michal Privoznik), + sanlock: Use STREQ_NULLABLE instead of STREQ on strings that may be null (Peter Krempa), + qemu: Fix startupPolicy for snapshot-revert (Michal Privoznik), + rpc: allow truncated return for virDomainGetCPUStats (Eric Blake), + conf: fix error log with "address address" (Laine Stump), + Ensure max_id is initialized in linuxParseCPUmap() (Daniel P. Berrange), + util: eliminate crash in virNetDevMacVLanCreateWithVPortProfile (Laine Stump), + rpc: Fix client crash on connection close (Jiri Denemark), + Correct a check for capacity arg of storageVolumeResize() (Zeeshan Ali (Khattak)), + qemu: Don't emit tls-port spice option if port is -1 (Jiri Denemark), + libxl: eliminate memory leak in libxmlDomainModifyDeviceFlags (Laine Stump), + qemu: fix cleanup of bridge during failure of qemuDomainAttachNetDevice (Laine Stump), + qemu: unescape HMP commands before converting them to json (Josh Durgin), + virsh: fix informational message in iface-bridge command (Laine Stump), + virterror: Misleading error message when name is missing (Benjamin Cama), + util: Fix virFileAccessibleAs return path from parent (Michal Privoznik), + qemu: Prevent crash of libvirtd without guest agent (Alex Jia), + qemu: Unlock monitor when connecting to dest qemu fails (Jiri Denemark), + qemu: Fix segfault when host CPU is empty (Jiri Denemark), + Fix polkit0 authentication (Jim Fehlig), + snapshot: fix snapshot deletion use-after-free (Eric Blake), + daemon: fix logic bug with virAsprintf (Eric Blake), + daemon: plug memory leak (Eric Blake), + Fix typos in API XML file paths (Daniel P. Berrange) </li> - <li> Improvements: - Xen: Fix <clock> handling (Philipp Hahn), - Support clock=variable relative to localtime (Philipp Hahn), - python: improve conversion validation (Eric Blake), - Fix client only RPM build & other misc RPM problems (Daniel P. Berrange), - Refactor the libvirt RPM daemon pieces (Daniel P. Berrange), - virnetdevtap: Don't check for flags in virNetDevTapCreateFlags (Michal Privoznik), - Consistent style for usage of sizeof operator (Daniel P. Berrange), - Don't redefine the CPU comparison constants in CPU test (Daniel P. Berrange), - Fix some format specifiers for size_t vs ssize_t (Daniel P. Berrange), - build: silence recent syntax check violations (Eric Blake), - private.syms: Add virNetDevMacVLanRestartWithVPortProfile (Zhou Peng), - Set default name for SPICE agent channel (Christophe Fergeau), - python: make python APIs use these helper functions (Guannan Ren), - python: Add new helper functions for python to C integral conversion (Guannan Ren), - Enable all warnings permanently & default to -Werror for GIT builds (Daniel P. Berrange), - Enable build of test suite programs by default for GIT checkouts (Daniel P. Berrange), - Change the default of mdns_adv to false (Stef Walter), - Add LXC XML files to schema test & fix problems this uncovers (Daniel P. Berrange), - Add support for setting init argv for LXC (Daniel P. Berrange), - Detect location fo selinux mount point (Daniel P. Berrange), - qemu,util: on restart of libvirt restart vepa callbacks (D. Herrendoerfer), - build: fix "missing initializer" error in qemu_process.c (Laine Stump), - build: fix "missing initializer" errors in virsh.c (Laine Stump), - Added syntax-check rule for return with parentheses (Martin Kletzander), - Cleanup for a return statement in source files (Martin Kletzander), - Fix and test round-trip of query parameters (Eric Blake), - snapshot: improve qemu handling of reused snapshot targets (Eric Blake), - snapshot: wire up qemu transaction command (Eric Blake), - snapshot: add support for qemu transaction command (Eric Blake), - snapshot: rudimentary qemu support for atomic disk snapshot (Eric Blake), - snapshot: make offline qemu snapshots atomic (Eric Blake), - snapshot: add atomic create flag (Eric Blake), - snapshot: add qemu capability for 'transaction' command (Eric Blake), - build: fix incorrect enum declaration (Eric Blake), - Add qemu support for ppc64 on FC16 or above for rpm packaging (Li Zhang), - Fix typo s/virURIFormatQuery/virURIFormatParams/ (Daniel P. Berrange), - qemu: Update domain status to running while wakeup event is emitted (Osier Yang), - qemu: Update domain state to pmsuspended while suspend event occurs (Osier Yang), - New domain state pmsuspended (Osier Yang), - Add support for the wakeup event (Osier Yang), - qemu: Update tray status while tray moved event is emitted (Osier Yang), - qemu: Prohibit setting tray status as open for block type disk (Osier Yang), - qemu: Do not start with source for removable disks if tray is open (Osier Yang), - conf: Parse and for the tray attribute (Osier Yang), - Implement sysinfo on PowerPC. (Prerna Saxena), - Lookup auth credentials in config file before prompting (Daniel P. Berrange), - Refactor code prompting for SASL credentials (Daniel P. Berrange), - Add helper API for finding auth file path (Daniel P. Berrange), - Rename virRequest{Username,Password} to virAuthGet{Username,Password} (Daniel P. Berrange), - Rename src/util/authhelper.[ch] to src/util/virauth.[ch] (Daniel P. Berrange), - Add a virKeyfilePtr object for parsing '.ini' files (Daniel P. Berrange), - Convert drivers over to use virURIPtr for query params (Daniel P. Berrange), - Store parsed query parameters directly in the virURIPtr struct (Daniel P. Berrange), - Use a libvirt custom struct for virURIPtr (Daniel P. Berrange), - Centralize error reporting for URI parsing/formatting problems (Daniel P. Berrange), - s/xmlURIPtr/virURIPtr/ in virURIFormat impl (Daniel P. Berrange), - Use virURIFree instead of xmlFreeURI (Daniel P. Berrange), - Add test case for virURIPtr classs (Daniel P. Berrange), - python: add virDomainGetCPUStats python binding API (Guannan Ren), - qemu: Make autodestroy utilize connection close callbacks (Jiri Denemark), - qemu: Add connection close callbacks (Jiri Denemark), - qemu: Add support for domain cleanup callbacks (Jiri Denemark), - python: always include config.h first (Eric Blake), - Cpu mapping cleanup (Martin Kletzander), - virsh: trim aliases from -h output (Eric Blake), - Add support for forcing a private network namespace for LXC guests (Daniel P. Berrange), - Emit graphics events when a SPICE client connects/disconnects (Laine Stump), - numad: Fix typo and warning (Osier Yang), - Add container_uuid env variable to LXC guests (Daniel P. Berrange), - Allow overriding default URI in config file (Daniel P. Berrange), - virsh: A bit smarter attach-disk (Osier Yang), - qemu: Use scsi-block for lun passthrough instead of scsi-disk (Osier Yang), - cpu: Add cpu definition for Intel Sandy Bridge cpu type (Peter Krempa), - Added support for AMD Bulldozer CPU (Martin Kletzander), - graphics: Cleanup port policy (Michal Privoznik), - cpustats: report user and sys times (Eric Blake), - qemuxml2argvtest: Pass some additional flags to graphics-spice-agentmouse (Michal Privoznik), - qemu: spice agent-mouse support (Peng Zhou), - virsh: Use option alias for outmoded "--persistent" (Osier Yang), - util: consolidate duplicated error messages in pci.c (Laine Stump), - qemu: support persistent hotplug of <hostdev> devices (Laine Stump), - util: standardize return from functions calling virNetlinkCommand (Laine Stump), - util: make virDomainLeaseDefFree global (Laine Stump), - util: consolidate duplicated error messages in virnetlink.c (Laine Stump), - util: log error on OOM in virNetDevOpenvswitchAddPort (Laine Stump), - Attach vm-id to Open vSwitch interfaces. (Ansis Atteka), - util: whitespace change to virNetDevOpenvswitchAddPort (Laine Stump), - util: add stub pciConfigAddressToSysfsFile for non-linux platforms (Laine Stump), - rpc: generalize solution for VPATH builds (Eric Blake), - xml: Clean up schemas to use shared data types instead of local (Peter Krempa), - qemu: Don't parse device twice in attach/detach (Michal Privoznik), - virsh: improve memory unit parsing (Eric Blake), - virsh: improve storage unit parsing (Eric Blake), - virsh: add command aliases, and rename nodedev-detach (Eric Blake), - virsh: use option aliases (Eric Blake), - virsh: add option aliases (Eric Blake), - xml: allow scaled memory on input (Eric Blake), - xml: use better types for memory values (Eric Blake), - xml: use long long internally, to centralize overflow checks (Eric Blake), - xml: drop unenforced minimum memory limit from RNG (Eric Blake), - storage: support more scaling suffixes (Eric Blake), - xml: output memory unit for clarity (Eric Blake), - xml: share 'unit' in RNG (Eric Blake), - util: new function for scaling numbers (Eric Blake), - api: add overflow error (Eric Blake), - cpu-stats command shows cpu statistics information of a domain. (KAMEZAWA Hiroyuki), - qemu driver for virDomainGetCPUstats using cpuacct cgroup. (KAMEZAWA Hiroyuki), - add nodeGetCPUmap() for getting available CPU IDs in a cpumap. (KAMEZAWA Hiroyuki), - qemu: install port profile and mac address on netdev hostdevs (Roopa Prabhu), - util: Changes to support portprofiles for hostdevs (Roopa Prabhu), - util: support functions for mac/portprofile associations on hostdev (Roopa Prabhu), - util: two new pci util functions (Roopa Prabhu), - qemu: support type=hostdev network device live hotplug attach/detach (Laine Stump), - qemu: use virDomainNetRemove instead of inline code (Laine Stump), - conf: change virDomainNetRemove from static to global (Laine Stump), - conf: parse/format type='hostdev' network interfaces (Laine Stump), - qemu: refactor hotplug detach of hostdevs (Laine Stump), - qemu: re-order functions in qemu_hotplug.c (Laine Stump), - conf: hostdev utility functions (Laine Stump), - conf: put subsys part of virDomainHostdevDef into its own struct (Laine Stump), - conf: give each hostdevdef a parent pointer (Laine Stump), - conf: HostdevDef parse/format helper functions (Laine Stump), - conf: make hostdev info a separate object (Laine Stump), - conf: add device pointer to args of virDomainDeviceInfoIterate callback (Laine Stump), - qemu: rename virDomainDeviceInfoPtr variables to avoid confusion (Laine Stump), - conf: reorder static functions in domain_conf.c (Laine Stump), - conf: relocate virDomainDeviceDef and virDomainHostdevDef (Laine Stump), - conf: add missing device types to virDomainDevice(Type|Def) (Laine Stump), - blockResize: add flag for bytes (Eric Blake), - qemu: Shared or readonly disks are always safe wrt migration (Jiri Denemark), - libvirt-guests: Add parallel startup and shutdown of guests (Peter Krempa), - Fix type and add missed comment for diskChange callback (Osier Yang), - cpu: Add new flag supported by qemu to the cpu definition (Peter Krempa), - util: combine bools in virNetDevTapCreateInBridgePort into flags (Laine Stump), - util: centralize tap device MAC address 1st byte "0xFE" modification (Ansis Atteka), - build: use correct type for pid and similar types (Eric Blake), - build: prohibit cross-inclusion (Eric Blake), - virsh: expose partial pull (Eric Blake), - qemu: pass block pull backing file to monitor (Eric Blake), - qemu: require json for block jobs (Eric Blake), - fix alphabetical order of virNetlink functions in symbol file (Laine Stump), - build: update to latest gnulib (Eric Blake), - Add de-association handling to macvlan code (D. Herrendoerfer), - util: Add netlink event handling to virnetlink.c (D. Herrendoerfer), - Support for cpu64-rhel* qemu cpu models (Martin Kletzander), - libvirt-guests: Check if URI is reachable before launching commands (Peter Krempa), - libvirt-guests: Don't try to do a managed-save of transient guests (Peter Krempa), - libvirt-guests: Add documentation and clean up to use virsh's improved list (Peter Krempa), - qemu: Add pre-migration hook (Jiri Denemark), - hooks: Add support for capturing hook output (Jiri Denemark), - util: fix a typo (Alex Jia), - storage: fix a typo (Alex Jia), - Do not include binaries in EXTRA_DIST (Daniel Veillard), - virsh: New command cmdChangeMedia (Osier Yang), - virsh: Use vshFindDisk and vshPrepareDiskXML in cmdDetachDisk (Osier Yang), - virsh: Two new helper functions for disk device changes (Osier Yang), - tests: Add tests for virtio-scsi and ibmvscsi controllers (Osier Yang), - qemu: Build command line for the new address format (Osier Yang), - qemu: New cap flag to indicate if channel is supported by scsi-disk (Osier Yang), - conf: Introduce new attribute for device address format (Osier Yang), - conf: Add helper function to look up disk controller model (Osier Yang), - qemu: add virtio-scsi controller model (Paolo Bonzini), - qemu: add ibmvscsi controller model (Paolo Bonzini), - qemu: Add ability to abort existing console while creating new one (Peter Krempa), - util: Add helpers for safe domain console operations (Peter Krempa), - fdstream: Add internal callback on stream close (Peter Krempa), - fdstream: Emit stream abort callback even if poll() doesnt. (Peter Krempa), - virsh: add support for VIR_DOMAIN_CONSOLE_* flags (Peter Krempa), - Add flags for virDomainOpenConsole (Peter Krempa), - pidfile: Make checking binary path in virPidFileRead optional (Peter Krempa), - qemu: Implement virDomainPMWakeup API (Michal Privoznik), - virsh: Expose virDomainPMWakeup (Michal Privoznik), - Fixed URI parsing (Martin Kletzander), - Workaround python header file insanity (Daniel P. Berrange), - Improve error reporting when virsh console is run without a TTY (Daniel P. Berrange), - Error out when using SPICE TLS with spice_tls=0 (Christophe Fergeau), - vmx: Better Workstation vmx handling (Jean-Baptiste Rouault), - qemu: nicer error message on failed graceful destroy (Eric Blake), - qemu: Forbid migration with cache != none (Jiri Denemark), - Introduce virStorageFileIsClusterFS (Jiri Denemark), - virsh: Add --unsafe option to migrate command (Jiri Denemark), - Add support for unsafe migration (Jiri Denemark), - configure: Define program name if not found (Michal Privoznik), - virsh: Enhance list command to ease creation of shell scripts (Peter Krempa), - vmware: implement domainXMLFromNative (Jean-Baptiste Rouault), - esx: Correctly disable HTTP Expect header usage of libcurl (Matthias Bolte), - caps: Improve error if passed an unknown arch (Cole Robinson), - spec: use ix86 macros (Peter Robinson), - nwfilter: improved logging during driver initialization (Stefan Berger), - storage: Allow runtime detection of scrub (Michal Privoznik), - Fix build with polkit0 (Jim Fehlig), - python: Expose virDomain{G,S}etInterfaceParameters APIs in python binding (Alex Jia), - conf: rename virDomainNetGetActualDirectVirtPortProfile (Laine Stump), - qemu: increase the timeout before sending SIGKILL to qemu process (Laine Stump), - qemu: drop driver lock while trying to terminate qemu process (Laine Stump), - qemu: Implement DomainPMSuspendForDuration (Michal Privoznik), - qemu: Set capabilities based on supported monitor commands (Michal Privoznik), - Install API XML desc to a standard location (Daniel P. Berrange), - qemu: make block io tuning smarter (Eric Blake) + <li> Improvements: + Xen: Fix <clock> handling (Philipp Hahn), + Support clock=variable relative to localtime (Philipp Hahn), + python: improve conversion validation (Eric Blake), + Fix client only RPM build & other misc RPM problems (Daniel P. Berrange), + Refactor the libvirt RPM daemon pieces (Daniel P. Berrange), + virnetdevtap: Don't check for flags in virNetDevTapCreateFlags (Michal Privoznik), + Consistent style for usage of sizeof operator (Daniel P. Berrange), + Don't redefine the CPU comparison constants in CPU test (Daniel P. Berrange), + Fix some format specifiers for size_t vs ssize_t (Daniel P. Berrange), + build: silence recent syntax check violations (Eric Blake), + private.syms: Add virNetDevMacVLanRestartWithVPortProfile (Zhou Peng), + Set default name for SPICE agent channel (Christophe Fergeau), + python: make python APIs use these helper functions (Guannan Ren), + python: Add new helper functions for python to C integral conversion (Guannan Ren), + Enable all warnings permanently & default to -Werror for GIT builds (Daniel P. Berrange), + Enable build of test suite programs by default for GIT checkouts (Daniel P. Berrange), + Change the default of mdns_adv to false (Stef Walter), + Add LXC XML files to schema test & fix problems this uncovers (Daniel P. Berrange), + Add support for setting init argv for LXC (Daniel P. Berrange), + Detect location fo selinux mount point (Daniel P. Berrange), + qemu,util: on restart of libvirt restart vepa callbacks (D. Herrendoerfer), + build: fix "missing initializer" error in qemu_process.c (Laine Stump), + build: fix "missing initializer" errors in virsh.c (Laine Stump), + Added syntax-check rule for return with parentheses (Martin Kletzander), + Cleanup for a return statement in source files (Martin Kletzander), + Fix and test round-trip of query parameters (Eric Blake), + snapshot: improve qemu handling of reused snapshot targets (Eric Blake), + snapshot: wire up qemu transaction command (Eric Blake), + snapshot: add support for qemu transaction command (Eric Blake), + snapshot: rudimentary qemu support for atomic disk snapshot (Eric Blake), + snapshot: make offline qemu snapshots atomic (Eric Blake), + snapshot: add atomic create flag (Eric Blake), + snapshot: add qemu capability for 'transaction' command (Eric Blake), + build: fix incorrect enum declaration (Eric Blake), + Add qemu support for ppc64 on FC16 or above for rpm packaging (Li Zhang), + Fix typo s/virURIFormatQuery/virURIFormatParams/ (Daniel P. Berrange), + qemu: Update domain status to running while wakeup event is emitted (Osier Yang), + qemu: Update domain state to pmsuspended while suspend event occurs (Osier Yang), + New domain state pmsuspended (Osier Yang), + Add support for the wakeup event (Osier Yang), + qemu: Update tray status while tray moved event is emitted (Osier Yang), + qemu: Prohibit setting tray status as open for block type disk (Osier Yang), + qemu: Do not start with source for removable disks if tray is open (Osier Yang), + conf: Parse and for the tray attribute (Osier Yang), + Implement sysinfo on PowerPC. (Prerna Saxena), + Lookup auth credentials in config file before prompting (Daniel P. Berrange), + Refactor code prompting for SASL credentials (Daniel P. Berrange), + Add helper API for finding auth file path (Daniel P. Berrange), + Rename virRequest{Username,Password} to virAuthGet{Username,Password} (Daniel P. Berrange), + Rename src/util/authhelper.[ch] to src/util/virauth.[ch] (Daniel P. Berrange), + Add a virKeyfilePtr object for parsing '.ini' files (Daniel P. Berrange), + Convert drivers over to use virURIPtr for query params (Daniel P. Berrange), + Store parsed query parameters directly in the virURIPtr struct (Daniel P. Berrange), + Use a libvirt custom struct for virURIPtr (Daniel P. Berrange), + Centralize error reporting for URI parsing/formatting problems (Daniel P. Berrange), + s/xmlURIPtr/virURIPtr/ in virURIFormat impl (Daniel P. Berrange), + Use virURIFree instead of xmlFreeURI (Daniel P. Berrange), + Add test case for virURIPtr classs (Daniel P. Berrange), + python: add virDomainGetCPUStats python binding API (Guannan Ren), + qemu: Make autodestroy utilize connection close callbacks (Jiri Denemark), + qemu: Add connection close callbacks (Jiri Denemark), + qemu: Add support for domain cleanup callbacks (Jiri Denemark), + python: always include config.h first (Eric Blake), + Cpu mapping cleanup (Martin Kletzander), + virsh: trim aliases from -h output (Eric Blake), + Add support for forcing a private network namespace for LXC guests (Daniel P. Berrange), + Emit graphics events when a SPICE client connects/disconnects (Laine Stump), + numad: Fix typo and warning (Osier Yang), + Add container_uuid env variable to LXC guests (Daniel P. Berrange), + Allow overriding default URI in config file (Daniel P. Berrange), + virsh: A bit smarter attach-disk (Osier Yang), + qemu: Use scsi-block for lun passthrough instead of scsi-disk (Osier Yang), + cpu: Add cpu definition for Intel Sandy Bridge cpu type (Peter Krempa), + Added support for AMD Bulldozer CPU (Martin Kletzander), + graphics: Cleanup port policy (Michal Privoznik), + cpustats: report user and sys times (Eric Blake), + qemuxml2argvtest: Pass some additional flags to graphics-spice-agentmouse (Michal Privoznik), + qemu: spice agent-mouse support (Peng Zhou), + virsh: Use option alias for outmoded "--persistent" (Osier Yang), + util: consolidate duplicated error messages in pci.c (Laine Stump), + qemu: support persistent hotplug of <hostdev> devices (Laine Stump), + util: standardize return from functions calling virNetlinkCommand (Laine Stump), + util: make virDomainLeaseDefFree global (Laine Stump), + util: consolidate duplicated error messages in virnetlink.c (Laine Stump), + util: log error on OOM in virNetDevOpenvswitchAddPort (Laine Stump), + Attach vm-id to Open vSwitch interfaces. (Ansis Atteka), + util: whitespace change to virNetDevOpenvswitchAddPort (Laine Stump), + util: add stub pciConfigAddressToSysfsFile for non-linux platforms (Laine Stump), + rpc: generalize solution for VPATH builds (Eric Blake), + xml: Clean up schemas to use shared data types instead of local (Peter Krempa), + qemu: Don't parse device twice in attach/detach (Michal Privoznik), + virsh: improve memory unit parsing (Eric Blake), + virsh: improve storage unit parsing (Eric Blake), + virsh: add command aliases, and rename nodedev-detach (Eric Blake), + virsh: use option aliases (Eric Blake), + virsh: add option aliases (Eric Blake), + xml: allow scaled memory on input (Eric Blake), + xml: use better types for memory values (Eric Blake), + xml: use long long internally, to centralize overflow checks (Eric Blake), + xml: drop unenforced minimum memory limit from RNG (Eric Blake), + storage: support more scaling suffixes (Eric Blake), + xml: output memory unit for clarity (Eric Blake), + xml: share 'unit' in RNG (Eric Blake), + util: new function for scaling numbers (Eric Blake), + api: add overflow error (Eric Blake), + cpu-stats command shows cpu statistics information of a domain. (KAMEZAWA Hiroyuki), + qemu driver for virDomainGetCPUstats using cpuacct cgroup. (KAMEZAWA Hiroyuki), + add nodeGetCPUmap() for getting available CPU IDs in a cpumap. (KAMEZAWA Hiroyuki), + qemu: install port profile and mac address on netdev hostdevs (Roopa Prabhu), + util: Changes to support portprofiles for hostdevs (Roopa Prabhu), + util: support functions for mac/portprofile associations on hostdev (Roopa Prabhu), + util: two new pci util functions (Roopa Prabhu), + qemu: support type=hostdev network device live hotplug attach/detach (Laine Stump), + qemu: use virDomainNetRemove instead of inline code (Laine Stump), + conf: change virDomainNetRemove from static to global (Laine Stump), + conf: parse/format type='hostdev' network interfaces (Laine Stump), + qemu: refactor hotplug detach of hostdevs (Laine Stump), + qemu: re-order functions in qemu_hotplug.c (Laine Stump), + conf: hostdev utility functions (Laine Stump), + conf: put subsys part of virDomainHostdevDef into its own struct (Laine Stump), + conf: give each hostdevdef a parent pointer (Laine Stump), + conf: HostdevDef parse/format helper functions (Laine Stump), + conf: make hostdev info a separate object (Laine Stump), + conf: add device pointer to args of virDomainDeviceInfoIterate callback (Laine Stump), + qemu: rename virDomainDeviceInfoPtr variables to avoid confusion (Laine Stump), + conf: reorder static functions in domain_conf.c (Laine Stump), + conf: relocate virDomainDeviceDef and virDomainHostdevDef (Laine Stump), + conf: add missing device types to virDomainDevice(Type|Def) (Laine Stump), + blockResize: add flag for bytes (Eric Blake), + qemu: Shared or readonly disks are always safe wrt migration (Jiri Denemark), + libvirt-guests: Add parallel startup and shutdown of guests (Peter Krempa), + Fix type and add missed comment for diskChange callback (Osier Yang), + cpu: Add new flag supported by qemu to the cpu definition (Peter Krempa), + util: combine bools in virNetDevTapCreateInBridgePort into flags (Laine Stump), + util: centralize tap device MAC address 1st byte "0xFE" modification (Ansis Atteka), + build: use correct type for pid and similar types (Eric Blake), + build: prohibit cross-inclusion (Eric Blake), + virsh: expose partial pull (Eric Blake), + qemu: pass block pull backing file to monitor (Eric Blake), + qemu: require json for block jobs (Eric Blake), + fix alphabetical order of virNetlink functions in symbol file (Laine Stump), + build: update to latest gnulib (Eric Blake), + Add de-association handling to macvlan code (D. Herrendoerfer), + util: Add netlink event handling to virnetlink.c (D. Herrendoerfer), + Support for cpu64-rhel* qemu cpu models (Martin Kletzander), + libvirt-guests: Check if URI is reachable before launching commands (Peter Krempa), + libvirt-guests: Don't try to do a managed-save of transient guests (Peter Krempa), + libvirt-guests: Add documentation and clean up to use virsh's improved list (Peter Krempa), + qemu: Add pre-migration hook (Jiri Denemark), + hooks: Add support for capturing hook output (Jiri Denemark), + util: fix a typo (Alex Jia), + storage: fix a typo (Alex Jia), + Do not include binaries in EXTRA_DIST (Daniel Veillard), + virsh: New command cmdChangeMedia (Osier Yang), + virsh: Use vshFindDisk and vshPrepareDiskXML in cmdDetachDisk (Osier Yang), + virsh: Two new helper functions for disk device changes (Osier Yang), + tests: Add tests for virtio-scsi and ibmvscsi controllers (Osier Yang), + qemu: Build command line for the new address format (Osier Yang), + qemu: New cap flag to indicate if channel is supported by scsi-disk (Osier Yang), + conf: Introduce new attribute for device address format (Osier Yang), + conf: Add helper function to look up disk controller model (Osier Yang), + qemu: add virtio-scsi controller model (Paolo Bonzini), + qemu: add ibmvscsi controller model (Paolo Bonzini), + qemu: Add ability to abort existing console while creating new one (Peter Krempa), + util: Add helpers for safe domain console operations (Peter Krempa), + fdstream: Add internal callback on stream close (Peter Krempa), + fdstream: Emit stream abort callback even if poll() doesnt. (Peter Krempa), + virsh: add support for VIR_DOMAIN_CONSOLE_* flags (Peter Krempa), + Add flags for virDomainOpenConsole (Peter Krempa), + pidfile: Make checking binary path in virPidFileRead optional (Peter Krempa), + qemu: Implement virDomainPMWakeup API (Michal Privoznik), + virsh: Expose virDomainPMWakeup (Michal Privoznik), + Fixed URI parsing (Martin Kletzander), + Workaround python header file insanity (Daniel P. Berrange), + Improve error reporting when virsh console is run without a TTY (Daniel P. Berrange), + Error out when using SPICE TLS with spice_tls=0 (Christophe Fergeau), + vmx: Better Workstation vmx handling (Jean-Baptiste Rouault), + qemu: nicer error message on failed graceful destroy (Eric Blake), + qemu: Forbid migration with cache != none (Jiri Denemark), + Introduce virStorageFileIsClusterFS (Jiri Denemark), + virsh: Add --unsafe option to migrate command (Jiri Denemark), + Add support for unsafe migration (Jiri Denemark), + configure: Define program name if not found (Michal Privoznik), + virsh: Enhance list command to ease creation of shell scripts (Peter Krempa), + vmware: implement domainXMLFromNative (Jean-Baptiste Rouault), + esx: Correctly disable HTTP Expect header usage of libcurl (Matthias Bolte), + caps: Improve error if passed an unknown arch (Cole Robinson), + spec: use ix86 macros (Peter Robinson), + nwfilter: improved logging during driver initialization (Stefan Berger), + storage: Allow runtime detection of scrub (Michal Privoznik), + Fix build with polkit0 (Jim Fehlig), + python: Expose virDomain{G,S}etInterfaceParameters APIs in python binding (Alex Jia), + conf: rename virDomainNetGetActualDirectVirtPortProfile (Laine Stump), + qemu: increase the timeout before sending SIGKILL to qemu process (Laine Stump), + qemu: drop driver lock while trying to terminate qemu process (Laine Stump), + qemu: Implement DomainPMSuspendForDuration (Michal Privoznik), + qemu: Set capabilities based on supported monitor commands (Michal Privoznik), + Install API XML desc to a standard location (Daniel P. Berrange), + qemu: make block io tuning smarter (Eric Blake) </li> - <li> Cleanups: - Fix typos and spacing in messages. (Yuri Chornoivan), - qemu: eliminate nested switch, simplify code (Laine Stump), - Fix typo in previous patch (Daniel P. Berrange), - build: drop obsolete qparams test (Eric Blake), - build: drop a painfully long gnulib test (Eric Blake), - Removed more AMD-specific features from cpu64-rhel* models (Martin Kletzander), - conf: eliminate redundant VIR_ALLOC of 1st element of network DNS hosts. (Laine Stump), - remove daemon/probes.h from .gitignore (Laine Stump), - sanlock: Fix condition left crippled while debugging (Peter Krempa), - qemu: Fix indention (Osier Yang), - daemon: Remove deprecated HAL from init script dependencies (Peter Krempa), - util: remove unneeded #include in virrandom.c (Laine Stump), - util: wrap virnetlink.c to 80 columns (Laine Stump), - Fixed service handling in specfile (Martin Kletzander) + <li> Cleanups: + Fix typos and spacing in messages. (Yuri Chornoivan), + qemu: eliminate nested switch, simplify code (Laine Stump), + Fix typo in previous patch (Daniel P. Berrange), + build: drop obsolete qparams test (Eric Blake), + build: drop a painfully long gnulib test (Eric Blake), + Removed more AMD-specific features from cpu64-rhel* models (Martin Kletzander), + conf: eliminate redundant VIR_ALLOC of 1st element of network DNS hosts. (Laine Stump), + remove daemon/probes.h from .gitignore (Laine Stump), + sanlock: Fix condition left crippled while debugging (Peter Krempa), + qemu: Fix indention (Osier Yang), + daemon: Remove deprecated HAL from init script dependencies (Peter Krempa), + util: remove unneeded #include in virrandom.c (Laine Stump), + util: wrap virnetlink.c to 80 columns (Laine Stump), + Fixed service handling in specfile (Martin Kletzander) </li> </ul> -- 1.7.8.5

3 4

[libvirt] sysctl variables, FreeBSD
by Jason Helfman 04 Apr '12

04 Apr '12

Is there a method that can be used to remove the sysctl tuning for FreeBSD in the pipeline? Here are the current patches I have, but would like to remove: http://www.freebsd.org/cgi/cvsweb.cgi/ports/devel/libvirt/files/ Thanks! Jason

2 3

[libvirt] [PATCH 0/8] Refactor libvirt RPM to allow fine grained installed
by Daniel P. Berrange 04 Apr '12

04 Apr '12

This is an update of the patch DV reverted from GIT https://www.redhat.com/archives/libvir-list/2012-March/msg01332.html At the end of this series we have the following RPMs with files The daemon itself (if %with_libvirtd == 1 - ie skipped for %client_only builds) - libvirt-daemon - just libvirtd daemon & secondary drivers (storage, network, nwfilter, etc) Two optional config file packages (if %with_libvirtd == 1): - libvirt-daemon-config-network - just the network driver default config - libvirt-daemon-config-nwfilter - just the nwfilter default config Four hypervisor driver packages (%with_driver_modules == 1, now on by default) - libvirt-daemon-driver-qemu - libvirt_driver_qemu.so + related driver files - libvirt-daemon-driver-lxc - libvirt_driver_lxc.so + related driver files - libvirt-daemon-driver-uml - libvirt_driver_uml.so + related driver files - libvirt-daemon-driver-xen - libvirt_driver_{xen,libxl}.so + related driver files Other non-daemon packages always enabled - libvirt-client - libvirt.so + virsh - libvirt-devel - libvirt header files & libraries - libvirt-python - libvirt python module - libvirt-docs - API docs and website docs Finally there are a handful of virtual empty packages To preserve the existing upgrade path & avoid breaking existing app dependancies: - libvirt - Depends libvirt-daemon, libvirt-client, libvirt-daemon-config-* and libvirt-daemon-driver-*. To allow applications to depend on specific libvirt drivers: - libvirt-daemon-qemu - Depends on libvirt-daemon, libvirt-daemon-driver-qemu & qemu - libvirt-daemon-kvm - Depends on libvirt-daemon, libvirt-daemon-driver-qemu & qemu-kvm - libvirt-daemon-lxc - Depends on libvirt-daemon, libvirt-daemon-driver-lxc - libvirt-daemon-uml - Depends on libvirt-daemon, libvirt-daemon-driver-uml - libvirt-daemon-xen - Depends on libvirt-daemon, libvirt-daemon-driver-xen & xen The result is: - To install everything (daemon, all drivers, all configs) yum install libvirt - To install just KVM with no configs yum install libvirt-daemon-kvm - To install KVM + default configs yum install libvirt-daemon-kvm libvirt-daemon-config-network libvirt-daemon-config-nwfilter The problems solved are - Can install libvirtd without the default configs which many apps don't want and causing death to networking if installed inside a guest - Applications don't need to know about the underlying hypervisor package names - libvirt pulls in the correct packages - Applications can install KVM without pulling in Xen libraries

2 19

[libvirt] [PATCH] virsh: Clarify escape sequence
by Michal Privoznik 03 Apr '12

03 Apr '12

Currently, we put no strains on escape sequence possibly leaving users with console that cannot be terminated. However, not all ASCII characters can be used as escape sequence. Only those falling in @ - _ can be; implement and document this constraint. --- tools/console.c | 3 ++- tools/virsh.c | 13 ++++++++++++- tools/virsh.pod | 3 ++- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/tools/console.c b/tools/console.c index ca226c3..0f30b95 100644 --- a/tools/console.c +++ b/tools/console.c @@ -34,6 +34,7 @@ # include <errno.h> # include <unistd.h> # include <signal.h> +# include <c-ctype.h> # include "internal.h" # include "console.h" @@ -292,7 +293,7 @@ static char vshGetEscapeChar(const char *s) { if (*s == '^') - return CONTROL(s[1]); + return CONTROL(c_islower(s[1]) ? c_toupper(s[1]) : s[1]); return *s; } diff --git a/tools/virsh.c b/tools/virsh.c index 1ed2dda..cfdd040 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -19879,6 +19879,16 @@ vshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED) vshPrint(ctl, "\n"); } +static bool +vshAllowedEscapeChar(char c) +{ + /* Allowed escape characters: + * a-z A-Z @ [ \ ] ^ _ + */ + return ('a' <= c && c <= 'z') || + ('@' <= c && c <= '_'); +} + /* * argv[]: virsh [options] [command] * @@ -19942,7 +19952,8 @@ vshParseArgv(vshControl *ctl, int argc, char **argv) case 'e': len = strlen(optarg); - if ((len == 2 && *optarg == '^') || + if ((len == 2 && *optarg == '^' && + vshAllowedEscapeChar(optarg[1])) || (len == 1 && *optarg != '^')) { ctl->escapeChar = optarg; } else { diff --git a/tools/virsh.pod b/tools/virsh.pod index d4971a3..a60e667 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -95,7 +95,8 @@ Output elapsed time information for each command. =item B<-e>, B<--escape> I<string> Set alternative escape sequence for I<console> command. By default, -telnet's B<^]> is used. +telnet's B<^]> is used. Allowed characters when using hat notation are: +alphabetic character, @, [, ], \, ^, _. =back -- 1.7.8.5

3 3

[libvirt] [PATCH 00/10] Enable loadable modules for libvirtd
by Daniel P. Berrange 03 Apr '12

03 Apr '12

For a long timer we've had the ability to build each libvirt driver as a loadable module. We have never used this by default and as a result it constantly bit-rots. This series fixes various bugs, and then enables it by default in configure. It also makes the PRMs use the loadable modules, adding new new sub-RPMs for each module. We can now finally install minimal libvirt binaries for each hypervisor. ie yum install libvirt-kvm will not pull in Xen libraries!

3 22