- Devel - libvirt List Archives

[libvirt] [PATCH V2 0/2] (Basic) FirewallD support
by Stefan Berger 21 Aug '12

21 Aug '12

The following two patches provide basic firewalld support for libvirt. I took Thomas Woerner's patches and modified them where needed. Stefan

5 9

[libvirt] [PATCH] command: avoid double close in virExecWithHook
by Ján Tomko 21 Aug '12

21 Aug '12

Fix possible double close in the child process after the fork in case infd and outfd are equal, just like they are after being called from virNetSocketNewConnectCommand. --- src/util/command.c | 14 +++++--------- 1 files changed, 5 insertions(+), 9 deletions(-) diff --git a/src/util/command.c b/src/util/command.c index 7755572..49ec178 100644 --- a/src/util/command.c +++ b/src/util/command.c @@ -547,17 +547,13 @@ virExecWithHook(const char *const*argv, goto fork_error; } - if (infd != STDIN_FILENO && infd != null) + if (infd != STDIN_FILENO && infd != null && infd != childerr && + infd != childout) VIR_FORCE_CLOSE(infd); - if (childout > STDERR_FILENO && childout != null) { - tmpfd = childout; /* preserve childout value */ - VIR_FORCE_CLOSE(tmpfd); - } - if (childerr > STDERR_FILENO && - childerr != childout && - childerr != null) { + if (childout > STDERR_FILENO && childout != null && childout != childerr) + VIR_FORCE_CLOSE(childout); + if (childerr > STDERR_FILENO && childerr != null) VIR_FORCE_CLOSE(childerr); - } VIR_FORCE_CLOSE(null); /* Initialize full logging for a while */ -- 1.7.8.6

3 2

[libvirt] [PATCH] sanlock: Provide better error if lockspace directory is missing
by Jiri Denemark 21 Aug '12

21 Aug '12

Generating "Unable to add lockspace /lock/space/dir/__LIBVIRT__DISKS__: No such file or directory" is correct but not exactly clear. This patch changes the error message to "Unable to create lockspace /lock/space/dir/__LIBVIRT__DISKS__: parent directory does not exist or is not a directory". --- src/locking/lock_driver_sanlock.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index f046102..7700b31 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -35,6 +35,7 @@ #include <sanlock_resource.h> #include <sanlock_admin.h> +#include "dirname.h" #include "lock_driver.h" #include "logging.h" #include "virterror_internal.h" @@ -150,6 +151,7 @@ static int virLockManagerSanlockSetupLockspace(void) int rv; struct sanlk_lockspace ls; char *path = NULL; + char *dir = NULL; if (virAsprintf(&path, "%s/%s", driver->autoDiskLeasePath, @@ -174,6 +176,19 @@ static int virLockManagerSanlockSetupLockspace(void) */ if (stat(path, &st) < 0) { VIR_DEBUG("Lockspace %s does not yet exist", path); + + if (!(dir = mdir_name(path))) { + virReportOOMError(); + goto error; + } + if (stat(dir, &st) < 0 || !S_ISDIR(st.st_mode)) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to create lockspace %s: parent directory" + " does not exist or is not a directory"), + path); + goto error; + } + if ((fd = open(path, O_WRONLY|O_CREAT|O_EXCL, 0600)) < 0) { if (errno != EEXIST) { virReportSystemError(errno, @@ -257,6 +272,7 @@ error_unlink: error: VIR_FORCE_CLOSE(fd); VIR_FREE(path); + VIR_FREE(dir); return -1; } -- 1.7.11.1

2 2

[libvirt] [PATCH] daemon: Autodetect lock driver directory
by Jiri Denemark 21 Aug '12

21 Aug '12

When running libvirtd from a build directory, libvirtd would load lock drivers from system directory unless explicitly overridden by setting LIBVIRT_LOCK_MANAGER_PLUGIN_DIR environment variable. Since we already autodetect driver directory if libvirt is build with driver modules, we can use the same trick to automagically set lock driver directory. --- daemon/libvirtd.c | 6 ++++-- src/libvirt_private.syms | 1 + src/locking/lock_manager.c | 12 +++++++++++- src/locking/lock_manager.h | 1 + 4 files changed, 17 insertions(+), 3 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index f0b0a3c..5245740 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -55,6 +55,7 @@ #include "hooks.h" #include "uuid.h" #include "viraudit.h" +#include "locking/lock_manager.h" #ifdef WITH_DRIVER_MODULES # include "driver.h" @@ -971,7 +972,6 @@ int main(int argc, char **argv) { /* initialize early logging */ virLogSetFromEnv(); -#ifdef WITH_DRIVER_MODULES if (strstr(argv[0], "lt-libvirtd") || strstr(argv[0], "/daemon/.libs/libvirtd")) { char *tmp = strrchr(argv[0], '/'); @@ -990,11 +990,13 @@ int main(int argc, char **argv) { argv[0], driverdir); exit(EXIT_FAILURE); } + virLockManagerSetPluginDir(driverdir); +#ifdef WITH_DRIVER_MODULES virDriverModuleInitialize(driverdir); +#endif *tmp = '/'; /* Must not free 'driverdir' - it is still used */ } -#endif while (1) { int optidx = 0; diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4cfa95f..e2d6d27 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -757,6 +757,7 @@ virLockManagerPluginUnref; virLockManagerPluginUsesState; virLockManagerPluginGetName; virLockManagerRelease; +virLockManagerSetPluginDir; # logging.h diff --git a/src/locking/lock_manager.c b/src/locking/lock_manager.c index 1d9c1bf..068327f 100644 --- a/src/locking/lock_manager.c +++ b/src/locking/lock_manager.c @@ -64,6 +64,16 @@ struct _virLockManagerPlugin { #define DEFAULT_LOCK_MANAGER_PLUGIN_DIR LIBDIR "/libvirt/lock-driver" +static const char *virLockManagerPluginDir = DEFAULT_LOCK_MANAGER_PLUGIN_DIR; + +void +virLockManagerSetPluginDir(const char *dir) +{ + if (dir) + virLockManagerPluginDir = dir; +} + + static void virLockManagerLogParams(size_t nparams, virLockManagerParamPtr params) { @@ -128,7 +138,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name, driver = &virLockDriverNop; } else { if (moddir == NULL) - moddir = DEFAULT_LOCK_MANAGER_PLUGIN_DIR; + moddir = virLockManagerPluginDir; VIR_DEBUG("Module load %s from %s", name, moddir); diff --git a/src/locking/lock_manager.h b/src/locking/lock_manager.h index 25c7f7f..6a779f0 100644 --- a/src/locking/lock_manager.h +++ b/src/locking/lock_manager.h @@ -28,6 +28,7 @@ typedef struct _virLockManagerPlugin virLockManagerPlugin; typedef virLockManagerPlugin *virLockManagerPluginPtr; +void virLockManagerSetPluginDir(const char *dir); virLockManagerPluginPtr virLockManagerPluginNew(const char *name, const char *configFile, unsigned int flags); -- 1.7.11.1

2 2

[libvirt] [PATCH 00/23] Introduce a virtlockd daemon for disk locking
by Daniel P. Berrange 21 Aug '12

21 Aug '12

This is a long overdue update to a patch series I posted about a year ago https://www.redhat.com/archives/libvir-list/2011-July/msg00337.html There have been some major changes since that series - A general purpose lockspace module has been created (virLockSpacePtr in src/util/virlockspace.[ch]) - The virtlockd daemon protocol has been re-written so it only operates at the level of virLockSpacePtr APIs, and knows nothing of the usage wrt to virDomainObjPtrs - The lock driver client now translates requests for disk locks on a virDomainObjPtr into requests for resources in a lockspace managed by virtlockd. - The virtlockd daemon now has the ability to re-exec() itself to upgrade software without loosing active locks or clients - By default the locks are held directly on the file paths, rather than in a parallel "locks" directory based on sha256 checksums of the filename Still todo - Add ability to quiesce all server/client I/O when doing re-exec() - Add ability to save/restore data in any virNetMessagePtr structs in the client rx or tx queues - Add ability to use custom lockspaces for LVM and SCSI/ISCSI block devices, instead of locking based on path, to gain cross-node safety, instead of node-local safety. NB, the current re-exec() support works, but is not race safe without those first 2 todo items being completed .gitignore | 5 cfg.mk | 9 daemon/libvirtd.c | 2 daemon/remote.c | 15 daemon/remote.h | 6 include/libvirt/virterror.h | 2 libvirt.spec.in | 16 po/POTFILES.in | 5 src/Makefile.am | 182 ++++- src/internal.h | 22 src/libvirt_private.syms | 32 src/locking/domain_lock.c | 26 src/locking/lock_daemon.c | 1336 +++++++++++++++++++++++++++++++++++++ src/locking/lock_daemon.h | 56 + src/locking/lock_daemon_dispatch.c | 370 ++++++++++ src/locking/lock_daemon_dispatch.h | 31 src/locking/lock_driver_lockd.c | 561 +++++++++++++++ src/locking/lock_manager.c | 31 src/locking/lock_manager.h | 3 src/locking/lock_protocol.x | 89 ++ src/locking/virtlockd.init.in | 93 ++ src/locking/virtlockd.service.in | 13 src/locking/virtlockd.socket.in | 8 src/locking/virtlockd.sysconf | 3 src/lxc/lxc_controller.c | 24 src/lxc/lxc_monitor.c | 2 src/qemu/qemu.conf | 17 src/qemu/qemu_agent.c | 10 src/qemu/qemu_conf.c | 2 src/qemu/qemu_monitor_json.c | 12 src/qemu/test_libvirtd_qemu.aug.in | 2 src/remote/remote_driver.c | 9 src/rpc/virnetclient.c | 81 +- src/rpc/virnetclient.h | 3 src/rpc/virnetserver.c | 308 ++++++++ src/rpc/virnetserver.h | 20 src/rpc/virnetserverclient.c | 198 ++++- src/rpc/virnetserverclient.h | 28 src/rpc/virnetserverservice.c | 211 +++++ src/rpc/virnetserverservice.h | 13 src/rpc/virnetsocket.c | 128 +++ src/rpc/virnetsocket.h | 9 src/util/json.c | 9 src/util/json.h | 3 src/util/threadpool.c | 19 src/util/threadpool.h | 4 src/util/virlockspace.c | 784 +++++++++++++++++++++ src/util/virlockspace.h | 62 + src/util/virterror.c | 9 tests/Makefile.am | 7 tests/virlockspacetest.c | 363 ++++++++++ 51 files changed, 5080 insertions(+), 173 deletions(-)

2 52

[libvirt] [PATCH 0/5] support guest agent general command
by MATSUDA, Daiki 21 Aug '12

21 Aug '12

Hi, All. I rewrote the patches as Eric suggested. virsh # help qemu-agent-command NAME qemu-agent-command - Qemu Guest Agent Command SYNOPSIS qemu-agent-command <domain> [--timeout <number>] {[--cmd] <string>}... DESCRIPTION Qemu Guest Agent Command OPTIONS [--domain] <string> domain name, id or uuid --timeout <number> timeout [--cmd] <string> command virsh # qemu-agent-command RHEL58_64 '{"execute":"guest-info"}' {"return":{"version":"1.1.50","supported_commands":[{"enabled":true,"name":"guest-network-get-interfaces"},{"enabled":true,"name":"guest-suspend-hybrid"},{"enabled":true,"name":"guest-suspend-ram"},{"enabled":true,"name":"guest-suspend-disk"},{"enabled":true,"name":"guest-fsfreeze-thaw"},{"enabled":true,"name":"guest-fsfreeze-freeze"},{"enabled":true,"name":"guest-fsfreeze-status"},{"enabled":true,"name":"guest-file-flush"},{"enabled":true,"name":"guest-file-seek"},{"enabled":true,"name":"guest-file-write"},{"enabled":true,"name":"guest-file-read"},{"enabled":true,"name":"guest-file-close"},{"enabled":true,"name":"guest-file-open"},{"enabled":true,"name":"guest-shutdown"},{"enabled":true,"name":"guest-info"},{"enabled":true,"name":"guest-ping"},{"enabled":true,"name":"guest-sync"},{"enabled":true,"name":"guest-sync-delimited"}]}} virsh # qemu-agent-command RHEL58_64 '{"execute":"guest-sync", "arguments":{"id":123}}' {"return":123}

3 3

[libvirt] [PATCH] build: split driver_storage into convenience library
by Eric Blake 21 Aug '12

21 Aug '12

Commit 1d22ba95 was complete at the time, but we have since reintroduced a warning that is fixed in the same manner: CCLD storagebackendsheepdogtest *** Warning: Linking the executable storagebackendsheepdogtest against the loadable module *** libvirt_driver_storage.so is not portable! * src/Makefile.am (libvirt_driver_storage.la): Factor into new convenience library. * tests/Makefile.am (storagebackendsheepdogtest_LDADD): Link to convenience library, not shared library. --- src/Makefile.am | 49 +++++++++++++++++++++++++------------------------ tests/Makefile.am | 3 ++- 2 files changed, 27 insertions(+), 25 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index d35edd6..2827e86 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1050,66 +1050,67 @@ libvirt_driver_secret_la_SOURCES = $(SECRET_DRIVER_SOURCES) endif # Needed to keep automake quiet about conditionals -libvirt_driver_storage_la_SOURCES = -libvirt_driver_storage_la_CFLAGS = \ +libvirt_driver_storage_impl_la_SOURCES = +libvirt_driver_storage_impl_la_CFLAGS = \ -I$(top_srcdir)/src/conf $(AM_CFLAGS) -libvirt_driver_storage_la_LDFLAGS = $(AM_LDFLAGS) -libvirt_driver_storage_la_LIBADD = +libvirt_driver_storage_impl_la_LDFLAGS = $(AM_LDFLAGS) +libvirt_driver_storage_impl_la_LIBADD = if WITH_SECDRIVER_SELINUX -libvirt_driver_storage_la_LIBADD += $(SELINUX_LIBS) +libvirt_driver_storage_impl_la_LIBADD += $(SELINUX_LIBS) endif if WITH_SECDRIVER_APPARMOR -libvirt_driver_storage_la_LIBADD += $(APPARMOR_LIBS) +libvirt_driver_storage_impl_la_LIBADD += $(APPARMOR_LIBS) endif if HAVE_LIBBLKID -libvirt_driver_storage_la_CFLAGS += $(BLKID_CFLAGS) -libvirt_driver_storage_la_LIBADD += $(BLKID_LIBS) +libvirt_driver_storage_impl_la_CFLAGS += $(BLKID_CFLAGS) +libvirt_driver_storage_impl_la_LIBADD += $(BLKID_LIBS) endif if WITH_STORAGE +noinst_LTLIBRARIES += libvirt_driver_storage_impl.la +libvirt_driver_storage_la_SOURCES = +libvirt_driver_storage_la_LIBADD = libvirt_driver_storage_impl.la if WITH_DRIVER_MODULES mod_LTLIBRARIES += libvirt_driver_storage.la +libvirt_driver_storage_la_LIBADD += ../gnulib/lib/libgnu.la +libvirt_driver_storage_la_LDFOAGS = -module -avoid-version else noinst_LTLIBRARIES += libvirt_driver_storage.la # Stateful, so linked to daemon instead #libvirt_la_BUILT_LIBADD += libvirt_driver_storage.la endif -if WITH_DRIVER_MODULES -libvirt_driver_storage_la_LIBADD += ../gnulib/lib/libgnu.la -libvirt_driver_storage_la_LDFLAGS += -module -avoid-version -endif -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_SOURCES) -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_FS_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_FS_SOURCES) endif if WITH_STORAGE_LVM -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_LVM_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_LVM_SOURCES) endif if WITH_STORAGE_ISCSI -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_ISCSI_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_ISCSI_SOURCES) endif if WITH_STORAGE_SCSI -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_SCSI_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_SCSI_SOURCES) endif if WITH_STORAGE_MPATH -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_MPATH_SOURCES) -libvirt_driver_storage_la_CFLAGS += $(DEVMAPPER_CFLAGS) -libvirt_driver_storage_la_LIBADD += $(DEVMAPPER_LIBS) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_MPATH_SOURCES) +libvirt_driver_storage_impl_la_CFLAGS += $(DEVMAPPER_CFLAGS) +libvirt_driver_storage_impl_la_LIBADD += $(DEVMAPPER_LIBS) endif if WITH_STORAGE_DISK -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_DISK_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_DISK_SOURCES) endif if WITH_STORAGE_RBD -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_RBD_SOURCES) -libvirt_driver_storage_la_LIBADD += $(LIBRBD_LIBS) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_RBD_SOURCES) +libvirt_driver_storage_impl_la_LIBADD += $(LIBRBD_LIBS) endif if WITH_STORAGE_SHEEPDOG -libvirt_driver_storage_la_SOURCES += $(STORAGE_DRIVER_SHEEPDOG_SOURCES) +libvirt_driver_storage_impl_la_SOURCES += $(STORAGE_DRIVER_SHEEPDOG_SOURCES) endif if WITH_NODE_DEVICES diff --git a/tests/Makefile.am b/tests/Makefile.am index e97a487..8cf8015 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -412,7 +412,8 @@ if WITH_STORAGE_SHEEPDOG storagebackendsheepdogtest_SOURCES = \ storagebackendsheepdogtest.c \ testutils.c testutils.h -storagebackendsheepdogtest_LDADD = ../src/libvirt_driver_storage.la $(LDADDS) +storagebackendsheepdogtest_LDADD = \ + ../src/libvirt_driver_storage_impl.la $(LDADDS) else EXTRA_DIST += storagebackendsheepdogtest.c endif -- 1.7.11.4

2 2

[libvirt] [PATCH] build: silence stupid gcc warning on STREQ_NULLABLE
by Eric Blake 21 Aug '12

21 Aug '12

Our existing STRNEQ_NULLABLE() triggered a warning in gcc 4.7 when used with a literal NULL argument: qemumonitorjsontest.c: In function 'testQemuMonitorJSONGetMachines': qemumonitorjsontest.c:289:5: error: null argument where non-null required (argument 1) [-Werror=nonnull] even though the strcmp is provably dead when a null argument is present. Squelch the warning by refactoring things so that gcc never sees strcmp() called with NULL arguments (we still compare NULL as not equal to "", this rewrite merely aids gcc). Next, gcc has a valid warning about a literal NULLSTR(NULL): qemumonitorjsontest.c:289:5: error: invalid application of 'sizeof' to a void type [-Werror=pointer-arith] Of course, you'd never write NULLSTR(NULL) directly, but it is handy to use through macros. And since we only really need the code to be warning-free when developing with modern gcc, and merely compiled correctly elsewhere, we can rely on gcc extensions to avoid dereferencing NULL even inside a sizeof operation. * src/internal.h (STREQ_NULLABLE, STRNEQ_NULLABLE): Avoid gcc 4.7 stupidity. (NULLSTR): Allow passing compile-time constants via macros. --- src/internal.h | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/internal.h b/src/internal.h index 300de3a..c27ffc5 100644 --- a/src/internal.h +++ b/src/internal.h @@ -79,10 +79,9 @@ # define STRSKIP(a,b) (STRPREFIX(a,b) ? (a) + strlen(b) : NULL) # define STREQ_NULLABLE(a, b) \ - ((!(a) && !(b)) || ((a) && (b) && STREQ((a), (b)))) + ((a) ? (b) && STREQ((a) ? (a) : "", (b) ? (b) : "") : !(b)) # define STRNEQ_NULLABLE(a, b) \ - ((!(a) ^ !(b)) || ((a) && (b) && STRNEQ((a), (b)))) - + ((a) ? !(b) || STRNEQ((a) ? (a) : "", (b) ? (b) : "") : !!(b)) # define NUL_TERMINATE(buf) do { (buf)[sizeof(buf)-1] = '\0'; } while (0) # define ARRAY_CARDINALITY(Array) (sizeof(Array) / sizeof(*(Array))) @@ -206,9 +205,22 @@ /* * Use this when passing possibly-NULL strings to printf-a-likes. */ -# define NULLSTR(s) \ - ((void)verify_true(sizeof(*(s)) == sizeof(char)), \ - (s) ? (s) : "(null)") +# if __GNUC_PREREQ(4, 6) +char *link_error_due_to_bad_NULLSTR_type(void); +# define NULLSTR(s) \ + ({ \ + const char *_tmp; \ + if (__builtin_constant_p(s) || \ + __builtin_types_compatible_p(typeof(s), char *) || \ + __builtin_types_compatible_p(typeof(s), const char *)) \ + _tmp = (s) ? (s) : "(null)"; \ + else \ + _tmp = link_error_due_to_bad_NULLSTR_type(); \ + _tmp; \ + }) +# else +# define NULLSTR(s) ((s) ? (s) : "(null)") +# endif /** * TODO: -- 1.7.11.4

2 2

[libvirt] [PATCH 0/4] Support for limiting guest coredumps
by Martin Kletzander 21 Aug '12

21 Aug '12

This series applies on the disable_s3/s4 series [1] and works with qemu patch [2] (not applied yet), so it shouldn't be pushed before the qemu part is. Basically qemu supports marking guest memory as (not)dumpable using madvise(2) system call and in case the guest memory is not desired the option can reduce the coredump by a reasonable size. Martin [1] https://www.redhat.com/archives/libvir-list/2012-August/msg00572.html [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg00554.html Martin Kletzander (4): Add support for limiting guest coredump qemu: add support for dump-guest-core option tests: Add tests for dump-core option docs: Document dump-core memory feature docs/formatdomain.html.in | 13 ++- docs/schemas/domaincommon.rng | 8 ++ src/conf/domain_conf.c | 19 ++++- src/conf/domain_conf.h | 10 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 89 ++++++++++++++++++-- tests/qemuargv2xmltest.c | 2 + .../qemuxml2argv-machine-core-off.args | 5 + .../qemuxml2argv-machine-core-off.xml | 26 ++++++ .../qemuxml2argv-machine-core-on.args | 5 + .../qemuxml2argv-machine-core-on.xml | 26 ++++++ tests/qemuxml2argvtest.c | 3 + tests/qemuxml2xmltest.c | 2 + 15 files changed, 202 insertions(+), 13 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-off.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-machine-core-on.xml -- 1.7.8.6

2 8

[libvirt] [PATCHv2 0/4] Add LibSSH2 transport
by Peter Krempa 21 Aug '12

21 Aug '12

This is a second respin of the LibSSH2 transport patch series. The most notable changes: ------------------------- - Rebased on top of current upstream (virObject, new error codes) - ported to use virObject stuff - re-named all functions and other literals to contain the "2" - implemented suggestions from Eric's review - added symbol file and various other cleanups The easiest way to test the actual implementation is to apply the patchset and try connecting to a remote host using virsh and then trying some API's. The most complex part of the code are the various authentication options that can be selected in the connection URI. Peter Krempa (4): libssh2_transport: add main libssh2 transport implementation libssh2_transport: add ssh context support to virNetSocket libssh2_transport: Add libssh2 session support to net client code libssh2_transport: Use libssh2 driver code in remote driver configure.ac | 40 +- include/libvirt/virterror.h | 2 + po/POTFILES.in | 1 + src/Makefile.am | 16 +- src/libvirt_libssh2.syms | 18 + src/libvirt_private.syms | 2 + src/remote/remote_driver.c | 47 ++- src/rpc/virnetclient.c | 117 ++++ src/rpc/virnetclient.h | 14 +- src/rpc/virnetlibssh2session.c | 1464 ++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibssh2session.h | 83 +++ src/rpc/virnetsocket.c | 178 +++++- src/rpc/virnetsocket.h | 13 + src/util/virterror.c | 8 +- 14 files changed, 1993 insertions(+), 10 deletions(-) create mode 100644 src/libvirt_libssh2.syms create mode 100644 src/rpc/virnetlibssh2session.c create mode 100644 src/rpc/virnetlibssh2session.h -- 1.7.8.6

4 15