- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/9] improve virBitmap
by Hu Tao 12 Sep '12

12 Sep '12

In many places we store bitmap info in a chunk of data (pointed to by a char *), and have redundant codes to set/unset bits. This series extends virBitmap, and convert those codes to use virBitmap. changes: v2: - fix bug in qemuSetupCgroupForEmulator - new function virBitmapNextSetBit - virBitmapcmp -> virBitmapEqual - virBitmap: store bits in little endian format - some improvements of virBitmap - fix some memory leaks Hu Tao (9): fix bug in qemuSetupCgroupForEmulator New functions for virBitmap use virBitmap to store cpupin info use virBitmap to store cpu affinity info use virBitmap to store numa nodemask info. use virBitmap to store cpumask info. use virBitmap to store cells' cpumask info. use virBitmap to store nodeinfo. remove virDomainCpuSetFormat and virDomainCpuSetParse .gitignore | 1 + src/conf/cpu_conf.c | 17 +- src/conf/cpu_conf.h | 3 +- src/conf/domain_conf.c | 392 ++++++--------------------------- src/conf/domain_conf.h | 18 +- src/libvirt_private.syms | 14 +- src/lxc/lxc_controller.c | 56 ++--- src/nodeinfo.c | 26 +-- src/nodeinfo.h | 6 +- src/parallels/parallels_driver.c | 5 +- src/qemu/qemu_cgroup.c | 18 +- src/qemu/qemu_cgroup.h | 2 +- src/qemu/qemu_command.c | 43 +--- src/qemu/qemu_driver.c | 168 +++++++------- src/qemu/qemu_process.c | 141 ++++-------- src/test/test_driver.c | 5 +- src/util/bitmap.c | 451 +++++++++++++++++++++++++++++++++++++- src/util/bitmap.h | 34 +++ src/util/processinfo.c | 36 +-- src/util/processinfo.h | 9 +- src/vmx/vmx.c | 36 +-- tests/Makefile.am | 7 +- tests/cpuset | 2 +- tests/virbitmaptest.c | 233 ++++++++++++++++++++ 24 files changed, 1034 insertions(+), 689 deletions(-) create mode 100644 tests/virbitmaptest.c -- 1.7.10.2

2 15

[libvirt] [PATCH] python: Initialize new_params in virDomainSetSchedulerParameters
by Federico Simoncelli 12 Sep '12

12 Sep '12

The new_params variable must be initialized in case the virDomainGetSchedulerParameters call fails and we hit the cleanup section before actually allocating the new parameters. Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> --- python/libvirt-override.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/libvirt-override.c b/python/libvirt-override.c index bb1d881..485ed28 100644 --- a/python/libvirt-override.c +++ b/python/libvirt-override.c @@ -700,7 +700,7 @@ libvirt_virDomainSetSchedulerParameters(PyObject *self ATTRIBUTE_UNUSED, int i_retval; int nparams = 0; Py_ssize_t size = 0; - virTypedParameterPtr params, new_params; + virTypedParameterPtr params, new_params = NULL; if (!PyArg_ParseTuple(args, (char *)"OO:virDomainSetScedulerParameters", &pyobj_domain, &info)) -- 1.7.1

3 2

[libvirt] 1 of 56 tests failed
by fugui_li 11 Sep '12

11 Sep '12

======================================= make[2]: *** [check-TESTS] Error 1 make[2]: Leaving directory `/home/work/libvirt/91021/libvirt-0.9.10/build/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/work/libvirt/91021/libvirt-0.9.10/build/tests' make: *** [check-recursive] Error 1 exec 3>&- test "$st" = 0 fugui_li

2 1

[libvirt] [PATCH] docs: page.xsl: fix FAQ link in subdirectories
by Ján Tomko 11 Sep '12

11 Sep '12

Links to the FAQ didn't work on pages in subdirectories, like devhelp/libvirt-virterror.html or internals/command.html, because they have had href_base prepended to them. --- docs/page.xsl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/page.xsl b/docs/page.xsl index fc782a2..bc8ea2a 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -54,7 +54,7 @@ <xsl:when test="$pagename = a/@href"> <span class="{$class}"><xsl:value-of select="a"/></span> </xsl:when> - <xsl:when test="a/@href = 'http://wiki.libvirt.org'"> + <xsl:when test="starts-with(a/@href, 'http://wiki.libvirt.org')"> <a title="{./span}" class="{$class}" href="{a/@href}"><xsl:value-of select="a"/></a> </xsl:when> <xsl:otherwise> -- 1.7.8.6

2 1

[libvirt] [PATCHv1 0/4] Subject: [PATCHv1 0/4] qemu: Add sandbox support
by Ján Tomko 11 Sep '12

11 Sep '12

This series adds support to run QEMU with sandbox enabled, a syscall filter using seccomp. It can be configured in qemu.conf to on, off, or the QEMU default, which is off in 1.2. Default value is the QEMU default. V1 of the patches supports tri-state configuration and includes a test for detecting the capability. Ján Tomko (4): qemu: add capability flag for sandbox qemu: conf: add sandbox option qemu: add -sandbox to command line if requested tests: add qemu-1.2.0 data src/qemu/qemu.conf | 8 + src/qemu/qemu_capabilities.c | 3 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_conf.c | 5 + src/qemu/qemu_conf.h | 1 + tests/qemuhelpdata/qemu-1.2.0 | 270 ++++++++++++++++++++++++++++++++++ tests/qemuhelpdata/qemu-1.2.0-device | 181 +++++++++++++++++++++++ tests/qemuhelptest.c | 82 ++++++++++ 9 files changed, 558 insertions(+), 0 deletions(-) create mode 100644 tests/qemuhelpdata/qemu-1.2.0 create mode 100644 tests/qemuhelpdata/qemu-1.2.0-device -- 1.7.8.6

2 10

Re: [libvirt] problems using virt-manager
by 王金浦 11 Sep '12

11 Sep '12

2012/9/11 Lentes, Bernd <bernd.lentes(a)helmholtz-muenchen.de> > > Hi, > > i try to run virt-manager on a SLES 11 SP1 box. I'm using kernel 2.6.32.12 > and virt-manager 0.9.4-106.1.x86_64 . > The system is a 64bit box. > > Here is the output: > ========================= > > pc56846:/media/idg2/SysAdmin_AG_Wurst/software_und_treiber/virt_manager/sles_11_sp1 > # virt-manager & > [1] 9659 > > pc56846:/media/idg2/SysAdmin_AG_Wurst/software_und_treiber/virt_manager/sles_11_sp1 > # Traceback (most recent call last): > File "/usr/share/virt-manager/virt-manager.py", line 386, in <module> > main() > File "/usr/share/virt-manager/virt-manager.py", line 247, in main > from virtManager import cli > File "/usr/share/virt-manager/virtManager/cli.py", line 29, in <module> > import libvirt > File "/usr/lib64/python2.6/site-packages/libvirt.py", line 25, in > <module> > raise lib_e > ImportError: /usr/lib64/libvirt.so.0: undefined symbol: > selinux_virtual_domain_context_path > > [1]+ Exit 1 virt-manager > ========================= > Seems libvirt popup a importError, so libvir list may be a good place to ask, add into cc. Jack

2 1

[libvirt] [PATCH] docs: hacking.html.in: fix table of contents
by Ján Tomko 11 Sep '12

11 Sep '12

Two sections didn't have a working link in the TOC. --- docs/hacking.html.in | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index eb79953..a97dc22 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -350,7 +350,7 @@ } </pre> - <h2><a href="types">Preprocessor</a></h2> + <h2><a name="preprocessor">Preprocessor</a></h2> <p> For variadic macros, stick with C99 syntax: @@ -368,7 +368,7 @@ #endif </pre> - <h2><a href="types">C types</a></h2> + <h2><a name="types">C types</a></h2> <p> Use the right type. -- 1.7.8.6

2 1

[libvirt] [libvirt-designer][PATCH 0/3] Cleanup
by Michal Privoznik 11 Sep '12

11 Sep '12

The first two patches are trivial, the third would require some review. Michal Privoznik (3): disk_add: Don't hardcode 'qemu' driver style: Use two blank lines between functions virtxml: Drop direct libvirt usage configure.ac | 24 +++++++++++++++++++-- examples/Makefile.am | 6 +++- examples/virtxml.c | 24 ++++++++-------------- libvirt-designer/libvirt-designer-domain.c | 30 +++++++++++++++++++++++++++- 4 files changed, 63 insertions(+), 21 deletions(-) -- 1.7.8.6

2 5

[libvirt] [PATCH 0/7 v4] Atomic API to list networks
by Osier Yang 11 Sep '12

11 Sep '12

v3 - v4: - Just rebase on top, and split the API from the big set Osier Yang (7): list: Define new API virConnectListAllNetworks list: Implement RPC calls for virConnectListAllNetworks list: Add helpers to list network objects list: Implement listAllNetworks for network driver list: Implement listAllNetworks for test driver list: Use virConnectListAllNetworks in virsh list: Expose virConnectListAllNetworks to Python binding daemon/remote.c | 55 +++++ include/libvirt/libvirt.h.in | 20 ++ python/generator.py | 1 + python/libvirt-override-api.xml | 6 + python/libvirt-override-virConnect.py | 12 ++ python/libvirt-override.c | 48 +++++ src/conf/network_conf.c | 91 +++++++++ src/conf/network_conf.h | 22 ++ src/driver.h | 5 + src/libvirt.c | 86 ++++++++- src/libvirt_private.syms | 1 + src/libvirt_public.syms | 1 + src/network/bridge_driver.c | 17 ++ src/remote/remote_driver.c | 64 ++++++ src/remote/remote_protocol.x | 13 ++- src/remote_protocol-structs | 12 ++ src/test/test_driver.c | 17 ++ tools/virsh-network.c | 352 ++++++++++++++++++++++++-------- tools/virsh.pod | 12 +- 19 files changed, 743 insertions(+), 92 deletions(-) -- 1.7.7.3

3 20

[libvirt] libvirt use of dnsmasq to provide dhcp-ipv6 service
by Gene Czarcinski 11 Sep '12

11 Sep '12

Since around the 2.61 dnsmasq supports providing dhcp-ipv6 services. Yes, I am aware that F17, F18, and rawhide all currently have dnsmasq 2.59 ... I am currently running dnsmasq-2.63. What are the plans for supporting dhcp-ipv6 from dnsmasq? I noticed that if you plug in a dhcp range specification under an ipv6 definition in the xml configuration file that virsh net-edit does not complain about it ... it just makes it disappear! Is the code there but not enabled because you need to support earlier versions of dnsmasq? If the code is there, what is the "magic switch" to turn it on? I understand that if I do that I may well be on my own. Gene

3 3