- Devel - libvirt List Archives

[libvirt] [PATCH 00/10 v2] Automatically shutdown VMs on session quit
by Daniel P. Berrange 30 Nov '12

30 Nov '12

A re-post of https://www.redhat.com/archives/libvir-list/2012-October/msg01768.html Changed in this version - Fixed only review bug mentioned last time - Rebased to current GIT

2 31

[libvirt] [PATCH 0/2] Clean up qemu driver configuration parser.
by Peter Krempa 30 Nov '12

30 Nov '12

Done while hacking on other series (that is not yet ready). Peter Krempa (2): qemu: Refactor config parameter retrieval qemu: Refactor error reporting in qemu driver configuration parser src/qemu/qemu_conf.c | 479 +++++++++++++++------------------------------------ 1 file changed, 142 insertions(+), 337 deletions(-) -- 1.8.0

2 6

[libvirt] [PATCHv3 0/3] network: resolve CVE 2012-3411
by Laine Stump 30 Nov '12

30 Nov '12

(This obsoletes the V2 patches I sent yesterday: https://www.redhat.com/archives/libvir-list/2012-November/msg01216.html ) This patch series resolves the libvirt part of CVE 2012-3411: https://bugzilla.redhat.com/show_bug.cgi?id=833033 Further details are in PATCH 3/3. The changes from V1 to V3: (resulting from Doug Goldstein's review, and a comment in the BZ record from the CVE reporter, David Woodhouse) 1) rework dnsmasqCapsRefresh() to create a new caps object if it's given a NULL object (function now gets dnsmasqCapsPtr* instead of dnsmasCapsPtr). This makes it possible to recover properly if dnsmasq is installed after libvirtd has already been started. 2) Add the following before each run of dnsmasq: virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); 3) Fixed a missing space after comma :-) 4) remove empty if () { } around initial call to dnsmasqCapsNewFromBinary() in bridge_driver.c 5) include FEC0::/10 as a "local" range when checking for private addresses to allow in the absence of an updated dnsmasq.

2 9

[libvirt] [PATCH 0/3] IPv6 enhancements; put dnsmasq parameters in conf-file
by Gene Czarcinski 29 Nov '12

29 Nov '12

These three patch files are packaged together because they serially depend on each other. These files have been rebased to "v3" of the dnsmasq capabilities and bind-dynamic patches. The DHCPv6 support checks dnsmasq's version and requires a minimum of 2.64. Also, using dnsmasq for providing the RA service is checked against the dnsmasq version and is currently 2.64. As with IPv4, IPv6 DHCP is only one subnetwork on an interface. Additionally, if other IPv6 addresses are defined, a warning message is issued since the Router Advertisement service will support only state-full (DHCP) or state-less (SLAAC) addressing on a network interface (not both). Thus, the additional subnetworks will need to be manually configured to properly function. If dnsmasq provides the RA service, it also points to itself as a RDNSS (Recursive DNS Server) as part of the information is supplies. If IPv6 DHCP is not being run, then SLAAC addressing is supported for any IPv6 addresses specified. Gene Czarcinski (3): v1: allow guest to guest IPv6 without gateway definition v8.1 add support for DHCPv6 v7.9: put dnsmasq parameters into conf-file docs/formatnetwork.html.in | 126 ++++- docs/schemas/network.rng | 12 +- src/conf/network_conf.c | 100 ++-- src/network/bridge_driver.c | 590 ++++++++++++++------- src/network/bridge_driver.h | 7 +- src/util/dnsmasq.c | 9 +- tests/networkxml2argvdata/dhcp6-nat-network.argv | 14 + tests/networkxml2argvdata/dhcp6-nat-network.xml | 24 + tests/networkxml2argvdata/dhcp6-network.argv | 14 + tests/networkxml2argvdata/dhcp6-network.xml | 14 + .../dhcp6host-routed-network.argv | 12 + .../dhcp6host-routed-network.xml | 19 + tests/networkxml2argvdata/isolated-network.argv | 25 +- .../networkxml2argvdata/nat-network-dns-hosts.argv | 14 +- .../nat-network-dns-srv-record-minimal.argv | 34 +- .../nat-network-dns-srv-record.argv | 24 +- .../nat-network-dns-txt-record.argv | 22 +- tests/networkxml2argvdata/nat-network.argv | 22 +- tests/networkxml2argvdata/netboot-network.argv | 28 +- .../networkxml2argvdata/netboot-proxy-network.argv | 26 +- tests/networkxml2argvdata/routed-network.argv | 11 +- tests/networkxml2argvtest.c | 47 +- 22 files changed, 838 insertions(+), 356 deletions(-) create mode 100644 tests/networkxml2argvdata/dhcp6-nat-network.argv create mode 100644 tests/networkxml2argvdata/dhcp6-nat-network.xml create mode 100644 tests/networkxml2argvdata/dhcp6-network.argv create mode 100644 tests/networkxml2argvdata/dhcp6-network.xml create mode 100644 tests/networkxml2argvdata/dhcp6host-routed-network.argv create mode 100644 tests/networkxml2argvdata/dhcp6host-routed-network.xml -- 1.7.11.7

1 3

[libvirt] [PATCH 0/6] More coverity issues
by Ján Tomko 29 Nov '12

29 Nov '12

REVERSE_INULL, SIZEOF_MISMATCH and some uninitialized variables. Ján Tomko (6): conf: fix NULL check in virNetDevBandwidthParse util: fix virBitmap allocation in virProcessInfoGetAffinity virsh: use correct sizeof when allocating cpumap virsh: do timing even for unusable connections rpc: don't destroy xdr before creating it in virNetMessageEncodeHeader conf: fix uninitialized variable in virDomainListSnapshots src/conf/netdev_bandwidth_conf.c | 4 +++- src/conf/snapshot_conf.c | 2 +- src/rpc/virnetmessage.c | 2 +- src/util/processinfo.c | 2 +- tools/virsh-domain.c | 4 ++-- tools/virsh.c | 12 ++++++------ 6 files changed, 14 insertions(+), 12 deletions(-) -- 1.7.8.6

2 13

[libvirt] libvirt-tck breackage
by Guido Günther 29 Nov '12

29 Nov '12

Hi, it seems a recent commit broke allmost all off the libvirt-tck tests: http://honk.sigxcpu.org:8001/job/libvirt-tck-debian-wheezy-qemu-session/196… I won't have a chance to have a closer look but but wanted to at least send a heads up. I'll have a closer look later this week. Cheers, -- Guido

2 3

[libvirt] Globally Reserve Resources for Host
by Dusty Mabe 29 Nov '12

29 Nov '12

Hi, I am interested in the capability to globally reserve resources(cpu and memory) for a KVM host. I know you can configure memory limits for each guest (http://libvirt.org/formatdomain.html#elementsMemoryTuning) but would like the ability to reserve host cpu and memory without having to actively do it by modifying each guests xml. For clarity, what I mean by "reserve resources" is that there are certain cpus and a certain amount of memory that guests will never have access to. This can be achieved using cgroups. Does anyone think this functionality would be useful? This is primarily to prevent the host from being starved when the allocation of guests have the host overcommitted/oversubscribed. Note: I think vmware has a similar functionality, but I am not sure as I don't really use vmware http://blogs.technet.com/b/virtualpfe/archive/2011/08/29/hyper-v-dynamic-me… Thanks for any thoughts, Dusty

3 6

[libvirt] [PATCH v2 0/4] Support for sending signals to guest processes
by Daniel P. Berrange 29 Nov '12

29 Nov '12

A follow up to https://www.redhat.com/archives/libvir-list/2012-November/msg01283.html Changed in this version - Switch pid to long long to allow process groups & 64-bit pids - Add explicit enum entries for RT signals - Do case insensitive parsing in virsh - Fix version numbers - Improve docs

2 10

[libvirt] [PATCH] network: fix crash when portgroup has no name
by Laine Stump 29 Nov '12

29 Nov '12

This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=879473 The name attribute is required for portgroup elements (yes, the RNG specifies that), and there is code in libvirt that assumes it is non-null. Unfortunately, the portgroup parsing function wasn't checking for lack of portgroup. One adverse result of this was that attempts to update a network by adding a portgroup with no name would cause libvirtd to segfault. For example: virsh net-update default add portgroup "<portgroup default='yes'/>" This patch causes virNetworkPortGroupParseXML to fail if no name is specified, thus avoiding any later problems. --- src/conf/network_conf.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 228951d..6ce2e63 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -1175,6 +1175,12 @@ virNetworkPortGroupParseXML(virPortGroupDefPtr def, /* grab raw data from XML */ def->name = virXPathString("string(./@name)", ctxt); + if (!def->name) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("Missing required name attribute in portgroup")); + goto error; + } + isDefault = virXPathString("string(./@default)", ctxt); def->isDefault = isDefault && STRCASEEQ(isDefault, "yes"); -- 1.7.11.7

2 3

[libvirt] [PATCH] qemu: Remove full stop from error messages
by Jiri Denemark 29 Nov '12

29 Nov '12

--- Pushed as trivial. src/qemu/qemu_agent.c | 2 +- src/qemu/qemu_monitor.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 7062d53..893f7f2 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -242,7 +242,7 @@ qemuAgentOpenUnix(const char *monitor, pid_t cpid, bool *inProgress) if (ret != 0) { virReportSystemError(errno, "%s", - _("monitor socket did not show up.")); + _("monitor socket did not show up")); goto error; } diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index fe8424f..aef5044 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -297,7 +297,7 @@ qemuMonitorOpenUnix(const char *monitor, pid_t cpid) if (ret != 0) { virReportSystemError(errno, "%s", - _("monitor socket did not show up.")); + _("monitor socket did not show up")); goto error; } -- 1.8.0

1 0