- Devel - libvirt List Archives

[libvirt] [PATCH v2 0/7] Introduce virCommandDoAsyncIO
by Michal Privoznik 29 Jan '13

29 Jan '13

Currently, if we want to use IO with asynchronous command we have to copy code from virFileWrapperFd to misuse our event loop for reading and writing to the command. However, we can extend our virCommand implementation to automatically set things up. All patches but the first has been ACKed already. diff to v1: -drop usleep(100) while waiting for the event loop to process our string IOs and do it ourselves instead. Michal Privoznik (7): virCommand: Introduce virCommandDoAsyncIO Introduce event loop to commandtest tests: Create test for virCommandDoAsyncIO virFileWrapperFd: Switch to new virCommandDoAsyncIO qemu: Catch stderr of image decompression binary qemu: Catch stderr of image compression binary qemu: Destroy domain on decompression binary error src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_migration.c | 9 +- src/util/vircommand.c | 279 ++++++++++++++++++++++++++++++++++++++++++-- src/util/vircommand.h | 1 + src/util/virfile.c | 82 +------------ tests/commanddata/test3.log | 2 +- tests/commandtest.c | 136 +++++++++++++++++++++ 8 files changed, 430 insertions(+), 89 deletions(-) -- 1.8.0.2

2 10

[libvirt] [Libvirt][QEMU][HLFS]How to test HLFS driver for Libvirt
by harryxiyou 29 Jan '13

29 Jan '13

Hi Morita and other developers, I have programed HLFS(HDFS based Log-structured FileSystem) driver for Libvirt according to Morita's patch(commit 036ad5052b43fe9f0d197e89fd16715950408e1d) for Libvirt, which my patch is not for Libvirt latest version but the version of Morita's patch time.I have called back my git tree to commit 036ad5052b43fe9f0d197e89fd16715950408e1d, then i develop this patch. My patch is now available at http://cloudxy.googlecode.com/svn/branches/hlfs/person/harry/hlfs/hlfs_driv… Therefore, i am not clear about how to test it. How could i know whether it works well for libvirt&QEMU? Could Morita (Or other developers) give me some suggestions? Thanks in advance ;-) -- Thanks Harry Wei

2 10

[libvirt] [PATCH] build: Regenerate man pages on version bump
by Jiri Denemark 29 Jan '13

29 Jan '13

Whenever libvirt version changes in configure.ac, we need to regenerate man pages so that they contain correct version info. --- daemon/Makefile.am | 2 +- tools/Makefile.am | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/daemon/Makefile.am b/daemon/Makefile.am index 72c6190..4d5c2fd 100644 --- a/daemon/Makefile.am +++ b/daemon/Makefile.am @@ -395,7 +395,7 @@ endif # WITH_LIBVIRTD POD2MAN = pod2man -c "Virtualization Support" \ -r "$(PACKAGE)-$(VERSION)" -s 8 -$(srcdir)/libvirtd.8.in: libvirtd.pod.in +$(srcdir)/libvirtd.8.in: libvirtd.pod.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name LIBVIRTD $< $@ \ && if grep 'POD ERROR' $@ ; then rm $@; exit 1; fi diff --git a/tools/Makefile.am b/tools/Makefile.am index 8a0429c..0010c39 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -61,7 +61,7 @@ virt-xml-validate: virt-xml-validate.in Makefile $(AM_V_GEN)sed -e 's|[@]schemadir@|$(pkgdatadir)/schemas|' < $< > $@ \ || (rm $@ && exit 1) && chmod +x $@ -virt-xml-validate.1: virt-xml-validate.in +virt-xml-validate.1: virt-xml-validate.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-XML-VALIDATE $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi @@ -70,12 +70,12 @@ virt-pki-validate: virt-pki-validate.in Makefile $(AM_V_GEN)sed -e 's|[@]sysconfdir@|$(sysconfdir)|' < $< > $@ \ || (rm $@ && exit 1) && chmod +x $@ -virt-pki-validate.1: virt-pki-validate.in +virt-pki-validate.1: virt-pki-validate.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-PKI-VALIDATE $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi -virt-host-validate.1: virt-host-validate.c +virt-host-validate.1: virt-host-validate.c $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-HOST-VALIDATE $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi @@ -85,7 +85,7 @@ virt-sanlock-cleanup: virt-sanlock-cleanup.in Makefile -e 's|[@]localstatedir@|$(localstatedir)|' < $< > $@ \ || (rm $@ && exit 1) && chmod +x $@ -virt-sanlock-cleanup.8: virt-sanlock-cleanup.in +virt-sanlock-cleanup.8: virt-sanlock-cleanup.in $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) --name VIRT-SANLOCK-CLEANUP $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi @@ -171,7 +171,7 @@ virsh_win_icon.$(OBJEXT): virsh_win_icon.rc --output-format coff --output $@ endif -virsh.1: virsh.pod +virsh.1: virsh.pod $(top_srcdir)/configure.ac $(AM_V_GEN)$(POD2MAN) $< $(srcdir)/$@ \ && if grep 'POD ERROR' $(srcdir)/$@ ; then \ rm $(srcdir)/$@; exit 1; fi -- 1.8.1.1

2 2

[libvirt] [PATCH 0/2] conf: fix some memory leaks
by Ján Tomko 29 Jan '13

29 Jan '13

Ján Tomko (2): conf: Fix cpumask leak in virDomainDefFree conf: Fix leaks in virNetworkObjUpdateParseFile src/conf/domain_conf.c | 2 +- src/conf/network_conf.c | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) -- 1.7.8.6

3 7

[libvirt] [libvirt-sandbox][PATCH] Don't redefine _FORTIFY_SOURCE macro
by Michal Privoznik 29 Jan '13

29 Jan '13

If the _FORTIFY_SOURCE has been already defined, we unconditionally redefine it, leaving us with warning/error thrown at compilation time. --- m4/virt-compile-warnings.m4 | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index cdcbad9..894ab59 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -84,8 +84,13 @@ AC_DEFUN([LIBVIRT_SANDBOX_COMPILE_WARNINGS],[ gl_WARN_ADD([-Wframe-larger-than=4096]) # Use improved glibc headers - AC_DEFINE([_FORTIFY_SOURCE], [2], - [enable compile-time and run-time bounds-checking, and some warnings]) + AH_VERBATIM([FORTIFY_SOURCE], + [/* Enable compile-time and run-time bounds-checking, and some warnings, + without upsetting newer glibc. */ + #if !defined _FORTIFY_SOURCE && defined __OPTIMIZE__ && __OPTIMIZE__ + # define _FORTIFY_SOURCE 2 + #endif + ]) # Extra special flags dnl -fstack-protector stuff passes gl_WARN_ADD with gcc -- 1.8.0.2

2 2

[libvirt] [PATCH] LXC: create directory /dev/shm automatically
by Gao feng 29 Jan '13

29 Jan '13

Now we mount /dev as tmpfs and haven't created directory /dev/shm,so the glibc api such as shm_open/sem_open will create files under dir /dev.(since /dev is mounted as tmpfs) Through these api still useable in container,but this cause directory /dev looks a little chaos. This patch create directory /dev/shm automatically,the files created by shm_open/sem_open will stay in this directroy. Signed-off-by: Gao feng <gaofeng(a)cn.fujitsu.com> --- src/lxc/lxc_container.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 497539c..5150564 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -586,6 +586,13 @@ static int lxcContainerMountBasicFS(bool pivotRoot, "devfs", "/dev", "tmpfs", opts); goto cleanup; } + + VIR_DEBUG("create directory /dev/shm for POSIX shared memory and named semphore"); + if (virFileMakePath("/dev/shm") < 0) { + virReportSystemError(errno, "%s", + _("Failed to mkdir /dev/shm")); + goto cleanup; + } } rc = 0; -- 1.7.11.7

3 8

[libvirt] Candidate Release 2 of libvirt-1.0.2
by Daniel Veillard 29 Jan '13

29 Jan '13

I have just tagged the rc2 in git and pushed the associated tarball and rpms for F17 to the FTP area: ftp://libvirt.org/libvirt/ Seems to work just fine for m limited testing, but please give it a try, and let's limit commits to only bug fixes until the release. I think I will push 1.0.2 final on Wednesday morning if everything is going fine until then, thanks for any testing and feedback ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

4 3

[libvirt] [PATCH v3 0/3] add pci-bridge support
by liguang 29 Jan '13

29 Jan '13

Now, it's impossible to arrange devices into multi-pci-bus, for example: <sound model='ac97'> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </sound> <video> <model type='cirrus' vram='9216' heads='1'/> <address type='pci' domain='0x0000' bus='0x1' slot='0x02' function='0x0'/> </video> libvirt will complain about "bus != 0", fortunately, qemu supports pci-to-pci bridge, if we want to use multi-pci-bus, we can define 2 pci bridge controllers, then attach 1 to the other as a subordinate pci-bus, so, 2 pci-buses appear. for example: <controller type='pci-bridge' index='0'/> <controller type='pci-bridge' index='1'> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </controller> <sound model='ac97'> <address type='pci' domain='0x0000' bus='0x01' slot='0x02' function='0x0'/> </sound> <video> <model type='cirrus' vram='9216' heads='1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> src/conf/domain_conf.c | 5 ++++- src/conf/domain_conf.h | 1 + docs/schemas/domaincommon.rng | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 70 ++++++++++++++++++++----- 6 files changed, 57 insertions(+), 23 deletions(-)

4 11

[libvirt] ANNOUNCE: libvirt 0.9.6.4 maintenance release
by Cole Robinson 29 Jan '13

29 Jan '13

libvirt 0.9.6.4 maintenance release is now available. This is libvirt 0.9.6 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.6.4.tar.gz Changes in this version: * rpc: Fix crash on error paths of message dispatching * qemu: Clear async job when p2p migration fails early For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 0.9.11.9 maintenance release
by Cole Robinson 29 Jan '13

29 Jan '13

libvirt 0.9.11.9 maintenance release is now available. This is libvirt 0.9.11 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.11.9.tar.gz Changes in this version: * Fix race condition when destroying guests * rpc: Fix crash on error paths of message dispatching * util: fix botched check for new netlink request filters * util: add missing error log messages when failing to get netlink VFINFO * util: fix functions that retrieve SRIOV VF info * network: prevent dnsmasq from listening on localhost For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0