- Devel - libvirt List Archives

[libvirt] [PATCH] Escaping leading '.' in cgroup names
by Daniel P. Berrange 13 May '13

13 May '13

From: "Daniel P. Berrange" <berrange(a)redhat.com> Escaping a leading '.' with '_' in the cgroup names Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/util/vircgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 473d2fc..4de1d55 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -1106,7 +1106,8 @@ static int virCgroupPartitionNeedsEscaping(const char *path) if (STRPREFIX(path, "cgroup.")) return 1; - if (path[0] == '_') + if (path[0] == '_' || + path[0] == '.') return 1; if (!(fp = fopen("/proc/cgroups", "r"))) -- 1.8.1.4

2 1

[libvirt] [PATCH] security_apparmor.c: Include virscsi.h
by Michal Privoznik 13 May '13

13 May '13

After introducing AppArmorSetSecuritySCSILabel() in 2691cd5f we are using virSCSIDevicePtr type without proper include. --- Pushed as build breaker. src/security/security_apparmor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 50d7983..3680279 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -49,6 +49,7 @@ #include "vircommand.h" #include "virlog.h" #include "virstring.h" +#include "virscsi.h" #define VIR_FROM_THIS VIR_FROM_SECURITY #define SECURITY_APPARMOR_VOID_DOI "0" -- 1.8.2.1

1 0

[libvirt] wrong warning flags for clang
by Roman Bogorodskiy 13 May '13

13 May '13

Appears that configure doesn't properly detect the case when clang is used instead of gcc: CC=clang ./configure runs fine, but produces a long list of warning flags that clang doesn't support: configure: Warning Flags: -W -Waddress -Wall -Warray-bounds -Wattributes -Wbad-function-cast ... trimmed ... At some point, compilation fails: CC libvirt_util_la-viralloc.lo clang: error: unknown warning option '-Wclobbered' [-Werror,-Wunknown-warning-option] clang: error: unknown warning option '-Wcoverage-mismatch'; did you mean '-Wpointer-type-mismatch'? [-Werror,-Wunknown-warning-option] and many other similar errors. Any idea what would be a proper fix for that? Roman Bogorodskiy

2 1

[libvirt] [libvirt PATCH] node_device: Clean up unused macros
by Osier Yang 13 May '13

13 May '13

All of these macros are not used anymore, remove them. --- src/node_device/node_device_driver.h | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/node_device/node_device_driver.h b/src/node_device/node_device_driver.h index 2dff70f..0f62c83 100644 --- a/src/node_device/node_device_driver.h +++ b/src/node_device/node_device_driver.h @@ -28,15 +28,6 @@ # include "driver.h" # include "node_device_conf.h" -# define LINUX_SYSFS_SCSI_HOST_PREFIX "/sys/class/scsi_host/" -# define LINUX_SYSFS_SCSI_HOST_POSTFIX "device" -# define LINUX_SYSFS_FC_HOST_PREFIX "/sys/class/fc_host/" - -# define VPORT_CREATE 0 -# define VPORT_DELETE 1 -# define LINUX_SYSFS_VPORT_CREATE_POSTFIX "/vport_create" -# define LINUX_SYSFS_VPORT_DELETE_POSTFIX "/vport_delete" - # define LINUX_NEW_DEVICE_WAIT_TIME 60 # ifdef WITH_HAL -- 1.8.1.4

2 2

[libvirt] [PATCH v3] domain: add 'pre-startup' signal and do nodedevs checking
by Guannan Ren 13 May '13

13 May '13

This patch introduces 'pre-start' signal and registers nodedev checking handler to check duplicate USB devices. If virt-manager can not identify unique usb device any more before domain startup, it will throw a tip error to tell it is time to reattach host USB devices to get updated bus/addr info. --- virtManager/domain.py | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/virtManager/domain.py b/virtManager/domain.py index 791f2af..89c226b 100644 --- a/virtManager/domain.py +++ b/virtManager/domain.py @@ -149,6 +149,7 @@ class vmmDomain(vmmLibvirtObject): "status-changed": (GObject.SignalFlags.RUN_FIRST, None, [int, int]), "resources-sampled": (GObject.SignalFlags.RUN_FIRST, None, []), "inspection-changed": (GObject.SignalFlags.RUN_FIRST, None, []), + "pre-startup": (GObject.SignalFlags.RUN_FIRST, None, [object]), } def __init__(self, conn, backend, uuid): @@ -252,7 +253,34 @@ class vmmDomain(vmmLibvirtObject): self.connect("status-changed", self._update_start_vcpus) self.connect("config-changed", self._reparse_xml) + self.connect("pre-startup", self._prestartup_nodedev_check) + def _prestartup_nodedev_check(self, src, ret): + ignore = src + error = _("These is more than one '%s' device attached to " + "your host, and we can't determine which one to " + "use for your guest.\n" + "To fix this, remove and reattach the USB device " + "to your guest using the 'Add Hardware' wizard.") + + for hostdev in self.get_hostdev_devices(): + devtype = hostdev.type + + if devtype != "usb": + continue + + vendor = hostdev.vendor + product = hostdev.product + bus = hostdev.bus + device = hostdev.device + + if vendor and product: + count = self.conn.get_nodedevs_number("usb_device", + vendor, + product) + if count > 1 and not (bus and device): + prettyname = "%s %s" % (vendor, product) + ret.append(error % prettyname) ########################### # Misc API getter methods # @@ -1171,6 +1199,13 @@ class vmmDomain(vmmLibvirtObject): if self.get_cloning(): raise RuntimeError(_("Cannot start guest while cloning " "operation in progress")) + + pre_startup_ret = [] + self.emit("pre-startup", pre_startup_ret) + + for error in pre_startup_ret: + raise RuntimeError(error) + self._backend.create() self.idle_add(self.force_update_status) -- 1.8.1.4

1 1

[libvirt] [libvirt-glib 0/3] small cleanups
by Christophe Fergeau 13 May '13

13 May '13

The 3 patches fix various small warnings when building, and a misnamed function call in some examples. Christophe

2 4

[libvirt] Another pass. virt-sandbox-service create --mount suport
by dwalsh＠redhat.com 13 May '13

13 May '13

[sandbox PATCH] Add support for virt-sandbox-service to add

2 2

[libvirt] [PATCH v2 0/8] Add user namespace support for libvirt lxc
by Gao feng 13 May '13

13 May '13

This patchset try to add userns support for libvirt lxc. Since userns is nearly completed in linux-3.9, the old kernel doesn't support userns, I add some New XML elements to let people decide if enable userns.The userns is enabled only when user configure the XML. The format of user namespace related XML file like below: <idmap> <uid start='0' target='1000' count='10'> <gid start='0' target='1000' count='10'> </idmap> it means the user in container (which uid:gid is 0:0) will be mapped to the user in host (uid:gid is 1000:1000), count is used to form an u/gid range: The users in container which uid in [start, start + count -1] will be mapped. You can have multiple lines to map differnet id ranges, caution, you must make sure the root user of container has been mapped. This patchset also does the below jobs. 1, Because the uninit userns has no right to create devices, we should create devices for container on host. 2, Changes the owner of fuse and tty device. Gao feng (8): LXC: Introduce New XML element for user namespace LXC: enable user namespace when user set the uidmap LXC: sort the uidmap/gidmap of domain LXC: introduce virLXCControllerSetupUserns and lxcContainerSetUserns LXC: Creating devices for container on host side LXC: change the owner of devices created on host LXC: change the owner of tty devices to the root user of container LXC: fuse: Change files owner to the root user of container docs/formatdomain.html.in | 23 +++++ docs/schemas/domaincommon.rng | 28 ++++++ src/conf/domain_conf.c | 111 +++++++++++++++++++++ src/conf/domain_conf.h | 19 ++++ src/lxc/lxc_container.c | 120 +++++++++++------------ src/lxc/lxc_controller.c | 218 +++++++++++++++++++++++++++++++++++++++++- src/lxc/lxc_fuse.c | 6 ++ 7 files changed, 455 insertions(+), 70 deletions(-) -- 1.8.1.4

3 17

[libvirt] [PATCH] build: fix use of mmap
by Eric Blake 11 May '13

11 May '13

Commit bfe7721d introduced a regression, but only on platforms like FreeBSD that lack posix_fallocate and where mmap serves as a nice fallback for safezero. util/virfile.c: In function 'safezero': util/virfile.c:837: error: 'PROT_READ' undeclared (first use in this function) * src/util/virutil.c (includes): Move use of <sys/mman.h>... * src/util/virfile.c (includes): ...to the file that uses mmap. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule. src/util/virfile.c | 3 +++ src/util/virutil.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 1491f27..a59d67d 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -39,6 +39,9 @@ # include <mntent.h> #endif #include <stdlib.h> +#if HAVE_MMAP +# include <sys/mman.h> +#endif #if defined(__linux__) && HAVE_DECL_LO_FLAGS_AUTOCLEAR # include <linux/loop.h> diff --git a/src/util/virutil.c b/src/util/virutil.c index 43814df..3c0a481 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -36,9 +36,6 @@ #include <sys/stat.h> #include <sys/types.h> #include <sys/ioctl.h> -#if HAVE_MMAP -# include <sys/mman.h> -#endif #include <string.h> #include <termios.h> #include <locale.h> -- 1.8.1.4

1 0

[libvirt] [PATCH] build: update to latest gnulib, for syntax-check
by Eric Blake 11 May '13

11 May '13

This picks up a fix for a syntax-check weakness mentioned here: https://www.redhat.com/archives/libvir-list/2013-May/msg00811.html * .gnulib: Update to latest, for maint.mk improvement. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the trivial rule. * .gnulib 0f8ddbf...a363f4e (3): > maint.mk: catch more abuse of HAVE_DECL in syntax-check > deps: require Automake >= 1.9.6 in generated Makefile fragments > autoupdate .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 0f8ddbf..a363f4e 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 0f8ddbf1a13a93a4584afdd82f0f87e498a0db6f +Subproject commit a363f4ed4a0e69187c97686ac44502c49c7f4b3d -- 1.8.1.4

1 0