- Devel - libvirt List Archives

Re: [libvirt] [Users] Live Migration failed oVirt 3.3 Nightly
by Dan Kenigsberg 16 Sep '13

16 Sep '13

On Sun, Sep 15, 2013 at 09:57:47PM +1000, Andrew Lau wrote: > On Sun, Sep 15, 2013 at 9:34 PM, Dan Kenigsberg <danken(a)redhat.com> wrote: > > > On Sun, Sep 15, 2013 at 08:44:18PM +1000, Andrew Lau wrote: > > > On Sun, Sep 15, 2013 at 8:00 PM, Dan Kenigsberg <danken(a)redhat.com> > > wrote: > > > > > > > On Sun, Sep 15, 2013 at 06:48:41PM +1000, Andrew Lau wrote: > > > > > Hi Dan, > > > > > > > > > > Certainly, I've uploaded them to fedora's paste bin and tried to snip > > > > just > > > > > the relevant details. > > > > > > > > > > Sender (hv01.melb.domain.net) > > > > > http://paste.fedoraproject.org/39660/92339651/ > > > > > > > > This one has > > > > > > > > libvirtError: operation failed: Failed to connect to remote libvirt > > > > URI qemu+tls://hv02.melb.domain.net/system > > > > > > > > which is most often related to firewall issues, and some time to key > > > > mismatch. > > > > > > > > Does > > > > virsh -c qemu+tls://hv02.melb.domain.net/system capabilities > > > > work when run from the command line of hv01? > > > > > > > > Dan. > > > > > Receiver (hv02.melb.domain.net) ` > > > > > http://paste.fedoraproject.org/39661/23406913/ > > > > > > > > > > VM being transfered is ovirt_guest_vm > > > > > > > > > > Thanks, > > > > > Andrew > > > > > > > > > > virsh -c qemu+tls://hv02.melb.domain.net/system > > > 2013-09-15 10:41:10.620+0000: 23994: info : libvirt version: 0.10.2, > > > package: 18.el6_4.9 (CentOS BuildSystem <http://bugs.centos.org>, > > > 2013-07-02-11:19:29, c6b8.bsys.dev.centos.org) > > > 2013-09-15 10:41:10.620+0000: 23994: warning : > > > virNetTLSContextCheckCertificate:1102 : Certificate check failed > > > Certificate failed validation: The certificate hasn't got a known issuer. > > > > Would you share your > > > > > > openssl x509 -in > > /etc/pki/vdsm/certs/cacert.pem -text > > > > openssl x509 -in /etc/pki/vdsm/certs/vdsmcert.pem -text > > > > on both hosts? This content may be sensitive, and may not > > provide an answer why libvirt on src cannot contact libvirtd on the > > other host. So before you do that, would you test if > > > > > > vdsClient -s hv02.melb.domain.net getVdsCapabilities > > > > works when run on hv01? It may be that the certificates are fine, but > > libvirt is not configured to use the correct ones. > > > > Dan. > > > > > vdsClient -s hv02.melb.domain.net getVdsCapabilities runs fine > > I did a quick comparison between the files on both hosts, they seem to have > the right details (host names, authority etc.) > cacert.pem matches > > /etc/libvirt/libvirtd.conf > > ca_file="/etc/pki/vdsm/certs/cacert.pem" > cert_file="/etc/pki/vdsm/certs/vdsmcert.pem" > key_file="/etc/pki/vdsm/keys/vdsmkey.pem" Maybe someone on libvir-list could guess why this could be happening?

3 4

[libvirt] [PATCH] virsh: move command maxvcpus from domain group to host group.
by yangdongsheng 16 Sep '13

16 Sep '13

Since the maxvcpus command query the maximum number of virtual CPUs supported for a guest VM on this connection, it should be in virsh-host.c but not virsh-domain.c. Signed-off-by: yangdongsheng <yangds.fnst(a)cn.fujitsu.com> --- tools/virsh-domain.c | 44 -------------------------------------------- tools/virsh-host.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 44 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 4f85f5f..50a57ee 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5172,44 +5172,6 @@ cmdDomjobabort(vshControl *ctl, const vshCmd *cmd) } /* - * "maxvcpus" command - */ -static const vshCmdInfo info_maxvcpus[] = { - {.name = "help", - .data = N_("connection vcpu maximum") - }, - {.name = "desc", - .data = N_("Show maximum number of virtual CPUs for guests on this connection.") - }, - {.name = NULL} -}; - -static const vshCmdOptDef opts_maxvcpus[] = { - {.name = "type", - .type = VSH_OT_STRING, - .help = N_("domain type") - }, - {.name = NULL} -}; - -static bool -cmdMaxvcpus(vshControl *ctl, const vshCmd *cmd) -{ - const char *type = NULL; - int vcpus; - - if (vshCommandOptStringReq(ctl, cmd, "type", &type) < 0) - return false; - - if ((vcpus = virConnectGetMaxVcpus(ctl->conn, type)) < 0) - return false; - - vshPrint(ctl, "%d\n", vcpus); - - return true; -} - -/* * "vcpucount" command */ static const vshCmdInfo info_vcpucount[] = { @@ -10637,12 +10599,6 @@ const vshCmdDef domManagementCmds[] = { .info = info_managedsaveremove, .flags = 0 }, - {.name = "maxvcpus", - .handler = cmdMaxvcpus, - .opts = opts_maxvcpus, - .info = info_maxvcpus, - .flags = 0 - }, {.name = "memtune", .handler = cmdMemtune, .opts = opts_memtune, diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 880ae4b..f69ab79 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -193,6 +193,44 @@ cleanup: } /* + * "maxvcpus" command + */ +static const vshCmdInfo info_maxvcpus[] = { + {.name = "help", + .data = N_("connection vcpu maximum") + }, + {.name = "desc", + .data = N_("Show maximum number of virtual CPUs for guests on this connection.") + }, + {.name = NULL} +}; + +static const vshCmdOptDef opts_maxvcpus[] = { + {.name = "type", + .type = VSH_OT_STRING, + .help = N_("domain type") + }, + {.name = NULL} +}; + +static bool +cmdMaxvcpus(vshControl *ctl, const vshCmd *cmd) +{ + const char *type = NULL; + int vcpus; + + if (vshCommandOptStringReq(ctl, cmd, "type", &type) < 0) + return false; + + if ((vcpus = virConnectGetMaxVcpus(ctl->conn, type)) < 0) + return false; + + vshPrint(ctl, "%d\n", vcpus); + + return true; +} + +/* * "nodeinfo" command */ static const vshCmdInfo info_nodeinfo[] = { @@ -863,6 +901,12 @@ const vshCmdDef hostAndHypervisorCmds[] = { .info = info_hostname, .flags = 0 }, + {.name = "maxvcpus", + .handler = cmdMaxvcpus, + .opts = opts_maxvcpus, + .info = info_maxvcpus, + .flags = 0 + }, {.name = "node-memory-tune", .handler = cmdNodeMemoryTune, .opts = opts_node_memory_tune, -- 1.7.10.1

4 3

[libvirt] [PATCH RESEND 0/4] Pre-create storage on live migration
by Michal Privoznik 16 Sep '13

16 Sep '13

[Resending due to some list difficulties] Currently users are required to pre-create storage on their own upon migration. This patch set implements the feature for RAW, QCOW and QCOW2 images. While for the RAW fallocate() is used (so we are guaranteed subsequent write() won't fail with ENOSPC, for the latter two we have no other option than using qemu-img, which uses ftruncate(). On the other hand, this is not such big deal. If the spare runs out as a domain is migrating, the migration is aborted, and pre-created storage unlink()-ed. There's no difference to what will happen if user will pre-create storage by hand. https://bugzilla.redhat.com/show_bug.cgi?id=927252 Michal Privoznik (4): qemu: Expose file opening functions qemu_domain: Introduce qemuDomainGetDiskBlockInfo qemu_migration: Check size prerequisites qemu_migration: Unlink pre-created storage on error src/qemu/qemu_domain.c | 299 ++++++++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_domain.h | 16 +++ src/qemu/qemu_driver.c | 276 ++--------------------------------------- src/qemu/qemu_migration.c | 304 +++++++++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_process.c | 8 ++ 5 files changed, 627 insertions(+), 276 deletions(-) -- 1.8.1.5

2 7

[libvirt] [PATCH] Explicitly link libvirt_net_rpc against SELINUX_LIBS
by Guido Günther 14 Sep '13

14 Sep '13

Since virnetsocket conditionally uses selinux we need to link against it otherwise the build fails with: CCLD libvirtd /usr/bin/ld: ../src/.libs/libvirt-lxc.so: undefined reference to symbol 'freecon' /lib/i386-linux-gnu/libselinux.so.1: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status make[3]: *** [libvirtd] Error 1 --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 711da32..1a74435 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2226,6 +2226,7 @@ libvirt_net_rpc_la_LDFLAGS = \ $(GNUTLS_LIBS) \ $(SASL_LIBS) \ $(SSH2_LIBS)\ + $(SELINUX_LIBS) \ $(AM_LDFLAGS) \ $(CYGWIN_EXTRA_LDFLAGS) \ $(MINGW_EXTRA_LDFLAGS) -- 1.8.4.rc3

2 2

[libvirt] Non-deterministic mail delivery problems
by Daniel P. Berrange 14 Sep '13

14 Sep '13

FYI, we are aware that there are mail delivery problems with this list, that started sometime yesterday. The symptom is mails appearing in the list archive fine, but never making it into your INBOX. We have a ticket open for someone to investigate & resolve this problem. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 2

[libvirt] [PATCH] tools: fix a judgment of equalling zero about an array's length
by lawrancejing 14 Sep '13

14 Sep '13

There is no need to go on executing code when the array's length is zero. --- tools/virsh-snapshot.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index e37a5b3..d7a4c7b 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -239,7 +239,7 @@ vshParseSnapshotMemspec(vshControl *ctl, virBufferPtr buf, const char *str) return 0; narray = vshStringToArray(str, &array); - if (narray < 0) + if (narray <= 0) goto cleanup; for (i = 0; i < narray; i++) { -- 1.7.1

2 1

[libvirt] [v0.9.12-maint v3 00/12] Debian's 0.9.12 patches
by Guido Günther 13 Sep '13

13 Sep '13

These are the patches Debian is currently carrying on 0.9.12. Most are straight cherry-picks. Since we're maintaining 0.9.12 for our current stable release I'm happy to push these to v0.9.12-maint. The only change over v2 is the adjuste commit message. Daniel P. Berrange (2): Don't ignore return value of qemuProcessKill Fix race condition when destroying guests Eric Blake (1): build: fix virnetlink on glibc 2.11 Jiri Denemark (3): daemon: Fix crash in virTypedParameterArrayClear Revert "rpc: Discard non-blocking calls only when necessary" qemu: Add support for -no-user-config Luca Tettamanti (1): storage: Need to also VIR_FREE(reg) Martin Kletzander (1): security: Fix libvirtd crash possibility Peter Krempa (4): qemu: Fix off-by-one error while unescaping monitor strings rpc: Fix crash on error paths of message dispatching conf: Remove callback from stream when freeing entries in console hash conf: Remove console stream callback only when freeing console helper cfg.mk | 3 +- daemon/remote.c | 16 +- src/conf/virconsole.c | 13 ++ src/qemu/qemu_capabilities.c | 7 +- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 11 +- src/qemu/qemu_driver.c | 21 ++- src/qemu/qemu_monitor.c | 11 +- src/rpc/virnetclient.c | 21 +-- src/rpc/virnetserverclient.c | 3 + src/rpc/virnetserverprogram.c | 11 +- src/storage/storage_backend_logical.c | 5 +- src/util/virnetlink.h | 2 + tests/qemuhelpdata/qemu-1.1 | 268 ++++++++++++++++++++++++++++++++++ tests/qemuhelpdata/qemu-1.1-device | 160 ++++++++++++++++++++ tests/qemuhelptest.c | 75 ++++++++++ 16 files changed, 586 insertions(+), 42 deletions(-) create mode 100644 tests/qemuhelpdata/qemu-1.1 create mode 100644 tests/qemuhelpdata/qemu-1.1-device -- 1.8.4.rc3

2 14

[libvirt] [PATCH] docs: mention hostname subtlety
by Eric Blake 13 Sep '13

13 Sep '13

An off-list bug report mentioned some confusion where the public documentation of libvirt.c:virConnectGetHostname did not match the private documentation of util/virutil.c:virGetHostname. * src/libvirt.c (virConnectGetHostname): Tweak docs. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- src/libvirt.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 20a2d4c..a6fcab0 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1701,9 +1701,10 @@ error: * virConnectGetHostname: * @conn: pointer to a hypervisor connection * - * This returns the system hostname on which the hypervisor is - * running (the result of the gethostname system call). If - * we are connected to a remote system, then this returns the + * This returns a system hostname on which the hypervisor is + * running (based on the result of the gethostname system call, but + * possibly expanded to a fully-qualified domain name via getaddrinfo). + * If we are connected to a remote system, then this returns the * hostname of the remote system. * * Returns the hostname which must be freed by the caller, or -- 1.8.3.1

2 2

[libvirt] [PATCH] tools: add missing 'interface' type and update man page
by Alex Jia 13 Sep '13

13 Sep '13

Signed-off-by: Alex Jia <ajia(a)redhat.com> --- tools/virt-xml-validate.in | 19 +++++++++++++++++++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/tools/virt-xml-validate.in b/tools/virt-xml-validate.in index 6bfa68f..8be9595 100644 --- a/tools/virt-xml-validate.in +++ b/tools/virt-xml-validate.in @@ -83,6 +83,9 @@ if [ -z "$TYPE" ]; then *secret*) TYPE="secret" ;; + *interface*) + TYPE="interface" + ;; *) echo "$0: cannot determine schema type for $XMLFILE" >&2 exit 3 @@ -124,6 +127,10 @@ Valid schema names currently include =over 4 +=item C<domainsnapshot> + +The schema for the XML format used by domain snapshot configuration + =item C<domain> The schema for the XML format used by guest domains configuration @@ -148,6 +155,18 @@ The schema for the XML format used by node device descriptions The schema for the XML format used to declare driver capabilities +=item C<nwfilter> + +The schema for the XML format used by network traffic filters + +=item C<secret> + +The schema for the XML format used by secrets descriptions + +=item C<interface> + +The schema for the XML format used by virtual interface + =back =head1 OPTIONS -- 1.7.1

2 1

[libvirt] [PATCH 0/2] tests: Fix virsh-uriprecedence when ran as root
by Martin Kletzander 13 Sep '13

13 Sep '13

Basically v2 of http://www.redhat.com/archives/libvir-list/2013-September/msg00689.html Martin Kletzander (2): test-lib: Make case skipping possible tests: Don't test user config file if ran as root tests/test-lib.sh | 18 ++++++++++++++++++ tests/virsh-uriprecedence | 6 +++++- 2 files changed, 23 insertions(+), 1 deletion(-) -- 1.8.3.2

4 8