- Devel - libvirt List Archives

[libvirt] libvirt-glib fails to compile with CLANG compiler
by Jason Helfman 02 Oct '13

02 Oct '13

When compiling libvirt-glib with CLANG, I get the following error. 16 warnings generated. CCLD libvirt-glib-1.0.la GEN LibvirtGLib-1.0.gir /usr/local/lib/libvirt.so: undefined reference to `__stack_chk_fail_local' clang: error: linker command failed with exit code 1 (use -v to see invocation) linking of temporary binary failed: Command '['/usr/local/bin/libtool', '--mode=link', '--tag=CC', '--silent', 'clang', '-o', '/usr/home/helfman/workspace/ports/devel/libvirt-glib/work/libvirt-glib-0.1.7/libvirt-glib/tmp-introspectOO6vqG/LibvirtGLib-1.0', '-export-dynamic', '-O2', '-pipe', '-fno-strict-aliasing', '-L/usr/local/lib', '-fstack-protector', '/usr/home/helfman/workspace/ports/devel/libvirt-glib/work/libvirt-glib-0.1.7/libvirt-glib/tmp-introspectOO6vqG/LibvirtGLib-1.0.o', '-L.', './libvirt-glib-1.0.la', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-lgthread-2.0', '-pthread', '-L/usr/local/lib', '-lglib-2.0', '-lintl']' returned non-zero exit status 1 gmake[2]: *** [LibvirtGLib-1.0.gir] Error 1 gmake[2]: Leaving directory `/usr/home/helfman/workspace/ports/devel/libvirt-glib/work/libvirt-glib-0.1.7/libvirt-glib' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/usr/home/helfman/workspace/ports/devel/libvirt-glib/work/libvirt-glib-0.1.7' gmake: *** [all] Error 2 *** [do-build] Error code 1 -jgh -- Jason Helfman | FreeBSD Committer jgh(a)FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve

3 7

[libvirt] ANNOUNCE: libvirt 0.9.12.2 maintenance release
by Guido Günther 02 Oct '13

02 Oct '13

libvirt 0.9.12.2 maintenance release is now available. This is libvirt 0.9.12 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.12.2.tar.gz md5sum: 8d5fdc4517a83ba9d99fd47fa70f7ed1 libvirt-0.9.12.2.tar.gz sha1: 8c49123c673231f1f0ed665156c88dd7c109be30 libvirt-0.9.12.2.tar.gz sha256: 32b48c7e56048f670ffe980abc9d60710e7811e361a162b0ac31ec57719ac577 libvirt-0.9.12.2.tar.gz Changes in this release: Prepare for 0.9.12.2 (Guido Günther) Distribute viratomic.h (Guido Günther) Fix crash in remoteDispatchDomainMemoryStats (CVE-2013-4296) (Daniel P. Berrange) Add support for using 3-arg pkcheck syntax for process (CVE-2013-4311) (Daniel P. Berrange) Include process start time when doing polkit checks (Daniel P. Berrange) Move virProcess{Kill, Abort, TranslateStatus} into virprocess.{c, h} (Daniel P. Berrange) Move virProcessKill into virprocess.{h, c} (Daniel P. Berrange) Rename virCommandTranslateStatus to virProcessTranslateStatus (Daniel P. Berrange) Rename virPid{Abort, Wait} to virProcess{Abort, Wait} (Daniel P. Berrange) Rename virKillProcess to virProcessKill (Daniel P. Berrange) Introduce APIs for splitting/joining strings (Daniel P. Berrange) For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Cheers, -- Guido

1 0

[libvirt] [v0.9.12-maint] Distribute viratomic.h
by Guido Günther 02 Oct '13

02 Oct '13

Sicne cbcb1983afbd76f0503185e4183afa10af88af47 we need viratmic.h in the distributed tarball as well. This fixes "make distcheck". --- src/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Makefile.am b/src/Makefile.am index 6656fa0..88b6160 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -52,6 +52,7 @@ augeastest_DATA = # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ + util/viratomic.h \ util/bitmap.c util/bitmap.h \ util/buf.c util/buf.h \ util/command.c util/command.h \ -- 1.8.4.rc3

3 4

[libvirt] [PATCH] qemu: cgroup: Fix crash if starting nographics guest
by Cole Robinson 02 Oct '13

02 Oct '13

We can dereference graphics[0] even if guest has no graphics device configured. I screwed this up in a216e6487255d3b65d97c7ec1fa5da63dbced902 --- src/qemu/qemu_cgroup.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index f95c7f2..ace7e35 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -490,9 +490,10 @@ qemuSetupDevicesCgroup(virQEMUDriverPtr driver, if (vm->def->nsounds && ((!vm->def->ngraphics && cfg->nogfxAllowHostAudio) || - ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && + (vm->def->graphics && + ((vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && cfg->vncAllowHostAudio) || - (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)))) { + (vm->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL))))) { rv = virCgroupAllowDeviceMajor(priv->cgroup, 'c', DEVICE_SND_MAJOR, VIR_CGROUP_DEVICE_RW); virDomainAuditCgroupMajor(vm, priv->cgroup, "allow", DEVICE_SND_MAJOR, -- 1.8.3.1

2 2

[libvirt] [PATCH] qemu_hotplug: Allow QoS update in qemuDomainChangeNet
by Michal Privoznik 01 Oct '13

01 Oct '13

The qemuDomainChangeNet() is called when 'virsh update-device' is invoked on a NIC. Currently, we fail to update the QoS even though we have routines for that. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_hotplug.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index f06930e..41b942f 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2062,8 +2062,6 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(olddev) || !virNetDevVPortProfileEqual(virDomainNetGetActualVirtPortProfile(olddev), virDomainNetGetActualVirtPortProfile(newdev)) || - !virNetDevBandwidthEqual(virDomainNetGetActualBandwidth(olddev), - virDomainNetGetActualBandwidth(newdev)) || !virNetDevVlanEqual(virDomainNetGetActualVlan(olddev), virDomainNetGetActualVlan(newdev))) { needReconnect = true; @@ -2081,6 +2079,18 @@ qemuDomainChangeNet(virQEMUDriverPtr driver, goto cleanup; } + if (!virNetDevBandwidthEqual(virDomainNetGetActualBandwidth(olddev), + virDomainNetGetActualBandwidth(newdev))) { + if (virNetDevBandwidthSet(newdev->ifname, + virDomainNetGetActualBandwidth(newdev), + false) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot set bandwidth limits on %s"), + newdev->ifname); + goto cleanup; + } + needReplaceDevDef = true; + } if (needBridgeChange) { if (qemuDomainChangeNetBridge(dom->conn, vm, olddev, newdev) < 0) goto cleanup; -- 1.8.1.5

2 1

[libvirt] ANNOUNCE: libvirt 0.9.12.1 maintenance release
by Guido Günther 01 Oct '13

01 Oct '13

libvirt 0.9.12.1 maintenance release is now available. This is libvirt 0.9.12 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-0.9.12.1.tar.gz Checksums: md5sum: 65fb37b247281bcdd027f51e6d7d3847 sha1: 2710e415bed06043a75ebbf0a7de773ce0748250 sha256: e5d0055c8bde84620f65bfe6968acc39a1015ab17b735b951e982d67909f5484 Changes in this version: Prepare 0.9.12.1 (Guido Günther) Fix TLS tests with gnutls 3 (Daniel P. Berrange) build: avoid confusing make with raw name 'undefine' (Eric Blake) virsh: Fix POD syntax (Jiri Denemark) build: more workarounds for if_bridge.h (Eric Blake) build: allow building with newer glibc-headers and -O0 (Eric Blake) Fix race condition when destroying guests (Daniel P. Berrange) Don't ignore return value of qemuProcessKill (Daniel P. Berrange) conf: Remove console stream callback only when freeing console helper (Peter Krempa) conf: Remove callback from stream when freeing entries in console hash (Peter Krempa) storage: Need to also VIR_FREE(reg) (Luca Tettamanti) qemu: Add support for -no-user-config (Jiri Denemark) rpc: Fix crash on error paths of message dispatching (Peter Krempa) qemu: Fix off-by-one error while unescaping monitor strings (Peter Krempa) Revert "rpc: Discard non-blocking calls only when necessary" (Jiri Denemark) build: fix virnetlink on glibc 2.11 (Eric Blake) security: Fix libvirtd crash possibility (Martin Kletzander) daemon: Fix crash in virTypedParameterArrayClear (Jiri Denemark) For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Cheers, -- Guido

1 0

[libvirt] [PATCH] selinux: Only close the selabel_handle once
by Ján Tomko 01 Oct '13

01 Oct '13

On selinux driver initialization failure (missing/incorrectly formated contexts file), selabel_handle was closed twice. Introduced by 6159710. --- src/security/security_selinux.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 38de060..c408fa8 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -460,6 +460,7 @@ virSecuritySELinuxLXCInitialize(virSecurityManagerPtr mgr) error: # if HAVE_SELINUX_LABEL_H selabel_close(data->label_handle); + data->label_handle = NULL; # endif virConfFree(selinux_conf); VIR_FREE(data->domain_context); @@ -547,6 +548,7 @@ virSecuritySELinuxQEMUInitialize(virSecurityManagerPtr mgr) error: #if HAVE_SELINUX_LABEL_H selabel_close(data->label_handle); + data->label_handle = NULL; #endif VIR_FREE(data->domain_context); VIR_FREE(data->alt_domain_context); @@ -808,7 +810,8 @@ virSecuritySELinuxSecurityDriverClose(virSecurityManagerPtr mgr) return 0; #if HAVE_SELINUX_LABEL_H - selabel_close(data->label_handle); + if (data->label_handle) + selabel_close(data->label_handle); #endif virHashFree(data->mcs); -- 1.8.1.5

2 2

[libvirt] [PATCH] Fix handling of IPv6 listen addresses in cmdDomDisplay
by Ján Tomko 01 Oct '13

01 Oct '13

Use virSocketAddrIsWildcard instead of STREQ to check for the ANY address and put brackets around the address if it contains ':'. --- tools/virsh-domain.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index fa012d1..42c9920 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9043,6 +9043,7 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) int flags = 0; bool params = false; const char *xpath_fmt = "string(/domain/devices/graphics[@type='%s']/@%s)"; + virSocketAddr addr; if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) return false; @@ -9126,8 +9127,12 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, ":%s@", passwd); /* Then host name or IP */ - if (!listen_addr || STREQ((const char *)listen_addr, "0.0.0.0")) + if (!listen_addr || + (virSocketAddrParse(&addr, listen_addr, AF_UNSPEC) > 0 && + virSocketAddrIsWildcard(&addr))) virBufferAddLit(&buf, "localhost"); + else if (strchr(listen_addr, ':')) + virBufferAsprintf(&buf, "[%s]", listen_addr); else virBufferAsprintf(&buf, "%s", listen_addr); -- 1.8.1.5

2 2

[libvirt] [PATCH] LXC: Detect fs support. Mount only supported fs in containers
by Bogdan Purcareata 01 Oct '13

01 Oct '13

Some filesystems - specifically securityfs - are not supported in all systems running libvirt containers. When starting a container, mount only the filesystems that are supported on the host. Detection of filesystem support is done at runtime. Signed-off-by: Bogdan Purcareata <bogdan.purcareata(a)freescale.com> --- src/lxc/lxc_container.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index c60f5d8..eff9a24 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -509,6 +509,61 @@ static int lxcContainerChildMountSort(const void *a, const void *b) # define MS_SLAVE (1<<19) #endif +/* + * This function attempts to detect kernel support + * for a specific filesystem type. This is done by + * inspecting /proc/filesystems. + */ +static int lxcCheckFSSupport(const char *fs_type) +{ + FILE *fp = NULL; + int ret = -1; + const char *fslist = "/proc/filesystems"; + char *line = NULL; + const char *type; + + if (!fs_type) + return 1; + + VIR_DEBUG("Checking kernel support for %s", fs_type); + + VIR_DEBUG("Open %s", fslist); + if (!(fp = fopen(fslist, "r"))) { + if (errno == ENOENT) + + virReportSystemError(errno, + _("Unable to read %s"), + fslist); + goto cleanup; + } + + while (!feof(fp)) { + size_t n; + VIR_FREE(line); + if (getline(&line, &n, fp) <= 0) { + if (feof(fp)) + break; + + goto cleanup; + } + + type = strstr(line, fs_type); + if (type) { + ret = 1; + goto cleanup; + } + } + + VIR_DEBUG("No kernel support for %s", fs_type); + + ret = 0; + +cleanup: + VIR_FREE(line); + VIR_FORCE_FCLOSE(fp); + return ret; +} + static int lxcContainerGetSubtree(const char *prefix, char ***mountsret, size_t *nmountsret) @@ -855,17 +910,23 @@ static int lxcContainerMountBasicFS(bool userns_enabled) for (i = 0; i < ARRAY_CARDINALITY(lxcBasicMounts); i++) { virLXCBasicMountInfo const *mnt = &lxcBasicMounts[i]; const char *srcpath = NULL; + const char *dstpath = NULL; VIR_DEBUG("Processing %s -> %s", mnt->src, mnt->dst); srcpath = mnt->src; + dstpath = mnt->dst; /* Skip if mount doesn't exist in source */ if ((srcpath[0] == '/') && (access(srcpath, R_OK) < 0)) continue; + if ((access(dstpath, R_OK) < 0) || /* mount is not present on host */ + (!lxcCheckFSSupport(mnt->type))) /* no fs support in kernel */ + continue; + #if WITH_SELINUX if (STREQ(mnt->src, SELINUX_MOUNT) && (!is_selinux_enabled() || userns_enabled)) -- 1.7.11.7

3 2

[libvirt] networking restart after redefinition
by Mihamina Rakotomandimby 01 Oct '13

01 Oct '13

Hi all, Running Fedora 18 and the bundled libvirt and virt-tools. Desktop use. As I like to access my guests with a hostname and not a numerical IP address, I fix the IP addressing in the network configuration: http://pastebin.com/rfMKn40j Unfortunately, I cant find a way to add a host without loosing the whole networking, as when I add a ahost, I destroy and redefine the network. Restarting libvirtd is not the solution. How would you recommend to have networking UP after network redefinition? -- RMA.

2 2