- Devel - libvirt List Archives

[Libvir] Release of libvirt-0.1.7
by Daniel Veillard 29 Sep '06

29 Sep '06

Is available on ftp://libvirt.org/libvirt/ It's 0.1.6 with the fixes for the 2 bugs that Daniel Berrange fixed yesterday: - failure of domain info when using the hypervisor on 32 bits with 3.0.3 - the memory corrption which can happen when reading vCPU info from xend Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

Re: [Libvir] Proposal for virtual devices described in XML
by michel.ponceau＠bull.net 28 Sep '06

28 Sep '06

When specified at device creation, vifname is put in XenStore directory /local/domain/0/backend/vif/<domID>/<vif_number>. All vifnames used in a domain are returned by Get "/xend/domain/<domID>?detail=1" and converted into XML "target" by virDomainGetXMLDesc. For convenience, we could force the vifname, either at domain creation or in Attach, and ignore any "target" in "interface", except for Detach. The vifname value could be the sequence number of network device creation in domain (for Xen, it would be equal to vif number). Veuillez répondre à "Daniel P. Berrange" <berrange(a)redhat.com> Pour : michel.ponceau(a)bull.net cc : libvir-list(a)redhat.com Objet : Re: [Libvir] Proposal for virtual devices described in XML On Wed, Sep 27, 2006 at 05:21:33PM +0200, michel.ponceau(a)bull.net wrote: > After comments from Daniel P. Berrange and from Bull people, my proposal > is reduced to following 2 functions: > > /* Create a virtual device attachment to backend */ > int virDomainAttachDevice(virDomainPtr domain, char *xml); This is definitely a good way forward - it lets us re-use the existing code for parsing device descriptions very easily. > /* Destroy a virtual device attachment to backend */ > int virDomainDetachDevice(virDomainPtr domain, char *xml); > /* @domain: pointer to domain object > * @xml: pointer to XML description of one device > * Returns 0 in case of success, -1 in case of failure. */ I was wondering whether we need to have the full XML block passed in for detaching devices. Perhaps it is sufficient to just pass i nthe target name of the device. Then again, some implementations may prefer to have the full XML blob available to allow greater sanity checking when detaching, so its probably worth while. > The XML would be in same form as the part of domain description for a > single device, either <disk.../disk> or <interface.../interface>. Very nice. > The device is identified by its target name. This attribute is optional > for "interface" in domain description, but would become mandatory in > Attach/Detach description. It is not yet processed in Libvirt-0.1.6 source > xml.c (function virDomainParseXMLIfDesc). I have successfully tried the attached patch, which tranlates "target" > into Xen "vifname". (It processes "ip" attribute in same way, but my try > failed, maybe because address value was invalid for Xen). I'm not sure I like the idea of having to explicitly set a vif name for every guest NIC we define - principally because there's no straightforward way for a user of this API to determine what VIF names are already in use, vs free. It also seems XenD does not tell us what the vifname for running domains are - although I think the info is in xenstore somewhere. I can see why we need the vifname to detach the device though. If we can find a way to fill in the vifname when dumping the XML, then this would let a caller uniquely identify an existing device, without us requireing that vifnames are used when creating a domain/attaching a new device (& thus let Xen still auto-allocate them) Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 1

[Libvir] Proposal for virtual devices described in XML
by michel.ponceau＠bull.net 28 Sep '06

28 Sep '06

My try of "ip" attribute failed because of a bug in patch. With this corrected file, it works as well as "target". Pour : libvir-list(a)redhat.com cc : Objet : Proposal for virtual devices described in XML After comments from Daniel P. Berrange and from Bull people, my proposal is reduced to following 2 functions: /* Create a virtual device attachment to backend */ int virDomainAttachDevice(virDomainPtr domain, char *xml); /* Destroy a virtual device attachment to backend */ int virDomainDetachDevice(virDomainPtr domain, char *xml); /* @domain: pointer to domain object * @xml: pointer to XML description of one device * Returns 0 in case of success, -1 in case of failure. */ The XML would be in same form as the part of domain description for a single device, either <disk.../disk> or <interface.../interface>. The device is identified by its target name. This attribute is optional for "interface" in domain description, but would become mandatory in Attach/Detach description. It is not yet processed in Libvirt-0.1.6 source xml.c (function virDomainParseXMLIfDesc). I have successfully tried the attached patch, which tranlates "target" into Xen "vifname". (It processes "ip" attribute in same way, but my try failed, maybe because address value was invalid for Xen).

1 0

[Libvir] virDomainDestroy not synchronous?
by Lon Hohberger 28 Sep '06

28 Sep '06

i686 libvirt-0.1.5-3 xen-3.0.2-33 Code: domain_desc = virDomainGetXMLDesc(vdp, 0); response = virDomainDestroy(vdp); if (response == 0 && domain_desc) { /* sleep(3); */ virDomainCreateLinux(vp, domain_desc, 0); free(domain_desc); } If I add the 'sleep()', the domain dies and virDomainCreateLinux() fails with the following error: libvir: Xen Daemon error : POST operation failed: No such domain futon1 Failed to get devices for domain futon1 That really doesn't bother me, and it's likely my fault anyway (it's not a fully configured domain; it's a dom-U sitting in the anaconda install screen). Of course, it's moot if we get a guaranteed synchronous reboot flag for virDomainReboot()... hint hint ;) What bothers me is that if I *don't* put the sleep in, the domain never actually gets destroyed. In this particular case, the domain is still sitting at the anaconda install screen; all I have to do is reconnect using xm console. If I only do a virDomainDestroy(), the domain gets destroyed. So, it looks like like the virDomainCreateLinux() cancels the destroy request before it can be completed. This makes it look like that the destroy request is not synchronous, and/or the result of the operation is not guaranteed (only that the request was made). Is it supposed to work this way, or is this a bug/problem? -- Lon

4 7

[Libvir] Proposal for virtual devices described in XML
by michel.ponceau＠bull.net 27 Sep '06

27 Sep '06

After comments from Daniel P. Berrange and from Bull people, my proposal is reduced to following 2 functions: /* Create a virtual device attachment to backend */ int virDomainAttachDevice(virDomainPtr domain, char *xml); /* Destroy a virtual device attachment to backend */ int virDomainDetachDevice(virDomainPtr domain, char *xml); /* @domain: pointer to domain object * @xml: pointer to XML description of one device * Returns 0 in case of success, -1 in case of failure. */ The XML would be in same form as the part of domain description for a single device, either <disk.../disk> or <interface.../interface>. The device is identified by its target name. This attribute is optional for "interface" in domain description, but would become mandatory in Attach/Detach description. It is not yet processed in Libvirt-0.1.6 source xml.c (function virDomainParseXMLIfDesc). I have successfully tried the attached patch, which tranlates "target" into Xen "vifname". (It processes "ip" attribute in same way, but my try failed, maybe because address value was invalid for Xen).

2 1

[Libvir] Flag to virDomainReboot to immediately reboot a domain?
by Lon Hohberger 22 Sep '06

22 Sep '06

Hi, For fencing Xen domains, I would like the ability to guarantee an immediate reboot of a domain without notifying the OS inside. Basically, I would like something equivalent to pressing the reset button on a physical machine. There's a currently unused "flags" option to virDomainReboot which would allow such an addition without breaking the ABI. Doing getXMLDesc/Destroy/Create introduces a race condition in clusters: What if outside management software notices notices the VM is missing and decides to start it up on *another* host node before we bring up the VM again using the Create call? An immediate reboot should eliminate the race (even though it's a very small window), and probably will not add any complexity. For now, 'reboot' is done as above, and 'off' is a simple Destroy call. 'On' is not possible to implement for various reasons, the most obvious of which is that the caller does not know any of the configuration information about particular domUs (except for their names). -- Lon

1 0

[Libvir] Release of libvirt-0.1.6
by Daniel Veillard 22 Sep '06

22 Sep '06

Available at ftp://libvirt.org/libvirt/ Mostly a few bug fixes, preparing the upcoming xen-3.0.3, and localization support were added in the last 2 weeks: * Support for localization of strings using gettext (Daniel Berrange) * Support for new Xen-3.0.3 cdrom and disk configuration (Daniel Berrange) * Support for setting VNC port when creating domains with new xend config files (Daniel Berrange) * Fix bug when running against xen-3.0.2 hypercalls (Jim Fehlig) * Fix reconnection problem when talking directly to http xend thanks to everybody who helped testing, improving and fixing it ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard(a)redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/

1 0

[Libvir] gettext i18n support for libvirt
by Daniel P. Berrange 21 Sep '06

21 Sep '06

Attached is an updated version of my previous patch to add gettext support to libvirt. It should be pretty self-explanatory - basically wrapping all strings with _(..) or gettext_noop(...) where appropriate. I also took the opportunity to make some of the messages more consistent with each other. (To cut down size, I'm not including the actual libvirt.pot file ) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

2 5

[Libvir] problem with virConnectClose in libvirt 0.1.5
by Philippe Berthault 21 Sep '06

21 Sep '06

After closing libvirt with virConnectClose, it's possible to open libvirt again in the same program with virConnectOpen but following operations on domains systematically fail. In example: conn = virConnectOpen(NULL); dom = virDomainLookupByID(conn, id); virDomainFree(dom); virConnectClose(conn); ... conn = virConnectOpen(NULL); dom = virDomainLookupByID(conn, id); ==> ERROR The second virDomainLookupByID call fails because of the do_connect() function in xend_internal.c source file. In this function, the connect() API returns ENOENT on the second virDomainLookupByID() call. ENOENT return code isn't documented in the man of connect API ! I suppose that some cleaning are missing when virConnectClose is called or in the opposite, too cleaning is done. Regards.

2 2

[Libvir] New style CDROM config in Xen 3.0.3
by Daniel P. Berrange 14 Sep '06

14 Sep '06

So in a recent change to xen-unstable.hg the way CDROM devices are configured for HVM guests changed. They are now treated as regular IDE devices, and a CDROM is signified by presence of ':cdrom' suffix on the device name http://lists.xensource.com/archives/html/xen-devel/2006-08/msg00369.html libvirt obviously needs to support both this new style config, and the old (<= 3.0.2) style configs. Thus I requested addition of 'xend_config_format' attribute in the /xend/node SEXPR data from XenD. Christian recently committed this patch, so we can now support both CDROM style configs in libvirt. I am attaching a patch to implement this support - basically it touches xend_internal.c to fix XML->SEXPR conversion, and xml.c to fix SEXPR->XML conversion. Then this is corresponding additions to the unit tests to validate the new code, and also validate that I didn't break existing code. I am attaching the patches, but I don't intend to commit them to libvirt just yet because I don't actually have the new 3.0.3 xend running on my test systems fully yet. If anyone is using 3.0.3 any testing would be appreciated, otherwise I aim to test this towards end of next week. Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|

1 2