- Devel - libvirt List Archives

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3
by liushuyu＠aosc.io 01 Nov '19

01 Nov '19

From: liushuyu <liushuyu011(a)gmail.com> --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else: missing.add(el) - print "missing: %s, implemented: %s" % (len(missing), len(implemented)) - print "missing:" + print("missing: %s, implemented: %s" % (len(missing), len(implemented))) + print("missing:") for x in missing: - print x.attrib + print(x.attrib) #print "implemented:" #for x in implemented: # print x.attrib -- 2.23.0

1 0

[libvirt] [PATCH Rust] api_tests.py: update to use Python 3
by liushuyu＠aosc.io 01 Nov '19

01 Nov '19

From: liushuyu <liushuyu011(a)gmail.com> --- tools/api_tests.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/api_tests.py b/tools/api_tests.py index b26ec34..9e66c92 100644 --- a/tools/api_tests.py +++ b/tools/api_tests.py @@ -47,10 +47,10 @@ def main(): else: missing.add(el) - print "missing: %s, implemented: %s" % (len(missing), len(implemented)) - print "missing:" + print("missing: %s, implemented: %s" % (len(missing), len(implemented))) + print("missing:") for x in missing: - print x.attrib + print(x.attrib) #print "implemented:" #for x in implemented: # print x.attrib -- 2.23.0

1 0

[libvirt] Entering freeze for libvirt 5.9.0
by Daniel Veillard 01 Nov '19

01 Nov '19

We are getting close to the end of the month, a lot of developers are at KVM Forum in Lyon, so starting the release process now looks a good idea. I have tagged the RC1 in git and pushed signed tarball and source rpm to the usual place: https://libvirt.org/sources/ Seems to work in my limited testing, the Ci is almost all green https://ci.centos.org/view/libvirt/ so things looks good in my perspective. Please give it a try, I will try to push RC2 on Wednesday, and based on feedback roll the release on Friday or during the week-end, thanks in advance, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 6

[libvirt] [PULL 0/9] Ide patches
by John Snow 01 Nov '19

01 Nov '19

The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c: hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- John Snow (1): IDE: deprecate ide-drive Sam Eiderman (8): block: Refactor macros - fix tabbing block: Support providing LCHS from user bootdevice: Add interface to gather LCHS scsi: Propagate unrealize() callback to scsi-hd bootdevice: Gather LCHS from all relevant devices bootdevice: Refactor get_boot_devices_list bootdevice: FW_CFG interface for LCHS values hd-geo-test: Add tests for lchs override qemu-deprecated.texi | 5 + include/hw/block/block.h | 22 +- include/hw/scsi/scsi.h | 1 + include/sysemu/sysemu.h | 4 + bootdevice.c | 147 +++++++-- hw/block/virtio-blk.c | 6 + hw/ide/qdev.c | 10 +- hw/nvram/fw_cfg.c | 14 +- hw/scsi/scsi-bus.c | 16 + hw/scsi/scsi-disk.c | 12 + tests/hd-geo-test.c | 551 ++++++++++++++++++++++++++++++++++ tests/Makefile.include | 2 +- tests/qemu-iotests/051.pc.out | 6 +- 13 files changed, 753 insertions(+), 43 deletions(-) -- 2.21.0

6 16

[libvirt] [PATCH 0/2] Doc fix and news entry for Xen ACPI support
by Jim Fehlig 31 Oct '19

31 Oct '19

I was jetlagged and not thinking clearly when I pushed Marek's patches that add support for specifying ACPI firmware path in the libxl driver. I pushed them outside of my usual dev setup hence misssed Reviewed-by: tags and forgot to update the docs with s/5.8.0/5.9.0/. There's nothing I can do about the former, but the latter can be fixed with trivial patch 1. Patch 2 adds a news entry. Jim Fehlig (2): docs: Fix version that introduced Xen support for ACPI firmware news: Add entry for ACPI firmware support in Xen docs/formatdomain.html.in | 2 +- docs/news.xml | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.23.0

2 3

[libvirt] [PULL v2 0/9] Ide patches
by John Snow 31 Oct '19

31 Oct '19

The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17: Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000) are available in the Git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull-request for you to fetch changes up to dc237c45aee52f268369dc6a485c623f1232e1d3: hd-geo-test: Add tests for lchs override (2019-10-31 11:47:43 -0400) ---------------------------------------------------------------- Pull request ---------------------------------------------------------------- John Snow (1): IDE: deprecate ide-drive Sam Eiderman (8): block: Refactor macros - fix tabbing block: Support providing LCHS from user bootdevice: Add interface to gather LCHS scsi: Propagate unrealize() callback to scsi-hd bootdevice: Gather LCHS from all relevant devices bootdevice: Refactor get_boot_devices_list bootdevice: FW_CFG interface for LCHS values hd-geo-test: Add tests for lchs override qemu-deprecated.texi | 5 + include/hw/block/block.h | 22 +- include/hw/scsi/scsi.h | 1 + include/sysemu/sysemu.h | 4 + bootdevice.c | 147 +++++++-- hw/block/virtio-blk.c | 6 + hw/ide/qdev.c | 10 +- hw/nvram/fw_cfg.c | 14 +- hw/scsi/scsi-bus.c | 16 + hw/scsi/scsi-disk.c | 12 + tests/hd-geo-test.c | 551 ++++++++++++++++++++++++++++++++++ tests/Makefile.include | 2 +- tests/qemu-iotests/051.pc.out | 6 +- 13 files changed, 753 insertions(+), 43 deletions(-) -- 2.21.0

3 11

[libvirt] [PATCH v2] storage: improve the while loop virStorageBackendFileSystemIsMounted
by Yi Li 30 Oct '19

30 Oct '19

Move virStorageBackendFileSystemGetPoolSource outside of the while loop Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_backend_fs.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 02b8248..92516c8 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -258,10 +258,10 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) goto cleanup; } - while ((getmntent_r(mtab, &ent, buf, sizeof(buf))) != NULL) { - if (!(src = virStorageBackendFileSystemGetPoolSource(pool))) - goto cleanup; + if ((src = virStorageBackendFileSystemGetPoolSource(pool)) == NULL) + goto cleanup; + while ((getmntent_r(mtab, &ent, buf, sizeof(buf))) != NULL) { /* compare both mount destinations and sources to be sure the mounted * FS pool is really the one we're looking for */ @@ -274,12 +274,13 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) goto cleanup; } - VIR_FREE(src); } ret = 0; cleanup: + if (src) + VIR_FREE(src); VIR_FORCE_FCLOSE(mtab); return ret; } -- 2.7.5

1 0

[libvirt] [PATCH] storage: improve the while loop virStorageBackendFileSystemIsMounted
by Yi Li 30 Oct '19

30 Oct '19

Move virStorageBackendFileSystemGetPoolSource outside of the while loop Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_backend_fs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 02b8248..10d9457 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -258,10 +258,10 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) goto cleanup; } - while ((getmntent_r(mtab, &ent, buf, sizeof(buf))) != NULL) { - if (!(src = virStorageBackendFileSystemGetPoolSource(pool))) - goto cleanup; + if ((src = virStorageBackendFileSystemGetPoolSource(pool)) == NULL) + goto cleanup; + while ((getmntent_r(mtab, &ent, buf, sizeof(buf))) != NULL) { /* compare both mount destinations and sources to be sure the mounted * FS pool is really the one we're looking for */ -- 2.7.5

1 0

[libvirt] the test-file
by Leo Hou 29 Oct '19

29 Oct '19

hello，everyone： If I want to add a new CPU model ,the test-file x86_64-cpuid-*-host.xml , x86_64-cpuid-*-guest.xml ,x86_64-cpuid-*-json.xml and x86_64-cpuid-*.sig how to generate in the /tests/cputestdata/ ? ________________________________ Leo-Hou(a)hotmail.com

2 2

[libvirt] [PATCH v3 REBASE 00/12] hostdev: handle usb detach/attach on node
by Nikolay Shirokovskiy 29 Oct '19

29 Oct '19

Diff to v2[1] version: - add 'replug' attribute for hostdev element to allow replug semantics - avoid accuiring domain lock in event loop thread on udev events as suggested by Peter - nit picks after review by Daniel Henrique Barboza * is used to mark patches that were 'Reviewed-by' by Daniel (sometimes with very minor changes to take into account new replug flag). [1] https://www.redhat.com/archives/libvir-list/2019-September/msg00321.html Nikolay Shirokovskiy (12): conf: add replug option for usb hostdev qemu: track hostdev delete intention qemu: support host usb device unplug qemu: support usb hostdev plugging back qemu: handle host usb device add/del udev events qemu: handle libvirtd restart after host usb device unplug qemu: handle race on device deletion and usb host device plugging qemu: hotplug: update device list on device deleted event qemu: handle host usb device plug/unplug when libvirtd is down qemu: don't mess with non mandatory hostdevs on reattaching qemu: handle detaching of unplugged hostdev conf: parse hostdev missing flag docs/formatdomain.html.in | 10 +- docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 62 +++ src/conf/domain_conf.h | 17 + src/qemu/Makefile.inc.am | 2 + src/qemu/qemu_conf.h | 3 + src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 404 +++++++++++++++++- src/qemu/qemu_hotplug.c | 104 ++++- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_process.c | 60 +++ src/util/virhostdev.c | 2 + tests/qemuhotplugtest.c | 2 +- tests/qemuxml2argvdata/hostdev-usb-replug.xml | 36 ++ .../qemuxml2xmloutdata/hostdev-usb-replug.xml | 40 ++ tests/qemuxml2xmltest.c | 1 + 17 files changed, 733 insertions(+), 22 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-usb-replug.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-usb-replug.xml -- 2.23.0

2 16