- Devel - libvirt List Archives

[libvirt] [PATCH 0/8] Coverity related patches
by John Ferlan 11 Nov '19

11 Nov '19

Some related to "new-ish" changes that have caused Coverity to discover new issues and some from older changes from a pile of 50 or so that are not essentially "false positives". John Ferlan (8): vbox: Fix possible NULL deref conf: Remove ATTRIBUTE_NONNULL for virDomainQemuMonitorEventNew tests: Fix memory leak in mymain lxc: Remove unnecessary comment tests: Remove _NULLABLE in virNetDevExists mock qemu: Fix possible NULL deref in qemuDomainSaveImageStartVM tests: Add return value check in checkUserInfo tests: Fix logic to not have possible NULL deref src/conf/domain_event.c | 6 +++++- src/conf/domain_event.h | 2 +- src/lxc/lxc_container.c | 5 ----- src/qemu/qemu_driver.c | 2 +- src/vbox/vbox_common.c | 4 ++-- tests/qemuagenttest.c | 4 +++- tests/qemuhotplugtest.c | 3 +-- tests/qemuxml2argvmock.c | 2 +- tests/virbitmaptest.c | 6 ++++-- 9 files changed, 18 insertions(+), 16 deletions(-) -- 2.20.1

3 10

[libvirt] [PATCH] util: Fix segmentation fault when seclabel fails to allocate memory
by jcfaracco＠gmail.com 11 Nov '19

11 Nov '19

From: Julio Faracco <jcfaracco(a)gmail.com> In function virSecurityDeviceLabelDefNew(), when libvirt fails to allocate seclabel structure it returns a failure. This case is setting seclabel as a NULL pointer and accessing its attribute below. This commit fixes this wrong logic. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/util/virseclabel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virseclabel.c b/src/util/virseclabel.c index a2b5ebf6b7..2141d84210 100644 --- a/src/util/virseclabel.c +++ b/src/util/virseclabel.c @@ -77,7 +77,7 @@ virSecurityDeviceLabelDefNew(const char *model) if (VIR_ALLOC(seclabel) < 0) { virSecurityDeviceLabelDefFree(seclabel); - seclabel = NULL; + return NULL; } seclabel->model = g_strdup(model); -- 2.20.1

2 1

[libvirt] [dockerfiles PATCH 0/3] Refresh after recent changes
by Andrea Bolognani 11 Nov '19

11 Nov '19

Pushed under the Dockerfiles refresh rules. As usual, patches as sent to the list don't apply and are to be considered informational only. Andrea Bolognani (3): Drop Fedora 29 Add Fedora 31 Refresh afted adding python3-docutils for libvirt buildenv-libosinfo-fedora-29.zip | Bin 544 -> 0 bytes buildenv-libosinfo-fedora-31.zip | Bin 0 -> 544 bytes buildenv-libvirt-centos-7.zip | Bin 759 -> 765 bytes buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 1010 -> 1016 bytes buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 1003 -> 1009 bytes buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 1008 -> 1013 bytes buildenv-libvirt-debian-10-cross-i686.zip | Bin 1001 -> 1008 bytes buildenv-libvirt-debian-10-cross-mips.zip | Bin 997 -> 1003 bytes buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 1011 -> 1017 bytes buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 1001 -> 1007 bytes buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 1012 -> 1019 bytes buildenv-libvirt-debian-10-cross-s390x.zip | Bin 1000 -> 1006 bytes buildenv-libvirt-debian-10.zip | Bin 898 -> 904 bytes buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 1042 -> 1048 bytes buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 1033 -> 1039 bytes buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 1039 -> 1045 bytes buildenv-libvirt-debian-9-cross-mips.zip | Bin 1033 -> 1039 bytes buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 1041 -> 1051 bytes buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 1036 -> 1043 bytes buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 1045 -> 1053 bytes buildenv-libvirt-debian-9-cross-s390x.zip | Bin 1034 -> 1040 bytes buildenv-libvirt-debian-9.zip | Bin 927 -> 934 bytes buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 1010 -> 1015 bytes buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 1003 -> 1009 bytes buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 1008 -> 1013 bytes buildenv-libvirt-debian-sid-cross-i686.zip | Bin 1001 -> 1008 bytes buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1000 -> 1006 bytes ...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 1014 -> 1017 bytes buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 1005 -> 1011 bytes buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 1012 -> 1018 bytes buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 1000 -> 1006 bytes buildenv-libvirt-debian-sid.zip | Bin 898 -> 904 bytes buildenv-libvirt-fedora-29.zip | Bin 768 -> 0 bytes buildenv-libvirt-fedora-30.zip | Bin 891 -> 897 bytes buildenv-libvirt-fedora-31.zip | Bin 0 -> 776 bytes buildenv-libvirt-fedora-rawhide.zip | Bin 788 -> 796 bytes buildenv-libvirt-ubuntu-16.zip | Bin 933 -> 939 bytes buildenv-libvirt-ubuntu-18.zip | Bin 935 -> 941 bytes 38 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 buildenv-libosinfo-fedora-29.zip create mode 100644 buildenv-libosinfo-fedora-31.zip delete mode 100644 buildenv-libvirt-fedora-29.zip create mode 100644 buildenv-libvirt-fedora-31.zip -- 2.21.0

1 3

[libvirt] [PATCH] spec: fix rpm build with VPATH
by Pavel Hrdina 11 Nov '19

11 Nov '19

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 723ced3535..eb8b2df055 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1532,7 +1532,7 @@ exit 0 %files docs %doc AUTHORS ChangeLog NEWS README README.md -%doc libvirt-docs/* +%doc %{_vpath_builddir}/libvirt-docs/* %files daemon @@ -1892,7 +1892,7 @@ exit 0 %config(noreplace) %{_sysconfdir}/sysconfig/libvirt-guests %attr(0755, root, root) %{_libexecdir}/libvirt-guests.sh -%files libs -f %{name}.lang +%files libs -f %{_vpath_builddir}/%{name}.lang %license COPYING COPYING.LESSER %config(noreplace) %{_sysconfdir}/libvirt/libvirt.conf %config(noreplace) %{_sysconfdir}/libvirt/libvirt-admin.conf -- 2.23.0

2 1

[libvirt] [PATCH] src: lxc: Fix typo in a Makefile variable
by Michal Privoznik 10 Nov '19

10 Nov '19

In commit 0985a9597bb0348d46c0d18dc548a676bf0ad8e2 we stopped distributing generated source file. This is done by prepending binary_SOURCES variable with "nodist_". However, there is a typo - the prefix is "nodst_" instead of "nodist_". Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/lxc/Makefile.inc.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index d3a7cbf93b..6aaec09fb4 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -127,7 +127,7 @@ augeastest_DATA += lxc/test_virtlxcd.aug CLEANFILES += lxc/virtlxcd.aug virtlxcd_SOURCES = $(REMOTE_DAEMON_SOURCES) -nodst_virtlxcd_SOURCES = $(REMOTE_DAEMON_GENERATED) +nodist_virtlxcd_SOURCES = $(REMOTE_DAEMON_GENERATED) virtlxcd_CFLAGS = \ $(REMOTE_DAEMON_CFLAGS) \ -DDAEMON_NAME="\"virtlxcd\"" \ -- 2.23.0

1 0

[libvirt] [PATCH 0/5] Update news for versions from 5.7 to 5.8
by Han Han 10 Nov '19

10 Nov '19

Han Han (5): news: Support for kvm dedicated performance hint in 5.7 news: Support unmanaged macvtap devices in 5.8 news: Support to run SLIRP networking in a separate process in 5.8 news: Support vhost-user-gpu in 5.8 news: Introduce virConnectSetIdentity API in 5.8 docs/news.xml | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) -- 2.24.0.rc1

4 10

[libvirt] [PATCH] src: add missing include access path for bhyve and vz drivers
by Pavel Hrdina 08 Nov '19

08 Nov '19

Commit <b98f90cf913965243c6e2c49a52aa170a48093ef> forgot to update bhyve and vz Makefile files as well. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under build-breaker rule. src/bhyve/Makefile.inc.am | 1 + src/vz/Makefile.inc.am | 1 + 2 files changed, 2 insertions(+) diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index de9fbe9239..1fc100d5ab 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -42,6 +42,7 @@ libvirt_driver_bhyve_la_LDFLAGS = $(AM_LDFLAGS_MOD_NOUNDEF) libvirt_driver_bhyve_impl_la_CFLAGS = \ -I$(srcdir)/access \ + -I$(builddir)/access \ -I$(srcdir)/conf \ $(AM_CFLAGS) \ $(NULL) diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index 1757c8ba10..acada11148 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -29,6 +29,7 @@ libvirt_driver_vz_la_LDFLAGS = $(AM_LDFLAGS_MOD_NOUNDEF) libvirt_driver_vz_impl_la_CFLAGS = \ -I$(srcdir)/conf \ -I$(srcdir)/access \ + -I$(builddir)/access \ $(AM_CFLAGS) \ $(PARALLELS_SDK_CFLAGS) \ $(LIBNL_CFLAGS) \ -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH v2] Add python3-docutils package for libvirt
by Daniel P. Berrangé 08 Nov '19

08 Nov '19

This is needed to acquire the rst2html command line tool Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt.yml | 1 + 2 files changed, 6 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index ba0f1cf..81d0916 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -795,6 +795,11 @@ mappings: default: polkit deb: policykit-1 + python3-docutils: + default: python3-docutils + CentOS7: python36-docutils + FreeBSD: py36-docutils + python2: default: python Fedora: python2 diff --git a/guests/vars/projects/libvirt.yml b/guests/vars/projects/libvirt.yml index 8fcb286..780a5aa 100644 --- a/guests/vars/projects/libvirt.yml +++ b/guests/vars/projects/libvirt.yml @@ -46,6 +46,7 @@ packages: - openwsman - parted - polkit + - python3-docutils - qemu-img - radvd - readline -- 2.23.0

2 2

[libvirt] [PATCH 0/2] qemu: Check for job being set when getting iothread stats
by Michal Privoznik 08 Nov '19

08 Nov '19

I've been playing with domstats and encountered a crasher. Here's the fix. Michal Prívozník (2): qemu: Warn on possibly incorrect usage of EnterMonitor* qemu: Check for job being set when getting iothread stats src/qemu/qemu_domain.c | 5 +++++ src/qemu/qemu_driver.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) -- 2.23.0

2 7

[libvirt] [jenkins-ci PATCH 0/5] Add Fedora 31, drop Fedora 29
by Andrea Bolognani 08 Nov '19

08 Nov '19

You know the drill :) Andrea Bolognani (5): guests: Explicitly enable ssh root login in kickstart guests: Add Fedora 31 Start building on Fedora 31 Stop building on Fedora 29 guests: Drop Fedora 29 guests/configs/kickstart.cfg | 12 +++ guests/configs/preseed.cfg | 12 ++- guests/host_vars/libvirt-fedora-29/docker.yml | 2 - guests/host_vars/libvirt-fedora-31/docker.yml | 2 + .../install.yml | 2 +- .../main.yml | 2 +- guests/inventory | 2 +- guests/playbooks/build/jobs/defaults.yml | 4 +- guests/playbooks/build/projects/libosinfo.yml | 2 +- .../playbooks/build/projects/libvirt-dbus.yml | 3 +- .../build/projects/libvirt-go-xml.yml | 2 +- .../playbooks/build/projects/libvirt-go.yml | 2 +- .../build/projects/libvirt-sandbox.yml | 4 +- .../playbooks/build/projects/libvirt-tck.yml | 4 +- guests/playbooks/build/projects/libvirt.yml | 2 +- .../build/projects/osinfo-db-tools.yml | 2 +- .../playbooks/build/projects/virt-manager.yml | 6 +- .../playbooks/build/projects/virt-viewer.yml | 2 +- guests/vars/vault.yml | 82 +++++++++---------- jenkins/jobs/defaults.yaml | 4 +- jenkins/projects/libosinfo.yaml | 2 +- jenkins/projects/libvirt-dbus.yaml | 4 +- jenkins/projects/libvirt-go-xml.yaml | 2 +- jenkins/projects/libvirt-go.yaml | 2 +- jenkins/projects/libvirt-sandbox.yaml | 4 +- jenkins/projects/libvirt-tck.yaml | 4 +- jenkins/projects/libvirt.yaml | 2 +- jenkins/projects/osinfo-db-tools.yaml | 2 +- jenkins/projects/virt-manager.yaml | 6 +- jenkins/projects/virt-viewer.yaml | 2 +- 30 files changed, 100 insertions(+), 83 deletions(-) delete mode 100644 guests/host_vars/libvirt-fedora-29/docker.yml create mode 100644 guests/host_vars/libvirt-fedora-31/docker.yml rename guests/host_vars/{libvirt-fedora-29 => libvirt-fedora-31}/install.yml (66%) rename guests/host_vars/{libvirt-fedora-29 => libvirt-fedora-31}/main.yml (95%) -- 2.21.0

3 11