- Devel - libvirt List Archives

[libvirt] [PATCH for 5.10.0] news: Update for 5.10.0 release
by Michal Privoznik 27 Nov '19

27 Nov '19

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 124 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 124 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 72c0edb317..b6782df136 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -81,8 +81,132 @@ </change> </section> <section title="Improvements"> + <change> + <summary> + Devices CGroup v2 support + </summary> + <description> + Libvirt supported all controllers of CGroup v2 but the devices + controller which is implemented in this release. + </description> + </change> + <change> + <summary> + Cold plug of sound device + </summary> + <description> + The QEMU driver now can handle cold plug of + <code><sound/></code> devices. + </description> + </change> + <change> + <summary> + More GLib integration + </summary> + <description> + More patches were merged that replace our internal functions with + GLib ones. Also some effort was invested in replacing gnulib modules + with GLib functions. + </description> + </change> + <change> + <summary> + Rewrite of Perl scripts into Python + </summary> + <description> + Libvirt used Perl scripts to check for coding style, generate some + code and things like that. To bring the number of languages used + down, these scripts were rewritten into Python. + </description> + </change> + <change> + <summary> + Probe for default CPU types + </summary> + <description> + With QEMU 4.2.0 we can probe for the default CPU model used by QEMU + for a particular machine type and store it in the domain XML. This + way the chosen CPU model is more visible to users and libvirt will + make sure the guest will see the exact same CPU after migration. + </description> + </change> + <change> + <summary> + Adaptation to qemu's blockdev + </summary> + <description> + QEMU introduced a new way of specifying disks on the command line + which enables fine-grained control over the block stack. Libvirt has + adapted to this. + </description> + </change> </section> <section title="Bug fixes"> + <change> + <summary> + Warn verbosely if using old loader:nvram pairs + </summary> + <description> + Some distributions still use <code>--with-loader-nvram</code> or + <code>nvram</code> variable in qemu.conf. This is now discouraged in + favour of FW descriptors. However, instead of silently ignoring user's + config, libvirt warns if outdated config is detected. + </description> + </change> + <change> + <summary> + Drop pconfig from Icelake-Server CPU model + </summary> + <description> + The pconfig feature was enabled in QEMU by accident in 3.1.0. All + other newer versions do not support it and it was removed from the + Icelake-Server CPU model in QEMU. + </description> + </change> + <change> + <summary> + Wait longer for device removal confirmation on PPC64 + </summary> + <description> + After sending device hot unplug request to QEMU, libvirt waits up to + 5 seconds for qemu to confirm the device removal. On some + architectures (like PPC64) this can take longer time and libvirt now + reflects that. + </description> + </change> + <change> + <summary> + Forcibly create nodes in domain's namespace + </summary> + <description> + The QEMU driver starts a domain in a namepsace with private + <code>/dev</code> and creates only those nodes there which the domain + is configured to have. However, it may have happened that if a node + changed its minor number this change wasn't propagated to the + namespace. + </description> + </change> + <change> + <summary> + Various AppArmor bugfixes + </summary> + <description> + The AppArmor driver now knows how to handle + <code><shmem/></code> devices and also snapshotting more disks + at once. + </description> + </change> + <change> + <summary> + Improved video model autoselection + </summary> + <description> + If a graphics device was added to XML that had no video device, + libvirt automatically added a video device which was always of type + 'cirrus' on x86_64, even if the underlying qemu didn't support + cirrus. Libvirt now bases the decision on qemu's capabilities. + </description> + </change> </section> </release> <release version="v5.9.0" date="2019-11-05"> -- 2.23.0

4 7

[libvirt] [PATCH for 5.10] Revert "qemu: Don't repeat virDomainObjEndAPI in qemuDomainBlockPull"
by Peter Krempa 27 Nov '19

27 Nov '19

This reverts commit 421c9550f5446729b513ee50f5c44e6f6969b5a2. qemuDomainBlockPullCommon calls virDomainObjEndAPI internally so the original commit made us shed two references of @vm instead of one getting us into a premature free of @vm. This is not a straight revert as qemuDomainBlockPull was modified meanwhile. I've also added a warning comment that @vm is consumed. https://bugzilla.redhat.com/show_bug.cgi?id=1777230 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- /me hides in shame src/qemu/qemu_driver.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 669c12d6ca..8c2670d377 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18443,24 +18443,23 @@ qemuDomainBlockPull(virDomainPtr dom, const char *path, unsigned long bandwidth, unsigned int flags) { virDomainObjPtr vm; - int ret = -1; - virCheckFlags(VIR_DOMAIN_BLOCK_PULL_BANDWIDTH_BYTES, -1); if (!(vm = qemuDomainObjFromDomain(dom))) return -1; - if (virDomainBlockPullEnsureACL(dom->conn, vm->def) < 0) - goto cleanup; - - if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0) - goto cleanup; + if (virDomainBlockPullEnsureACL(dom->conn, vm->def) < 0) { + virDomainObjEndAPI(&vm); + return -1; + } - ret = qemuDomainBlockPullCommon(vm, path, NULL, bandwidth, flags); + if (qemuDomainSupportsCheckpointsBlockjobs(vm) < 0) { + virDomainObjEndAPI(&vm); + return -1; + } - cleanup: - virDomainObjEndAPI(&vm); - return ret; + /* qemuDomainBlockPullCommon consumes the reference on @vm */ + return qemuDomainBlockPullCommon(vm, path, NULL, bandwidth, flags); } -- 2.23.0

2 1

[libvirt] configuraton error while configuring libvirt
by Billa Surendra 27 Nov '19

27 Nov '19

HI all, I am trying to install libvirt-5.4.0 in fedora 31 host pc, but I am > getting error like *configure: error: You must install the gnutls >= > 3.2.0 pkg-config module to compile libvirt*. I have higher version of > gnutls avilable in my host pc already. Any one tell me how to install > libvirt in fedora and how to resolve above error. Is there any perfect > steps for installation of libvirt. > Thanks In Advance

2 1

[libvirt] [PATCH 0/4] replace setenv and unsetenv by Glib functions (kill-a-gnulib-module-a-day initiative)
by Pavel Hrdina 27 Nov '19

27 Nov '19

2 6

[libvirt] [PATCH 00/10] qemu: Fixes of the blockdev job handling (a blockdev-add series)
by Peter Krempa 26 Nov '19

26 Nov '19

While playing with the incremental backup stuff I came across few corner cases in the blockdev job handling. Peter Krempa (10): qemu: monitor: Finish implementation of infrastructure for 'query-jobs' qemu: blockjob: Properly propagate cancellation of blockjobs qemu: process: Move block job refresh after async job recovery qemu: blockjob: Fix deadlock when terminating job with invalid data qemu: blockjob: Log blockjobs which are dropped when untracked by qemu qemu: blockjob: Mark job with broken data but tracked by qemu as reconnected qemu: blockjob: Don't stop processing the finished job early qemu: blockjob: Separate clearing of per-job data qemu: blockjob: Introduce "broken" block job type qemu: blockjob: Finish handling job with broken data src/qemu/qemu_blockjob.c | 70 ++++++++++++------- src/qemu/qemu_blockjob.h | 3 + src/qemu/qemu_domain.c | 13 +++- src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.h | 4 +- src/qemu/qemu_monitor_json.c | 6 ++ src/qemu/qemu_process.c | 6 +- .../blockjob-blockdev-in.xml | 1 + 8 files changed, 73 insertions(+), 31 deletions(-) -- 2.23.0

2 20

[libvirt] [PATCH 0/9] domain job stats handling improvements (incremental backup prequels)
by Peter Krempa 26 Nov '19

26 Nov '19

Improve few aspecs of the domain job stats handling. I felt these make life simpler when using the domain stats specifically when trying to figure out how stuff works. Peter Krempa (9): virsh: domain: Extract the code converting domain job stats to virDomainJobInfo api: Allow keeping completed domain job stats when reading them virsh: Implement VIR_DOMAIN_JOB_STATS_COMPLETED_KEEP for 'domjobinfo' qemu: Implement VIR_DOMAIN_JOB_STATS_COMPLETED_KEEP virsh: domjobinfo: Print also job operation for failed jobs virsh: domjobinfo: Allow printing stats also for failed and other jobs virsh: domjobinfo: Add switch to print raw fields API: Introduce VIR_DOMAIN_JOB_SUCCESS field for virDomainGetJobStats qemu: Always reset @info in qemuDomainGetJobInfo include/libvirt/libvirt-domain.h | 9 +++ src/libvirt-domain.c | 6 +- src/qemu/qemu_driver.c | 9 ++- tools/virsh-domain.c | 124 +++++++++++++++++++++---------- tools/virsh.pod | 16 +++- 5 files changed, 115 insertions(+), 49 deletions(-) -- 2.23.0

2 18

[libvirt] [PATCH] util: whitelist Oracle ACFS as a shared filesystem
by Daniel P. Berrangé 26 Nov '19

26 Nov '19

The magic number is taken from the coreutils stat.c file since there is no constant for it in normal system headers. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virfile.c | 8 +++++++- src/util/virfile.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index fca7ff9d35..3dd2b1a527 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3426,6 +3426,8 @@ int virFilePrintf(FILE *fp, const char *msg, ...) # define QB_MAGIC 0x51626d6e # endif +# define VIR_ACFS_MAGIC 0x61636673 + # define PROC_MOUNTS "/proc/mounts" static int @@ -3578,6 +3580,9 @@ virFileIsSharedFSType(const char *path, if ((fstypes & VIR_FILE_SHFS_QB) && (f_type == QB_MAGIC)) return 1; + if ((fstypes & VIR_FILE_SHFS_ACFS) && + (f_type == VIR_ACFS_MAGIC)) + return 1; return 0; } @@ -3765,7 +3770,8 @@ int virFileIsSharedFS(const char *path) VIR_FILE_SHFS_CIFS | VIR_FILE_SHFS_CEPH | VIR_FILE_SHFS_GPFS| - VIR_FILE_SHFS_QB); + VIR_FILE_SHFS_QB | + VIR_FILE_SHFS_ACFS); } diff --git a/src/util/virfile.h b/src/util/virfile.h index 9a8709b52c..bcae40ee06 100644 --- a/src/util/virfile.h +++ b/src/util/virfile.h @@ -209,6 +209,7 @@ enum { VIR_FILE_SHFS_CEPH = (1 << 6), VIR_FILE_SHFS_GPFS = (1 << 7), VIR_FILE_SHFS_QB = (1 << 8), + VIR_FILE_SHFS_ACFS = (1 << 9), }; int virFileIsSharedFSType(const char *path, int fstypes) ATTRIBUTE_NONNULL(1); -- 2.21.0

2 1

[libvirt] [PATCH] libxl: fix typo in error message
by Daniel P. Berrangé 26 Nov '19

26 Nov '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/libxl/libxl_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index e6c6f5f6ad..1e9d5dc875 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -2384,7 +2384,7 @@ libxlDriverNodeGetInfo(libxlDriverPrivatePtr driver, virNodeInfoPtr info) if (virStrcpyStatic(info->model, virArchToString(hostarch)) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("machine type %s too big for destination"), + _("host arch %s too big for destination"), virArchToString(hostarch)); goto cleanup; } -- 2.23.0

3 2

[libvirt] [PATCH] all: don't wait for driver lock during startup
by Michal Privoznik 26 Nov '19

26 Nov '19

There are two daemons that wait for acquiring their pid files: virtnetworkd and virtstoraged. This is undesirable as the idea is to quit early if unable to acquire the pid file. This was missed in v5.6.0-rc1~207. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.c | 2 +- src/storage/storage_driver.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 07dba8cfe4..e360645969 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -761,7 +761,7 @@ networkStateInitialize(bool privileged, if ((network_driver->lockFD = virPidFileAcquire(network_driver->stateDir, "driver", - true, getpid())) < 0) + false, getpid())) < 0) goto error; /* if this fails now, it will be retried later with dnsmasqCapsRefresh() */ diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index d8355d3c3c..580a5e6f15 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -296,7 +296,7 @@ storageStateInitialize(bool privileged, if ((driver->lockFD = virPidFileAcquire(driver->stateDir, "driver", - true, getpid())) < 0) + false, getpid())) < 0) goto error; if (virStoragePoolObjLoadAllState(driver->pools, -- 2.23.0

3 2

[libvirt] ANNOUNCE: libvirt-glib release 3.0.0
by Daniel P. Berrangé 26 Nov '19

26 Nov '19

I am pleased to announce that a new release of the libvirt-glib package, version 3.0.0, is now available from https://libvirt.org/sources/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) Changes in this release: * Add support for bochs video device * Add API to query firmware config * Improve testing coverage * Validate min/max glib API versions in use * Remove deprecated G_PARAM_PRIVATE * Fix docs build linking problems * Convert python demos to be python 3 compatible & use modern best practice for pyobject introspection bindings * Add API to query domain capaibilities * Refresh translations * Simplify build process for handling translations * Fix some memory leaks * Add API for setting storage volume features Thanks to everyone who contributed to this new release through testing, patches, bug reports, translations and more. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0