- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] qemu: Refactor qemuDomainAbortJob
by Peter Krempa 05 Dec '19

05 Dec '19

Review of my incremental backup series prompted for refactor of qemuDomainAbortJob Peter Krempa (2): qemu: driver: Split out cancellation of migration from qemuDomainAbortJob qemu: Convert aborting of a domain job to a switch statement src/qemu/qemu_driver.c | 90 +++++++++++++++++++++++++++++------------- 1 file changed, 63 insertions(+), 27 deletions(-) -- 2.23.0

2 3

[libvirt] [PATCH] docs: document some recent news items
by Daniel P. Berrangé 05 Dec '19

05 Dec '19

Document xz compression improvements, docutils build requirements, and dropped python 2 support. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 43aa96f497..63d57a85ac 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -44,11 +44,48 @@ <libvirt> <release version="v6.0.0" date="unreleased"> <section title="New features"> + <change> + <summary> + docs: the python docutils toolset is now required + </summary> + <description> + The use of rst2html has been introduced for the + website build process since docs are now being + written in the RST as an alternative to HTML. + </description> + </change> </section> <section title="Improvements"> + <change> + <summary> + qemu: xz save image compression is faster + </summary> + <description> + When using the xz format to compressed virtual + machine saved state images, the "-3" compression + level preset is now used. This results in slightly + larger files, but with a massively reduced time + to compress. The xz format offers the best compression + level for saved state images, albeit still with the + slowest running time. For the fastest possible + running time, at cost of the larest compressed size, + lzop should be used. + </description> + </change> </section> <section title="Bug fixes"> </section> + <section title="Removed features"> + <change> + <summary> + support for python2 is removed + </summary> + <description> + Libvirt is no longer able to be built using the + Python 2 binary. Python 3 must be used instead. + </description> + </change> + </section> </release> <release version="v5.10.0" date="2019-12-02"> <section title="New features"> -- 2.21.0

2 1

[libvirt] [PATCH v2] qemuProcessStop: Remove image metadata only when allowed
by Michal Privoznik 05 Dec '19

05 Dec '19

In v5.9.0-370-g8fa0374c5b I've tried to fix a bug by removing some stale XATTRs in qemuProcessStop(). However, I forgot to do nothing when the VIR_QEMU_PROCESS_STOP_NO_RELABEL flag was specified. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 75ee3893c6..5e178b3c6c 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7648,13 +7648,15 @@ void qemuProcessStop(virQEMUDriverPtr driver, /* Do this explicitly after vm->pid is reset so that security drivers don't * try to enter the domain's namespace which is non-existent by now as qemu * is no longer running. */ - for (i = 0; i < def->ndisks; i++) { - virDomainDiskDefPtr disk = def->disks[i]; + if (!(flags & VIR_QEMU_PROCESS_STOP_NO_RELABEL)) { + for (i = 0; i < def->ndisks; i++) { + virDomainDiskDefPtr disk = def->disks[i]; - if (disk->mirror) - qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->mirror); + if (disk->mirror) + qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->mirror); - qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->src); + qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->src); + } } /* clear all private data entries which are no longer needed */ -- 2.23.0

2 1

[libvirt] [PATCH] qemuProcessStop: Remove image metadata only when allowed
by Michal Privoznik 04 Dec '19

04 Dec '19

In v5.9.0-370-g8fa0374c5b I've tried to fix a bug by removing some stale XATTRs in qemuProcessStop(). However, I forgot to do nothing when the VIR_QEMU_PROCESS_STOP_NO_RELABEL flag was specified. 🤦 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_process.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 75ee3893c6..df19977bb3 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7648,13 +7648,15 @@ void qemuProcessStop(virQEMUDriverPtr driver, /* Do this explicitly after vm->pid is reset so that security drivers don't * try to enter the domain's namespace which is non-existent by now as qemu * is no longer running. */ - for (i = 0; i < def->ndisks; i++) { - virDomainDiskDefPtr disk = def->disks[i]; + if ((flags & VIR_QEMU_PROCESS_STOP_NO_RELABEL)) { + for (i = 0; i < def->ndisks; i++) { + virDomainDiskDefPtr disk = def->disks[i]; - if (disk->mirror) - qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->mirror); + if (disk->mirror) + qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->mirror); - qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->src); + qemuBlockRemoveImageMetadata(driver, vm, disk->dst, disk->src); + } } /* clear all private data entries which are no longer needed */ -- 2.23.0

2 1

[libvirt] [PATCH] add lock priv->lock protection in remoteClientCloseFunc()
by LanceLiu 04 Dec '19

04 Dec '19

sometimes, virsh console session may closed by virsh console existed session(when virsh console client exit) and new virsh console --force session simutaneously. So in one thread(Job worker), it calls daemonStreamEvent() and referencing stream, and in another thread(main thread), virNetServerClientClose() was called, and the callback remoteClientCloseFunc() was called, without protect by priv->lock in remoteClientCloseFunc(), it may lead to daemonStreamEvent reference stream released by remoteClientCloseFunc(), and also need change virNetServerClientClose() to be virNetServerClientImmediateClose() in daemonStreamEvent(), or it lead to libvirt daemon deadlock by double lock priv->lock in daemonStreamEvent() --- src/remote/remote_daemon_dispatch.c | 2 ++ src/remote/remote_daemon_stream.c | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon_dispatch.c index f369ffb..b0982b7 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -1724,7 +1724,9 @@ static void remoteClientCloseFunc(virNetServerClientPtr client) { struct daemonClientPrivate *priv = virNetServerClientGetPrivateData(client); + virMutexLock(&priv->lock); daemonRemoveAllClientStreams(priv->streams); + virMutexUnlock(&priv->lock); remoteClientFreePrivateCallbacks(priv); } diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_stream.c index 73e4d7b..6a84fdf 100644 --- a/src/remote/remote_daemon_stream.c +++ b/src/remote/remote_daemon_stream.c @@ -141,7 +141,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) (events & VIR_STREAM_EVENT_WRITABLE)) { if (daemonStreamHandleWrite(client, stream) < 0) { daemonRemoveClientStream(client, stream); - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } } @@ -151,7 +151,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) events = events & ~(VIR_STREAM_EVENT_READABLE); if (daemonStreamHandleRead(client, stream) < 0) { daemonRemoveClientStream(client, stream); - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } /* If we detected EOF during read processing, @@ -176,7 +176,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) if (daemonStreamHandleFinish(client, stream, msg) < 0) { virNetMessageFree(msg); daemonRemoveClientStream(client, stream); - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } break; @@ -186,7 +186,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) if (daemonStreamHandleAbort(client, stream, msg) < 0) { virNetMessageFree(msg); daemonRemoveClientStream(client, stream); - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } break; @@ -205,7 +205,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) stream->recvEOF = true; if (!(msg = virNetMessageNew(false))) { daemonRemoveClientStream(client, stream); - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } msg->cb = daemonStreamMessageFinished; @@ -219,7 +219,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) "", 0) < 0) { virNetMessageFree(msg); daemonRemoveClientStream(client, stream); - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } } @@ -262,7 +262,7 @@ daemonStreamEvent(virStreamPtr st, int events, void *opaque) } daemonRemoveClientStream(client, stream); if (ret < 0) - virNetServerClientClose(client); + virNetServerClientImmediateClose(client); goto cleanup; } -- 1.8.3.1

2 1

[libvirt] [python PATCH] Fix RPM deps for centos 7
by Daniel P. Berrangé 04 Dec '19

04 Dec '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt-python.spec.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 1e92f3c..33d2775 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -21,8 +21,13 @@ Url: http://libvirt.org License: LGPLv2+ BuildRequires: libvirt-devel == %{version} BuildRequires: python3-devel +%if 0%{?rhel} == 7 +BuildRequires: python36-nose +BuildRequires: python36-lxml +%else BuildRequires: python3-nose BuildRequires: python3-lxml +%endif BuildRequires: gcc # Don't want provides for python shared objects -- 2.23.0

2 1

[libvirt] [jenkins-ci PATCH] lcitool: Add 'install=' to the extra_arg
by Fabiano Fidêncio 04 Dec '19

04 Dec '19

Add "install=" unconditionally to the extra_arg parameter passed to virt-install. It's needed as the virt-install present on CentOS CI host does not use the correct kernel URL argument when installing OpenSUSE. This does not cause issues on other installations as the other distros will just ignore the argument passed. Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- I've verified this solution works on a CentOS 7 host. I've verified this solution doesn't cause regressions on a Fedora 31 host. --- guests/lcitool | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index 0e27796..c7f949d 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -542,8 +542,13 @@ class Application: # but we need to point anaconda in the right direction through # the 'ks' kernel parameter. We can use 'ks' unconditionally # for simplicity's sake, because distributions that don't use - # kickstart for unattended installation will simply ignore it - extra_arg = "console=ttyS0 ks=file:/{}".format(install_config) + # kickstart for unattended installation will simply ignore it. + # Similarly to how we can use 'ks' unconditionally, we also can + # do the same with 'install' argument, needed to workaround a + # a bug on virt-install as it does not use the correct kernel + # URL argument when installing an OpenSUSE guest. + extra_arg = ("console=ttyS0 ks=file:/{} install={}". + format(install_config, facts["install_url"])) virt_install = distutils.spawn.find_executable("virt-install") if virt_install is None: -- 2.23.0

2 1

[libvirt] [PATCH] build: only support python3 binary
by Daniel P. Berrangé 04 Dec '19

04 Dec '19

python2 will be end of life by the time of the next libvirt release. All our supported build targets, including CentOS7, have a python3 build available. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- configure.ac | 4 ++-- docs/apibuild.py | 4 +--- docs/reformat-news.py | 4 +--- libvirt.spec.in | 10 +--------- scripts/augeas-gentest.py | 4 +--- scripts/check-aclperms.py | 4 +--- scripts/check-aclrules.py | 4 +--- scripts/check-driverimpls.py | 4 +--- scripts/check-drivername.py | 4 +--- scripts/check-symfile.py | 4 +--- scripts/check-symsorting.py | 4 +--- scripts/dtrace2systemtap.py | 4 +--- scripts/genpolkit.py | 4 +--- scripts/gensystemtap.py | 4 +--- scripts/header-ifdef.py | 4 +--- scripts/minimize-po.py | 4 +--- scripts/mock-noinline.py | 4 +--- scripts/prohibit-duplicate-header.py | 4 +--- src/esx/esx_vi_generator.py | 4 +--- src/hyperv/hyperv_wmi_generator.py | 4 +--- tests/cputestdata/cpu-gather.sh | 9 +-------- 21 files changed, 22 insertions(+), 73 deletions(-) diff --git a/configure.ac b/configure.ac index 76d28d2f67..2e5af075ea 100644 --- a/configure.ac +++ b/configure.ac @@ -701,9 +701,9 @@ if test "$with_linux" = "yes"; then fi dnl Allow perl/python overrides -AC_PATH_PROGS([PYTHON], [python3 python2 python]) +AC_PATH_PROGS([PYTHON], [python3]) if test -z "$PYTHON"; then - AC_MSG_ERROR(['python3', 'python2' or 'python' binary is required to build libvirt]) + AC_MSG_ERROR(['python3' binary is required to build libvirt]) fi AC_PATH_PROG([FLAKE8], [flake8]) if test -z "$FLAKE8"; then diff --git a/docs/apibuild.py b/docs/apibuild.py index 5a0224c1c6..2f7314b379 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # This is the API builder, it parses the C sources and build the # API formal description in XML. @@ -8,8 +8,6 @@ # daniel(a)veillard.com # -from __future__ import print_function - import os import sys import glob diff --git a/docs/reformat-news.py b/docs/reformat-news.py index a06f945c02..7bc752d821 100755 --- a/docs/reformat-news.py +++ b/docs/reformat-news.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # reformat-news.py: Reformat the NEWS file properly # @@ -18,8 +18,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import sys COLUMNS = 80 diff --git a/libvirt.spec.in b/libvirt.spec.in index 4c6161a26f..72ed2fd96b 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -188,14 +188,6 @@ %define with_bash_completion 0%{!?_without_bash_completion:1} -# Use Python 3 when possible, Python 2 otherwise -%if 0%{?fedora} || 0%{?rhel} > 7 - %define python python3 -%else - %define python python2 -%endif - - %if %{with_qemu} || %{with_lxc} # numad is used to manage the CPU and memory placement dynamically, # it's not available on many non-x86 architectures. @@ -281,7 +273,7 @@ BuildRequires: perl-interpreter %else BuildRequires: perl %endif -BuildRequires: %{python} +BuildRequires: python3 BuildRequires: systemd-units %if %{with_libxl} BuildRequires: xen-devel diff --git a/scripts/augeas-gentest.py b/scripts/augeas-gentest.py index 60e12fb77e..8976785cad 100755 --- a/scripts/augeas-gentest.py +++ b/scripts/augeas-gentest.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2012-2019 Red Hat, Inc. # @@ -19,8 +19,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import re import sys diff --git a/scripts/check-aclperms.py b/scripts/check-aclperms.py index b1084a3758..67de0efabd 100755 --- a/scripts/check-aclperms.py +++ b/scripts/check-aclperms.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2013-2019 Red Hat, Inc. # @@ -21,8 +21,6 @@ # a lot of auto-generation of code, so when these don't match # problems occur, preventing auth from succeeding at all. -from __future__ import print_function - import re import sys diff --git a/scripts/check-aclrules.py b/scripts/check-aclrules.py index 5a7d275410..a1fa473174 100755 --- a/scripts/check-aclrules.py +++ b/scripts/check-aclrules.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2013-2019 Red Hat, Inc. # @@ -32,8 +32,6 @@ # detected EnsureACL call recorded. # -from __future__ import print_function - import re import sys diff --git a/scripts/check-driverimpls.py b/scripts/check-driverimpls.py index bc3f16a816..8289b8051e 100755 --- a/scripts/check-driverimpls.py +++ b/scripts/check-driverimpls.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2013-2019 Red Hat, Inc. # @@ -17,8 +17,6 @@ # <http://www.gnu.org/licenses/>. # -from __future__ import print_function - import re import sys diff --git a/scripts/check-drivername.py b/scripts/check-drivername.py index ba77a6d48d..39eff836c7 100644 --- a/scripts/check-drivername.py +++ b/scripts/check-drivername.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2013-2019 Red Hat, Inc. # @@ -17,8 +17,6 @@ # <http://www.gnu.org/licenses/>. # -from __future__ import print_function - import re import sys diff --git a/scripts/check-symfile.py b/scripts/check-symfile.py index 7aeb047d89..0f6e780df0 100755 --- a/scripts/check-symfile.py +++ b/scripts/check-symfile.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2012-2019 Red Hat, Inc. # @@ -16,8 +16,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import re import subprocess import sys diff --git a/scripts/check-symsorting.py b/scripts/check-symsorting.py index 8e698c0657..fd00449c44 100755 --- a/scripts/check-symsorting.py +++ b/scripts/check-symsorting.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # Copyright (C) 2012-2019 Red Hat, Inc. # @@ -16,8 +16,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import os.path import re import sys diff --git a/scripts/dtrace2systemtap.py b/scripts/dtrace2systemtap.py index d6bf1f8d1f..506db9c503 100755 --- a/scripts/dtrace2systemtap.py +++ b/scripts/dtrace2systemtap.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2011-2019 Red Hat, Inc. # @@ -23,8 +23,6 @@ # python dtrace2systemtap.py probes.d > libvirt_probes.stp # -from __future__ import print_function - import re import sys diff --git a/scripts/genpolkit.py b/scripts/genpolkit.py index 230d920f70..8845ea44e0 100755 --- a/scripts/genpolkit.py +++ b/scripts/genpolkit.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2012-2019 Red Hat, Inc. # @@ -17,8 +17,6 @@ # <http://www.gnu.org/licenses/>. # -from __future__ import print_function - import re import sys diff --git a/scripts/gensystemtap.py b/scripts/gensystemtap.py index 7b391cc911..ad808e3033 100755 --- a/scripts/gensystemtap.py +++ b/scripts/gensystemtap.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2011-2019 Red Hat, Inc. # @@ -22,8 +22,6 @@ # python gensystemtap.py */*.x > libvirt_functions.stp # -from __future__ import print_function - import re import sys diff --git a/scripts/header-ifdef.py b/scripts/header-ifdef.py index d5ec7b45fe..e668875f18 100644 --- a/scripts/header-ifdef.py +++ b/scripts/header-ifdef.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2018-2019 Red Hat, Inc. # @@ -44,8 +44,6 @@ # ....content.... # #endif /* SYMBOL */ -from __future__ import print_function - import os.path import re import sys diff --git a/scripts/minimize-po.py b/scripts/minimize-po.py index d548b427e9..c305229721 100755 --- a/scripts/minimize-po.py +++ b/scripts/minimize-po.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2018-2019 Red Hat, Inc. # @@ -16,8 +16,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import re import sys diff --git a/scripts/mock-noinline.py b/scripts/mock-noinline.py index b338c5f097..4fc60c0be3 100644 --- a/scripts/mock-noinline.py +++ b/scripts/mock-noinline.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2017-2019 Red Hat, Inc. # @@ -16,8 +16,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import re import sys diff --git a/scripts/prohibit-duplicate-header.py b/scripts/prohibit-duplicate-header.py index 420311ccef..33a91ddbc5 100644 --- a/scripts/prohibit-duplicate-header.py +++ b/scripts/prohibit-duplicate-header.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # Copyright (C) 2016-2019 Red Hat, Inc. # @@ -16,8 +16,6 @@ # License along with this library. If not, see # <http://www.gnu.org/licenses/>. -from __future__ import print_function - import re import sys diff --git a/src/esx/esx_vi_generator.py b/src/esx/esx_vi_generator.py index 2f685c0898..048f5dde9e 100755 --- a/src/esx/esx_vi_generator.py +++ b/src/esx/esx_vi_generator.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # esx_vi_generator.py: generates most of the SOAP type mapping code @@ -22,8 +22,6 @@ # <http://www.gnu.org/licenses/>. # -from __future__ import print_function - import sys import os import os.path diff --git a/src/hyperv/hyperv_wmi_generator.py b/src/hyperv/hyperv_wmi_generator.py index 3001f222f7..736eabd598 100755 --- a/src/hyperv/hyperv_wmi_generator.py +++ b/src/hyperv/hyperv_wmi_generator.py @@ -1,4 +1,4 @@ -#!/usr/bin/env python +#!/usr/bin/env python3 # # hyperv_wmi_generator.py: generates most of the WMI type mapping code @@ -20,8 +20,6 @@ # <http://www.gnu.org/licenses/>. # -from __future__ import print_function - import sys import os import os.path diff --git a/tests/cputestdata/cpu-gather.sh b/tests/cputestdata/cpu-gather.sh index cefd1b0d0d..79e3fddf22 100755 --- a/tests/cputestdata/cpu-gather.sh +++ b/tests/cputestdata/cpu-gather.sh @@ -9,9 +9,7 @@ grep 'model name' /proc/cpuinfo | head -n1 cpuid -1r echo -for python in python3 python2; do - $python <<EOF -from __future__ import print_function +python3 <<EOF from struct import pack, unpack from fcntl import ioctl import sys, errno @@ -51,11 +49,6 @@ except IOError as e: pass EOF - if [[ $? -eq 0 ]]; then - break - fi -done - qemu=qemu-system-x86_64 for cmd in /usr/bin/$qemu /usr/bin/qemu-kvm /usr/libexec/qemu-kvm; do if [[ -x $cmd ]]; then -- 2.21.0

3 3

[libvirt] [jenkins-ci PATCH] Drop support for python 2
by Daniel P. Berrangé 04 Dec '19

04 Dec '19

CentOS7 now has support for python 3 out of the box Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 2 -- guests/playbooks/update/tasks/bootstrap.yml | 6 ------ guests/vars/mappings.yml | 24 --------------------- guests/vars/projects/base.yml | 1 - guests/vars/projects/libvirt-python.yml | 4 ---- 5 files changed, 37 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index 94e29af..d730aa2 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -16,5 +16,3 @@ package_format: 'rpm' package_manager: 'yum' os_name: 'CentOS' os_version: '7' - -ansible_python_interpreter: /usr/bin/python2 diff --git a/guests/playbooks/update/tasks/bootstrap.yml b/guests/playbooks/update/tasks/bootstrap.yml index 2e1dc42..c77d3a1 100644 --- a/guests/playbooks/update/tasks/bootstrap.yml +++ b/guests/playbooks/update/tasks/bootstrap.yml @@ -7,11 +7,5 @@ - set_fact: python: python3 -- set_fact: - python: python2 - when: - - os_name == 'CentOS' - - os_version == '7' - - name: Bootstrap Ansible raw: '{{ package_manager }} install -y {{ python }}' diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 9c339f2..ce1294c 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -804,30 +804,6 @@ mappings: CentOS7: python36-docutils FreeBSD: py36-docutils - python2: - default: python - Fedora: python2 - FreeBSD: python2 - - python2-devel: - deb: python-dev - pkg: python2 - rpm: python2-devel - cross-policy-deb: foreign - - python2-lxml: - default: python-lxml - Fedora: python2-lxml - FreeBSD: py27-lxml - - python2-nose: - default: python-nose - Fedora: python2-nose - FreeBSD: py27-nose - - python2-setuptools: - CentOS7: python2-setuptools - python3: default: python3 diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 275211c..29c10b4 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -25,7 +25,6 @@ packages: - patch - perl - pkg-config - - python2-setuptools - python3 - python3-pip - python3-setuptools diff --git a/guests/vars/projects/libvirt-python.yml b/guests/vars/projects/libvirt-python.yml index 86b5aab..71a0717 100644 --- a/guests/vars/projects/libvirt-python.yml +++ b/guests/vars/projects/libvirt-python.yml @@ -1,9 +1,5 @@ --- packages: - - python2 - - python2-devel - - python2-lxml - - python2-nose - python3-devel - python3-lxml - python3-nose -- 2.23.0

3 2

[libvirt] [jenkins-ci PATCH] lcitool: Decouple Python interpreters for Ansible and builds
by Andrea Bolognani 04 Dec '19

04 Dec '19

We need to keep using Python 2 for Ansible, because Python 3 is only supported by the dnf module and on CentOS 7 we have to use the yum module instead; at the same time, all libvirt projects have now dropped Python 2 support so we need to make sure we use Python 3 for building them. Decouple the Python versions used for the two purposes so that we can keep everything working. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/paths.yml | 2 ++ guests/playbooks/update/templates/bashrc.j2 | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/guests/playbooks/update/tasks/paths.yml b/guests/playbooks/update/tasks/paths.yml index aada1f3..c204462 100644 --- a/guests/playbooks/update/tasks/paths.yml +++ b/guests/playbooks/update/tasks/paths.yml @@ -14,6 +14,7 @@ - make - ninja - ninja-build + - python3 - su - name: 'Look for files' @@ -39,6 +40,7 @@ bash: '{{ commands["bash"] }}' ccache: '{{ commands["ccache"] }}' java: '{{ commands["java"] }}' + python: '{{ commands["python3"] }}' su: '{{ commands["su"] }}' sudoers: '{{ files["sudoers"] }}' diff --git a/guests/playbooks/update/templates/bashrc.j2 b/guests/playbooks/update/templates/bashrc.j2 index d3fc652..9cea90c 100644 --- a/guests/playbooks/update/templates/bashrc.j2 +++ b/guests/playbooks/update/templates/bashrc.j2 @@ -2,7 +2,7 @@ export PS1="[\u@\h \w]\$ " export MAKE="{{ make }}" export NINJA="{{ ninja }}" -export PYTHON="{{ ansible_python_interpreter }}" +export PYTHON="{{ python }}" export MAKEFLAGS="-j{{ install_vcpus|int + 1 }}" -- 2.23.0

2 1