- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: remove nested branching to enhance readability
by Pavel Mores 06 Dec '19

06 Dec '19

This is a follow-up to patch series posted in https://www.redhat.com/archives/libvir-list/2019-November/msg01180.html It implements a suggestion made by Cole in https://www.redhat.com/archives/libvir-list/2019-November/msg01207.html and discussed in follow-up messages as there were no objections to the change. The aim is to make the code more readable by replacing nested branching with a flat structure. Signed-off-by: Pavel Mores <pmores(a)redhat.com> --- src/qemu/qemu_domain.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index d1596a28ca..5e4eede3c2 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -7914,19 +7914,16 @@ static int qemuDomainDefaultVideoDevice(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { - if (ARCH_IS_PPC64(def->os.arch)) { + if (ARCH_IS_PPC64(def->os.arch)) return VIR_DOMAIN_VIDEO_TYPE_VGA; - } else if (qemuDomainIsARMVirt(def) || - qemuDomainIsRISCVVirt(def) || - ARCH_IS_S390(def->os.arch)) { + if (qemuDomainIsARMVirt(def) || qemuDomainIsRISCVVirt(def) || + ARCH_IS_S390(def->os.arch)) return VIR_DOMAIN_VIDEO_TYPE_VIRTIO; - } else { - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_CIRRUS_VGA)) - return VIR_DOMAIN_VIDEO_TYPE_CIRRUS; - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VGA)) - return VIR_DOMAIN_VIDEO_TYPE_VGA; - return VIR_DOMAIN_VIDEO_TYPE_DEFAULT; - } + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_CIRRUS_VGA)) + return VIR_DOMAIN_VIDEO_TYPE_CIRRUS; + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VGA)) + return VIR_DOMAIN_VIDEO_TYPE_VGA; + return VIR_DOMAIN_VIDEO_TYPE_DEFAULT; } -- 2.21.0

3 2

[libvirt] [PATCH 0/4] Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param
by Jiri Denemark 06 Dec '19

06 Dec '19

Normally the TLS certificate from the destination host must match the host's name for TLS verification to succeed. When the certificate does not match the destination hostname and the expected cetificate's hostname is known, this parameter can be used to pass this expected hostname when starting the migration. Jiri Denemark (4): qemu: Add support for setting string migration params Introduce VIR_MIGRATE_PARAM_TLS_DESTINATION migration param qemu: Implement VIR_MIGRATE_PARAM_TLS_DESTINATION virsh: Add --tls-destination option for migrate command include/libvirt/libvirt-domain.h | 14 +++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 65 +++++++++++++++++++++++++++++++- tools/virsh-domain.c | 11 ++++++ tools/virsh.pod | 8 +++- 5 files changed, 96 insertions(+), 3 deletions(-) -- 2.24.0

2 5

[libvirt] [PATCH 0/3] Remove deprecated pc-0.x machine types and related hacks
by Thomas Huth 06 Dec '19

06 Dec '19

These have been on the deprecation list since a year now, so it's time to finally remove the pc-0.x machine types. We then can also remove some compatibility hacks in the devices, i.e. the "use_broken_id" in ac97 and "command_serr_enable" in PCI devices. Note that there is also the "rombar" property of the PCI devices which is now not required for the x86 machine types anymore. But it seems to me like this is still used by various people to bypass the ROM loading for PCI devices in certain cases, so I did not remove that property here yet. Thomas Huth (3): hw/i386: Remove the deprecated machines 0.12 up to 0.15 hw/audio: Remove the "use_broken_id" hack from the AC97 device hw/pci: Remove the "command_serr_enable" property hw/audio/ac97.c | 9 ----- hw/i386/pc_piix.c | 82 ------------------------------------------- hw/pci/pci.c | 6 +--- include/hw/pci/pci.h | 3 -- qemu-deprecated.texi | 2 +- tests/cpu-plug-test.c | 6 +--- 6 files changed, 3 insertions(+), 105 deletions(-) -- 2.18.1

6 11

[libvirt] [PATCH] qemu_monitor_text: Drop unused variable and avoid crash
by Michal Privoznik 06 Dec '19

06 Dec '19

In v5.8.0-rc1~122 we've removed the only use of @safename in qemuMonitorTextLoadSnapshot(). What we are left with is an declared but not initialized variable that is passed to VIR_FREE(). Caught by libvirt-php test suite. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/qemu/qemu_monitor_text.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 9054682d60..b387235821 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -161,7 +161,6 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) char *cmd = NULL; char *reply = NULL; int ret = -1; - char *safename; cmd = g_strdup_printf("loadvm \"%s\"", name); @@ -194,7 +193,6 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) ret = 0; cleanup: - VIR_FREE(safename); VIR_FREE(cmd); VIR_FREE(reply); return ret; -- 2.23.0

1 0

[libvirt] [PATCH] news: Update the qemu version that dedicated performance hint is from
by Han Han 05 Dec '19

05 Dec '19

KVM dedicated performance hint is added since qemu version 2.10.0 not 2.10.1. Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 2eb3bfdf6e..3ddebfddfb 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -469,7 +469,7 @@ With <code><hint-dedicated state='on'/></code> and <code><cpu mode='host-passthrough'/></code>, it allows a guest to enable optimizations when running on dedicated - vCPUs. QEMU newer than 2.12.1 and kernel newer than 4.17 + vCPUs. QEMU newer than 2.12.0 and kernel newer than 4.17 are required. </description> </change> -- 2.24.0.rc1

2 1

[libvirt] [PATCH] docs: Update minimum QEMU version for kvm-hint-dedicated
by Andrea Bolognani 05 Dec '19

05 Dec '19

Same fix that was applied to release notes in a595c66a134d. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6df4a8b26e..5c0a00350b 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2226,7 +2226,7 @@ <td>hint-dedicated</td> <td>Allows a guest to enable optimizations when running on dedicated vCPUs</td> <td>on, off</td> - <td><span class="since">5.7.0 (QEMU 2.12.1)</span></td> + <td><span class="since">5.7.0 (QEMU 2.12.0)</span></td> </tr> </table> </dd> -- 2.23.0

1 0

[libvirt] [PATCH v2 0/4] Update news for versions from 5.7 to 5.8
by Han Han 05 Dec '19

05 Dec '19

Remove news of unmanaged macvtap devices since Laine has update that. v1: https://www.redhat.com/archives/libvir-list/2019-November/msg00176.html Han Han (4): news: Support for kvm dedicated performance hint in 5.7 news: Support to run SLIRP in a separate process in 5.8 news: Support vhost-user-gpu in 5.8 news: Introduce virConnectSetIdentity API in 5.8 docs/news.xml | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) -- 2.23.0

2 10

[libvirt] [PATCH] i386: Resolve CPU models to v1 by default
by Eduardo Habkost 05 Dec '19

05 Dec '19

When using `query-cpu-definitions` using `-machine none`, QEMU is resolving all CPU models to their latest versions. The actual CPU model version being used by another machine type (e.g. `pc-q35-4.0`) might be different. In theory, this was OK because the correct CPU model version is returned when using the correct `-machine` argument. Except that in practice, this breaks libvirt expectations: libvirt always use `-machine none` when checking if a CPU model is runnable, because runnability is not expected to be affected when the machine type is changed. For example, when running on a Haswell host without TSX, Haswell-v4 is runnable, but Haswell-v1 is not. On those hosts, `query-cpu-definitions` says Haswell is runnable if using `-machine none`, but Haswell is actually not runnable using any of the `pc-*` machine types (because they resolve Haswell to Haswell-v1). In other words, we're breaking the "runnability guarantee" we promised to not break for a few releases (see qemu-deprecated.texi). To address this issue, change the default CPU model version to v1 on all machine types, so we make `query-cpu-definitions` output when using `-machine none` match the results when using `pc-*`. This will change in the future (the plan is to always return the latest CPU model version if using `-machine none`), but only after giving libvirt the opportunity to adapt. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1779078 Signed-off-by: Eduardo Habkost <ehabkost(a)redhat.com> --- I don't think this should block QEMU 4.2.0 from being tagged. The bug is present since 4.1.0, so we can fix it in 4.1.2 and/or 4.2.1. --- qemu-deprecated.texi | 8 ++++++++ target/i386/cpu.c | 8 +++++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 4b4b7425ac..b42d8b3c5f 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -374,6 +374,14 @@ guarantees must resolve the CPU model aliases using te ``alias-of'' field returned by the ``query-cpu-definitions'' QMP command. +While those guarantees are kept, the return value of +``query-cpu-definitions'' will have existing CPU model aliases +point to a version that doesn't break runnability guarantees +(specifically, version 1 of those CPU models). In future QEMU +versions, aliases will point to newer CPU model versions +depending on the machine type, so management software must +resolve CPU model aliases before starting a virtual machine. + @node Recently removed features @appendix Recently removed features diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 69f518a21a..54e7f18a09 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -3924,7 +3924,13 @@ static PropValue tcg_default_props[] = { }; -X86CPUVersion default_cpu_version = CPU_VERSION_LATEST; +/* + * We resolve CPU model aliases using -v1 when using "-machine + * none", but this is just for compatibility while libvirt isn't + * adapted to resolve CPU model versions before creating VMs. + * See "Runnability guarantee of CPU models" at * qemu-deprecated.texi. + */ +X86CPUVersion default_cpu_version = 1; void x86_cpu_set_default_version(X86CPUVersion version) { -- 2.23.0

1 0

Re: [libvirt] [PATCH v3] qga: fence guest-set-time if hwclock not available
by Philippe Mathieu-Daudé 05 Dec '19

05 Dec '19

On 12/5/19 2:12 PM, Cornelia Huck wrote: > On Thu, 5 Dec 2019 14:05:19 +0100 > Philippe Mathieu-Daudé <philmd(a)redhat.com> wrote: > >> Hi Cornelia, >> >> On 12/5/19 12:53 PM, Cornelia Huck wrote: >>> The Posix implementation of guest-set-time invokes hwclock to >>> set/retrieve the time to/from the hardware clock. If hwclock >>> is not available, the user is currently informed that "hwclock >>> failed to set hardware clock to system time", which is quite >>> misleading. This may happen e.g. on s390x, which has a different >>> timekeeping concept anyway. >>> >>> Let's check for the availability of the hwclock command and >>> return QERR_UNSUPPORTED for guest-set-time if it is not available. >>> >>> Reviewed-by: Laszlo Ersek <lersek(a)redhat.com> >>> Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com> >>> Reviewed-by: Michael Roth <mdroth(a)linux.vnet.ibm.com> >>> Signed-off-by: Cornelia Huck <cohuck(a)redhat.com> >>> --- >>> >>> v2->v3: >>> - added 'static' keyword to hwclock_path >>> >>> Not sure what tree this is going through; if there's no better place, >>> I can also take this through the s390 tree. >> >> s390 or trivial trees seems appropriate. >> >>> >>> --- >>> qga/commands-posix.c | 13 ++++++++++++- >>> 1 file changed, 12 insertions(+), 1 deletion(-) >>> >>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c >>> index 1c1a165daed8..0be301a4ea77 100644 >>> --- a/qga/commands-posix.c >>> +++ b/qga/commands-posix.c >>> @@ -156,6 +156,17 @@ void qmp_guest_set_time(bool has_time, int64_t time_ns, Error **errp) >>> pid_t pid; >>> Error *local_err = NULL; >>> struct timeval tv; >>> + static const char hwclock_path[] = "/sbin/hwclock"; >>> + static int hwclock_available = -1; >>> + >>> + if (hwclock_available < 0) { >>> + hwclock_available = (access(hwclock_path, X_OK) == 0); >>> + } >>> + >>> + if (!hwclock_available) { >>> + error_setg(errp, QERR_UNSUPPORTED); >> >> In include/qapi/qmp/qerror.h we have: >> >> /* >> * These macros will go away, please don't use in new code, and do not >> * add new ones! >> */ > > Sigh, it is really hard to keep track here :( I just copied from other > callers in this file... > >> >> Maybe we can replace it by "this feature is not supported on this >> architecture"? (or without 'on this architecture'). > > This is not really architecture specific, you'd get this on any setup > that does not have /sbin/hwclock. > > Q: Is libvirt doing anything with such an error message from QEMU? Do > we have the freedom to say e.g "guest-set-time is not supported" or so? > Or is it beneficial to print the same error message for any unsupported > feature? Cc'ing Markus who added the command and libvir-list. Using "guest-set-time is not supported" or "this command is not supported": Reviewed-by: Philippe Mathieu-Daudé <philmd(a)redhat.com> >>> + return; >>> + } >>> >>> /* If user has passed a time, validate and set it. */ >>> if (has_time) { >>> @@ -195,7 +206,7 @@ void qmp_guest_set_time(bool has_time, int64_t time_ns, Error **errp) >>> >>> /* Use '/sbin/hwclock -w' to set RTC from the system time, >>> * or '/sbin/hwclock -s' to set the system time from RTC. */ >>> - execle("/sbin/hwclock", "hwclock", has_time ? "-w" : "-s", >>> + execle(hwclock_path, "hwclock", has_time ? "-w" : "-s", >>> NULL, environ); >>> _exit(EXIT_FAILURE); >>> } else if (pid < 0) { >>> >> >

1 0

[libvirt] [PATCH 0/2] qemu: Refactor qemuDomainAbortJob
by Peter Krempa 05 Dec '19

05 Dec '19

Review of my incremental backup series prompted for refactor of qemuDomainAbortJob Peter Krempa (2): qemu: driver: Split out cancellation of migration from qemuDomainAbortJob qemu: Convert aborting of a domain job to a switch statement src/qemu/qemu_driver.c | 90 +++++++++++++++++++++++++++++------------- 1 file changed, 63 insertions(+), 27 deletions(-) -- 2.23.0

2 3