- Devel - libvirt List Archives

[PATCH] virt-host-validate: Fix IOMMU output on S390
by Boris Fiuczynski 17 Dec '21

17 Dec '21

Commit 93e9e92c1e eliminated the option for skipping but left code in the s390 check which makes use of a skip. This leads to an output without result destroying the correct format. e.g. QEMU: Checking for hardware virtualization : PASS QEMU: Checking if device /dev/kvm exists : PASS QEMU: Checking if device /dev/kvm is accessible : PASS QEMU: Checking if device /dev/vhost-net exists : PASS QEMU: Checking if device /dev/net/tun exists : PASS QEMU: Checking for cgroup 'cpu' controller support : PASS QEMU: Checking for cgroup 'cpuacct' controller support : PASS QEMU: Checking for cgroup 'cpuset' controller support : PASS QEMU: Checking for cgroup 'memory' controller support : PASS QEMU: Checking for cgroup 'devices' controller support : PASS QEMU: Checking for cgroup 'blkio' controller support : PASS QEMU: Checking for device assignment IOMMU support : QEMU: Checking for secure guest support : PASS Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- tools/virt-host-validate-common.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 647ed7b48b..1cb9d206b5 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -378,11 +378,17 @@ int virHostValidateIOMMU(const char *hvname, * devices (which is quite usual on s390x). If there are * no PCI devices the directory is still there but is * empty. */ - if (!virDirOpen(&dir, "/sys/bus/pci/devices")) - return 0; + if (!virDirOpen(&dir, "/sys/bus/pci/devices")) { + virHostMsgFail(VIR_HOST_VALIDATE_NOTE, + "Skipped - PCI support disabled"); + return VIR_HOST_VALIDATE_FAILURE(VIR_HOST_VALIDATE_NOTE); + } rc = virDirRead(dir, &dent, NULL); - if (rc <= 0) - return 0; + if (rc <= 0) { + virHostMsgFail(VIR_HOST_VALIDATE_NOTE, + "Skipped - No PCI devices are online"); + return VIR_HOST_VALIDATE_FAILURE(VIR_HOST_VALIDATE_NOTE); + } virHostMsgPass(); } else { virHostMsgFail(level, -- 2.31.1

2 1

[PATCH v5 0/3] remove sysconfig files
by Olaf Hering 17 Dec '21

17 Dec '21

fix path to sysconfig file in NEWS.rst (jfehlig) rebased to 85574319952af2cf538d185bd58e4ed3edc7a3e8 Olaf Hering (3): libvirt.spec: relocate pre script of daemon-driver-qemu remove sysconfig files NEWS: mention removal of sysconfig NEWS.rst | 10 +++ docs/daemons.rst | 20 +++++ docs/remote.html.in | 6 +- libvirt.spec.in | 99 +++++++++++++++++-------- src/ch/meson.build | 5 -- src/ch/virtchd.service.in | 1 + src/ch/virtchd.sysconf | 3 - src/interface/meson.build | 5 -- src/interface/virtinterfaced.service.in | 1 + src/interface/virtinterfaced.sysconf | 3 - src/libxl/meson.build | 5 -- src/libxl/virtxend.service.in | 1 + src/libxl/virtxend.sysconf | 3 - src/locking/meson.build | 5 -- src/locking/virtlockd.service.in | 1 + src/locking/virtlockd.sysconf | 3 - src/logging/meson.build | 5 -- src/logging/virtlogd.sysconf | 3 - src/lxc/meson.build | 5 -- src/lxc/virtlxcd.service.in | 1 + src/lxc/virtlxcd.sysconf | 3 - src/meson.build | 16 ---- src/network/meson.build | 5 -- src/network/virtnetworkd.service.in | 1 + src/network/virtnetworkd.sysconf | 3 - src/node_device/meson.build | 5 -- src/node_device/virtnodedevd.service.in | 1 + src/node_device/virtnodedevd.sysconf | 3 - src/nwfilter/meson.build | 5 -- src/nwfilter/virtnwfilterd.service.in | 1 + src/nwfilter/virtnwfilterd.sysconf | 3 - src/qemu/meson.build | 5 -- src/qemu/virtqemud.service.in | 7 ++ src/qemu/virtqemud.sysconf | 12 --- src/remote/libvirtd.service.in | 7 ++ src/remote/libvirtd.sysconf | 21 ------ src/remote/meson.build | 10 --- src/remote/virtproxyd.service.in | 1 + src/remote/virtproxyd.sysconf | 3 - src/secret/meson.build | 5 -- src/secret/virtsecretd.service.in | 1 + src/secret/virtsecretd.sysconf | 3 - src/storage/meson.build | 5 -- src/storage/virtstoraged.service.in | 1 + src/storage/virtstoraged.sysconf | 3 - src/vbox/meson.build | 5 -- src/vbox/virtvboxd.service.in | 1 + src/vbox/virtvboxd.sysconf | 3 - src/vz/meson.build | 5 -- src/vz/virtvzd.service.in | 1 + src/vz/virtvzd.sysconf | 3 - tools/libvirt-guests.sh.in | 40 ++++++++++ tools/libvirt-guests.sysconf | 50 ------------- tools/meson.build | 6 -- 54 files changed, 167 insertions(+), 262 deletions(-) delete mode 100644 src/ch/virtchd.sysconf delete mode 100644 src/interface/virtinterfaced.sysconf delete mode 100644 src/libxl/virtxend.sysconf delete mode 100644 src/locking/virtlockd.sysconf delete mode 100644 src/logging/virtlogd.sysconf delete mode 100644 src/lxc/virtlxcd.sysconf delete mode 100644 src/network/virtnetworkd.sysconf delete mode 100644 src/node_device/virtnodedevd.sysconf delete mode 100644 src/nwfilter/virtnwfilterd.sysconf delete mode 100644 src/qemu/virtqemud.sysconf delete mode 100644 src/remote/libvirtd.sysconf delete mode 100644 src/remote/virtproxyd.sysconf delete mode 100644 src/secret/virtsecretd.sysconf delete mode 100644 src/storage/virtstoraged.sysconf delete mode 100644 src/vbox/virtvboxd.sysconf delete mode 100644 src/vz/virtvzd.sysconf delete mode 100644 tools/libvirt-guests.sysconf

3 6

[PATCH 0/4] vsh-table: Various small improvements
by Michal Privoznik 17 Dec '21

17 Dec '21

*** BLURB HERE *** Michal Prívozník (4): vshtabletest: Fix potential memleak vsh-table: Hide vshTableRow typedef vsh-table.h: Modernize declarations vsh-table: Ensure NULL terminated arguments to vshTable*() tests/vshtabletest.c | 6 ++++-- tools/vsh-table.c | 1 + tools/vsh-table.h | 22 ++++++++++++++++------ 3 files changed, 21 insertions(+), 8 deletions(-) -- 2.32.0

2 5

[PATCH v2 0/6] qemu: Explicitly forbid live changing nodeset for strict numatune
by Michal Privoznik 17 Dec '21

17 Dec '21

v2 of: https://listman.redhat.com/archives/libvir-list/2021-December/msg00708.html diff to v1: - Wrote documentation, per Pavel's request - Wrote a completer Michal Prívozník (6): manpages: Document 'restrictive' mode for numatune virsh-completer: Provide completer for numatune --mode qemu: Allow VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE in qemuDomainSetNumaParamsLive() qemu: Explicitly forbid live changing nodeset for strict numatune qemu_command: do use host-nodes for system memory NEWS: Document recent numatune change NEWS.rst | 8 ++++ docs/formatdomain.rst | 3 ++ docs/manpages/virsh.rst | 10 ++--- src/libvirt-domain.c | 7 ++++ src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 37 +++++++++++++------ .../numatune-system-memory.x86_64-latest.args | 2 +- tools/virsh-completer-domain.c | 20 ++++++++++ tools/virsh-completer-domain.h | 5 +++ tools/virsh-domain.c | 1 + 10 files changed, 76 insertions(+), 20 deletions(-) -- 2.32.0

4 10

[PATCH] qemucapabilitiesdata: Fix command name in caps_3.0.0.ppc64.replies
by Michal Privoznik 17 Dec '21

17 Dec '21

Under the qemucapabilitiesdata we have a replies file for QEMU-3.0.0.ppc64. At least we think so. In fact, the file contains replies from a development snapshot release that predates 3.0.0 (specifically it's v2.12.0-1689-g518d23a) and as such does not reflect any change that was made to QEMU after the snapshot and before the official relase. One of such changes was renaming 'exit-preconfig' command to 'x-exit-preconfig' (QEMU commit v3.0.0-rc1~21^2~3). Ideally, we would just regenerate capabilities using the official release but since this is a PPC64 machine and pretty old version anyway let's just fix the command name. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies index 3df67b71de..c12ee7814e 100644 --- a/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies +++ b/tests/qemucapabilitiesdata/caps_3.0.0.ppc64.replies @@ -1296,7 +1296,7 @@ "arg-type": "0" }, { - "name": "exit-preconfig", + "name": "x-exit-preconfig", "ret-type": "0", "allow-oob": false, "allow-preconfig": true, @@ -12327,7 +12327,7 @@ "name": "system_wakeup" }, { - "name": "exit-preconfig" + "name": "x-exit-preconfig" }, { "name": "cont" -- 2.32.0

2 1

[PATCH] qemuGetSEVInfoToParams: Reformat to standard coding style
by Peter Krempa 16 Dec '21

16 Dec '21

The function was formatted weirdly which prompted additions to conform to the unusual style. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_driver.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bae8b7c39b..372e1360b5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19901,30 +19901,30 @@ qemuGetSEVInfoToParams(virQEMUCaps *qemuCaps, virCheckFlags(VIR_TYPED_PARAM_STRING_OKAY, -1); if (virTypedParamsAddString(&sevParams, &n, &maxpar, - VIR_NODE_SEV_PDH, sev->pdh) < 0) + VIR_NODE_SEV_PDH, sev->pdh) < 0) return -1; if (virTypedParamsAddString(&sevParams, &n, &maxpar, - VIR_NODE_SEV_CERT_CHAIN, sev->cert_chain) < 0) + VIR_NODE_SEV_CERT_CHAIN, sev->cert_chain) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_CBITPOS, sev->cbitpos) < 0) + VIR_NODE_SEV_CBITPOS, sev->cbitpos) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_REDUCED_PHYS_BITS, - sev->reduced_phys_bits) < 0) + VIR_NODE_SEV_REDUCED_PHYS_BITS, + sev->reduced_phys_bits) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_MAX_GUESTS, - sev->max_guests) < 0) + VIR_NODE_SEV_MAX_GUESTS, + sev->max_guests) < 0) goto cleanup; if (virTypedParamsAddUInt(&sevParams, &n, &maxpar, - VIR_NODE_SEV_MAX_ES_GUESTS, - sev->max_es_guests) < 0) + VIR_NODE_SEV_MAX_ES_GUESTS, + sev->max_es_guests) < 0) goto cleanup; *params = g_steal_pointer(&sevParams); -- 2.31.1

2 1

[PATCH 0/3] qemu: Explicitly forbid changing nodeset for strict numatune
by Michal Privoznik 16 Dec '21

16 Dec '21

See 2/3 for explanation. Michal Prívozník (3): qemu: Allow VIR_DOMAIN_NUMATUNE_MEM_RESTRICTIVE in qemuDomainSetNumaParamsLive() qemu: Explicitly forbid changing nodeset for strict numatune qemu_command: do use host-nodes for system memory src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 37 +++++++++++++------ .../numatune-system-memory.x86_64-latest.args | 2 +- 3 files changed, 27 insertions(+), 15 deletions(-) -- 2.32.0

3 5

[PATCH 0/2] conf: Don't crash when one of disks is missing
by Peter Krempa 16 Dec '21

16 Dec '21

Peter Krempa (2): virDomainDiskInsert: Don't access NULL disk target qemuxml2argvtest: disk-missing-target: Add two disks with same bus src/conf/domain_conf.c | 1 + tests/qemuxml2argvdata/disk-missing-target-invalid.xml | 3 +++ 2 files changed, 4 insertions(+) -- 2.31.1

2 3

[libvirt PATCH] qemu: validate VNC password length
by Daniel P. Berrangé 16 Dec '21

16 Dec '21

The VNC password authentication scheme is quite horrendous in that it takes the user password and directly uses it as a DES case. DES is a byte 8 keyed cipher, so the VNC password can never be more than 8 characters long. Anything over that length will be silently dropped. We should validate this length restriction when accepting user XML configs and report an error. For the global VNC password we don't really want to break daemon startup by reporting an error, but logging a warning is worthwhile. https://bugzilla.redhat.com/show_bug.cgi?id=1506689 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/qemu/qemu_conf.c | 6 ++++++ src/qemu/qemu_validate.c | 8 ++++++++ 2 files changed, 14 insertions(+) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 7eb04e66a0..6077457ff4 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -451,6 +451,12 @@ virQEMUDriverConfigLoadVNCEntry(virQEMUDriverConfig *cfg, if (virConfGetValueBool(conf, "vnc_allow_host_audio", &cfg->vncAllowHostAudio) < 0) return -1; + if (cfg->vncPassword && + strlen(cfg->vncPassword) > 8) { + VIR_WARN("VNC password is %zu characters long, only 8 permitted, truncating", + strlen(cfg->vncPassword)); + cfg->vncPassword[8] = '\0'; + } return 0; } diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index f9a195e991..46b40303f6 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -4109,6 +4109,14 @@ qemuValidateDomainDeviceDefVNCGraphics(const virDomainGraphicsDef *graphics, return -1; } + if (graphics->data.vnc.auth.passwd && + strlen(graphics->data.vnc.auth.passwd) > 8) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("VNC password is %zu characters long, only 8 permitted"), + strlen(graphics->data.vnc.auth.passwd)); + return -1; + } + return 0; } -- 2.33.1

2 1

[libvirt PATCH] qemu: qemu_command: clean up includes
by Ján Tomko 16 Dec '21

16 Dec '21

Over time, the code using them got split into other files. (Mostly qemu_interface.c and qemu_process.c) Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_command.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6d00105b24..b9105aa10b 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -22,7 +22,6 @@ #include <config.h> #include "qemu_command.h" -#include "qemu_hostdev.h" #include "qemu_capabilities.h" #include "qemu_dbus.h" #include "qemu_interface.h" @@ -30,14 +29,11 @@ #include "qemu_security.h" #include "qemu_slirp.h" #include "qemu_block.h" -#include "cpu/cpu.h" #include "viralloc.h" #include "virlog.h" #include "virarch.h" #include "virerror.h" #include "virfile.h" -#include "virnetdev.h" -#include "virnetdevbridge.h" #include "virqemu.h" #include "virstring.h" #include "virtime.h" @@ -50,7 +46,6 @@ #include "snapshot_conf.h" #include "storage_conf.h" #include "secret_conf.h" -#include "virnetdevtap.h" #include "virnetdevopenvswitch.h" #include "device_conf.h" #include "storage_source_conf.h" @@ -60,11 +55,6 @@ #include "virgic.h" #include "virmdev.h" #include "virdomainsnapshotobjlist.h" -#if defined(__linux__) -# include <linux/capability.h> -#endif -#include "logging/log_manager.h" -#include "logging/log_protocol.h" #include "virutil.h" #include "virsecureerase.h" -- 2.31.1

2 1